[INFO] crate boldline 0.1.1 is already in cache
[INFO] extracting crate boldline 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/boldline/0.1.1
[INFO] extracting crate boldline 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/boldline/0.1.1
[INFO] validating manifest of boldline-0.1.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of boldline-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing boldline-0.1.1
[INFO] finished frobbing boldline-0.1.1
[INFO] frobbed toml for boldline-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/boldline/0.1.1/Cargo.toml
[INFO] started frobbing boldline-0.1.1
[INFO] finished frobbing boldline-0.1.1
[INFO] frobbed toml for boldline-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/boldline/0.1.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting boldline-0.1.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/boldline/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 2513ad65440656a74d6e955d8386ec9c44bc5c5dc60fa427c61f2709a792f937
[INFO] running `"docker" "start" "-a" "2513ad65440656a74d6e955d8386ec9c44bc5c5dc60fa427c61f2709a792f937"`
[INFO] [stderr]     Checking clap v2.32.0
[INFO] [stderr]     Checking boldline v0.1.1 (/opt/crater/workdir)
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         let mut next_to_eachother = false;
[INFO] [stderr] 142 | |         if left+1 == right || right+1 == left {
[INFO] [stderr] 143 | |             next_to_eachother = true;
[INFO] [stderr] 144 | |         } else {
[INFO] [stderr] 145 | |             was_next_to_last_iter = false;
[INFO] [stderr] 146 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> next_to_eachother = if left+1 == right || right+1 == left { true } else { ..; false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:134:44
[INFO] [stderr]     |
[INFO] [stderr] 134 |         if (leftwise && !should_bold(input[left..left+1].as_bytes()[0] as char)) ||
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: use: `left..=left`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:135:45
[INFO] [stderr]     |
[INFO] [stderr] 135 |            (rightwise && !should_bold(input[right..right+1].as_bytes()[0] as char)) {
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^ help: use: `right..=right`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:159:28
[INFO] [stderr]     |
[INFO] [stderr] 159 |             let c = &input[j..j+1];
[INFO] [stderr]     |                            ^^^^^^ help: use: `j..=j`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         let mut next_to_eachother = false;
[INFO] [stderr] 142 | |         if left+1 == right || right+1 == left {
[INFO] [stderr] 143 | |             next_to_eachother = true;
[INFO] [stderr] 144 | |         } else {
[INFO] [stderr] 145 | |             was_next_to_last_iter = false;
[INFO] [stderr] 146 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> next_to_eachother = if left+1 == right || right+1 == left { true } else { ..; false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:134:44
[INFO] [stderr]     |
[INFO] [stderr] 134 |         if (leftwise && !should_bold(input[left..left+1].as_bytes()[0] as char)) ||
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: use: `left..=left`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:135:45
[INFO] [stderr]     |
[INFO] [stderr] 135 |            (rightwise && !should_bold(input[right..right+1].as_bytes()[0] as char)) {
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^ help: use: `right..=right`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:159:28
[INFO] [stderr]     |
[INFO] [stderr] 159 |             let c = &input[j..j+1];
[INFO] [stderr]     |                            ^^^^^^ help: use: `j..=j`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         let mut next_to_eachother = false;
[INFO] [stderr] 142 | |         if left+1 == right || right+1 == left {
[INFO] [stderr] 143 | |             next_to_eachother = true;
[INFO] [stderr] 144 | |         } else {
[INFO] [stderr] 145 | |             was_next_to_last_iter = false;
[INFO] [stderr] 146 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> next_to_eachother = if left+1 == right || right+1 == left { true } else { ..; false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:134:44
[INFO] [stderr]     |
[INFO] [stderr] 134 |         if (leftwise && !should_bold(input[left..left+1].as_bytes()[0] as char)) ||
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: use: `left..=left`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:135:45
[INFO] [stderr]     |
[INFO] [stderr] 135 |            (rightwise && !should_bold(input[right..right+1].as_bytes()[0] as char)) {
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^ help: use: `right..=right`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:159:28
[INFO] [stderr]     |
[INFO] [stderr] 159 |             let c = &input[j..j+1];
[INFO] [stderr]     |                            ^^^^^^ help: use: `j..=j`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:6:1
[INFO] [stderr]    |
[INFO] [stderr] 6  | / fn parse_marking<'a>(input: &'a str) -> Option<Marking> {
[INFO] [stderr] 7  | |     match input {
[INFO] [stderr] 8  | |         "ansibold"     | "ansi" | "terminal" | "t"            => Some(Marking::ANSIBold),
[INFO] [stderr] 9  | |         "htmlbold"     | "html" | "h"                         => Some(Marking::HTMLBold),
[INFO] [stderr] ...  |
[INFO] [stderr] 13 | |     }
[INFO] [stderr] 14 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | / fn parse_pattern<'a>(input: &'a str) -> Option<Pattern> {
[INFO] [stderr] 17 | |     match input {
[INFO] [stderr] 18 | |         "l" |       "left"  => Some(Pattern::Left),
[INFO] [stderr] 19 | |         "r" |       "right" => Some(Pattern::Right),
[INFO] [stderr] ...  |
[INFO] [stderr] 22 | |     }
[INFO] [stderr] 23 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/lib.rs:141:9
[INFO] [stderr]     |
[INFO] [stderr] 141 | /         let mut next_to_eachother = false;
[INFO] [stderr] 142 | |         if left+1 == right || right+1 == left {
[INFO] [stderr] 143 | |             next_to_eachother = true;
[INFO] [stderr] 144 | |         } else {
[INFO] [stderr] 145 | |             was_next_to_last_iter = false;
[INFO] [stderr] 146 | |         }
[INFO] [stderr]     | |_________^ help: it is more idiomatic to write: `let <mut> next_to_eachother = if left+1 == right || right+1 == left { true } else { ..; false };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:134:44
[INFO] [stderr]     |
[INFO] [stderr] 134 |         if (leftwise && !should_bold(input[left..left+1].as_bytes()[0] as char)) ||
[INFO] [stderr]     |                                            ^^^^^^^^^^^^ help: use: `left..=left`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:135:45
[INFO] [stderr]     |
[INFO] [stderr] 135 |            (rightwise && !should_bold(input[right..right+1].as_bytes()[0] as char)) {
[INFO] [stderr]     |                                             ^^^^^^^^^^^^^^ help: use: `right..=right`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/lib.rs:159:28
[INFO] [stderr]     |
[INFO] [stderr] 159 |             let c = &input[j..j+1];
[INFO] [stderr]     |                            ^^^^^^ help: use: `j..=j`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:6:1
[INFO] [stderr]    |
[INFO] [stderr] 6  | / fn parse_marking<'a>(input: &'a str) -> Option<Marking> {
[INFO] [stderr] 7  | |     match input {
[INFO] [stderr] 8  | |         "ansibold"     | "ansi" | "terminal" | "t"            => Some(Marking::ANSIBold),
[INFO] [stderr] 9  | |         "htmlbold"     | "html" | "h"                         => Some(Marking::HTMLBold),
[INFO] [stderr] ...  |
[INFO] [stderr] 13 | |     }
[INFO] [stderr] 14 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]   --> src/main.rs:16:1
[INFO] [stderr]    |
[INFO] [stderr] 16 | / fn parse_pattern<'a>(input: &'a str) -> Option<Pattern> {
[INFO] [stderr] 17 | |     match input {
[INFO] [stderr] 18 | |         "l" |       "left"  => Some(Pattern::Left),
[INFO] [stderr] 19 | |         "r" |       "right" => Some(Pattern::Right),
[INFO] [stderr] ...  |
[INFO] [stderr] 22 | |     }
[INFO] [stderr] 23 | | }
[INFO] [stderr]    | |_^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 8.20s
[INFO] running `"docker" "inspect" "2513ad65440656a74d6e955d8386ec9c44bc5c5dc60fa427c61f2709a792f937"`
[INFO] running `"docker" "rm" "-f" "2513ad65440656a74d6e955d8386ec9c44bc5c5dc60fa427c61f2709a792f937"`
[INFO] [stdout] 2513ad65440656a74d6e955d8386ec9c44bc5c5dc60fa427c61f2709a792f937