[INFO] crate bodyparser 0.8.0 is already in cache [INFO] extracting crate bodyparser 0.8.0 into work/ex/clippy-test-run/sources/stable/reg/bodyparser/0.8.0 [INFO] extracting crate bodyparser 0.8.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bodyparser/0.8.0 [INFO] validating manifest of bodyparser-0.8.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bodyparser-0.8.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bodyparser-0.8.0 [INFO] finished frobbing bodyparser-0.8.0 [INFO] frobbed toml for bodyparser-0.8.0 written to work/ex/clippy-test-run/sources/stable/reg/bodyparser/0.8.0/Cargo.toml [INFO] started frobbing bodyparser-0.8.0 [INFO] finished frobbing bodyparser-0.8.0 [INFO] frobbed toml for bodyparser-0.8.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bodyparser/0.8.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bodyparser-0.8.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bodyparser/0.8.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f97ab8fb096d690c552cbba631a829c319367c10b059750deece07624931a7a9 [INFO] running `"docker" "start" "-a" "f97ab8fb096d690c552cbba631a829c319367c10b059750deece07624931a7a9"` [INFO] [stderr] Checking bodyparser v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/limit_reader.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | LimitReader { limit: limit, inner: r } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/limit_reader.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | LimitReader { limit: limit, inner: r } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `limit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/limit_reader.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match res { [INFO] [stderr] 34 | | Ok(len) => self.limit -= len, [INFO] [stderr] 35 | | _ => {} [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(len) = res { self.limit -= len }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | let max_length = req [INFO] [stderr] | ______________________________^ [INFO] [stderr] 78 | | .get::>() [INFO] [stderr] 79 | | .ok() [INFO] [stderr] 80 | | .map(|x| *x) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 77 | let max_length = req [INFO] [stderr] 78 | .get::>() [INFO] [stderr] 79 | .ok().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:132:47 [INFO] [stderr] | [INFO] [stderr] 132 | reverse_option(maybe_body.map(|body| from_value(body))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `from_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/limit_reader.rs:33:9 [INFO] [stderr] | [INFO] [stderr] 33 | / match res { [INFO] [stderr] 34 | | Ok(len) => self.limit -= len, [INFO] [stderr] 35 | | _ => {} [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(len) = res { self.limit -= len }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:77:30 [INFO] [stderr] | [INFO] [stderr] 77 | let max_length = req [INFO] [stderr] | ______________________________^ [INFO] [stderr] 78 | | .get::>() [INFO] [stderr] 79 | | .ok() [INFO] [stderr] 80 | | .map(|x| *x) [INFO] [stderr] | |____________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 77 | let max_length = req [INFO] [stderr] 78 | .get::>() [INFO] [stderr] 79 | .ok().cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/lib.rs:132:47 [INFO] [stderr] | [INFO] [stderr] 132 | reverse_option(maybe_body.map(|body| from_value(body))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `from_value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 7.75s [INFO] running `"docker" "inspect" "f97ab8fb096d690c552cbba631a829c319367c10b059750deece07624931a7a9"` [INFO] running `"docker" "rm" "-f" "f97ab8fb096d690c552cbba631a829c319367c10b059750deece07624931a7a9"` [INFO] [stdout] f97ab8fb096d690c552cbba631a829c319367c10b059750deece07624931a7a9