[INFO] crate bns 0.1.0 is already in cache [INFO] extracting crate bns 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bns/0.1.0 [INFO] extracting crate bns 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bns/0.1.0 [INFO] validating manifest of bns-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bns-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bns-0.1.0 [INFO] finished frobbing bns-0.1.0 [INFO] frobbed toml for bns-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bns/0.1.0/Cargo.toml [INFO] started frobbing bns-0.1.0 [INFO] finished frobbing bns-0.1.0 [INFO] frobbed toml for bns-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bns/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bns-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bns/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2fd93fa1bed0cfbdaaa88f9fff785b1506e922766b3623046e570c930b5f7cb7 [INFO] running `"docker" "start" "-a" "2fd93fa1bed0cfbdaaa88f9fff785b1506e922766b3623046e570c930b5f7cb7"` [INFO] [stderr] Compiling curl-sys v0.2.5 [INFO] [stderr] Checking tendril v0.2.4 [INFO] [stderr] Compiling string_cache v0.2.29 [INFO] [stderr] Compiling html5ever v0.5.4 [INFO] [stderr] Checking selectors v0.5.9 [INFO] [stderr] Checking scraper v0.4.0 [INFO] [stderr] Checking curl v0.3.11 [INFO] [stderr] Checking bns v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | server: server, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | faction: faction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `faction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | faction_rank: faction_rank, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `faction_rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | clan: clan [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `clan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | name: name, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | class: class, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `class` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:122:13 [INFO] [stderr] | [INFO] [stderr] 122 | server: server, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `server` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | faction: faction, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `faction` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | faction_rank: faction_rank, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `faction_rank` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/players/mod.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | clan: clan [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `clan` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/players/mod.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / match ch.first_child() { [INFO] [stderr] 81 | | Some(f_ch) => { [INFO] [stderr] 82 | | match f_ch.value().as_text() { [INFO] [stderr] 83 | | Some(t) => { [INFO] [stderr] ... | [INFO] [stderr] 92 | | None => {} [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if let Some(f_ch) = ch.first_child() { [INFO] [stderr] 81 | match f_ch.value().as_text() { [INFO] [stderr] 82 | Some(t) => { [INFO] [stderr] 83 | rest.push(match std::str::from_utf8(t.as_bytes()){ [INFO] [stderr] 84 | Ok(x) => x, [INFO] [stderr] 85 | Err(_) => "" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/players/mod.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | / match f_ch.value().as_text() { [INFO] [stderr] 83 | | Some(t) => { [INFO] [stderr] 84 | | rest.push(match std::str::from_utf8(t.as_bytes()){ [INFO] [stderr] 85 | | Ok(x) => x, [INFO] [stderr] ... | [INFO] [stderr] 89 | | None => {} [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(t) = f_ch.value().as_text() { [INFO] [stderr] 83 | rest.push(match std::str::from_utf8(t.as_bytes()){ [INFO] [stderr] 84 | Ok(x) => x, [INFO] [stderr] 85 | Err(_) => "" [INFO] [stderr] 86 | }.to_owned()); [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/players/mod.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | / match ch.first_child() { [INFO] [stderr] 81 | | Some(f_ch) => { [INFO] [stderr] 82 | | match f_ch.value().as_text() { [INFO] [stderr] 83 | | Some(t) => { [INFO] [stderr] ... | [INFO] [stderr] 92 | | None => {} [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 80 | if let Some(f_ch) = ch.first_child() { [INFO] [stderr] 81 | match f_ch.value().as_text() { [INFO] [stderr] 82 | Some(t) => { [INFO] [stderr] 83 | rest.push(match std::str::from_utf8(t.as_bytes()){ [INFO] [stderr] 84 | Ok(x) => x, [INFO] [stderr] 85 | Err(_) => "" [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/players/mod.rs:82:21 [INFO] [stderr] | [INFO] [stderr] 82 | / match f_ch.value().as_text() { [INFO] [stderr] 83 | | Some(t) => { [INFO] [stderr] 84 | | rest.push(match std::str::from_utf8(t.as_bytes()){ [INFO] [stderr] 85 | | Ok(x) => x, [INFO] [stderr] ... | [INFO] [stderr] 89 | | None => {} [INFO] [stderr] 90 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 82 | if let Some(t) = f_ch.value().as_text() { [INFO] [stderr] 83 | rest.push(match std::str::from_utf8(t.as_bytes()){ [INFO] [stderr] 84 | Ok(x) => x, [INFO] [stderr] 85 | Err(_) => "" [INFO] [stderr] 86 | }.to_owned()); [INFO] [stderr] 87 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 45s [INFO] running `"docker" "inspect" "2fd93fa1bed0cfbdaaa88f9fff785b1506e922766b3623046e570c930b5f7cb7"` [INFO] running `"docker" "rm" "-f" "2fd93fa1bed0cfbdaaa88f9fff785b1506e922766b3623046e570c930b5f7cb7"` [INFO] [stdout] 2fd93fa1bed0cfbdaaa88f9fff785b1506e922766b3623046e570c930b5f7cb7