[INFO] crate bmp085 0.1.2 is already in cache [INFO] extracting crate bmp085 0.1.2 into work/ex/clippy-test-run/sources/stable/reg/bmp085/0.1.2 [INFO] extracting crate bmp085 0.1.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bmp085/0.1.2 [INFO] validating manifest of bmp085-0.1.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bmp085-0.1.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bmp085-0.1.2 [INFO] finished frobbing bmp085-0.1.2 [INFO] frobbed toml for bmp085-0.1.2 written to work/ex/clippy-test-run/sources/stable/reg/bmp085/0.1.2/Cargo.toml [INFO] started frobbing bmp085-0.1.2 [INFO] finished frobbing bmp085-0.1.2 [INFO] frobbed toml for bmp085-0.1.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bmp085/0.1.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bmp085-0.1.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bmp085/0.1.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0d189191403ca4a6fabf331e8bc888f40187cc57c060937e41ae2fad1a62db02 [INFO] running `"docker" "start" "-a" "0d189191403ca4a6fabf331e8bc888f40187cc57c060937e41ae2fad1a62db02"` [INFO] [stderr] Checking bmp085 v0.1.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:16 [INFO] [stderr] | [INFO] [stderr] 228 | dev: dev, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dev` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:16 [INFO] [stderr] | [INFO] [stderr] 229 | coeff: coeff, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `coeff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:230:16 [INFO] [stderr] | [INFO] [stderr] 230 | accuracy: accuracy, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `accuracy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | coeff: coeff, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `coeff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:228:16 [INFO] [stderr] | [INFO] [stderr] 228 | dev: dev, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dev` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:229:16 [INFO] [stderr] | [INFO] [stderr] 229 | coeff: coeff, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `coeff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:230:16 [INFO] [stderr] | [INFO] [stderr] 230 | accuracy: accuracy, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `accuracy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:455:13 [INFO] [stderr] | [INFO] [stderr] 455 | coeff: coeff, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `coeff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Bmp` [INFO] [stderr] --> src/lib.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / enum Register { [INFO] [stderr] 43 | | Bmp085CalAC1 = 0xAA, // R Calibration data (16 bits) [INFO] [stderr] 44 | | Bmp085CalAC2 = 0xAC, // R Calibration data (16 bits) [INFO] [stderr] 45 | | Bmp085CalAC3 = 0xAE, // R Calibration data (16 bits) [INFO] [stderr] ... | [INFO] [stderr] 55 | | Bmp085Data = 0xF6, // Pressure & Temp [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | let x1: i32 = ((ut - ac6) as i64 * _ac5 >> 15) as i32; // Note: X>>15 == X/(pow(2,15)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((ut - ac6) as i64 * _ac5) >> 15` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:133:20 [INFO] [stderr] | [INFO] [stderr] 133 | let up: i32 = ((msb << 16) + (lsb << 8) + xlsb >> (8 - sampling)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((msb << 16) + (lsb << 8) + xlsb) >> (8 - sampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:181:21 [INFO] [stderr] | [INFO] [stderr] 181 | let p = if b7 < 0x80000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: field is never used: `cal_mb` [INFO] [stderr] --> src/lib.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | cal_mb: i16, // unused? [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | let ut: i32 = i_to_be(try!(dev.smbus_read_word_data(Register::Bmp085Data as u8))) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(i_to_be(try!(dev.smbus_read_word_data(Register::Bmp085Data as u8))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | let ac6: i32 = coeff.cal_ac6 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | let ac5: i32 = coeff.cal_ac5 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | let md: i32 = coeff.cal_md as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_md)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | let mc: i32 = coeff.cal_mc as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_mc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | let _ac5 = ac5 as i64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(ac5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | let x1: i32 = ((ut - ac6) as i64 * _ac5 >> 15) as i32; // Note: X>>15 == X/(pow(2,15)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(ut - ac6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:129:15 [INFO] [stderr] | [INFO] [stderr] 129 | let msb = try!(dev.smbus_read_byte_data(data_registers[0])) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | let msb = u32::from(match $ expr { [INFO] [stderr] 130 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 131 | :: Err ( err ) => { [INFO] [stderr] 132 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 133 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:130:15 [INFO] [stderr] | [INFO] [stderr] 130 | let lsb = try!(dev.smbus_read_byte_data(data_registers[1])) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | let lsb = u32::from(match $ expr { [INFO] [stderr] 131 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 132 | :: Err ( err ) => { [INFO] [stderr] 133 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 134 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | let xlsb = try!(dev.smbus_read_byte_data(data_registers[2])) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | let xlsb = u32::from(match $ expr { [INFO] [stderr] 132 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 133 | :: Err ( err ) => { [INFO] [stderr] 134 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 135 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | let b1: i32 = coeff.cal_b1 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_b1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | let b2: i32 = coeff.cal_b2 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | let ac1: i32 = coeff.cal_ac1 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:20 [INFO] [stderr] | [INFO] [stderr] 162 | let ac2: i32 = coeff.cal_ac2 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | let ac3: i32 = coeff.cal_ac3 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | let ac4: u32 = coeff.cal_ac4 as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(coeff.cal_ac4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: All variants have the same prefix: `Bmp` [INFO] [stderr] --> src/lib.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | / enum Register { [INFO] [stderr] 43 | | Bmp085CalAC1 = 0xAA, // R Calibration data (16 bits) [INFO] [stderr] 44 | | Bmp085CalAC2 = 0xAC, // R Calibration data (16 bits) [INFO] [stderr] 45 | | Bmp085CalAC3 = 0xAE, // R Calibration data (16 bits) [INFO] [stderr] ... | [INFO] [stderr] 55 | | Bmp085Data = 0xF6, // Pressure & Temp [INFO] [stderr] 56 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::enum_variant_names)] on by default [INFO] [stderr] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | let x1: i32 = ((ut - ac6) as i64 * _ac5 >> 15) as i32; // Note: X>>15 == X/(pow(2,15)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((ut - ac6) as i64 * _ac5) >> 15` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::precedence)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: operator precedence can trip the unwary [INFO] [stderr] --> src/lib.rs:133:20 [INFO] [stderr] | [INFO] [stderr] 133 | let up: i32 = ((msb << 16) + (lsb << 8) + xlsb >> (8 - sampling)) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider parenthesizing your expression: `((msb << 16) + (lsb << 8) + xlsb) >> (8 - sampling)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:181:21 [INFO] [stderr] | [INFO] [stderr] 181 | let p = if b7 < 0x80000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/lib.rs:508:13 [INFO] [stderr] | [INFO] [stderr] 508 | for i in 0..n { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:90:19 [INFO] [stderr] | [INFO] [stderr] 90 | let ut: i32 = i_to_be(try!(dev.smbus_read_word_data(Register::Bmp085Data as u8))) as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(i_to_be(try!(dev.smbus_read_word_data(Register::Bmp085Data as u8))))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:91:20 [INFO] [stderr] | [INFO] [stderr] 91 | let ac6: i32 = coeff.cal_ac6 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:92:20 [INFO] [stderr] | [INFO] [stderr] 92 | let ac5: i32 = coeff.cal_ac5 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:93:19 [INFO] [stderr] | [INFO] [stderr] 93 | let md: i32 = coeff.cal_md as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_md)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:94:19 [INFO] [stderr] | [INFO] [stderr] 94 | let mc: i32 = coeff.cal_mc as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_mc)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:97:16 [INFO] [stderr] | [INFO] [stderr] 97 | let _ac5 = ac5 as i64; [INFO] [stderr] | ^^^^^^^^^^ help: try: `i64::from(ac5)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:98:20 [INFO] [stderr] | [INFO] [stderr] 98 | let x1: i32 = ((ut - ac6) as i64 * _ac5 >> 15) as i32; // Note: X>>15 == X/(pow(2,15)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `i64::from(ut - ac6)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:129:15 [INFO] [stderr] | [INFO] [stderr] 129 | let msb = try!(dev.smbus_read_byte_data(data_registers[0])) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 129 | let msb = u32::from(match $ expr { [INFO] [stderr] 130 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 131 | :: Err ( err ) => { [INFO] [stderr] 132 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 133 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:130:15 [INFO] [stderr] | [INFO] [stderr] 130 | let lsb = try!(dev.smbus_read_byte_data(data_registers[1])) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 130 | let lsb = u32::from(match $ expr { [INFO] [stderr] 131 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 132 | :: Err ( err ) => { [INFO] [stderr] 133 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 134 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:131:16 [INFO] [stderr] | [INFO] [stderr] 131 | let xlsb = try!(dev.smbus_read_byte_data(data_registers[2])) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 131 | let xlsb = u32::from(match $ expr { [INFO] [stderr] 132 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 133 | :: Err ( err ) => { [INFO] [stderr] 134 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 135 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:159:19 [INFO] [stderr] | [INFO] [stderr] 159 | let b1: i32 = coeff.cal_b1 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_b1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:160:19 [INFO] [stderr] | [INFO] [stderr] 160 | let b2: i32 = coeff.cal_b2 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_b2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:161:20 [INFO] [stderr] | [INFO] [stderr] 161 | let ac1: i32 = coeff.cal_ac1 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac1)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:162:20 [INFO] [stderr] | [INFO] [stderr] 162 | let ac2: i32 = coeff.cal_ac2 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac2)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:163:20 [INFO] [stderr] | [INFO] [stderr] 163 | let ac3: i32 = coeff.cal_ac3 as i32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `i32::from(coeff.cal_ac3)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:164:20 [INFO] [stderr] | [INFO] [stderr] 164 | let ac4: u32 = coeff.cal_ac4 as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(coeff.cal_ac4)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | assert_eq!(dev.pressure_kpa().unwrap(), 69.964); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:472:9 [INFO] [stderr] | [INFO] [stderr] 472 | assert_eq!(dev.pressure_kpa().unwrap(), 69.964); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | assert_eq!(dev.pressure_kpa().unwrap(), 1.234); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:480:9 [INFO] [stderr] | [INFO] [stderr] 480 | assert_eq!(dev.pressure_kpa().unwrap(), 1.234); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:487:9 [INFO] [stderr] | [INFO] [stderr] 487 | assert_eq!(dev.temperature_celsius().unwrap(), 15.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:487:9 [INFO] [stderr] | [INFO] [stderr] 487 | assert_eq!(dev.temperature_celsius().unwrap(), 15.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:494:9 [INFO] [stderr] | [INFO] [stderr] 494 | assert_eq!(dev.temperature_celsius().unwrap(), -139.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:494:9 [INFO] [stderr] | [INFO] [stderr] 494 | assert_eq!(dev.temperature_celsius().unwrap(), -139.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | assert_eq!(dev.temperature_celsius().unwrap(), -139.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:501:9 [INFO] [stderr] | [INFO] [stderr] 501 | assert_eq!(dev.temperature_celsius().unwrap(), -139.2); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bmp085`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "0d189191403ca4a6fabf331e8bc888f40187cc57c060937e41ae2fad1a62db02"` [INFO] running `"docker" "rm" "-f" "0d189191403ca4a6fabf331e8bc888f40187cc57c060937e41ae2fad1a62db02"` [INFO] [stdout] 0d189191403ca4a6fabf331e8bc888f40187cc57c060937e41ae2fad1a62db02