[INFO] crate bmidi 0.0.2 is already in cache [INFO] extracting crate bmidi 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/bmidi/0.0.2 [INFO] extracting crate bmidi 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bmidi/0.0.2 [INFO] validating manifest of bmidi-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bmidi-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bmidi-0.0.2 [INFO] finished frobbing bmidi-0.0.2 [INFO] frobbed toml for bmidi-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/bmidi/0.0.2/Cargo.toml [INFO] started frobbing bmidi-0.0.2 [INFO] finished frobbing bmidi-0.0.2 [INFO] frobbed toml for bmidi-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bmidi/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bmidi-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bmidi/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6fcf5441556b463fd5380376008d692dd9c1c09825994b6496d001f6366441a5 [INFO] running `"docker" "start" "-a" "6fcf5441556b463fd5380376008d692dd9c1c09825994b6496d001f6366441a5"` [INFO] [stderr] Checking pitch_calc v0.11.1 [INFO] [stderr] Checking bmidi v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | File { format: format, division: division, tracks: tracks } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | File { format: format, division: division, tracks: tracks } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `division` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:76:52 [INFO] [stderr] | [INFO] [stderr] 76 | File { format: format, division: division, tracks: tracks } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tracks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | Key {typ: typ, note: note, velocity: velocity} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:161:32 [INFO] [stderr] | [INFO] [stderr] 161 | Key {typ: typ, note: note, velocity: velocity} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `note` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:161:44 [INFO] [stderr] | [INFO] [stderr] 161 | Key {typ: typ, note: note, velocity: velocity} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `velocity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:190:28 [INFO] [stderr] | [INFO] [stderr] 190 | Meta { typ: typ, data: data } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:190:38 [INFO] [stderr] | [INFO] [stderr] 190 | Meta { typ: typ, data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combined_iterator.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | iter: iter [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combined_iterator.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | states: states, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `states` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combined_iterator.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | heap: heap [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `heap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:76:16 [INFO] [stderr] | [INFO] [stderr] 76 | File { format: format, division: division, tracks: tracks } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:76:32 [INFO] [stderr] | [INFO] [stderr] 76 | File { format: format, division: division, tracks: tracks } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `division` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:76:52 [INFO] [stderr] | [INFO] [stderr] 76 | File { format: format, division: division, tracks: tracks } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tracks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | reader: reader, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:161:22 [INFO] [stderr] | [INFO] [stderr] 161 | Key {typ: typ, note: note, velocity: velocity} [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:161:32 [INFO] [stderr] | [INFO] [stderr] 161 | Key {typ: typ, note: note, velocity: velocity} [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `note` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:161:44 [INFO] [stderr] | [INFO] [stderr] 161 | Key {typ: typ, note: note, velocity: velocity} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `velocity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:190:28 [INFO] [stderr] | [INFO] [stderr] 190 | Meta { typ: typ, data: data } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `typ` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reader.rs:190:38 [INFO] [stderr] | [INFO] [stderr] 190 | Meta { typ: typ, data: data } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combined_iterator.rs:36:21 [INFO] [stderr] | [INFO] [stderr] 36 | iter: iter [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combined_iterator.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | states: states, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `states` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/combined_iterator.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | heap: heap [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `heap` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let ref track = self.tracks[index]; [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let track = &self.tracks[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parser.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | let iter = track.into_iter().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `track.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/parser.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | let iter = track.into_iter().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | let division = reader.read_short() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reader.read_short())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | Ok((res[0] as u16) << 8 | (res[1] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(res[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | Ok((res[0] as u16) << 8 | (res[1] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(res[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | Ok((((res[0] as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(res[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | | (res[1] as u32)) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(res[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | | (res[2] as u32)) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(res[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | | (res[3] as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(res[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | let next_byte = try!(self.read_byte()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | let next_byte = u32::from(match $ expr { [INFO] [stderr] 44 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 45 | :: Err ( err ) => { [INFO] [stderr] 46 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 47 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/reader.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | self.running_status; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | value: ((first_byte as u16) << 7) | self.read_byte() as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(first_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:174:53 [INFO] [stderr] | [INFO] [stderr] 174 | value: ((first_byte as u16) << 7) | self.read_byte() as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/note.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn to_step(&self) -> Step { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/note.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | Step(self.0 as f32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/combined_iterator.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | let state = self.states.get_mut(item.track).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.states[item.track]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/parser.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | let ref track = self.tracks[index]; [INFO] [stderr] | ----^^^^^^^^^---------------------- help: try: `let track = &self.tracks[index];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/parser.rs:20:20 [INFO] [stderr] | [INFO] [stderr] 20 | let iter = track.into_iter().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `track.into_iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/parser.rs:20:26 [INFO] [stderr] | [INFO] [stderr] 20 | let iter = track.into_iter().map(|x| *x); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u32 may become silently lossy if types change [INFO] [stderr] --> src/parser.rs:54:24 [INFO] [stderr] | [INFO] [stderr] 54 | let division = reader.read_short() as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(reader.read_short())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:27:12 [INFO] [stderr] | [INFO] [stderr] 27 | Ok((res[0] as u16) << 8 | (res[1] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(res[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:27:35 [INFO] [stderr] | [INFO] [stderr] 27 | Ok((res[0] as u16) << 8 | (res[1] as u16)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u16::from(res[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:33:14 [INFO] [stderr] | [INFO] [stderr] 33 | Ok((((res[0] as u32) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(res[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:34:13 [INFO] [stderr] | [INFO] [stderr] 34 | | (res[1] as u32)) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(res[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | | (res[2] as u32)) << 8 [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(res[2])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | | (res[3] as u32)) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u32::from(res[3])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:43:29 [INFO] [stderr] | [INFO] [stderr] 43 | let next_byte = try!(self.read_byte()) as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 43 | let next_byte = u32::from(match $ expr { [INFO] [stderr] 44 | $ crate :: result :: Result :: Ok ( val ) => val , $ crate :: result :: Result [INFO] [stderr] 45 | :: Err ( err ) => { [INFO] [stderr] 46 | return $ crate :: result :: Result :: Err ( [INFO] [stderr] 47 | $ crate :: convert :: From :: from ( err ) ) } }); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: statement with no effect [INFO] [stderr] --> src/reader.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | self.running_status; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::no_effect)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#no_effect [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:174:25 [INFO] [stderr] | [INFO] [stderr] 174 | value: ((first_byte as u16) << 7) | self.read_byte() as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(first_byte)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/reader.rs:174:53 [INFO] [stderr] | [INFO] [stderr] 174 | value: ((first_byte as u16) << 7) | self.read_byte() as u16 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.read_byte())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/note.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn to_step(&self) -> Step { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/note.rs:16:14 [INFO] [stderr] | [INFO] [stderr] 16 | Step(self.0 as f32) [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `f32::from(self.0)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `.get_mut().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/combined_iterator.rs:55:25 [INFO] [stderr] | [INFO] [stderr] 55 | let state = self.states.get_mut(item.track).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.states[item.track]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.84s [INFO] running `"docker" "inspect" "6fcf5441556b463fd5380376008d692dd9c1c09825994b6496d001f6366441a5"` [INFO] running `"docker" "rm" "-f" "6fcf5441556b463fd5380376008d692dd9c1c09825994b6496d001f6366441a5"` [INFO] [stdout] 6fcf5441556b463fd5380376008d692dd9c1c09825994b6496d001f6366441a5