[INFO] crate blurmock 0.1.3 is already in cache [INFO] extracting crate blurmock 0.1.3 into work/ex/clippy-test-run/sources/stable/reg/blurmock/0.1.3 [INFO] extracting crate blurmock 0.1.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blurmock/0.1.3 [INFO] validating manifest of blurmock-0.1.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blurmock-0.1.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blurmock-0.1.3 [INFO] finished frobbing blurmock-0.1.3 [INFO] frobbed toml for blurmock-0.1.3 written to work/ex/clippy-test-run/sources/stable/reg/blurmock/0.1.3/Cargo.toml [INFO] started frobbing blurmock-0.1.3 [INFO] finished frobbing blurmock-0.1.3 [INFO] frobbed toml for blurmock-0.1.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blurmock/0.1.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blurmock-0.1.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blurmock/0.1.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14edbe392dc3233a2179e8c85afc539b3d27924c5049ee54cd1a9bbfd160935e [INFO] running `"docker" "start" "-a" "14edbe392dc3233a2179e8c85afc539b3d27924c5049ee54cd1a9bbfd160935e"` [INFO] [stderr] Checking blurmock v0.1.3 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fake_discovery_session.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | adapter: adapter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `adapter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/fake_discovery_session.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | adapter: adapter, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `adapter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_adapter.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_adapter.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_device.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_device.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fake_device.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | return Err(Box::from("Could not connect to the device.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::from("Could not connect to the device."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fake_device.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | return Err(Box::from("The device is not connected.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::from("The device is not connected."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_service.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_service.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_characteristic.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_characteristic.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_descriptor.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_descriptor.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_adapter.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_adapter.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_device.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_device.rs:118:5 [INFO] [stderr] | [INFO] [stderr] 118 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fake_device.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | return Err(Box::from("Could not connect to the device.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::from("Could not connect to the device."))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/fake_device.rs:325:9 [INFO] [stderr] | [INFO] [stderr] 325 | return Err(Box::from("The device is not connected.")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(Box::from("The device is not connected."))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_service.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_service.rs:53:5 [INFO] [stderr] | [INFO] [stderr] 53 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_characteristic.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_characteristic.rs:57:5 [INFO] [stderr] | [INFO] [stderr] 57 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/lib.rs:23:13 [INFO] [stderr] | [INFO] [stderr] 23 | attr_value [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_descriptor.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/lib.rs:19:30 [INFO] [stderr] | [INFO] [stderr] 19 | let attr_value = match cloned.lock() { [INFO] [stderr] | ______________________________^ [INFO] [stderr] 20 | | Ok(guard) => guard.deref().clone(), [INFO] [stderr] 21 | | Err(_) => String::new(), [INFO] [stderr] 22 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/fake_descriptor.rs:48:5 [INFO] [stderr] | [INFO] [stderr] 48 | make_getter!(get_id, id); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (18/7) [INFO] [stderr] --> src/fake_adapter.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new(id: String, [INFO] [stderr] 32 | | is_present: bool, [INFO] [stderr] 33 | | is_powered: bool, [INFO] [stderr] 34 | | can_start_discovery: bool, [INFO] [stderr] ... | [INFO] [stderr] 69 | | }) [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:52:34 [INFO] [stderr] | [INFO] [stderr] 52 | is_present: Arc::new(Mutex::new(is_present)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | is_powered: Arc::new(Mutex::new(is_powered)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:54:43 [INFO] [stderr] | [INFO] [stderr] 54 | can_start_discovery: Arc::new(Mutex::new(can_start_discovery)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | can_stop_discovery: Arc::new(Mutex::new(can_stop_discovery)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | is_discoverable: Arc::new(Mutex::new(is_discoverable)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:63:35 [INFO] [stderr] | [INFO] [stderr] 63 | is_pairable: Arc::new(Mutex::new(is_pairable)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:66:38 [INFO] [stderr] | [INFO] [stderr] 66 | is_discovering: Arc::new(Mutex::new(is_discovering)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (18/7) [INFO] [stderr] --> src/fake_adapter.rs:31:5 [INFO] [stderr] | [INFO] [stderr] 31 | / pub fn new(id: String, [INFO] [stderr] 32 | | is_present: bool, [INFO] [stderr] 33 | | is_powered: bool, [INFO] [stderr] 34 | | can_start_discovery: bool, [INFO] [stderr] ... | [INFO] [stderr] 69 | | }) [INFO] [stderr] 70 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_adapter.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | Ok(devices.push(device)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 198 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:52:34 [INFO] [stderr] | [INFO] [stderr] 52 | is_present: Arc::new(Mutex::new(is_present)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::mutex_atomic)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:53:34 [INFO] [stderr] | [INFO] [stderr] 53 | is_powered: Arc::new(Mutex::new(is_powered)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:54:43 [INFO] [stderr] | [INFO] [stderr] 54 | can_start_discovery: Arc::new(Mutex::new(can_start_discovery)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_adapter.rs:207:12 [INFO] [stderr] | [INFO] [stderr] 207 | Ok(devices.retain(|d| d.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 207 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:55:42 [INFO] [stderr] | [INFO] [stderr] 55 | can_stop_discovery: Arc::new(Mutex::new(can_stop_discovery)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:62:39 [INFO] [stderr] | [INFO] [stderr] 62 | is_discoverable: Arc::new(Mutex::new(is_discoverable)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:63:35 [INFO] [stderr] | [INFO] [stderr] 63 | is_pairable: Arc::new(Mutex::new(is_pairable)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_adapter.rs:66:38 [INFO] [stderr] | [INFO] [stderr] 66 | is_discovering: Arc::new(Mutex::new(is_discovering)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fake_adapter.rs:228:45 [INFO] [stderr] | [INFO] [stderr] 228 | let ids: Vec<&str> = modalias.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | (vendor[0] as u32) * 16 * 16 + (vendor[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vendor[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:236:40 [INFO] [stderr] | [INFO] [stderr] 236 | (vendor[0] as u32) * 16 * 16 + (vendor[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vendor[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | (product[0] as u32) * 16 * 16 + (product[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(product[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:237:41 [INFO] [stderr] | [INFO] [stderr] 237 | (product[0] as u32) * 16 * 16 + (product[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(product[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | (device[0] as u32) * 16 * 16 + (device[1] as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(device[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:238:40 [INFO] [stderr] | [INFO] [stderr] 238 | (device[0] as u32) * 16 * 16 + (device[1] as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(device[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fake_device.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | manufacturer_data: Arc>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fake_device.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | service_data: Arc>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (22/7) [INFO] [stderr] --> src/fake_device.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new(id: String, [INFO] [stderr] 37 | | adapter: Arc, [INFO] [stderr] 38 | | address: String, [INFO] [stderr] 39 | | appearance: Option, [INFO] [stderr] ... | [INFO] [stderr] 87 | | device [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | is_paired: Arc::new(Mutex::new(is_paired)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | is_connectable: Arc::new(Mutex::new(is_connectable)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | is_connected: Arc::new(Mutex::new(is_connected)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:72:34 [INFO] [stderr] | [INFO] [stderr] 72 | is_trusted: Arc::new(Mutex::new(is_trusted)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | is_blocked: Arc::new(Mutex::new(is_blocked)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | is_legacy_pairing: Arc::new(Mutex::new(is_legacy_pairing)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_adapter.rs:198:12 [INFO] [stderr] | [INFO] [stderr] 198 | Ok(devices.push(device)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 198 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_adapter.rs:207:12 [INFO] [stderr] | [INFO] [stderr] 207 | Ok(devices.retain(|d| d.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 207 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fake_adapter.rs:228:45 [INFO] [stderr] | [INFO] [stderr] 228 | let ids: Vec<&str> = modalias.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | (vendor[0] as u32) * 16 * 16 + (vendor[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vendor[0])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:236:40 [INFO] [stderr] | [INFO] [stderr] 236 | (vendor[0] as u32) * 16 * 16 + (vendor[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vendor[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | (product[0] as u32) * 16 * 16 + (product[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(product[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:237:41 [INFO] [stderr] | [INFO] [stderr] 237 | (product[0] as u32) * 16 * 16 + (product[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(product[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:238:9 [INFO] [stderr] | [INFO] [stderr] 238 | (device[0] as u32) * 16 * 16 + (device[1] as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(device[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_adapter.rs:238:40 [INFO] [stderr] | [INFO] [stderr] 238 | (device[0] as u32) * 16 * 16 + (device[1] as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(device[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fake_device.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | manufacturer_data: Arc>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/fake_device.rs:32:19 [INFO] [stderr] | [INFO] [stderr] 32 | service_data: Arc>>>>, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (22/7) [INFO] [stderr] --> src/fake_device.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | / pub fn new(id: String, [INFO] [stderr] 37 | | adapter: Arc, [INFO] [stderr] 38 | | address: String, [INFO] [stderr] 39 | | appearance: Option, [INFO] [stderr] ... | [INFO] [stderr] 87 | | device [INFO] [stderr] 88 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fake_device.rs:211:45 [INFO] [stderr] | [INFO] [stderr] 211 | let ids: Vec<&str> = modalias.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | (vendor[0] as u32) * 16 * 16 + (vendor[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vendor[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:218:40 [INFO] [stderr] | [INFO] [stderr] 218 | (vendor[0] as u32) * 16 * 16 + (vendor[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vendor[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | (product[0] as u32) * 16 * 16 + (product[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(product[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:219:41 [INFO] [stderr] | [INFO] [stderr] 219 | (product[0] as u32) * 16 * 16 + (product[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(product[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | (device[0] as u32) * 16 * 16 + (device[1] as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(device[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:220:40 [INFO] [stderr] | [INFO] [stderr] 220 | (device[0] as u32) * 16 * 16 + (device[1] as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(device[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:69:33 [INFO] [stderr] | [INFO] [stderr] 69 | is_paired: Arc::new(Mutex::new(is_paired)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:70:38 [INFO] [stderr] | [INFO] [stderr] 70 | is_connectable: Arc::new(Mutex::new(is_connectable)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:71:36 [INFO] [stderr] | [INFO] [stderr] 71 | is_connected: Arc::new(Mutex::new(is_connected)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:72:34 [INFO] [stderr] | [INFO] [stderr] 72 | is_trusted: Arc::new(Mutex::new(is_trusted)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:73:34 [INFO] [stderr] | [INFO] [stderr] 73 | is_blocked: Arc::new(Mutex::new(is_blocked)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_device.rs:74:41 [INFO] [stderr] | [INFO] [stderr] 74 | is_legacy_pairing: Arc::new(Mutex::new(is_legacy_pairing)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_device.rs:286:12 [INFO] [stderr] | [INFO] [stderr] 286 | Ok(gatt_services.push(service)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 286 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_device.rs:295:12 [INFO] [stderr] | [INFO] [stderr] 295 | Ok(gatt_services.retain(|s| s.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 295 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_service.rs:32:34 [INFO] [stderr] | [INFO] [stderr] 32 | is_primary: Arc::new(Mutex::new(is_primary)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/fake_device.rs:211:45 [INFO] [stderr] | [INFO] [stderr] 211 | let ids: Vec<&str> = modalias.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:218:9 [INFO] [stderr] | [INFO] [stderr] 218 | (vendor[0] as u32) * 16 * 16 + (vendor[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vendor[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_service.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(gatt_characteristics.push(characteristic)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:218:40 [INFO] [stderr] | [INFO] [stderr] 218 | (vendor[0] as u32) * 16 * 16 + (vendor[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(vendor[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 99 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | (product[0] as u32) * 16 * 16 + (product[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(product[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:219:41 [INFO] [stderr] | [INFO] [stderr] 219 | (product[0] as u32) * 16 * 16 + (product[1] as u32), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(product[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:220:9 [INFO] [stderr] | [INFO] [stderr] 220 | (device[0] as u32) * 16 * 16 + (device[1] as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(device[0])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/fake_device.rs:220:40 [INFO] [stderr] | [INFO] [stderr] 220 | (device[0] as u32) * 16 * 16 + (device[1] as u32))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u32::from(device[1])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_service.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | Ok(gatt_characteristics.retain(|c| c.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 108 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_service.rs:117:12 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(included_services.push(service)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 117 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_service.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | Ok(included_services.retain(|i| i.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 126 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_characteristic.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | is_notifying: Arc::new(Mutex::new(is_notifying)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_device.rs:286:12 [INFO] [stderr] | [INFO] [stderr] 286 | Ok(gatt_services.push(service)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 286 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_device.rs:295:12 [INFO] [stderr] | [INFO] [stderr] 295 | Ok(gatt_services.retain(|s| s.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 295 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_characteristic.rs:117:12 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(gatt_descriptors.push(descriptor)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 117 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_characteristic.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | Ok(gatt_descriptors.retain(|d| d.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] --> src/fake_service.rs:32:34 [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] 126 | Ok(()) [INFO] [stderr] 32 | is_primary: Arc::new(Mutex::new(is_primary)), [INFO] [stderr] | ^^ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_service.rs:99:12 [INFO] [stderr] | [INFO] [stderr] 99 | Ok(gatt_characteristics.push(characteristic)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 99 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_service.rs:108:12 [INFO] [stderr] | [INFO] [stderr] 108 | Ok(gatt_characteristics.retain(|c| c.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 108 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_service.rs:117:12 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(included_services.push(service)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 117 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_service.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | Ok(included_services.retain(|i| i.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 126 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: Consider using an AtomicBool instead of a Mutex here. If you just want the locking behaviour and not the internal type, consider using Mutex<()>. [INFO] [stderr] --> src/fake_characteristic.rs:35:36 [INFO] [stderr] | [INFO] [stderr] 35 | is_notifying: Arc::new(Mutex::new(is_notifying)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mutex_atomic [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_characteristic.rs:117:12 [INFO] [stderr] | [INFO] [stderr] 117 | Ok(gatt_descriptors.push(descriptor)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 117 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/fake_characteristic.rs:126:12 [INFO] [stderr] | [INFO] [stderr] 126 | Ok(gatt_descriptors.retain(|d| d.get_id() != id)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 126 | Ok(()) [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.61s [INFO] running `"docker" "inspect" "14edbe392dc3233a2179e8c85afc539b3d27924c5049ee54cd1a9bbfd160935e"` [INFO] running `"docker" "rm" "-f" "14edbe392dc3233a2179e8c85afc539b3d27924c5049ee54cd1a9bbfd160935e"` [INFO] [stdout] 14edbe392dc3233a2179e8c85afc539b3d27924c5049ee54cd1a9bbfd160935e