[INFO] crate blossom 0.3.3 is already in cache [INFO] extracting crate blossom 0.3.3 into work/ex/clippy-test-run/sources/stable/reg/blossom/0.3.3 [INFO] extracting crate blossom 0.3.3 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blossom/0.3.3 [INFO] validating manifest of blossom-0.3.3 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blossom-0.3.3 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blossom-0.3.3 [INFO] finished frobbing blossom-0.3.3 [INFO] frobbed toml for blossom-0.3.3 written to work/ex/clippy-test-run/sources/stable/reg/blossom/0.3.3/Cargo.toml [INFO] started frobbing blossom-0.3.3 [INFO] finished frobbing blossom-0.3.3 [INFO] frobbed toml for blossom-0.3.3 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blossom/0.3.3/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blossom-0.3.3 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blossom/0.3.3:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 05414fe66372e3e7f7f18c6b29616de9167a9d09cfc380ccbee522b02b4fd529 [INFO] running `"docker" "start" "-a" "05414fe66372e3e7f7f18c6b29616de9167a9d09cfc380ccbee522b02b4fd529"` [INFO] [stderr] Checking blossom v0.3.3 (/opt/crater/workdir) [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/graph.rs:219:14 [INFO] [stderr] | [INFO] [stderr] 219 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/weighted.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / if self.full_matching().is_none() { [INFO] [stderr] 20 | | return None; [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.full_matching()?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice [INFO] [stderr] --> src/graph.rs:219:14 [INFO] [stderr] | [INFO] [stderr] 219 | .into_iter() [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/graph.rs:444:28 [INFO] [stderr] | [INFO] [stderr] 444 | let gc = g.contract(1, &vec![2]); [INFO] [stderr] | ^^^^^^^^ help: you can use a slice directly: `&[2]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/graph.rs:457:28 [INFO] [stderr] | [INFO] [stderr] 457 | let gc = g.contract(2, &vec![1]); [INFO] [stderr] | ^^^^^^^^ help: you can use a slice directly: `&[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `REP` [INFO] [stderr] --> src/graph.rs:566:27 [INFO] [stderr] | [INFO] [stderr] 566 | test_random(1000, 1 * REP) [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/graph.rs:579:27 [INFO] [stderr] | [INFO] [stderr] 579 | let m = Matching::new(&vec![]); [INFO] [stderr] | ^^^^^^^ help: you can use a slice directly: `&[]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/graph.rs:593:27 [INFO] [stderr] | [INFO] [stderr] 593 | let m = Matching::new(&vec![(1, 2)]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[(1, 2)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/graph.rs:611:27 [INFO] [stderr] | [INFO] [stderr] 611 | let m = Matching::new(&vec![(1, 2)]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[(1, 2)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/graph.rs:629:27 [INFO] [stderr] | [INFO] [stderr] 629 | let m = Matching::new(&vec![(1, 2)]); [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[(1, 2)]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: this block may be rewritten with the `?` operator [INFO] [stderr] --> src/weighted.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | / if self.full_matching().is_none() { [INFO] [stderr] 20 | | return None; [INFO] [stderr] 21 | | } [INFO] [stderr] | |_________^ help: replace_it_with: `self.full_matching()?;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::question_mark)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.66s [INFO] running `"docker" "inspect" "05414fe66372e3e7f7f18c6b29616de9167a9d09cfc380ccbee522b02b4fd529"` [INFO] running `"docker" "rm" "-f" "05414fe66372e3e7f7f18c6b29616de9167a9d09cfc380ccbee522b02b4fd529"` [INFO] [stdout] 05414fe66372e3e7f7f18c6b29616de9167a9d09cfc380ccbee522b02b4fd529