[INFO] crate blorb 0.1.0 is already in cache [INFO] extracting crate blorb 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/blorb/0.1.0 [INFO] extracting crate blorb 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blorb/0.1.0 [INFO] validating manifest of blorb-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blorb-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blorb-0.1.0 [INFO] finished frobbing blorb-0.1.0 [INFO] frobbed toml for blorb-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/blorb/0.1.0/Cargo.toml [INFO] started frobbing blorb-0.1.0 [INFO] finished frobbing blorb-0.1.0 [INFO] frobbed toml for blorb-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blorb/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blorb-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blorb/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3d3180cea4340af5aa47ee9b48010f966d7679418cbca1d7cb775fed3f0831a5 [INFO] running `"docker" "start" "-a" "3d3180cea4340af5aa47ee9b48010f966d7679418cbca1d7cb775fed3f0831a5"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking blorb v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:165:62 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(Chunk::ResourceIndex{index: ResourceIndex{entries:entries}}) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:175:35 [INFO] [stderr] | [INFO] [stderr] 175 | Ok(Chunk::Unknown{meta: meta, data: data}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:175:47 [INFO] [stderr] | [INFO] [stderr] 175 | Ok(Chunk::Unknown{meta: meta, data: data}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:197:23 [INFO] [stderr] | [INFO] [stderr] 197 | Ok(IndexEntry{usage: usage, num: num, start: start}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:197:37 [INFO] [stderr] | [INFO] [stderr] 197 | Ok(IndexEntry{usage: usage, num: num, start: start}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:197:47 [INFO] [stderr] | [INFO] [stderr] 197 | Ok(IndexEntry{usage: usage, num: num, start: start}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(ChunkData{id: id, len: len}) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:205:30 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(ChunkData{id: id, len: len}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | index: index, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `index` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | file: file, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:165:62 [INFO] [stderr] | [INFO] [stderr] 165 | Ok(Chunk::ResourceIndex{index: ResourceIndex{entries:entries}}) [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `entries` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:175:35 [INFO] [stderr] | [INFO] [stderr] 175 | Ok(Chunk::Unknown{meta: meta, data: data}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `meta` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:175:47 [INFO] [stderr] | [INFO] [stderr] 175 | Ok(Chunk::Unknown{meta: meta, data: data}) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:197:23 [INFO] [stderr] | [INFO] [stderr] 197 | Ok(IndexEntry{usage: usage, num: num, start: start}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `usage` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:197:37 [INFO] [stderr] | [INFO] [stderr] 197 | Ok(IndexEntry{usage: usage, num: num, start: start}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:197:47 [INFO] [stderr] | [INFO] [stderr] 197 | Ok(IndexEntry{usage: usage, num: num, start: start}) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:205:22 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(ChunkData{id: id, len: len}) [INFO] [stderr] | ^^^^^^ help: replace it with: `id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/blorb.rs:205:30 [INFO] [stderr] | [INFO] [stderr] 205 | Ok(ChunkData{id: id, len: len}) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blorb.rs:147:45 [INFO] [stderr] | [INFO] [stderr] 147 | try!(self.file.seek(SeekFrom::Start(entry.start as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blorb.rs:147:45 [INFO] [stderr] | [INFO] [stderr] 147 | try!(self.file.seek(SeekFrom::Start(entry.start as u64))); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `u64::from(entry.start)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blorb.rs:169:32 [INFO] [stderr] | [INFO] [stderr] 169 | try!(file.take(meta.len as u64).read_to_end(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(meta.len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blorb.rs:174:32 [INFO] [stderr] | [INFO] [stderr] 174 | try!(file.take(meta.len as u64).read_to_end(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(meta.len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blorb.rs:169:32 [INFO] [stderr] | [INFO] [stderr] 169 | try!(file.take(meta.len as u64).read_to_end(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(meta.len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/blorb.rs:174:32 [INFO] [stderr] | [INFO] [stderr] 174 | try!(file.take(meta.len as u64).read_to_end(&mut data)); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `u64::from(meta.len)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.97s [INFO] running `"docker" "inspect" "3d3180cea4340af5aa47ee9b48010f966d7679418cbca1d7cb775fed3f0831a5"` [INFO] running `"docker" "rm" "-f" "3d3180cea4340af5aa47ee9b48010f966d7679418cbca1d7cb775fed3f0831a5"` [INFO] [stdout] 3d3180cea4340af5aa47ee9b48010f966d7679418cbca1d7cb775fed3f0831a5