[INFO] crate bloomfilter 0.0.12 is already in cache [INFO] extracting crate bloomfilter 0.0.12 into work/ex/clippy-test-run/sources/stable/reg/bloomfilter/0.0.12 [INFO] extracting crate bloomfilter 0.0.12 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bloomfilter/0.0.12 [INFO] validating manifest of bloomfilter-0.0.12 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bloomfilter-0.0.12 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bloomfilter-0.0.12 [INFO] finished frobbing bloomfilter-0.0.12 [INFO] frobbed toml for bloomfilter-0.0.12 written to work/ex/clippy-test-run/sources/stable/reg/bloomfilter/0.0.12/Cargo.toml [INFO] started frobbing bloomfilter-0.0.12 [INFO] finished frobbing bloomfilter-0.0.12 [INFO] frobbed toml for bloomfilter-0.0.12 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bloomfilter/0.0.12/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bloomfilter-0.0.12 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bloomfilter/0.0.12:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ffd8b2741aed94c1a27a548b3aaee1b2be43604c814bdd093329449ea5a2d1e [INFO] running `"docker" "start" "-a" "1ffd8b2741aed94c1a27a548b3aaee1b2be43604c814bdd093329449ea5a2d1e"` [INFO] [stderr] Checking bloomfilter v0.0.12 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | bitmap_bits: bitmap_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bitmap_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | k_num: k_num, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `k_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | sips: sips, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sips` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | bitmap_bits: bitmap_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bitmap_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | k_num: k_num, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `k_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | sips: sips, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sips` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | bitmap: bitmap, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `bitmap` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:49:13 [INFO] [stderr] | [INFO] [stderr] 49 | bitmap_bits: bitmap_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bitmap_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | k_num: k_num, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `k_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | sips: sips, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sips` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:77:13 [INFO] [stderr] | [INFO] [stderr] 77 | bitmap_bits: bitmap_bits, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bitmap_bits` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | k_num: k_num, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `k_num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bloomfilter/lib.rs:79:13 [INFO] [stderr] | [INFO] [stderr] 79 | sips: sips, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sips` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bloomfilter/lib.rs:178:75 [INFO] [stderr] | [INFO] [stderr] 178 | hashes[0].wrapping_add((k_i as u64).wrapping_mul(hashes[1]) % 0xffffffffffffffc5) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffc5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bloomfilter/lib.rs:115:16 [INFO] [stderr] | [INFO] [stderr] 115 | if self.bitmap.get(bit_offset).unwrap() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.bitmap.get(bit_offset).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bloomfilter/lib.rs:132:16 [INFO] [stderr] | [INFO] [stderr] 132 | if self.bitmap.get(bit_offset).unwrap() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.bitmap.get(bit_offset).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bloomfilter/lib.rs:172:28 [INFO] [stderr] | [INFO] [stderr] 172 | let sip = &mut self.sips[k_i as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.sips[k_i as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bloomfilter/lib.rs:178:36 [INFO] [stderr] | [INFO] [stderr] 178 | hashes[0].wrapping_add((k_i as u64).wrapping_mul(hashes[1]) % 0xffffffffffffffc5) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(k_i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/bloomfilter/lib.rs:178:75 [INFO] [stderr] | [INFO] [stderr] 178 | hashes[0].wrapping_add((k_i as u64).wrapping_mul(hashes[1]) % 0xffffffffffffffc5) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xffff_ffff_ffff_ffc5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bloomfilter/lib.rs:115:16 [INFO] [stderr] | [INFO] [stderr] 115 | if self.bitmap.get(bit_offset).unwrap() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.bitmap.get(bit_offset).unwrap()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bloomfilter/lib.rs:132:16 [INFO] [stderr] | [INFO] [stderr] 132 | if self.bitmap.get(bit_offset).unwrap() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!self.bitmap.get(bit_offset).unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/bloomfilter/lib.rs:172:28 [INFO] [stderr] | [INFO] [stderr] 172 | let sip = &mut self.sips[k_i as usize].clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.sips[k_i as usize]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/bloomfilter/lib.rs:178:36 [INFO] [stderr] | [INFO] [stderr] 178 | hashes[0].wrapping_add((k_i as u64).wrapping_mul(hashes[1]) % 0xffffffffffffffc5) [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u64::from(k_i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bloomfilter/lib.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | assert!(bloom.check(key) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!bloom.check(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bloomfilter/lib.rs:199:13 [INFO] [stderr] | [INFO] [stderr] 199 | assert!(bloom.check(key.clone()) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `bloom.check(key.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bloomfilter/lib.rs:206:13 [INFO] [stderr] | [INFO] [stderr] 206 | assert!(bloom.check_and_set(key) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!bloom.check_and_set(key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bloomfilter/lib.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | assert!(bloom.check_and_set(key.clone()) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `bloom.check_and_set(key.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bloomfilter/lib.rs:215:13 [INFO] [stderr] | [INFO] [stderr] 215 | assert!(bloom.check(&key) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `bloom.check(&key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/bloomfilter/lib.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | assert!(bloom.check(&key) == false); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!bloom.check(&key)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bloomfilter/lib.rs:225:13 [INFO] [stderr] | [INFO] [stderr] 225 | assert!(original.check(key.clone()) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `original.check(key.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: equality checks against true are unnecessary [INFO] [stderr] --> src/bloomfilter/lib.rs:231:13 [INFO] [stderr] | [INFO] [stderr] 231 | assert!(cloned.check(key.clone()) == true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `cloned.check(key.clone())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.02s [INFO] running `"docker" "inspect" "1ffd8b2741aed94c1a27a548b3aaee1b2be43604c814bdd093329449ea5a2d1e"` [INFO] running `"docker" "rm" "-f" "1ffd8b2741aed94c1a27a548b3aaee1b2be43604c814bdd093329449ea5a2d1e"` [INFO] [stdout] 1ffd8b2741aed94c1a27a548b3aaee1b2be43604c814bdd093329449ea5a2d1e