[INFO] crate blocktest 0.1.1 is already in cache [INFO] extracting crate blocktest 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/blocktest/0.1.1 [INFO] extracting crate blocktest 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blocktest/0.1.1 [INFO] validating manifest of blocktest-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blocktest-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blocktest-0.1.1 [INFO] finished frobbing blocktest-0.1.1 [INFO] frobbed toml for blocktest-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/blocktest/0.1.1/Cargo.toml [INFO] started frobbing blocktest-0.1.1 [INFO] finished frobbing blocktest-0.1.1 [INFO] frobbed toml for blocktest-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blocktest/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blocktest-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blocktest/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 85986fe878427f12bd8d51e81831b2c7a484b83e0712abcbe08657ad839802c1 [INFO] running `"docker" "start" "-a" "85986fe878427f12bd8d51e81831b2c7a484b83e0712abcbe08657ad839802c1"` [INFO] [stderr] Checking blocktest v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/buffer.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | fn write_file(contents: &String, dest: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/buffer.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | fn write_file(contents: &String, dest: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 13 | fn write_file(contents: &String, dest: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `dest.as_str()` to [INFO] [stderr] | [INFO] [stderr] 14 | let location = Path::new(dest); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/buffer.rs:40:33 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn compile(src: &Path, dst: &String, pat: &Regex, languages: &HashMap<&OsStr, &str>) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/block.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | fn split(line: &String, comment: &str) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/buffer.rs:13:25 [INFO] [stderr] | [INFO] [stderr] 13 | fn write_file(contents: &String, dest: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/buffer.rs:13:40 [INFO] [stderr] | [INFO] [stderr] 13 | fn write_file(contents: &String, dest: &String) { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 13 | fn write_file(contents: &String, dest: &str) { [INFO] [stderr] | ^^^^ [INFO] [stderr] help: change `dest.as_str()` to [INFO] [stderr] | [INFO] [stderr] 14 | let location = Path::new(dest); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/buffer.rs:40:33 [INFO] [stderr] | [INFO] [stderr] 40 | pub fn compile(src: &Path, dst: &String, pat: &Regex, languages: &HashMap<&OsStr, &str>) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/block.rs:9:16 [INFO] [stderr] | [INFO] [stderr] 9 | fn split(line: &String, comment: &str) -> String { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.05s [INFO] running `"docker" "inspect" "85986fe878427f12bd8d51e81831b2c7a484b83e0712abcbe08657ad839802c1"` [INFO] running `"docker" "rm" "-f" "85986fe878427f12bd8d51e81831b2c7a484b83e0712abcbe08657ad839802c1"` [INFO] [stdout] 85986fe878427f12bd8d51e81831b2c7a484b83e0712abcbe08657ad839802c1