[INFO] crate blockly-parser 0.1.0 is already in cache [INFO] extracting crate blockly-parser 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/blockly-parser/0.1.0 [INFO] extracting crate blockly-parser 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blockly-parser/0.1.0 [INFO] validating manifest of blockly-parser-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blockly-parser-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blockly-parser-0.1.0 [INFO] finished frobbing blockly-parser-0.1.0 [INFO] frobbed toml for blockly-parser-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/blockly-parser/0.1.0/Cargo.toml [INFO] started frobbing blockly-parser-0.1.0 [INFO] finished frobbing blockly-parser-0.1.0 [INFO] frobbed toml for blockly-parser-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blockly-parser/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blockly-parser-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blockly-parser/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a283b40aa6ae2e51c2c9c2c028407737ef546a10ff5e29b8abd32138a8865a54 [INFO] running `"docker" "start" "-a" "a283b40aa6ae2e51c2c9c2c028407737ef546a10ff5e29b8abd32138a8865a54"` [INFO] [stderr] Checking sxd-document v0.2.6 [INFO] [stderr] Checking blockly-parser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Program` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Self { [INFO] [stderr] 42 | | Self { [INFO] [stderr] 43 | | groups: Vec::new() [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / if let &ChildOfElement::Element(child_el) = child { [INFO] [stderr] 91 | | let child_name = child_el.name().local_part(); [INFO] [stderr] 92 | | match child_name { [INFO] [stderr] 93 | | "statement" => { [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | if let ChildOfElement::Element(child_el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match child { [INFO] [stderr] 118 | | &ChildOfElement::Text(text_node) => { [INFO] [stderr] 119 | | let value = text_node.text().to_string(); [INFO] [stderr] 120 | | return FieldValue::SimpleField(value); [INFO] [stderr] 121 | | }, [INFO] [stderr] 122 | | _ => panic!("TODO: Implement expression fields") [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | match *child { [INFO] [stderr] 118 | ChildOfElement::Text(text_node) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | / if let &ChildOfElement::Element(el) = child { [INFO] [stderr] 141 | | let element_name = el.name().local_part(); [INFO] [stderr] 142 | | match element_name { [INFO] [stderr] 143 | | "block" => { [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 140 | if let ChildOfElement::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | / match element_name { [INFO] [stderr] 143 | | "block" => { [INFO] [stderr] 144 | | program.groups.push(StatementBody::new(Some(el))); [INFO] [stderr] 145 | | }, [INFO] [stderr] 146 | | // TODO: handle `variables` [INFO] [stderr] 147 | | _ => {} [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | if let "block" = element_name { [INFO] [stderr] 143 | program.groups.push(StatementBody::new(Some(el))); [INFO] [stderr] 144 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / if let &ChildOfElement::Element(el) = child { [INFO] [stderr] 160 | | if el.name().local_part() == "next" { [INFO] [stderr] 161 | | return Some(el); [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | if let ChildOfElement::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | / if let &ChildOfRoot::Element(el) = child { [INFO] [stderr] 194 | | if el.name().local_part() == "xml" { [INFO] [stderr] 195 | | return Some(el); [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 193 | if let ChildOfRoot::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | / if let &ChildOfElement::Element(el) = child { [INFO] [stderr] 208 | | return Some(el); [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 207 | if let ChildOfElement::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Program` [INFO] [stderr] --> src/lib.rs:41:5 [INFO] [stderr] | [INFO] [stderr] 41 | / pub fn new() -> Self { [INFO] [stderr] 42 | | Self { [INFO] [stderr] 43 | | groups: Vec::new() [INFO] [stderr] 44 | | } [INFO] [stderr] 45 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 17 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | / if let &ChildOfElement::Element(child_el) = child { [INFO] [stderr] 91 | | let child_name = child_el.name().local_part(); [INFO] [stderr] 92 | | match child_name { [INFO] [stderr] 93 | | "statement" => { [INFO] [stderr] ... | [INFO] [stderr] 106 | | } [INFO] [stderr] 107 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 90 | if let ChildOfElement::Element(child_el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:117:13 [INFO] [stderr] | [INFO] [stderr] 117 | / match child { [INFO] [stderr] 118 | | &ChildOfElement::Text(text_node) => { [INFO] [stderr] 119 | | let value = text_node.text().to_string(); [INFO] [stderr] 120 | | return FieldValue::SimpleField(value); [INFO] [stderr] 121 | | }, [INFO] [stderr] 122 | | _ => panic!("TODO: Implement expression fields") [INFO] [stderr] 123 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 117 | match *child { [INFO] [stderr] 118 | ChildOfElement::Text(text_node) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | / if let &ChildOfElement::Element(el) = child { [INFO] [stderr] 141 | | let element_name = el.name().local_part(); [INFO] [stderr] 142 | | match element_name { [INFO] [stderr] 143 | | "block" => { [INFO] [stderr] ... | [INFO] [stderr] 148 | | } [INFO] [stderr] 149 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 140 | if let ChildOfElement::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | / match element_name { [INFO] [stderr] 143 | | "block" => { [INFO] [stderr] 144 | | program.groups.push(StatementBody::new(Some(el))); [INFO] [stderr] 145 | | }, [INFO] [stderr] 146 | | // TODO: handle `variables` [INFO] [stderr] 147 | | _ => {} [INFO] [stderr] 148 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 142 | if let "block" = element_name { [INFO] [stderr] 143 | program.groups.push(StatementBody::new(Some(el))); [INFO] [stderr] 144 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:159:13 [INFO] [stderr] | [INFO] [stderr] 159 | / if let &ChildOfElement::Element(el) = child { [INFO] [stderr] 160 | | if el.name().local_part() == "next" { [INFO] [stderr] 161 | | return Some(el); [INFO] [stderr] 162 | | } [INFO] [stderr] 163 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | if let ChildOfElement::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | / if let &ChildOfRoot::Element(el) = child { [INFO] [stderr] 194 | | if el.name().local_part() == "xml" { [INFO] [stderr] 195 | | return Some(el); [INFO] [stderr] 196 | | } [INFO] [stderr] 197 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 193 | if let ChildOfRoot::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:207:13 [INFO] [stderr] | [INFO] [stderr] 207 | / if let &ChildOfElement::Element(el) = child { [INFO] [stderr] 208 | | return Some(el); [INFO] [stderr] 209 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 207 | if let ChildOfElement::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:240:17 [INFO] [stderr] | [INFO] [stderr] 240 | / if let &ChildOfRoot::Element(el) = child { [INFO] [stderr] 241 | | return Some(el); [INFO] [stderr] 242 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 240 | if let ChildOfRoot::Element(el) = *child { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:328:21 [INFO] [stderr] | [INFO] [stderr] 328 | let group = program.groups.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&program.groups[0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:331:31 [INFO] [stderr] | [INFO] [stderr] 331 | let main_loop_block = group.blocks.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&group.blocks[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:343:32 [INFO] [stderr] | [INFO] [stderr] 343 | let inner_loop_block = main_loop_body_statement.blocks.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&main_loop_body_statement.blocks[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:353:28 [INFO] [stderr] | [INFO] [stderr] 353 | let led_on_block = inner_loop_statement.blocks.get(0).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&inner_loop_statement.blocks[0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:358:29 [INFO] [stderr] | [INFO] [stderr] 358 | let led_off_block = inner_loop_statement.blocks.get(1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&inner_loop_statement.blocks[1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.05s [INFO] running `"docker" "inspect" "a283b40aa6ae2e51c2c9c2c028407737ef546a10ff5e29b8abd32138a8865a54"` [INFO] running `"docker" "rm" "-f" "a283b40aa6ae2e51c2c9c2c028407737ef546a10ff5e29b8abd32138a8865a54"` [INFO] [stdout] a283b40aa6ae2e51c2c9c2c028407737ef546a10ff5e29b8abd32138a8865a54