[INFO] crate blockbuffers 0.1.0 is already in cache [INFO] extracting crate blockbuffers 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/blockbuffers/0.1.0 [INFO] extracting crate blockbuffers 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blockbuffers/0.1.0 [INFO] validating manifest of blockbuffers-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blockbuffers-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blockbuffers-0.1.0 [INFO] finished frobbing blockbuffers-0.1.0 [INFO] frobbed toml for blockbuffers-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/blockbuffers/0.1.0/Cargo.toml [INFO] started frobbing blockbuffers-0.1.0 [INFO] finished frobbing blockbuffers-0.1.0 [INFO] frobbed toml for blockbuffers-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blockbuffers/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blockbuffers-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blockbuffers/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ff202c832bed59b5290348abe3504f00ef6a6690aedac9df2943d264b00d4ba9 [INFO] running `"docker" "start" "-a" "ff202c832bed59b5290348abe3504f00ef6a6690aedac9df2943d264b00d4ba9"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking blockbuffers v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:311:44 [INFO] [stderr] | [INFO] [stderr] 311 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:311:54 [INFO] [stderr] | [INFO] [stderr] 311 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:404:44 [INFO] [stderr] | [INFO] [stderr] 404 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:404:54 [INFO] [stderr] | [INFO] [stderr] 404 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:577:44 [INFO] [stderr] | [INFO] [stderr] 577 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:577:54 [INFO] [stderr] | [INFO] [stderr] 577 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:657:44 [INFO] [stderr] | [INFO] [stderr] 657 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:657:54 [INFO] [stderr] | [INFO] [stderr] 657 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:748:44 [INFO] [stderr] | [INFO] [stderr] 748 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `buf` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> tests/common/example_generated.rs:748:54 [INFO] [stderr] | [INFO] [stderr] 748 | _tab: flatbuffers::Table { buf: buf, loc: loc }, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `loc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/le.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | assert_eq!(1f32, f32::from_le(1f32.to_le())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/le.rs:159:9 [INFO] [stderr] | [INFO] [stderr] 159 | assert_eq!(1f32, f32::from_le(1f32.to_le())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `blockbuffers`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/common/example_generated.rs:63:34 [INFO] [stderr] | [INFO] [stderr] 63 | const ENUM_NAMES_LANGUAGE: [&'static str; 2] = ["Rust", "Python"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> tests/common/example_generated.rs:116:37 [INFO] [stderr] | [INFO] [stderr] 116 | const ENUM_NAMES_CODE_OPTION: [&'static str; 2] = ["NONE", "Code"]; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> tests/common/example_generated.rs:168:20 [INFO] [stderr] | [INFO] [stderr] 168 | pub fn new<'a>(_byte_0: u8) -> Self { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:173:9 [INFO] [stderr] | [INFO] [stderr] 173 | / pub fn byte_0<'a>(&'a self) -> u8 { [INFO] [stderr] 174 | | self.byte_0_.from_little_endian() [INFO] [stderr] 175 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> tests/common/example_generated.rs:173:27 [INFO] [stderr] | [INFO] [stderr] 173 | pub fn byte_0<'a>(&'a self) -> u8 { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> tests/common/example_generated.rs:234:20 [INFO] [stderr] | [INFO] [stderr] 234 | pub fn new<'a>( [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (11/7) [INFO] [stderr] --> tests/common/example_generated.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | / pub fn new<'a>( [INFO] [stderr] 235 | | _a_byte: i8, [INFO] [stderr] 236 | | _a_ubyte: u8, [INFO] [stderr] 237 | | _a_bool: bool, [INFO] [stderr] ... | [INFO] [stderr] 262 | | } [INFO] [stderr] 263 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | / pub fn a_byte<'a>(&'a self) -> i8 { [INFO] [stderr] 265 | | self.a_byte_.from_little_endian() [INFO] [stderr] 266 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:267:9 [INFO] [stderr] | [INFO] [stderr] 267 | / pub fn a_ubyte<'a>(&'a self) -> u8 { [INFO] [stderr] 268 | | self.a_ubyte_.from_little_endian() [INFO] [stderr] 269 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | / pub fn a_bool<'a>(&'a self) -> bool { [INFO] [stderr] 271 | | self.a_bool_.from_little_endian() [INFO] [stderr] 272 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | / pub fn a_short<'a>(&'a self) -> i16 { [INFO] [stderr] 274 | | self.a_short_.from_little_endian() [INFO] [stderr] 275 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | / pub fn a_ushort<'a>(&'a self) -> u16 { [INFO] [stderr] 277 | | self.a_ushort_.from_little_endian() [INFO] [stderr] 278 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | / pub fn a_int<'a>(&'a self) -> i32 { [INFO] [stderr] 280 | | self.a_int_.from_little_endian() [INFO] [stderr] 281 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | / pub fn a_uint<'a>(&'a self) -> u32 { [INFO] [stderr] 283 | | self.a_uint_.from_little_endian() [INFO] [stderr] 284 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:285:9 [INFO] [stderr] | [INFO] [stderr] 285 | / pub fn a_float<'a>(&'a self) -> f32 { [INFO] [stderr] 286 | | self.a_float_.from_little_endian() [INFO] [stderr] 287 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:288:9 [INFO] [stderr] | [INFO] [stderr] 288 | / pub fn a_long<'a>(&'a self) -> i64 { [INFO] [stderr] 289 | | self.a_long_.from_little_endian() [INFO] [stderr] 290 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | / pub fn a_ulong<'a>(&'a self) -> u64 { [INFO] [stderr] 292 | | self.a_ulong_.from_little_endian() [INFO] [stderr] 293 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> tests/common/example_generated.rs:294:9 [INFO] [stderr] | [INFO] [stderr] 294 | / pub fn a_double<'a>(&'a self) -> f64 { [INFO] [stderr] 295 | | self.a_double_.from_little_endian() [INFO] [stderr] 296 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> tests/common/example_generated.rs:798:33 [INFO] [stderr] | [INFO] [stderr] 798 | self.code().map(|u| Code::init_from_table(u)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Code::init_from_table` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "ff202c832bed59b5290348abe3504f00ef6a6690aedac9df2943d264b00d4ba9"` [INFO] running `"docker" "rm" "-f" "ff202c832bed59b5290348abe3504f00ef6a6690aedac9df2943d264b00d4ba9"` [INFO] [stdout] ff202c832bed59b5290348abe3504f00ef6a6690aedac9df2943d264b00d4ba9