[INFO] crate blobby 0.1.1 is already in cache [INFO] extracting crate blobby 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/blobby/0.1.1 [INFO] extracting crate blobby 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blobby/0.1.1 [INFO] validating manifest of blobby-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blobby-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blobby-0.1.1 [INFO] finished frobbing blobby-0.1.1 [INFO] frobbed toml for blobby-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/blobby/0.1.1/Cargo.toml [INFO] started frobbing blobby-0.1.1 [INFO] finished frobbing blobby-0.1.1 [INFO] frobbed toml for blobby-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blobby/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blobby-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blobby/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d91f4025a1e9ea593c060d811d0f663d41120fd39878ea57a2ee3965548dd676 [INFO] running `"docker" "start" "-a" "d91f4025a1e9ea593c060d811d0f663d41120fd39878ea57a2ee3965548dd676"` [INFO] [stderr] Checking blobby v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if self.data.len() == 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | / fn read<'a>(self, data: &'a [u8]) -> (&'a [u8], &'a [u8]) { [INFO] [stderr] 169 | | match self { [INFO] [stderr] 170 | | IndexSize::N8 => { [INFO] [stderr] 171 | | let n = data[0] as usize; [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/lib.rs:60:12 [INFO] [stderr] | [INFO] [stderr] 60 | if self.data.len() == 0 { return None; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.data.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:168:5 [INFO] [stderr] | [INFO] [stderr] 168 | / fn read<'a>(self, data: &'a [u8]) -> (&'a [u8], &'a [u8]) { [INFO] [stderr] 169 | | match self { [INFO] [stderr] 170 | | IndexSize::N8 => { [INFO] [stderr] 171 | | let n = data[0] as usize; [INFO] [stderr] ... | [INFO] [stderr] 177 | | } [INFO] [stderr] 178 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.41s [INFO] running `"docker" "inspect" "d91f4025a1e9ea593c060d811d0f663d41120fd39878ea57a2ee3965548dd676"` [INFO] running `"docker" "rm" "-f" "d91f4025a1e9ea593c060d811d0f663d41120fd39878ea57a2ee3965548dd676"` [INFO] [stdout] d91f4025a1e9ea593c060d811d0f663d41120fd39878ea57a2ee3965548dd676