[INFO] crate blit 0.5.5 is already in cache [INFO] extracting crate blit 0.5.5 into work/ex/clippy-test-run/sources/stable/reg/blit/0.5.5 [INFO] extracting crate blit 0.5.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blit/0.5.5 [INFO] validating manifest of blit-0.5.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blit-0.5.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blit-0.5.5 [INFO] removed 0 missing examples [INFO] finished frobbing blit-0.5.5 [INFO] frobbed toml for blit-0.5.5 written to work/ex/clippy-test-run/sources/stable/reg/blit/0.5.5/Cargo.toml [INFO] started frobbing blit-0.5.5 [INFO] removed 0 missing examples [INFO] finished frobbing blit-0.5.5 [INFO] frobbed toml for blit-0.5.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blit/0.5.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blit-0.5.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blit/0.5.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 6f9790016fbceedcd230ec77ce3b9befb81659c3a87fda40c204337e7a1a77f5 [INFO] running `"docker" "start" "-a" "6f9790016fbceedcd230ec77ce3b9befb81659c3a87fda40c204337e7a1a77f5"` [INFO] [stderr] Compiling x11-dl v2.14.0 [INFO] [stderr] Compiling minifb v0.11.2 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking png v0.12.0 [INFO] [stderr] Checking aseprite v0.1.3 [INFO] [stderr] Checking image v0.20.1 [INFO] [stderr] Checking blit v0.5.5 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/image_feature/mod.rs:34:49 [INFO] [stderr] | [INFO] [stderr] 34 | data[index].1 = Color::from_u32(0xFFFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/image_feature/mod.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | data[index].1 = Color::from_u32(0xFFFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/image_feature/mod.rs:132:53 [INFO] [stderr] | [INFO] [stderr] 132 | data[index].1 = Color::from_u32(0xFFFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aseprite_feature/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Err(AnimationError::NoMatchingTag) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(AnimationError::NoMatchingTag)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aseprite_feature/mod.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return Ok(AnimationStatus::Playing); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(AnimationStatus::Playing)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:92:23 [INFO] [stderr] | [INFO] [stderr] 92 | Color(color | 0xFF000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:97:15 [INFO] [stderr] | [INFO] [stderr] 97 | Color(0xFF000000 | (u32::from(red) << 16) | (u32::from(green) << 8) | u32::from(blue)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:213:49 [INFO] [stderr] | [INFO] [stderr] 213 | data[index].1 = Color::from_u32(0xFFFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/image_feature/mod.rs:34:49 [INFO] [stderr] | [INFO] [stderr] 34 | data[index].1 = Color::from_u32(0xFFFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/image_feature/mod.rs:66:53 [INFO] [stderr] | [INFO] [stderr] 66 | data[index].1 = Color::from_u32(0xFFFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/image_feature/mod.rs:132:53 [INFO] [stderr] | [INFO] [stderr] 132 | data[index].1 = Color::from_u32(0xFFFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aseprite_feature/mod.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | return Err(AnimationError::NoMatchingTag) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(AnimationError::NoMatchingTag)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/aseprite_feature/mod.rs:102:9 [INFO] [stderr] | [INFO] [stderr] 102 | return Ok(AnimationStatus::Playing); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(AnimationStatus::Playing)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:92:23 [INFO] [stderr] | [INFO] [stderr] 92 | Color(color | 0xFF000000) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:97:15 [INFO] [stderr] | [INFO] [stderr] 97 | Color(0xFF000000 | (u32::from(red) << 16) | (u32::from(green) << 8) | u32::from(blue)) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xFF00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:213:49 [INFO] [stderr] | [INFO] [stderr] 213 | data[index].1 = Color::from_u32(0xFFFFFF); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/aseprite_feature/mod.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | self.duration += dt.as_secs() as f64 + dt.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dt.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/aseprite_feature/mod.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | while self.duration > frame.duration as f64 / 1000.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frame.duration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/aseprite_feature/mod.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | self.duration -= frame.duration as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frame.duration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:101:16 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/aseprite_feature/mod.rs:72:48 [INFO] [stderr] | [INFO] [stderr] 72 | self.duration += dt.as_secs() as f64 + dt.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(dt.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/aseprite_feature/mod.rs:78:31 [INFO] [stderr] | [INFO] [stderr] 78 | while self.duration > frame.duration as f64 / 1000.0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frame.duration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/aseprite_feature/mod.rs:79:30 [INFO] [stderr] | [INFO] [stderr] 79 | self.duration -= frame.duration as f64 / 1000.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(frame.duration)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/lib.rs:101:16 [INFO] [stderr] | [INFO] [stderr] 101 | pub fn u32(&self) -> u32 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/smiley.rs:12:25 [INFO] [stderr] | [INFO] [stderr] 12 | const MASK_COLOR: u32 = 0xFF00FF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_00FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/smiley.rs:16:37 [INFO] [stderr] | [INFO] [stderr] 16 | let mut buffer: Vec = vec![0x00FFFFFF; WIDTH * HEIGHT]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/smiley.rs:36:58 [INFO] [stderr] | [INFO] [stderr] 36 | rgb.blit(&mut buffer, WIDTH, (0, 0), Color::from_u32(0xFFFFFF)); [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused variable: `blit_buf` [INFO] [stderr] --> examples/smiley.rs:39:9 [INFO] [stderr] | [INFO] [stderr] 39 | let blit_buf = rgb.to_blit_buffer(Color::from_u32(MASK_COLOR)); [INFO] [stderr] | ^^^^^^^^ help: consider using `_blit_buf` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> examples/smiley.rs:65:9 [INFO] [stderr] | [INFO] [stderr] 65 | window.get_mouse_pos(MouseMode::Discard).map(|mouse| { [INFO] [stderr] | _________^ [INFO] [stderr] | |_________| [INFO] [stderr] | || [INFO] [stderr] 66 | || if draw_countdown <= 0 && window.get_mouse_down(MouseButton::Left) { [INFO] [stderr] 67 | || let x_pos = mouse.0 as i32 - (img_size.0 / 2) as i32; [INFO] [stderr] 68 | || let y_pos = mouse.1 as i32 - (img_size.1 / 2) as i32; [INFO] [stderr] ... || [INFO] [stderr] 72 | || } [INFO] [stderr] 73 | || }); [INFO] [stderr] | ||__________^- help: try this: `if let Some(mouse) = window.get_mouse_pos(MouseMode::Discard) { ... }` [INFO] [stderr] | |___________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/aseprite.rs:16:25 [INFO] [stderr] | [INFO] [stderr] 16 | const MASK_COLOR: u32 = 0xFF00FF; [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_00FF` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/aseprite.rs:20:37 [INFO] [stderr] | [INFO] [stderr] 20 | let mut buffer: Vec = vec![0x00FFFFFF; WIDTH * HEIGHT]; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/aseprite.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | *i = 0x00FFFFFF; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00FF_FFFF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/benchmarks.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `blit`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "6f9790016fbceedcd230ec77ce3b9befb81659c3a87fda40c204337e7a1a77f5"` [INFO] running `"docker" "rm" "-f" "6f9790016fbceedcd230ec77ce3b9befb81659c3a87fda40c204337e7a1a77f5"` [INFO] [stdout] 6f9790016fbceedcd230ec77ce3b9befb81659c3a87fda40c204337e7a1a77f5