[INFO] crate blip_buf 0.1.4 is already in cache [INFO] extracting crate blip_buf 0.1.4 into work/ex/clippy-test-run/sources/stable/reg/blip_buf/0.1.4 [INFO] extracting crate blip_buf 0.1.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blip_buf/0.1.4 [INFO] validating manifest of blip_buf-0.1.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blip_buf-0.1.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blip_buf-0.1.4 [INFO] removed path dependency blip_buf-sys from blip_buf-0.1.4 [INFO] finished frobbing blip_buf-0.1.4 [INFO] frobbed toml for blip_buf-0.1.4 written to work/ex/clippy-test-run/sources/stable/reg/blip_buf/0.1.4/Cargo.toml [INFO] started frobbing blip_buf-0.1.4 [INFO] removed path dependency blip_buf-sys from blip_buf-0.1.4 [INFO] finished frobbing blip_buf-0.1.4 [INFO] frobbed toml for blip_buf-0.1.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blip_buf/0.1.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blip_buf-0.1.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blip_buf/0.1.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c5a5c5af3dd2d4a39f146742b68c790f5de7b554f420e4e46b0fa93d243b79d9 [INFO] running `"docker" "start" "-a" "c5a5c5af3dd2d4a39f146742b68c790f5de7b554f420e4e46b0fa93d243b79d9"` [INFO] [stderr] Compiling blip_buf-sys v0.1.3 [INFO] [stderr] Checking blip_buf v0.1.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | BlipBuf { ptr: ptr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:50:23 [INFO] [stderr] | [INFO] [stderr] 50 | BlipBuf { ptr: ptr } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `ptr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> examples/sweep.rs:5:26 [INFO] [stderr] | [INFO] [stderr] 5 | const CLOCK_RATE : f64 = 1000000.0; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1_000_000.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::thread::sleep_ms': replaced by `std::thread::sleep` [INFO] [stderr] --> examples/sweep.rs:44:5 [INFO] [stderr] | [INFO] [stderr] 44 | std::thread::sleep_ms(1000); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> examples/sweep.rs:10:32 [INFO] [stderr] | [INFO] [stderr] 10 | blip.set_rates(CLOCK_RATE, SAMPLE_RATE as f64 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `f64::from(SAMPLE_RATE)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/sweep.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | period = period + 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `period += 3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/sweep.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | time = time + period; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time += period` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> examples/sweep.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | time = time - clocks; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `time -= clocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.78s [INFO] running `"docker" "inspect" "c5a5c5af3dd2d4a39f146742b68c790f5de7b554f420e4e46b0fa93d243b79d9"` [INFO] running `"docker" "rm" "-f" "c5a5c5af3dd2d4a39f146742b68c790f5de7b554f420e4e46b0fa93d243b79d9"` [INFO] [stdout] c5a5c5af3dd2d4a39f146742b68c790f5de7b554f420e4e46b0fa93d243b79d9