[INFO] crate blender-mesh 0.3.0 is already in cache [INFO] extracting crate blender-mesh 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/blender-mesh/0.3.0 [INFO] extracting crate blender-mesh 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blender-mesh/0.3.0 [INFO] validating manifest of blender-mesh-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blender-mesh-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blender-mesh-0.3.0 [INFO] finished frobbing blender-mesh-0.3.0 [INFO] frobbed toml for blender-mesh-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/blender-mesh/0.3.0/Cargo.toml [INFO] started frobbing blender-mesh-0.3.0 [INFO] finished frobbing blender-mesh-0.3.0 [INFO] frobbed toml for blender-mesh-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blender-mesh/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blender-mesh-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blender-mesh/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1093117ed77c4aba7a9ff6fe836a6271cfbed0b961824dc8940a94bea65f430d [INFO] running `"docker" "start" "-a" "1093117ed77c4aba7a9ff6fe836a6271cfbed0b961824dc8940a94bea65f430d"` [INFO] [stderr] Compiling num-complex v0.2.1 [INFO] [stderr] Checking alga v0.7.2 [INFO] [stderr] Checking nalgebra v0.16.13 [INFO] [stderr] Checking blender-mesh v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:277:5 [INFO] [stderr] | [INFO] [stderr] 277 | return None; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[deny(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![deny(missing_docs)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/combine_indices.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | / match self.num_groups_for_each_vertex.as_ref() { [INFO] [stderr] 122 | | Some(num_groups_for_each_vertex) => { [INFO] [stderr] 123 | | let pos_index = vert_id as usize; [INFO] [stderr] 124 | | // Where in our vector of group indices / weights does this vertex start? [INFO] [stderr] ... | [INFO] [stderr] 144 | | None => {} [INFO] [stderr] 145 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 121 | if let Some(num_groups_for_each_vertex) = self.num_groups_for_each_vertex.as_ref() { [INFO] [stderr] 122 | let pos_index = vert_id as usize; [INFO] [stderr] 123 | // Where in our vector of group indices / weights does this vertex start? [INFO] [stderr] 124 | let group_data_start_idx = [INFO] [stderr] 125 | *vert_group_map.as_ref().unwrap().get(&pos_index).unwrap() as usize; [INFO] [stderr] 126 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/combine_indices.rs:186:39 [INFO] [stderr] | [INFO] [stderr] 186 | total_previous += *num as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `vertex_id as usize * 3` [INFO] [stderr] --> src/combine_indices.rs:203:31 [INFO] [stderr] | [INFO] [stderr] 203 | self.vertex_positions[vertex_id as usize * 3 + 0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `vertex_id as usize * 3` [INFO] [stderr] --> src/combine_indices.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | self.vertex_normals[vertex_id as usize * 3 + 0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `vertex_id as usize * 2` [INFO] [stderr] --> src/combine_indices.rs:221:43 [INFO] [stderr] | [INFO] [stderr] 221 | self.vertex_uvs.as_ref().unwrap()[vertex_id as usize * 2 + 0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/lib.rs:19:1 [INFO] [stderr] | [INFO] [stderr] 19 | #[deny(missing_docs)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![deny(missing_docs)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/combine_indices.rs:121:13 [INFO] [stderr] | [INFO] [stderr] 121 | / match self.num_groups_for_each_vertex.as_ref() { [INFO] [stderr] 122 | | Some(num_groups_for_each_vertex) => { [INFO] [stderr] 123 | | let pos_index = vert_id as usize; [INFO] [stderr] 124 | | // Where in our vector of group indices / weights does this vertex start? [INFO] [stderr] ... | [INFO] [stderr] 144 | | None => {} [INFO] [stderr] 145 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 121 | if let Some(num_groups_for_each_vertex) = self.num_groups_for_each_vertex.as_ref() { [INFO] [stderr] 122 | let pos_index = vert_id as usize; [INFO] [stderr] 123 | // Where in our vector of group indices / weights does this vertex start? [INFO] [stderr] 124 | let group_data_start_idx = [INFO] [stderr] 125 | *vert_group_map.as_ref().unwrap().get(&pos_index).unwrap() as usize; [INFO] [stderr] 126 | [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/combine_indices.rs:186:39 [INFO] [stderr] | [INFO] [stderr] 186 | total_previous += *num as u32; [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(*num)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `vertex_id as usize * 3` [INFO] [stderr] --> src/combine_indices.rs:203:31 [INFO] [stderr] | [INFO] [stderr] 203 | self.vertex_positions[vertex_id as usize * 3 + 0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `vertex_id as usize * 3` [INFO] [stderr] --> src/combine_indices.rs:212:29 [INFO] [stderr] | [INFO] [stderr] 212 | self.vertex_normals[vertex_id as usize * 3 + 0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `vertex_id as usize * 2` [INFO] [stderr] --> src/combine_indices.rs:221:43 [INFO] [stderr] | [INFO] [stderr] 221 | self.vertex_uvs.as_ref().unwrap()[vertex_id as usize * 2 + 0] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | / match num_verts_in_face { [INFO] [stderr] 112 | | &3 => { [INFO] [stderr] 113 | | triangulated_face_vertex_counts.push(3); [INFO] [stderr] 114 | | [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | match *num_verts_in_face { [INFO] [stderr] 112 | 3 => { [INFO] [stderr] 113 | triangulated_face_vertex_counts.push(3); [INFO] [stderr] 114 | [INFO] [stderr] 115 | triangulated_position_indices.push(self.vertex_position_indices[face_pointer]); [INFO] [stderr] 116 | triangulated_position_indices [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:70 [INFO] [stderr] | [INFO] [stderr] 181 | for index in current_index..(current_index + *group_count as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*group_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:204:42 [INFO] [stderr] | [INFO] [stderr] 204 | current_index += *group_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*group_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:263:57 [INFO] [stderr] | [INFO] [stderr] 263 | let mesh_filename: Vec<&str> = first_line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:266:42 [INFO] [stderr] | [INFO] [stderr] 266 | let mesh_name = first_line.split(" ").last().unwrap().to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | / match num_verts_in_face { [INFO] [stderr] 112 | | &3 => { [INFO] [stderr] 113 | | triangulated_face_vertex_counts.push(3); [INFO] [stderr] 114 | | [INFO] [stderr] ... | [INFO] [stderr] 142 | | } [INFO] [stderr] 143 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 111 | match *num_verts_in_face { [INFO] [stderr] 112 | 3 => { [INFO] [stderr] 113 | triangulated_face_vertex_counts.push(3); [INFO] [stderr] 114 | [INFO] [stderr] 115 | triangulated_position_indices.push(self.vertex_position_indices[face_pointer]); [INFO] [stderr] 116 | triangulated_position_indices [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:181:70 [INFO] [stderr] | [INFO] [stderr] 181 | for index in current_index..(current_index + *group_count as u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*group_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:473:14 [INFO] [stderr] | [INFO] [stderr] 473 | vec![val as f32, val as f32, val as f32] [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:204:42 [INFO] [stderr] | [INFO] [stderr] 204 | current_index += *group_count as u32; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(*group_count)` [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] | [INFO] [stderr] --> src/lib.rs:473:26 [INFO] [stderr] | [INFO] [stderr] 473 | vec![val as f32, val as f32, val as f32] [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:473:38 [INFO] [stderr] | [INFO] [stderr] 473 | vec![val as f32, val as f32, val as f32] [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:485:14 [INFO] [stderr] | [INFO] [stderr] 485 | vec![val as f32, val as f32] [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to f32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:485:26 [INFO] [stderr] | [INFO] [stderr] 485 | vec![val as f32, val as f32] [INFO] [stderr] | ^^^^^^^^^^ help: try: `f32::from(val)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:263:57 [INFO] [stderr] | [INFO] [stderr] 263 | let mesh_filename: Vec<&str> = first_line.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/lib.rs:266:42 [INFO] [stderr] | [INFO] [stderr] 266 | let mesh_name = first_line.split(" ").last().unwrap().to_string(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `blender-mesh`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: Could not compile `blender-mesh`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "1093117ed77c4aba7a9ff6fe836a6271cfbed0b961824dc8940a94bea65f430d"` [INFO] running `"docker" "rm" "-f" "1093117ed77c4aba7a9ff6fe836a6271cfbed0b961824dc8940a94bea65f430d"` [INFO] [stdout] 1093117ed77c4aba7a9ff6fe836a6271cfbed0b961824dc8940a94bea65f430d