[INFO] crate blake 2.0.0 is already in cache [INFO] extracting crate blake 2.0.0 into work/ex/clippy-test-run/sources/stable/reg/blake/2.0.0 [INFO] extracting crate blake 2.0.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blake/2.0.0 [INFO] validating manifest of blake-2.0.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of blake-2.0.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing blake-2.0.0 [INFO] finished frobbing blake-2.0.0 [INFO] frobbed toml for blake-2.0.0 written to work/ex/clippy-test-run/sources/stable/reg/blake/2.0.0/Cargo.toml [INFO] started frobbing blake-2.0.0 [INFO] finished frobbing blake-2.0.0 [INFO] frobbed toml for blake-2.0.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/blake/2.0.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting blake-2.0.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/blake/2.0.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3c0ffddf84354fcf065a601b8d4f8b2ab088c5d7041ce6637b297b34c19f1266 [INFO] running `"docker" "start" "-a" "3c0ffddf84354fcf065a601b8d4f8b2ab088c5d7041ce6637b297b34c19f1266"` [INFO] [stderr] Compiling blake v2.0.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of deprecated item 'gcc::Build': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | gcc::Build::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'gcc::Build::new': crate has been renamed to `cc`, the `gcc` name is not maintained [INFO] [stderr] --> build.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | gcc::Build::new() [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: ext/blake/blake_ref.c: In function 'Update32': [INFO] [stderr] warning: ext/blake/blake_ref.c:299:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if( left && ( ((databitlen >> 3) ) >= fill ) ) { [INFO] [stderr] warning: ^~ [INFO] [stderr] warning: ext/blake/blake_ref.c: In function 'Update64': [INFO] [stderr] warning: ext/blake/blake_ref.c:355:38: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if( left && ( ((databitlen >> 3) ) >= fill ) ) { [INFO] [stderr] warning: ^~ [INFO] [stderr] warning: ext/blake/blake_ref.c: In function 'Final32': [INFO] [stderr] warning: ext/blake/blake_ref.c:415:12: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if ( low < state->datalen ) [INFO] [stderr] warning: ^ [INFO] [stderr] warning: ext/blake/blake_ref.c: In function 'Final64': [INFO] [stderr] warning: ext/blake/blake_ref.c:538:12: warning: comparison between signed and unsigned integer expressions [-Wsign-compare] [INFO] [stderr] warning: if ( low < state->datalen ) [INFO] [stderr] warning: ^ [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:210:29 [INFO] [stderr] | [INFO] [stderr] 210 | 0 => Ok(Blake { raw_state: raw_state }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:210:29 [INFO] [stderr] | [INFO] [stderr] 210 | 0 => Ok(Blake { raw_state: raw_state }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raw_state` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | / match self { [INFO] [stderr] 405 | | &BlakeError::Fail => "Generic BLAKE fail", [INFO] [stderr] 406 | | &BlakeError::BadHashbitlen => "Incorrect hashbitlen", [INFO] [stderr] 407 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 404 | match *self { [INFO] [stderr] 405 | BlakeError::Fail => "Generic BLAKE fail", [INFO] [stderr] 406 | BlakeError::BadHashbitlen => "Incorrect hashbitlen", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:404:9 [INFO] [stderr] | [INFO] [stderr] 404 | / match self { [INFO] [stderr] 405 | | &BlakeError::Fail => "Generic BLAKE fail", [INFO] [stderr] 406 | | &BlakeError::BadHashbitlen => "Incorrect hashbitlen", [INFO] [stderr] 407 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 404 | match *self { [INFO] [stderr] 405 | BlakeError::Fail => "Generic BLAKE fail", [INFO] [stderr] 406 | BlakeError::BadHashbitlen => "Incorrect hashbitlen", [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.15s [INFO] running `"docker" "inspect" "3c0ffddf84354fcf065a601b8d4f8b2ab088c5d7041ce6637b297b34c19f1266"` [INFO] running `"docker" "rm" "-f" "3c0ffddf84354fcf065a601b8d4f8b2ab088c5d7041ce6637b297b34c19f1266"` [INFO] [stdout] 3c0ffddf84354fcf065a601b8d4f8b2ab088c5d7041ce6637b297b34c19f1266