[INFO] crate black_scholes 0.3.0 is already in cache [INFO] extracting crate black_scholes 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/black_scholes/0.3.0 [INFO] extracting crate black_scholes 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/black_scholes/0.3.0 [INFO] validating manifest of black_scholes-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of black_scholes-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing black_scholes-0.3.0 [INFO] finished frobbing black_scholes-0.3.0 [INFO] frobbed toml for black_scholes-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/black_scholes/0.3.0/Cargo.toml [INFO] started frobbing black_scholes-0.3.0 [INFO] finished frobbing black_scholes-0.3.0 [INFO] frobbed toml for black_scholes-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/black_scholes/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting black_scholes-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/black_scholes/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a46b43d5a06910d722921089b06301c88f2e4476d69d6168f612df6471428ab2 [INFO] running `"docker" "start" "-a" "a46b43d5a06910d722921089b06301c88f2e4476d69d6168f612df6471428ab2"` [INFO] [stderr] Checking black_scholes v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | else{ [INFO] [stderr] | _________^ [INFO] [stderr] 50 | | if s>k {s-k} else {0.0} [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ help: try: `if s>k {s-k} else {0.0}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | else{ [INFO] [stderr] | _________^ [INFO] [stderr] 92 | | if s>k {1.0} else {0.0} [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ help: try: `if s>k {1.0} else {0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | else{ [INFO] [stderr] | _________^ [INFO] [stderr] 195 | | if k>s {k-s} else {0.0} [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____^ help: try: `if k>s {k-s} else {0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | return cum_norm(d1)-1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cum_norm(d1)-1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | return if k>s {-1.0} else {0.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if k>s {-1.0} else {0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:335:19 [INFO] [stderr] | [INFO] [stderr] 335 | let precision=0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:378:19 [INFO] [stderr] | [INFO] [stderr] 378 | let precision=0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `Distribution` [INFO] [stderr] --> src/lib.rs:19:27 [INFO] [stderr] | [INFO] [stderr] 19 | use rand::distributions::{Distribution}; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | else{ [INFO] [stderr] | _________^ [INFO] [stderr] 50 | | if s>k {s-k} else {0.0} [INFO] [stderr] 51 | | } [INFO] [stderr] | |_____^ help: try: `if s>k {s-k} else {0.0}` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:91:9 [INFO] [stderr] | [INFO] [stderr] 91 | else{ [INFO] [stderr] | _________^ [INFO] [stderr] 92 | | if s>k {1.0} else {0.0} [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____^ help: try: `if s>k {1.0} else {0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | else{ [INFO] [stderr] | _________^ [INFO] [stderr] 195 | | if k>s {k-s} else {0.0} [INFO] [stderr] 196 | | } [INFO] [stderr] | |_____^ help: try: `if k>s {k-s} else {0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:234:9 [INFO] [stderr] | [INFO] [stderr] 234 | return cum_norm(d1)-1.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `cum_norm(d1)-1.0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:237:9 [INFO] [stderr] | [INFO] [stderr] 237 | return if k>s {-1.0} else {0.0}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `if k>s {-1.0} else {0.0}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:335:19 [INFO] [stderr] | [INFO] [stderr] 335 | let precision=0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:378:19 [INFO] [stderr] | [INFO] [stderr] 378 | let precision=0.000001; [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:417:85 [INFO] [stderr] | [INFO] [stderr] 417 | assert_abs_diff_eq!(SQRT_TWO_PI, (2.0*std::f64::consts::PI).sqrt(), epsilon=0.000000001); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0.000_000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:421:52 [INFO] [stderr] | [INFO] [stderr] 421 | assert_eq!(call(5.0, 4.5, 0.05, 0.3, 1.0), 0.9848721043419868); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.984_872_104_341_986_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:429:51 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(put(5.0, 4.5, 0.05, 0.3, 1.0), 0.2654045145951993); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.265_404_514_595_199_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:444:104 [INFO] [stderr] | [INFO] [stderr] 444 | assert_abs_diff_eq!(call_iv_guess(price, s, k, rate, maturity , initial_guess), sigma, epsilon=0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:474:22 [INFO] [stderr] | [INFO] [stderr] 474 | if price>0.000001{ [INFO] [stderr] | ^^^^^^^^ help: consider: `0.000_001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:484:16 [INFO] [stderr] | [INFO] [stderr] 484 | let s= 0.43065239380643594; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.430_652_393_806_435_94` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:485:15 [INFO] [stderr] | [INFO] [stderr] 485 | let k=0.5016203266170813; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.501_620_326_617_081_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:486:19 [INFO] [stderr] | [INFO] [stderr] 486 | let sigma=0.4192621453186373; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.419_262_145_318_637_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:503:81 [INFO] [stderr] | [INFO] [stderr] 503 | assert_abs_diff_eq!(put_iv(price, s, k, rate, maturity), sigma, epsilon=0.00000001); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.000_000_01` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | assert_eq!(call(5.0, 4.5, 0.05, 0.3, 1.0), 0.9848721043419868); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:421:9 [INFO] [stderr] | [INFO] [stderr] 421 | assert_eq!(call(5.0, 4.5, 0.05, 0.3, 1.0), 0.9848721043419868); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:425:9 [INFO] [stderr] | [INFO] [stderr] 425 | assert_eq!(call(5.0, 4.5, 0.05, 0.3, 0.0), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:425:9 [INFO] [stderr] | [INFO] [stderr] 425 | assert_eq!(call(5.0, 4.5, 0.05, 0.3, 0.0), 0.5); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(put(5.0, 4.5, 0.05, 0.3, 1.0), 0.2654045145951993); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:429:9 [INFO] [stderr] | [INFO] [stderr] 429 | assert_eq!(put(5.0, 4.5, 0.05, 0.3, 1.0), 0.2654045145951993); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/lib.rs:433:9 [INFO] [stderr] | [INFO] [stderr] 433 | assert_eq!(put(5.0, 4.5, 0.05, 0.3, 0.0), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/lib.rs:433:9 [INFO] [stderr] | [INFO] [stderr] 433 | assert_eq!(put(5.0, 4.5, 0.05, 0.3, 0.0), 0.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `black_scholes`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "a46b43d5a06910d722921089b06301c88f2e4476d69d6168f612df6471428ab2"` [INFO] running `"docker" "rm" "-f" "a46b43d5a06910d722921089b06301c88f2e4476d69d6168f612df6471428ab2"` [INFO] [stdout] a46b43d5a06910d722921089b06301c88f2e4476d69d6168f612df6471428ab2