[INFO] crate bitterlemon 0.2.2 is already in cache [INFO] extracting crate bitterlemon 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/bitterlemon/0.2.2 [INFO] extracting crate bitterlemon 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitterlemon/0.2.2 [INFO] validating manifest of bitterlemon-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bitterlemon-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bitterlemon-0.2.2 [INFO] finished frobbing bitterlemon-0.2.2 [INFO] frobbed toml for bitterlemon-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/bitterlemon/0.2.2/Cargo.toml [INFO] started frobbing bitterlemon-0.2.2 [INFO] finished frobbing bitterlemon-0.2.2 [INFO] frobbed toml for bitterlemon-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitterlemon/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bitterlemon-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bitterlemon/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 3db69ab55af0ffc4b2934c3c896e55778f68cafff819c5dc1f36e7cdfd9a16ee [INFO] running `"docker" "start" "-a" "3db69ab55af0ffc4b2934c3c896e55778f68cafff819c5dc1f36e7cdfd9a16ee"` [INFO] [stderr] Checking bitterlemon v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode.rs:146:4 [INFO] [stderr] | [INFO] [stderr] 146 | source: source [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode.rs:382:4 [INFO] [stderr] | [INFO] [stderr] 382 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode.rs:146:4 [INFO] [stderr] | [INFO] [stderr] 146 | source: source [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/encode.rs:382:4 [INFO] [stderr] | [INFO] [stderr] 382 | source: source, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `source` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_encode_round_trip.rs:41:54 [INFO] [stderr] | [INFO] [stderr] 41 | let mut rand_source = random::Xorshift128Plus::new([0x426173637265656e, 0x0123456789abcdef]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4261_7363_7265_656e` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test_encode_round_trip.rs:41:74 [INFO] [stderr] | [INFO] [stderr] 41 | let mut rand_source = random::Xorshift128Plus::new([0x426173637265656e, 0x0123456789abcdef]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x0123_4567_89ab_cdef` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/encode.rs:307:7 [INFO] [stderr] | [INFO] [stderr] 307 | let mut head_run = self.get_mut(*ptr as usize).unwrap(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/encode.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | fn size(&self) -> u8 { // TODO rename this to len for Rusticity [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/encode.rs:60:2 [INFO] [stderr] | [INFO] [stderr] 60 | fn size_mut<'a>(&'a mut self) -> &'a mut u8 { [INFO] [stderr] | _____^ [INFO] [stderr] 61 | | match *self { [INFO] [stderr] 62 | | Run::Set(ref mut x) => x, [INFO] [stderr] 63 | | Run::Clear(ref mut x) => x, [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/encode.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | fn bit(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/encode.rs:389:3 [INFO] [stderr] | [INFO] [stderr] 389 | match self.mode { [INFO] [stderr] | _________^ [INFO] [stderr] 390 | | WithFramesMode::FlushingFrame(_, _) => { return false; }, [INFO] [stderr] 391 | | _ => {} [INFO] [stderr] 392 | | } [INFO] [stderr] | |_________^ help: try this: `if let WithFramesMode::FlushingFrame(_, _) = self.mode { return false; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:397:24 [INFO] [stderr] | [INFO] [stderr] 397 | let cur_frame_size = self.runs.num_bits() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.runs.num_bits())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:398:23 [INFO] [stderr] | [INFO] [stderr] 398 | if cur_frame_size + (run_size as u16) > (RLE_MAX_FRAME as u16) { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(run_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:398:43 [INFO] [stderr] | [INFO] [stderr] 398 | if cur_frame_size + (run_size as u16) > (RLE_MAX_FRAME as u16) { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(RLE_MAX_FRAME)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/encode.rs:435:17 [INFO] [stderr] | [INFO] [stderr] 435 | else if let Some(_) = self.next_run { [INFO] [stderr] | ______________________- ^^^^^^^ [INFO] [stderr] 436 | | // expecting to fill a frame, but was told not to do it here [INFO] [stderr] 437 | | // move the run out instead [INFO] [stderr] 438 | | let moved_run = self.next_run.take().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 443 | | (None, None) [INFO] [stderr] 444 | | } [INFO] [stderr] | |_________________- help: try this: `if self.next_run.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/encode.rs:307:7 [INFO] [stderr] | [INFO] [stderr] 307 | let mut head_run = self.get_mut(*ptr as usize).unwrap(); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/encode.rs:53:10 [INFO] [stderr] | [INFO] [stderr] 53 | fn size(&self) -> u8 { // TODO rename this to len for Rusticity [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/encode.rs:60:2 [INFO] [stderr] | [INFO] [stderr] 60 | fn size_mut<'a>(&'a mut self) -> &'a mut u8 { [INFO] [stderr] | _____^ [INFO] [stderr] 61 | | match *self { [INFO] [stderr] 62 | | Run::Set(ref mut x) => x, [INFO] [stderr] 63 | | Run::Clear(ref mut x) => x, [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/encode.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | fn bit(&self) -> u8 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/encode.rs:243:54 [INFO] [stderr] | [INFO] [stderr] 243 | let collected : Vec = RunIterator::from_bits(bool_stream.iter().map(|&b| b)).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bool_stream.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/encode.rs:270:41 [INFO] [stderr] | [INFO] [stderr] 270 | let mut iter = RunIterator::from_bits((&[] as &[bool]).iter().map(|&b| b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `(&[] as &[bool]).iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/encode.rs:389:3 [INFO] [stderr] | [INFO] [stderr] 389 | match self.mode { [INFO] [stderr] | _________^ [INFO] [stderr] 390 | | WithFramesMode::FlushingFrame(_, _) => { return false; }, [INFO] [stderr] 391 | | _ => {} [INFO] [stderr] 392 | | } [INFO] [stderr] | |_________^ help: try this: `if let WithFramesMode::FlushingFrame(_, _) = self.mode { return false; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:397:24 [INFO] [stderr] | [INFO] [stderr] 397 | let cur_frame_size = self.runs.num_bits() as u16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(self.runs.num_bits())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:398:23 [INFO] [stderr] | [INFO] [stderr] 398 | if cur_frame_size + (run_size as u16) > (RLE_MAX_FRAME as u16) { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `u16::from(run_size)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/encode.rs:398:43 [INFO] [stderr] | [INFO] [stderr] 398 | if cur_frame_size + (run_size as u16) > (RLE_MAX_FRAME as u16) { return false; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u16::from(RLE_MAX_FRAME)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_some()` [INFO] [stderr] --> src/encode.rs:435:17 [INFO] [stderr] | [INFO] [stderr] 435 | else if let Some(_) = self.next_run { [INFO] [stderr] | ______________________- ^^^^^^^ [INFO] [stderr] 436 | | // expecting to fill a frame, but was told not to do it here [INFO] [stderr] 437 | | // move the run out instead [INFO] [stderr] 438 | | let moved_run = self.next_run.take().unwrap(); [INFO] [stderr] ... | [INFO] [stderr] 443 | | (None, None) [INFO] [stderr] 444 | | } [INFO] [stderr] | |_________________- help: try this: `if self.next_run.is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/encode.rs:537:34 [INFO] [stderr] | [INFO] [stderr] 537 | let mut iter = WithFrames::new((&[] as &[Run]).iter().map(|&b| b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `(&[] as &[Run]).iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/decode.rs:269:33 [INFO] [stderr] | [INFO] [stderr] 269 | let mut iter = super::decode(bytes.iter().map(|&b| b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/decode.rs:289:33 [INFO] [stderr] | [INFO] [stderr] 289 | let mut iter = super::decode(bytes.iter().map(|&b| b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bytes.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/decode.rs:322:32 [INFO] [stderr] | [INFO] [stderr] 322 | let mut iter = super::decode(src.iter().map(|&b| b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `src.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/test_encode_round_trip.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | let encoder = encode::encode(source.iter().map(|&b| b)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `source.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.43s [INFO] running `"docker" "inspect" "3db69ab55af0ffc4b2934c3c896e55778f68cafff819c5dc1f36e7cdfd9a16ee"` [INFO] running `"docker" "rm" "-f" "3db69ab55af0ffc4b2934c3c896e55778f68cafff819c5dc1f36e7cdfd9a16ee"` [INFO] [stdout] 3db69ab55af0ffc4b2934c3c896e55778f68cafff819c5dc1f36e7cdfd9a16ee