[INFO] crate bitter 0.1.0 is already in cache [INFO] extracting crate bitter 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bitter/0.1.0 [INFO] extracting crate bitter 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitter/0.1.0 [INFO] validating manifest of bitter-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bitter-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bitter-0.1.0 [INFO] finished frobbing bitter-0.1.0 [INFO] frobbed toml for bitter-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bitter/0.1.0/Cargo.toml [INFO] started frobbing bitter-0.1.0 [INFO] finished frobbing bitter-0.1.0 [INFO] frobbed toml for bitter-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitter/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bitter-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bitter/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0f1baa1ffbdcad1757fb3f138732d996cba5d4624ebb8963ad14f7d1ac1d188e [INFO] running `"docker" "start" "-a" "0f1baa1ffbdcad1757fb3f138732d996cba5d4624ebb8963ad14f7d1ac1d188e"` [INFO] [stderr] Checking cast v0.1.0 [INFO] [stderr] Checking bitreader v0.3.1 [INFO] [stderr] Checking bitstream-io v0.6.5 [INFO] [stderr] Checking bitter v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] Checking criterion-stats v0.1.3 [INFO] [stderr] Checking criterion-plot v0.1.3 [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/lib.rs:475:49 [INFO] [stderr] | [INFO] [stderr] 475 | pub fn if_get(&mut self, mut f: F) -> Option> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] Checking criterion v0.1.2 [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:179:13 [INFO] [stderr] | [INFO] [stderr] 179 | data: data, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `data` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:707:44 [INFO] [stderr] | [INFO] [stderr] 707 | assert_eq!(bitter.read_u32(), Some(0xcdab00ff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcdab_00ff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:709:44 [INFO] [stderr] | [INFO] [stderr] 709 | assert_eq!(bitter.read_u32(), Some(0xcdab00ff)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xcdab_00ff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: consider using `Option` instead of `Option>` or a custom enum if you need to distinguish all 3 cases [INFO] [stderr] --> src/lib.rs:475:49 [INFO] [stderr] | [INFO] [stderr] 475 | pub fn if_get(&mut self, mut f: F) -> Option> [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_option)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_option [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.57s [INFO] running `"docker" "inspect" "0f1baa1ffbdcad1757fb3f138732d996cba5d4624ebb8963ad14f7d1ac1d188e"` [INFO] running `"docker" "rm" "-f" "0f1baa1ffbdcad1757fb3f138732d996cba5d4624ebb8963ad14f7d1ac1d188e"` [INFO] [stdout] 0f1baa1ffbdcad1757fb3f138732d996cba5d4624ebb8963ad14f7d1ac1d188e