[INFO] crate bitsets 0.1.1 is already in cache [INFO] extracting crate bitsets 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/bitsets/0.1.1 [INFO] extracting crate bitsets 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitsets/0.1.1 [INFO] validating manifest of bitsets-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bitsets-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bitsets-0.1.1 [INFO] finished frobbing bitsets-0.1.1 [INFO] frobbed toml for bitsets-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/bitsets/0.1.1/Cargo.toml [INFO] started frobbing bitsets-0.1.1 [INFO] finished frobbing bitsets-0.1.1 [INFO] frobbed toml for bitsets-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitsets/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bitsets-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bitsets/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb8cf658d8f1c1e7ce49425f0cdc192c67ce93aa466e14e0a347ee9823a784b5 [INFO] running `"docker" "start" "-a" "eb8cf658d8f1c1e7ce49425f0cdc192c67ce93aa466e14e0a347ee9823a784b5"` [INFO] [stderr] Checking bitsets v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `super::*` [INFO] [stderr] --> src/lib.rs:306:9 [INFO] [stderr] | [INFO] [stderr] 306 | use super::*; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: item `DenseBitSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:73:1 [INFO] [stderr] | [INFO] [stderr] 73 | / impl DenseBitSet { [INFO] [stderr] 74 | | /// Creates a `DenseBitSet` that can contain at least `num_bits` bits. [INFO] [stderr] 75 | | /// This will be rounded to the nearest word size that can accomodate [INFO] [stderr] 76 | | /// `num_bits` bits. [INFO] [stderr] ... | [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / let words_to_allocate; [INFO] [stderr] 118 | | if remaining_bits > 0 { [INFO] [stderr] 119 | | words_to_allocate = full_words + 1; [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | words_to_allocate = full_words; [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let words_to_allocate = if remaining_bits > 0 { full_words + 1 } else { full_words };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:352:41 [INFO] [stderr] | [INFO] [stderr] 352 | let bs = DenseBitSet::from_bits(0b0101010101010111010111010101); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b0101_0101_0101_0111_0101_1101_0101` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:362:40 [INFO] [stderr] | [INFO] [stderr] 362 | let A = DenseBitSet::from_bits(0b111000111); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_1100_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:363:40 [INFO] [stderr] | [INFO] [stderr] 363 | let B = DenseBitSet::from_bits(0b111000111); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_1100_0111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:364:40 [INFO] [stderr] | [INFO] [stderr] 364 | let C = DenseBitSet::from_bits(0b110111111); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `0b1_1011_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:376:40 [INFO] [stderr] | [INFO] [stderr] 376 | let A = DenseBitSet::from_bits(0b1000110001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b10_0011_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:377:40 [INFO] [stderr] | [INFO] [stderr] 377 | let B = DenseBitSet::from_bits(0b0010000100); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b00_1000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:380:43 [INFO] [stderr] | [INFO] [stderr] 380 | let bits = DenseBitSet::from_bits(0b1010110101); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b10_1011_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:388:40 [INFO] [stderr] | [INFO] [stderr] 388 | let A = DenseBitSet::from_bits(0b1000110001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b10_0011_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:389:40 [INFO] [stderr] | [INFO] [stderr] 389 | let B = DenseBitSet::from_bits(0b1010100100); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b10_1010_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:392:43 [INFO] [stderr] | [INFO] [stderr] 392 | let bits = DenseBitSet::from_bits(0b1000100000); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b10_0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:400:40 [INFO] [stderr] | [INFO] [stderr] 400 | let A = DenseBitSet::from_bits(0b11100010101); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b111_0001_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:401:40 [INFO] [stderr] | [INFO] [stderr] 401 | let B = DenseBitSet::from_bits(0b11110100100); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b111_1010_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:404:43 [INFO] [stderr] | [INFO] [stderr] 404 | let bits = DenseBitSet::from_bits(0b00010110001); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b000_1011_0001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:412:45 [INFO] [stderr] | [INFO] [stderr] 412 | let mut bs = DenseBitSet::from_bits(0b11100011101); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0b111_0001_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:413:41 [INFO] [stderr] | [INFO] [stderr] 413 | let sb = DenseBitSet::from_bits(0b1111111111111111111111111111111111111111111111111111100011100010); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0b1111_1111_1111_1111_1111_1111_1111_1111_1111_1111_1111_1111_1111_1000_1110_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: item `DenseBitSet` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:73:1 [INFO] [stderr] | [INFO] [stderr] 73 | / impl DenseBitSet { [INFO] [stderr] 74 | | /// Creates a `DenseBitSet` that can contain at least `num_bits` bits. [INFO] [stderr] 75 | | /// This will be rounded to the nearest word size that can accomodate [INFO] [stderr] 76 | | /// `num_bits` bits. [INFO] [stderr] ... | [INFO] [stderr] 289 | | } [INFO] [stderr] 290 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/lib.rs:117:9 [INFO] [stderr] | [INFO] [stderr] 117 | / let words_to_allocate; [INFO] [stderr] 118 | | if remaining_bits > 0 { [INFO] [stderr] 119 | | words_to_allocate = full_words + 1; [INFO] [stderr] 120 | | } else { [INFO] [stderr] 121 | | words_to_allocate = full_words; [INFO] [stderr] 122 | | } [INFO] [stderr] | |_________^ help: it is more idiomatic to write: `let words_to_allocate = if remaining_bits > 0 { full_words + 1 } else { full_words };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: variable `A` should have a snake case name such as `a` [INFO] [stderr] --> src/lib.rs:362:13 [INFO] [stderr] | [INFO] [stderr] 362 | let A = DenseBitSet::from_bits(0b111000111); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable `B` should have a snake case name such as `b` [INFO] [stderr] --> src/lib.rs:363:13 [INFO] [stderr] | [INFO] [stderr] 363 | let B = DenseBitSet::from_bits(0b111000111); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `C` should have a snake case name such as `c` [INFO] [stderr] --> src/lib.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | let C = DenseBitSet::from_bits(0b110111111); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `A` should have a snake case name such as `a` [INFO] [stderr] --> src/lib.rs:376:13 [INFO] [stderr] | [INFO] [stderr] 376 | let A = DenseBitSet::from_bits(0b1000110001); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `B` should have a snake case name such as `b` [INFO] [stderr] --> src/lib.rs:377:13 [INFO] [stderr] | [INFO] [stderr] 377 | let B = DenseBitSet::from_bits(0b0010000100); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `C` should have a snake case name such as `c` [INFO] [stderr] --> src/lib.rs:378:13 [INFO] [stderr] | [INFO] [stderr] 378 | let C = A.or(&B); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `A` should have a snake case name such as `a` [INFO] [stderr] --> src/lib.rs:388:13 [INFO] [stderr] | [INFO] [stderr] 388 | let A = DenseBitSet::from_bits(0b1000110001); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `B` should have a snake case name such as `b` [INFO] [stderr] --> src/lib.rs:389:13 [INFO] [stderr] | [INFO] [stderr] 389 | let B = DenseBitSet::from_bits(0b1010100100); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `C` should have a snake case name such as `c` [INFO] [stderr] --> src/lib.rs:390:13 [INFO] [stderr] | [INFO] [stderr] 390 | let C = A.and(&B); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `A` should have a snake case name such as `a` [INFO] [stderr] --> src/lib.rs:400:13 [INFO] [stderr] | [INFO] [stderr] 400 | let A = DenseBitSet::from_bits(0b11100010101); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `B` should have a snake case name such as `b` [INFO] [stderr] --> src/lib.rs:401:13 [INFO] [stderr] | [INFO] [stderr] 401 | let B = DenseBitSet::from_bits(0b11110100100); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] warning: variable `C` should have a snake case name such as `c` [INFO] [stderr] --> src/lib.rs:402:13 [INFO] [stderr] | [INFO] [stderr] 402 | let C = A.xor(&B); [INFO] [stderr] | ^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.04s [INFO] running `"docker" "inspect" "eb8cf658d8f1c1e7ce49425f0cdc192c67ce93aa466e14e0a347ee9823a784b5"` [INFO] running `"docker" "rm" "-f" "eb8cf658d8f1c1e7ce49425f0cdc192c67ce93aa466e14e0a347ee9823a784b5"` [INFO] [stdout] eb8cf658d8f1c1e7ce49425f0cdc192c67ce93aa466e14e0a347ee9823a784b5