[INFO] crate bitreader 0.3.1 is already in cache [INFO] extracting crate bitreader 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/bitreader/0.3.1 [INFO] extracting crate bitreader 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitreader/0.3.1 [INFO] validating manifest of bitreader-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bitreader-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bitreader-0.3.1 [INFO] finished frobbing bitreader-0.3.1 [INFO] frobbed toml for bitreader-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/bitreader/0.3.1/Cargo.toml [INFO] started frobbing bitreader-0.3.1 [INFO] finished frobbing bitreader-0.3.1 [INFO] frobbed toml for bitreader-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitreader/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bitreader-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bitreader/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a6a0bf8ddfc61c4a9ba8ab40a371479a9c24b898b81bdc076f57a59676c566cd [INFO] running `"docker" "start" "-a" "a6a0bf8ddfc61c4a9ba8ab40a371479a9c24b898b81bdc076f57a59676c566cd"` [INFO] [stderr] Checking bitreader v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:70:13 [INFO] [stderr] | [INFO] [stderr] 70 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | Ok((value & 0xffffffff) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | Ok((value & 0xffffffff) as i32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:197:26 [INFO] [stderr] | [INFO] [stderr] 197 | self.position % (alignment_bytes as u64 * 8) == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(alignment_bytes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:221:44 [INFO] [stderr] | [INFO] [stderr] 221 | let end_position = self.position + bit_count as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(bit_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:226:28 [INFO] [stderr] | [INFO] [stderr] 226 | requested: bit_count as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(bit_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:236:23 [INFO] [stderr] | [INFO] [stderr] 236 | let bit = (byte >> shift) as u64 & 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(byte >> shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:52:46 [INFO] [stderr] | [INFO] [stderr] 52 | assert_eq!(reader.read_u64(64).unwrap(), 0x4a1e39bbd007ca9a); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0x4a1e_39bb_d007_ca9a` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:53:46 [INFO] [stderr] | [INFO] [stderr] 53 | assert_eq!(reader.read_u64(64).unwrap(), 0xa6ba25526f0a6aba); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0xa6ba_2552_6f0a_6aba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:56:46 [INFO] [stderr] | [INFO] [stderr] 56 | assert_eq!(reader.read_u32(32).unwrap(), 0x4a1e39bb); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4a1e_39bb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:57:46 [INFO] [stderr] | [INFO] [stderr] 57 | assert_eq!(reader.read_u32(32).unwrap(), 0xd007ca9a); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xd007_ca9a` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:58:46 [INFO] [stderr] | [INFO] [stderr] 58 | assert_eq!(reader.read_u32(32).unwrap(), 0xa6ba2552); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xa6ba_2552` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:59:46 [INFO] [stderr] | [INFO] [stderr] 59 | assert_eq!(reader.read_u32(32).unwrap(), 0x6f0a6aba); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x6f0a_6aba` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/tests.rs:90:46 [INFO] [stderr] | [INFO] [stderr] 90 | assert_eq!(reader.read_u16(10).unwrap(), 0b0101010101); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0b01_0101_0101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:121:21 [INFO] [stderr] | [INFO] [stderr] 121 | Ok((value & 0xffffffff) as u32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:148:21 [INFO] [stderr] | [INFO] [stderr] 148 | Ok((value & 0xffffffff) as i32) [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:197:26 [INFO] [stderr] | [INFO] [stderr] 197 | self.position % (alignment_bytes as u64 * 8) == 0 [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(alignment_bytes)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:221:44 [INFO] [stderr] | [INFO] [stderr] 221 | let end_position = self.position + bit_count as u64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(bit_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:226:28 [INFO] [stderr] | [INFO] [stderr] 226 | requested: bit_count as u64, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `u64::from(bit_count)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:236:23 [INFO] [stderr] | [INFO] [stderr] 236 | let bit = (byte >> shift) as u64 & 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(byte >> shift)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.16s [INFO] running `"docker" "inspect" "a6a0bf8ddfc61c4a9ba8ab40a371479a9c24b898b81bdc076f57a59676c566cd"` [INFO] running `"docker" "rm" "-f" "a6a0bf8ddfc61c4a9ba8ab40a371479a9c24b898b81bdc076f57a59676c566cd"` [INFO] [stdout] a6a0bf8ddfc61c4a9ba8ab40a371479a9c24b898b81bdc076f57a59676c566cd