[INFO] crate bitcoin_rpc_client 0.4.0 is already in cache [INFO] extracting crate bitcoin_rpc_client 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/bitcoin_rpc_client/0.4.0 [INFO] extracting crate bitcoin_rpc_client 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitcoin_rpc_client/0.4.0 [INFO] validating manifest of bitcoin_rpc_client-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bitcoin_rpc_client-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bitcoin_rpc_client-0.4.0 [INFO] finished frobbing bitcoin_rpc_client-0.4.0 [INFO] frobbed toml for bitcoin_rpc_client-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/bitcoin_rpc_client/0.4.0/Cargo.toml [INFO] started frobbing bitcoin_rpc_client-0.4.0 [INFO] finished frobbing bitcoin_rpc_client-0.4.0 [INFO] frobbed toml for bitcoin_rpc_client-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitcoin_rpc_client/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bitcoin_rpc_client-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bitcoin_rpc_client/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 378ef016a8282e0c46eeffc0c956c7ae261afc3a4982215d1668a2ec8e82ddbe [INFO] running `"docker" "start" "-a" "378ef016a8282e0c46eeffc0c956c7ae261afc3a4982215d1668a2ec8e82ddbe"` [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking openssl v0.10.16 [INFO] [stderr] Checking tc_core v0.2.0 [INFO] [stderr] Checking bitcoin v0.14.2 [INFO] [stderr] Checking tc_parity_parity v0.2.1 [INFO] [stderr] Checking tc_cli_client v0.1.1 [INFO] [stderr] Checking tc_coblox_bitcoincore v0.3.1 [INFO] [stderr] Checking tc_trufflesuite_ganachecli v0.3.1 [INFO] [stderr] Checking testcontainers v0.3.1 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.9 [INFO] [stderr] Checking jsonrpc_client v0.2.0 [INFO] [stderr] Checking bitcoin_rpc_client v0.4.0 (/opt/crater/workdir) [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/block.rs:83:32 [INFO] [stderr] | [INFO] [stderr] 83 | confirmations: 447014, [INFO] [stderr] | ^^^^^^ help: consider: `447_014` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/lib.rs:1:24 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(test, deny(warnings))] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::unreadable_literal)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/block.rs:97:23 [INFO] [stderr] | [INFO] [stderr] 97 | time: 1231469665, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_231_469_665` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/block.rs:98:29 [INFO] [stderr] | [INFO] [stderr] 98 | mediantime: 1231469665, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_231_469_665` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/block.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | nonce: 2573394689, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `2_573_394_689` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/blockchain.rs:132:29 [INFO] [stderr] | [INFO] [stderr] 132 | difficulty: 4.65654237390692e-10, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: consider: `4.656_542_373_906_92e-10` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/blockchain.rs:133:29 [INFO] [stderr] | [INFO] [stderr] 133 | mediantime: 1296688602, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_296_688_602` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/blockchain.rs:166:34 [INFO] [stderr] | [INFO] [stderr] 166 | timeout: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/blockchain.rs:173:34 [INFO] [stderr] | [INFO] [stderr] 173 | timeout: 9223372036854775807, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `9_223_372_036_854_775_807` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/transaction.rs:467:31 [INFO] [stderr] | [INFO] [stderr] 467 | sequence: 4294967295, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/transaction.rs:472:28 [INFO] [stderr] | [INFO] [stderr] 472 | value: 0.06990000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0.069_900_00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/transaction.rs:566:31 [INFO] [stderr] | [INFO] [stderr] 566 | sequence: 4294967295, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `4_294_967_295` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/transaction.rs:598:19 [INFO] [stderr] | [INFO] [stderr] 598 | time: 1525393130, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_525_393_130` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: long literal lacking separators [INFO] [stderr] --> src/types/transaction.rs:599:24 [INFO] [stderr] | [INFO] [stderr] 599 | blocktime: 1525393130, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_525_393_130` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: aborting due to 13 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bitcoin_rpc_client`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `stub_rpc_client::BitcoinStubClient` [INFO] [stderr] --> src/stub_rpc_client.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | / pub fn new() -> Self { [INFO] [stderr] 7 | | Self {} [INFO] [stderr] 8 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 3 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/types/transaction.rs:254:19 [INFO] [stderr] | [INFO] [stderr] 254 | txid: utxo.txid.clone(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `utxo.txid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `types::transaction::FundingOptions` [INFO] [stderr] --> src/types/transaction.rs:328:5 [INFO] [stderr] | [INFO] [stderr] 328 | / pub fn new() -> Self { [INFO] [stderr] 329 | | FundingOptions { [INFO] [stderr] 330 | | change_address: None, [INFO] [stderr] 331 | | change_position: None, [INFO] [stderr] ... | [INFO] [stderr] 337 | | } [INFO] [stderr] 338 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 292 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "378ef016a8282e0c46eeffc0c956c7ae261afc3a4982215d1668a2ec8e82ddbe"` [INFO] running `"docker" "rm" "-f" "378ef016a8282e0c46eeffc0c956c7ae261afc3a4982215d1668a2ec8e82ddbe"` [INFO] [stdout] 378ef016a8282e0c46eeffc0c956c7ae261afc3a4982215d1668a2ec8e82ddbe