[INFO] crate bitcoin-wallet 0.1.0 is already in cache [INFO] extracting crate bitcoin-wallet 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bitcoin-wallet/0.1.0 [INFO] extracting crate bitcoin-wallet 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitcoin-wallet/0.1.0 [INFO] validating manifest of bitcoin-wallet-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bitcoin-wallet-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bitcoin-wallet-0.1.0 [INFO] finished frobbing bitcoin-wallet-0.1.0 [INFO] frobbed toml for bitcoin-wallet-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bitcoin-wallet/0.1.0/Cargo.toml [INFO] started frobbing bitcoin-wallet-0.1.0 [INFO] finished frobbing bitcoin-wallet-0.1.0 [INFO] frobbed toml for bitcoin-wallet-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitcoin-wallet/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bitcoin-wallet-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bitcoin-wallet/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c2531b243a8467460a4c34d3c9bb3dc9c4b4269b20bb2009beaa038c0de84f11 [INFO] running `"docker" "start" "-a" "c2531b243a8467460a4c34d3c9bb3dc9c4b4269b20bb2009beaa038c0de84f11"` [INFO] [stderr] Checking bech32 v0.3.2 [INFO] [stderr] Compiling secp256k1 v0.9.2 [INFO] [stderr] Checking simple_logger v0.5.0 [INFO] [stderr] Checking strason v0.3.4 [INFO] [stderr] Checking bitcoin-bech32 v0.5.1 [INFO] [stderr] Checking bitcoin v0.13.2 [INFO] [stderr] Checking bitcoin-wallet v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `keyfactory::MasterKeyEntropy` [INFO] [stderr] --> src/mnemonic.rs:116:9 [INFO] [stderr] | [INFO] [stderr] 116 | use keyfactory::MasterKeyEntropy; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `bitcoin::util::bip32::ChildNumber` [INFO] [stderr] --> src/mnemonic.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | use bitcoin::util::bip32::ChildNumber; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ChildNumber`, `ExtendedPubKey` [INFO] [stderr] --> src/account.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | use bitcoin::util::bip32::{ExtendedPubKey, ExtendedPrivKey,ChildNumber}; [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `ChildNumber`, `ExtendedPubKey` [INFO] [stderr] --> src/account.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | use bitcoin::util::bip32::{ExtendedPubKey, ExtendedPrivKey,ChildNumber}; [INFO] [stderr] | ^^^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/mnemonic.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | let mut key_factory: KeyFactory = KeyFactory::new(); [INFO] [stderr] | ----^^^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `account_key` [INFO] [stderr] --> src/account.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | account_key: ExtendedPrivKey, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `address_type` [INFO] [stderr] --> src/account.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | address_type: AccountAddressType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `key_factory` [INFO] [stderr] --> src/account.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | key_factory: Arc [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variable `pkTestCount` should have a snake case name such as `pk_test_count` [INFO] [stderr] --> src/mnemonic.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | let mut pkTestCount = 0; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `t` is only used to index `tests`. [INFO] [stderr] --> src/mnemonic.rs:134:18 [INFO] [stderr] | [INFO] [stderr] 134 | for t in 0 .. tests.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 134 | for in &tests { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/mnemonic.rs:146:31 [INFO] [stderr] | [INFO] [stderr] 146 | let mut key = private_key.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `private_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:49:59 [INFO] [stderr] | [INFO] [stderr] 49 | WalletError::SymmetricCipherError(ref err) => match err { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 50 | | &symmetriccipher::SymmetricCipherError::InvalidLength => "invalid length", [INFO] [stderr] 51 | | &symmetriccipher::SymmetricCipherError::InvalidPadding => "invalid padding" [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | WalletError::SymmetricCipherError(ref err) => match *err { [INFO] [stderr] 50 | symmetriccipher::SymmetricCipherError::InvalidLength => "invalid length", [INFO] [stderr] 51 | symmetriccipher::SymmetricCipherError::InvalidPadding => "invalid padding" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:74:89 [INFO] [stderr] | [INFO] [stderr] 74 | WalletError::SymmetricCipherError(ref err) => write!(f, "Cipher error: {}", match err { [INFO] [stderr] | _________________________________________________________________________________________^ [INFO] [stderr] 75 | | &symmetriccipher::SymmetricCipherError::InvalidLength => "invalid length", [INFO] [stderr] 76 | | &symmetriccipher::SymmetricCipherError::InvalidPadding => "invalid padding" [INFO] [stderr] 77 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | WalletError::SymmetricCipherError(ref err) => write!(f, "Cipher error: {}", match *err { [INFO] [stderr] 75 | symmetriccipher::SymmetricCipherError::InvalidLength => "invalid length", [INFO] [stderr] 76 | symmetriccipher::SymmetricCipherError::InvalidPadding => "invalid padding" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `keyfactory::KeyFactory` [INFO] [stderr] --> src/keyfactory.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> KeyFactory { [INFO] [stderr] 39 | | KeyFactory { [INFO] [stderr] 40 | | secp: Secp256k1::new() [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | impl Default for keyfactory::KeyFactory { [INFO] [stderr] 37 | fn default() -> Self { [INFO] [stderr] 38 | Self::new() [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keyfactory.rs:134:31 [INFO] [stderr] | [INFO] [stderr] 134 | let mut key = master_private.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `master_private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/keyfactory.rs:143:53 [INFO] [stderr] | [INFO] [stderr] 143 | key = key_fabric.private_child(&key.clone(), child).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^ help: try removing the `clone` call: `key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/accountfactory.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | self.master_key.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.master_key` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: field is never used: `account_key` [INFO] [stderr] --> src/account.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | account_key: ExtendedPrivKey, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: field is never used: `address_type` [INFO] [stderr] --> src/account.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | address_type: AccountAddressType, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: field is never used: `key_factory` [INFO] [stderr] --> src/account.rs:37:5 [INFO] [stderr] | [INFO] [stderr] 37 | key_factory: Arc [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:49:59 [INFO] [stderr] | [INFO] [stderr] 49 | WalletError::SymmetricCipherError(ref err) => match err { [INFO] [stderr] | ___________________________________________________________^ [INFO] [stderr] 50 | | &symmetriccipher::SymmetricCipherError::InvalidLength => "invalid length", [INFO] [stderr] 51 | | &symmetriccipher::SymmetricCipherError::InvalidPadding => "invalid padding" [INFO] [stderr] 52 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 49 | WalletError::SymmetricCipherError(ref err) => match *err { [INFO] [stderr] 50 | symmetriccipher::SymmetricCipherError::InvalidLength => "invalid length", [INFO] [stderr] 51 | symmetriccipher::SymmetricCipherError::InvalidPadding => "invalid padding" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/error.rs:74:89 [INFO] [stderr] | [INFO] [stderr] 74 | WalletError::SymmetricCipherError(ref err) => write!(f, "Cipher error: {}", match err { [INFO] [stderr] | _________________________________________________________________________________________^ [INFO] [stderr] 75 | | &symmetriccipher::SymmetricCipherError::InvalidLength => "invalid length", [INFO] [stderr] 76 | | &symmetriccipher::SymmetricCipherError::InvalidPadding => "invalid padding" [INFO] [stderr] 77 | | }) [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 74 | WalletError::SymmetricCipherError(ref err) => write!(f, "Cipher error: {}", match *err { [INFO] [stderr] 75 | symmetriccipher::SymmetricCipherError::InvalidLength => "invalid length", [INFO] [stderr] 76 | symmetriccipher::SymmetricCipherError::InvalidPadding => "invalid padding" [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `keyfactory::KeyFactory` [INFO] [stderr] --> src/keyfactory.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> KeyFactory { [INFO] [stderr] 39 | | KeyFactory { [INFO] [stderr] 40 | | secp: Secp256k1::new() [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 36 | impl Default for keyfactory::KeyFactory { [INFO] [stderr] 37 | fn default() -> Self { [INFO] [stderr] 38 | Self::new() [INFO] [stderr] 39 | } [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/accountfactory.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | self.master_key.clone() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.master_key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.98s [INFO] running `"docker" "inspect" "c2531b243a8467460a4c34d3c9bb3dc9c4b4269b20bb2009beaa038c0de84f11"` [INFO] running `"docker" "rm" "-f" "c2531b243a8467460a4c34d3c9bb3dc9c4b4269b20bb2009beaa038c0de84f11"` [INFO] [stdout] c2531b243a8467460a4c34d3c9bb3dc9c4b4269b20bb2009beaa038c0de84f11