[INFO] crate bitcheck 0.2.8 is already in cache [INFO] extracting crate bitcheck 0.2.8 into work/ex/clippy-test-run/sources/stable/reg/bitcheck/0.2.8 [INFO] extracting crate bitcheck 0.2.8 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitcheck/0.2.8 [INFO] validating manifest of bitcheck-0.2.8 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bitcheck-0.2.8 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bitcheck-0.2.8 [INFO] finished frobbing bitcheck-0.2.8 [INFO] frobbed toml for bitcheck-0.2.8 written to work/ex/clippy-test-run/sources/stable/reg/bitcheck/0.2.8/Cargo.toml [INFO] started frobbing bitcheck-0.2.8 [INFO] finished frobbing bitcheck-0.2.8 [INFO] frobbed toml for bitcheck-0.2.8 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bitcheck/0.2.8/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bitcheck-0.2.8 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bitcheck/0.2.8:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] aa6ea61f06a1a9a61ac25fb379f7c6a8dcfa5dbc3a594e233315c67ea61eb213 [INFO] running `"docker" "start" "-a" "aa6ea61f06a1a9a61ac25fb379f7c6a8dcfa5dbc3a594e233315c67ea61eb213"` [INFO] [stderr] Checking arrayref v0.3.5 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking home v0.3.4 [INFO] [stderr] Checking generic-array v0.9.0 [INFO] [stderr] Checking block-buffer v0.3.3 [INFO] [stderr] Checking digest v0.7.6 [INFO] [stderr] Checking walkdir v2.2.7 [INFO] [stderr] Checking md-5 v0.7.0 [INFO] [stderr] Checking sha-1 v0.7.0 [INFO] [stderr] Checking bitcheck v0.2.8 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_setting.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return sha1sum_check; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sha1sum_check` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_setting.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return md5sum_check; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `md5sum_check` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_setting.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return labs_release_populate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `labs_release_populate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_setting.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return error_file; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `error_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | (home_dir().unwrap()).into_iter().filter_map [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | (home_dir().unwrap()).into_iter().filter_map(|e| e.ok()) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_walk` [INFO] [stderr] --> src/main.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner_walk: while entry.path().file_name().unwrap().eq(release) { [INFO] [stderr] 43 | | labs_filename = release; [INFO] [stderr] 44 | | break 'outer_walk; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | / 'outer: for release in labs_releases { [INFO] [stderr] 42 | | 'inner_walk: while entry.path().file_name().unwrap().eq(release) { [INFO] [stderr] 43 | | labs_filename = release; [INFO] [stderr] 44 | | break 'outer_walk; [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_walk` [INFO] [stderr] --> src/main.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner_walk: while entry.path().file_name().unwrap().eq(release) { [INFO] [stderr] 43 | | labs_filename = release; [INFO] [stderr] 44 | | break 'outer_walk; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner_walk: while entry.path().file_name().unwrap().eq(release) { [INFO] [stderr] 43 | | labs_filename = release; [INFO] [stderr] 44 | | break 'outer_walk; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | let hash_result = String::from(format!("{:x}", &output)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:x}", &output)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:84:27 [INFO] [stderr] | [INFO] [stderr] 84 | let hash_result = String::from(format!("{:x}", &output)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:x}", &output)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bitcheck`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_setting.rs:16:9 [INFO] [stderr] | [INFO] [stderr] 16 | return sha1sum_check; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `sha1sum_check` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_setting.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | return md5sum_check; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `md5sum_check` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_setting.rs:48:9 [INFO] [stderr] | [INFO] [stderr] 48 | return labs_release_populate; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `labs_release_populate` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/bit_setting.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | return error_file; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `error_file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::env::home_dir; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(deprecated)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:26:10 [INFO] [stderr] | [INFO] [stderr] 26 | (home_dir().unwrap()).into_iter().filter_map [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of deprecated item 'std::env::home_dir': This function's behavior is unexpected and probably not what you want. Consider using the home_dir function from https://crates.io/crates/dirs instead. [INFO] [stderr] --> src/main.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | (home_dir().unwrap()).into_iter().filter_map(|e| e.ok()) { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_walk` [INFO] [stderr] --> src/main.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner_walk: while entry.path().file_name().unwrap().eq(release) { [INFO] [stderr] 43 | | labs_filename = release; [INFO] [stderr] 44 | | break 'outer_walk; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'outer` [INFO] [stderr] --> src/main.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | / 'outer: for release in labs_releases { [INFO] [stderr] 42 | | 'inner_walk: while entry.path().file_name().unwrap().eq(release) { [INFO] [stderr] 43 | | labs_filename = release; [INFO] [stderr] 44 | | break 'outer_walk; [INFO] [stderr] 45 | | } [INFO] [stderr] 46 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: unused label `'inner_walk` [INFO] [stderr] --> src/main.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner_walk: while entry.path().file_name().unwrap().eq(release) { [INFO] [stderr] 43 | | labs_filename = release; [INFO] [stderr] 44 | | break 'outer_walk; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/main.rs:42:17 [INFO] [stderr] | [INFO] [stderr] 42 | / 'inner_walk: while entry.path().file_name().unwrap().eq(release) { [INFO] [stderr] 43 | | labs_filename = release; [INFO] [stderr] 44 | | break 'outer_walk; [INFO] [stderr] 45 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:63:27 [INFO] [stderr] | [INFO] [stderr] 63 | let hash_result = String::from(format!("{:x}", &output)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:x}", &output)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/main.rs:84:27 [INFO] [stderr] | [INFO] [stderr] 84 | let hash_result = String::from(format!("{:x}", &output)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `format!("{:x}", &output)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `bitcheck`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "aa6ea61f06a1a9a61ac25fb379f7c6a8dcfa5dbc3a594e233315c67ea61eb213"` [INFO] running `"docker" "rm" "-f" "aa6ea61f06a1a9a61ac25fb379f7c6a8dcfa5dbc3a594e233315c67ea61eb213"` [INFO] [stdout] aa6ea61f06a1a9a61ac25fb379f7c6a8dcfa5dbc3a594e233315c67ea61eb213