[INFO] crate bit-vec 0.5.0 is already in cache [INFO] extracting crate bit-vec 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/bit-vec/0.5.0 [INFO] extracting crate bit-vec 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit-vec/0.5.0 [INFO] validating manifest of bit-vec-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bit-vec-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bit-vec-0.5.0 [INFO] finished frobbing bit-vec-0.5.0 [INFO] frobbed toml for bit-vec-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/bit-vec/0.5.0/Cargo.toml [INFO] started frobbing bit-vec-0.5.0 [INFO] finished frobbing bit-vec-0.5.0 [INFO] frobbed toml for bit-vec-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit-vec/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bit-vec-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bit-vec/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d517704317e9c673b3b07fd7e6bde4ed8d9a479c0d7e1b52427fd05206aece7d [INFO] running `"docker" "start" "-a" "d517704317e9c673b3b07fd7e6bde4ed8d9a479c0d7e1b52427fd05206aece7d"` [INFO] [stderr] Checking bit-vec v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | nbits: nbits [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nbits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | nbits: nbits [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `nbits` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `MatchWords` [INFO] [stderr] --> src/lib.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | type MatchWords<'a, B> = Chain>, Skip>>>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | fn from_byte(byte: u8) -> Self { byte as $t } [INFO] [stderr] | ^^^^ help: try: `u16::from(byte)` [INFO] [stderr] ... [INFO] [stderr] 167 | / bit_block_impl!{ [INFO] [stderr] 168 | | (u8, 8), [INFO] [stderr] 169 | | (u16, 16), [INFO] [stderr] 170 | | (u32, 32), [INFO] [stderr] 171 | | (u64, 64), [INFO] [stderr] 172 | | (usize, core::mem::size_of::() * 8) [INFO] [stderr] 173 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | fn from_byte(byte: u8) -> Self { byte as $t } [INFO] [stderr] | ^^^^ help: try: `u32::from(byte)` [INFO] [stderr] ... [INFO] [stderr] 167 | / bit_block_impl!{ [INFO] [stderr] 168 | | (u8, 8), [INFO] [stderr] 169 | | (u16, 16), [INFO] [stderr] 170 | | (u32, 32), [INFO] [stderr] 171 | | (u64, 64), [INFO] [stderr] 172 | | (usize, core::mem::size_of::() * 8) [INFO] [stderr] 173 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | fn from_byte(byte: u8) -> Self { byte as $t } [INFO] [stderr] | ^^^^ help: try: `u64::from(byte)` [INFO] [stderr] ... [INFO] [stderr] 167 | / bit_block_impl!{ [INFO] [stderr] 168 | | (u8, 8), [INFO] [stderr] 169 | | (u16, 16), [INFO] [stderr] 170 | | (u32, 32), [INFO] [stderr] 171 | | (u64, 64), [INFO] [stderr] 172 | | (usize, core::mem::size_of::() * 8) [INFO] [stderr] 173 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | result = result | ((byte >> i) & 1) << (u8::bits() - 1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result |= ((byte >> i) & 1) << (u8::bits() - 1 - i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | / accumulator = accumulator | [INFO] [stderr] 342 | | (B::from_byte(reverse_bits(bytes[i * B::bytes() + idx])) << (idx * 8)) [INFO] [stderr] | |__________________________________________________________________________________________^ help: replace it with: `accumulator |= (B::from_byte(reverse_bits(bytes[i * B::bytes() + idx])) << (idx * 8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | / last_word = last_word | [INFO] [stderr] 351 | | (B::from_byte(reverse_bits(byte)) << (i * 8)); [INFO] [stderr] | |_________________________________________________________________^ help: replace it with: `last_word |= (B::from_byte(reverse_bits(byte)) << (i * 8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1706:44 [INFO] [stderr] | [INFO] [stderr] 1706 | let bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0110` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1706:56 [INFO] [stderr] | [INFO] [stderr] 1706 | let bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1706:68 [INFO] [stderr] | [INFO] [stderr] 1706 | let bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1715:36 [INFO] [stderr] | [INFO] [stderr] 1715 | assert_eq!(bv.to_bytes(), [0b10100000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1720:36 [INFO] [stderr] | [INFO] [stderr] 1720 | assert_eq!(bv.to_bytes(), [0b00100000, 0b10000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1720:48 [INFO] [stderr] | [INFO] [stderr] 1720 | assert_eq!(bv.to_bytes(), [0b00100000, 0b10000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1733:41 [INFO] [stderr] | [INFO] [stderr] 1733 | assert_eq!(BitVec::from_bytes(&[0b00100110]).iter().collect::>(), bools); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1831:38 [INFO] [stderr] | [INFO] [stderr] 1831 | let v = BitVec::from_bytes(&[0b00010100]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1853:19 [INFO] [stderr] | [INFO] [stderr] 1853 | 0, 0, 0b00010100, 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1854:22 [INFO] [stderr] | [INFO] [stderr] 1854 | 0, 0, 0, 0b00110100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Unnecessary `>= y + 1` or `x - 1 >=` [INFO] [stderr] --> src/lib.rs:1925:17 [INFO] [stderr] | [INFO] [stderr] 1925 | assert!(s.capacity() >= 12 * U32_BITS + 1); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::int_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#int_plus_one [INFO] [stderr] help: change `>= y + 1` to `> y` as shown [INFO] [stderr] | [INFO] [stderr] 1925 | assert!(s.capacity() > 12 * U32_BITS); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1939:48 [INFO] [stderr] | [INFO] [stderr] 1939 | let mut bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1939:60 [INFO] [stderr] | [INFO] [stderr] 1939 | let mut bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1939:72 [INFO] [stderr] | [INFO] [stderr] 1939 | let mut bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1941:50 [INFO] [stderr] | [INFO] [stderr] 1941 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1941:62 [INFO] [stderr] | [INFO] [stderr] 1941 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1941:74 [INFO] [stderr] | [INFO] [stderr] 1941 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1944:50 [INFO] [stderr] | [INFO] [stderr] 1944 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1944:62 [INFO] [stderr] | [INFO] [stderr] 1944 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1944:74 [INFO] [stderr] | [INFO] [stderr] 1944 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1947:50 [INFO] [stderr] | [INFO] [stderr] 1947 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1947:62 [INFO] [stderr] | [INFO] [stderr] 1947 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1947:74 [INFO] [stderr] | [INFO] [stderr] 1947 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b10101010, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1953:48 [INFO] [stderr] | [INFO] [stderr] 1953 | let mut bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1953:60 [INFO] [stderr] | [INFO] [stderr] 1953 | let mut bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1953:72 [INFO] [stderr] | [INFO] [stderr] 1953 | let mut bit_vec = BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1954:40 [INFO] [stderr] | [INFO] [stderr] 1954 | let ext = BitVec::from_bytes(&[0b01001001, 0b10010010, 0b10111101]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1954:52 [INFO] [stderr] | [INFO] [stderr] 1954 | let ext = BitVec::from_bytes(&[0b01001001, 0b10010010, 0b10111101]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1954:64 [INFO] [stderr] | [INFO] [stderr] 1954 | let ext = BitVec::from_bytes(&[0b01001001, 0b10010010, 0b10111101]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1956:50 [INFO] [stderr] | [INFO] [stderr] 1956 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1956:62 [INFO] [stderr] | [INFO] [stderr] 1956 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1956:74 [INFO] [stderr] | [INFO] [stderr] 1956 | assert_eq!(bit_vec, BitVec::from_bytes(&[0b10110110, 0b00000000, 0b11111111, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1957:38 [INFO] [stderr] | [INFO] [stderr] 1957 | 0b01001001, 0b10010010, 0b10111101])); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_1001` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1957:50 [INFO] [stderr] | [INFO] [stderr] 1957 | 0b01001001, 0b10010010, 0b10111101])); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1001_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1957:62 [INFO] [stderr] | [INFO] [stderr] 1957 | 0b01001001, 0b10010010, 0b10111101])); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_1101` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `MatchWords` [INFO] [stderr] --> src/lib.rs:115:1 [INFO] [stderr] | [INFO] [stderr] 115 | type MatchWords<'a, B> = Chain>, Skip>>>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u16 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | fn from_byte(byte: u8) -> Self { byte as $t } [INFO] [stderr] | ^^^^ help: try: `u16::from(byte)` [INFO] [stderr] ... [INFO] [stderr] 167 | / bit_block_impl!{ [INFO] [stderr] 168 | | (u8, 8), [INFO] [stderr] 169 | | (u16, 16), [INFO] [stderr] 170 | | (u32, 32), [INFO] [stderr] 171 | | (u64, 64), [INFO] [stderr] 172 | | (usize, core::mem::size_of::() * 8) [INFO] [stderr] 173 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | fn from_byte(byte: u8) -> Self { byte as $t } [INFO] [stderr] | ^^^^ help: try: `u32::from(byte)` [INFO] [stderr] ... [INFO] [stderr] 167 | / bit_block_impl!{ [INFO] [stderr] 168 | | (u8, 8), [INFO] [stderr] 169 | | (u16, 16), [INFO] [stderr] 170 | | (u32, 32), [INFO] [stderr] 171 | | (u64, 64), [INFO] [stderr] 172 | | (usize, core::mem::size_of::() * 8) [INFO] [stderr] 173 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:156:46 [INFO] [stderr] | [INFO] [stderr] 156 | fn from_byte(byte: u8) -> Self { byte as $t } [INFO] [stderr] | ^^^^ help: try: `u64::from(byte)` [INFO] [stderr] ... [INFO] [stderr] 167 | / bit_block_impl!{ [INFO] [stderr] 168 | | (u8, 8), [INFO] [stderr] 169 | | (u16, 16), [INFO] [stderr] 170 | | (u32, 32), [INFO] [stderr] 171 | | (u64, 64), [INFO] [stderr] 172 | | (usize, core::mem::size_of::() * 8) [INFO] [stderr] 173 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | result = result | ((byte >> i) & 1) << (u8::bits() - 1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result |= ((byte >> i) & 1) << (u8::bits() - 1 - i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:341:17 [INFO] [stderr] | [INFO] [stderr] 341 | / accumulator = accumulator | [INFO] [stderr] 342 | | (B::from_byte(reverse_bits(bytes[i * B::bytes() + idx])) << (idx * 8)) [INFO] [stderr] | |__________________________________________________________________________________________^ help: replace it with: `accumulator |= (B::from_byte(reverse_bits(bytes[i * B::bytes() + idx])) << (idx * 8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:350:17 [INFO] [stderr] | [INFO] [stderr] 350 | / last_word = last_word | [INFO] [stderr] 351 | | (B::from_byte(reverse_bits(byte)) << (i * 8)); [INFO] [stderr] | |_________________________________________________________________^ help: replace it with: `last_word |= (B::from_byte(reverse_bits(byte)) << (i * 8))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1726:31 [INFO] [stderr] | [INFO] [stderr] 1726 | let bit_vec: BitVec = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1739:31 [INFO] [stderr] | [INFO] [stderr] 1739 | let bit_vec: BitVec = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1744:31 [INFO] [stderr] | [INFO] [stderr] 1744 | let bit_vec: BitVec = long.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `long.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/lib.rs:1813:17 [INFO] [stderr] | [INFO] [stderr] 1813 | assert!(a <= b && a >= b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `a == b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `5 * U32_BITS` [INFO] [stderr] --> src/lib.rs:1932:22 [INFO] [stderr] | [INFO] [stderr] 1932 | assert_eq!(s[5 * U32_BITS - 0], true); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:2101:31 [INFO] [stderr] | [INFO] [stderr] 2101 | let bit_vec: BitVec = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:2110:31 [INFO] [stderr] | [INFO] [stderr] 2110 | let bit_vec: BitVec = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:2119:31 [INFO] [stderr] | [INFO] [stderr] 2119 | let bit_vec: BitVec = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.63s [INFO] running `"docker" "inspect" "d517704317e9c673b3b07fd7e6bde4ed8d9a479c0d7e1b52427fd05206aece7d"` [INFO] running `"docker" "rm" "-f" "d517704317e9c673b3b07fd7e6bde4ed8d9a479c0d7e1b52427fd05206aece7d"` [INFO] [stdout] d517704317e9c673b3b07fd7e6bde4ed8d9a479c0d7e1b52427fd05206aece7d