[INFO] crate bit-set 0.5.0 is already in cache [INFO] extracting crate bit-set 0.5.0 into work/ex/clippy-test-run/sources/stable/reg/bit-set/0.5.0 [INFO] extracting crate bit-set 0.5.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit-set/0.5.0 [INFO] validating manifest of bit-set-0.5.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bit-set-0.5.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bit-set-0.5.0 [INFO] finished frobbing bit-set-0.5.0 [INFO] frobbed toml for bit-set-0.5.0 written to work/ex/clippy-test-run/sources/stable/reg/bit-set/0.5.0/Cargo.toml [INFO] started frobbing bit-set-0.5.0 [INFO] finished frobbing bit-set-0.5.0 [INFO] frobbed toml for bit-set-0.5.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit-set/0.5.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bit-set-0.5.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bit-set/0.5.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2a2713c08c96882bcf5086e19ef715b2ea0d6a8400830d957ed7eb1b5a047dd0 [INFO] running `"docker" "start" "-a" "2a2713c08c96882bcf5086e19ef715b2ea0d6a8400830d957ed7eb1b5a047dd0"` [INFO] [stderr] Checking bit-set v0.5.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:221:18 [INFO] [stderr] | [INFO] [stderr] 221 | BitSet { bit_vec: bit_vec } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:221:18 [INFO] [stderr] | [INFO] [stderr] 221 | BitSet { bit_vec: bit_vec } [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `bit_vec` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:779:9 [INFO] [stderr] | [INFO] [stderr] 779 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:791:9 [INFO] [stderr] | [INFO] [stderr] 791 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:883:18 [INFO] [stderr] | [INFO] [stderr] 883 | _ => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:818:31 [INFO] [stderr] | [INFO] [stderr] 818 | let h = blocks.next().unwrap_or(B::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(B::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:779:9 [INFO] [stderr] | [INFO] [stderr] 779 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:791:9 [INFO] [stderr] | [INFO] [stderr] 791 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:883:18 [INFO] [stderr] | [INFO] [stderr] 883 | _ => return None [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `None` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around method argument [INFO] [stderr] --> src/lib.rs:996:44 [INFO] [stderr] | [INFO] [stderr] 996 | assert_eq!(bitset.contains((l-1)), b); [INFO] [stderr] | ^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Consider removing unnecessary double parentheses [INFO] [stderr] --> src/lib.rs:996:44 [INFO] [stderr] | [INFO] [stderr] 996 | assert_eq!(bitset.contains((l-1)), b); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_parens)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1146:38 [INFO] [stderr] | [INFO] [stderr] 1146 | let a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1147:38 [INFO] [stderr] | [INFO] [stderr] 1147 | let b = BitSet::from_bytes(&[0b01000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1149:38 [INFO] [stderr] | [INFO] [stderr] 1149 | let d = BitSet::from_bytes(&[0b00110000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1169:45 [INFO] [stderr] | [INFO] [stderr] 1169 | let expected = BitSet::from_bytes(&[0b10000100]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1174:42 [INFO] [stderr] | [INFO] [stderr] 1174 | let mut a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1175:42 [INFO] [stderr] | [INFO] [stderr] 1175 | let mut b = BitSet::from_bytes(&[0b01100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1186:42 [INFO] [stderr] | [INFO] [stderr] 1186 | let mut a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1187:42 [INFO] [stderr] | [INFO] [stderr] 1187 | let mut b = BitSet::from_bytes(&[0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1195:42 [INFO] [stderr] | [INFO] [stderr] 1195 | let mut a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1204:42 [INFO] [stderr] | [INFO] [stderr] 1204 | let mut a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1205:42 [INFO] [stderr] | [INFO] [stderr] 1205 | let mut b = BitSet::from_bytes(&[0b01100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1216:42 [INFO] [stderr] | [INFO] [stderr] 1216 | let mut a = BitSet::from_bytes(&[0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1217:38 [INFO] [stderr] | [INFO] [stderr] 1217 | let b = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1223:38 [INFO] [stderr] | [INFO] [stderr] 1223 | let b = BitSet::from_bytes(&[0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1228:42 [INFO] [stderr] | [INFO] [stderr] 1228 | let mut a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1229:42 [INFO] [stderr] | [INFO] [stderr] 1229 | let mut b = BitSet::from_bytes(&[0b01100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1246:45 [INFO] [stderr] | [INFO] [stderr] 1246 | let expected = BitSet::from_bytes(&[0b10000100]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1250:42 [INFO] [stderr] | [INFO] [stderr] 1250 | let mut a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1257:42 [INFO] [stderr] | [INFO] [stderr] 1257 | let mut a = BitSet::from_bytes(&[0b11100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1110_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1258:42 [INFO] [stderr] | [INFO] [stderr] 1258 | let mut b = BitSet::from_bytes(&[0b01101010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0110_1010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1268:38 [INFO] [stderr] | [INFO] [stderr] 1268 | let a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1269:38 [INFO] [stderr] | [INFO] [stderr] 1269 | let b = BitSet::from_bytes(&[0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1282:38 [INFO] [stderr] | [INFO] [stderr] 1282 | let a = BitSet::from_bytes(&[0b10100010]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0010` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1283:38 [INFO] [stderr] | [INFO] [stderr] 1283 | let b = BitSet::from_bytes(&[0b00000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:818:31 [INFO] [stderr] | [INFO] [stderr] 818 | let h = blocks.next().unwrap_or(B::zero()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(B::zero)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:1272:17 [INFO] [stderr] | [INFO] [stderr] 1272 | assert!(a == a); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::eq_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:1275:17 [INFO] [stderr] | [INFO] [stderr] 1275 | assert!(b == b); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: equal expressions as operands to `==` [INFO] [stderr] --> src/lib.rs:1277:17 [INFO] [stderr] | [INFO] [stderr] 1277 | assert!(c == c); [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#eq_op [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bit-set`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "2a2713c08c96882bcf5086e19ef715b2ea0d6a8400830d957ed7eb1b5a047dd0"` [INFO] running `"docker" "rm" "-f" "2a2713c08c96882bcf5086e19ef715b2ea0d6a8400830d957ed7eb1b5a047dd0"` [INFO] [stdout] 2a2713c08c96882bcf5086e19ef715b2ea0d6a8400830d957ed7eb1b5a047dd0