[INFO] crate bit-array 0.4.4 is already in cache [INFO] extracting crate bit-array 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/bit-array/0.4.4 [INFO] extracting crate bit-array 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit-array/0.4.4 [INFO] validating manifest of bit-array-0.4.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bit-array-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bit-array-0.4.4 [INFO] finished frobbing bit-array-0.4.4 [INFO] frobbed toml for bit-array-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/bit-array/0.4.4/Cargo.toml [INFO] started frobbing bit-array-0.4.4 [INFO] finished frobbing bit-array-0.4.4 [INFO] frobbed toml for bit-array-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bit-array/0.4.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bit-array-0.4.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bit-array/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9df09d5114fd016cb3c6ecb7fb37614c1d86caefb274ce4a99f44c8e0e0e4153 [INFO] running `"docker" "start" "-a" "9df09d5114fd016cb3c6ecb7fb37614c1d86caefb274ce4a99f44c8e0e0e4153"` [INFO] [stderr] Checking generic-array v0.3.2 [INFO] [stderr] Checking bit-array v0.4.4 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1446:60 [INFO] [stderr] | [INFO] [stderr] 1446 | let bit_array = BitArray::::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1011_0110` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1446:72 [INFO] [stderr] | [INFO] [stderr] 1446 | let bit_array = BitArray::::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1446:84 [INFO] [stderr] | [INFO] [stderr] 1446 | let bit_array = BitArray::::from_bytes(&[0b10110110, 0b00000000, 0b11111111]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1111_1111` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1455:36 [INFO] [stderr] | [INFO] [stderr] 1455 | assert_eq!(bv.to_bytes(), [0b10100000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1460:36 [INFO] [stderr] | [INFO] [stderr] 1460 | assert_eq!(bv.to_bytes(), [0b00100000, 0b10000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1460:48 [INFO] [stderr] | [INFO] [stderr] 1460 | assert_eq!(bv.to_bytes(), [0b00100000, 0b10000000]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1473:54 [INFO] [stderr] | [INFO] [stderr] 1473 | assert_eq!(BitArray::::from_bytes(&[0b00100110]).iter().collect::>(), bools); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0010_0110` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1572:51 [INFO] [stderr] | [INFO] [stderr] 1572 | let v = BitArray::::from_bytes(&[0b00010100]); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1594:19 [INFO] [stderr] | [INFO] [stderr] 1594 | 0, 0, 0b00010100, 0, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0001_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:1595:22 [INFO] [stderr] | [INFO] [stderr] 1595 | 0, 0, 0, 0b00110100, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0b0011_0100` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `MatchWords` [INFO] [stderr] --> src/lib.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | type MatchWords<'a, B> = Chain>, Skip>>>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | result = result | ((byte >> i) & 1) << (u8::bits() - 1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result |= ((byte >> i) & 1) << (u8::bits() - 1 - i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:193:14 [INFO] [stderr] | [INFO] [stderr] 193 | storage: GenericArray>> [INFO] [stderr] 197 | | ,BitsInOut [INFO] [stderr] 198 | | > [INFO] [stderr] 199 | | >, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: item `BitArray` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:227:1 [INFO] [stderr] | [INFO] [stderr] 227 | / impl BitArray [INFO] [stderr] 228 | | where NBits: Add<::Output>, [INFO] [stderr] 229 | | ::Output>>::Output: Sub, [INFO] [stderr] 230 | | <::Output>>::Output as Sub>::Output: Div<::Output>, [INFO] [stderr] ... | [INFO] [stderr] 821 | | } [INFO] [stderr] 822 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: type alias is never used: `MatchWords` [INFO] [stderr] --> src/lib.rs:114:1 [INFO] [stderr] | [INFO] [stderr] 114 | type MatchWords<'a, B> = Chain>, Skip>>>>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/lib.rs:147:9 [INFO] [stderr] | [INFO] [stderr] 147 | result = result | ((byte >> i) & 1) << (u8::bits() - 1 - i); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `result |= ((byte >> i) & 1) << (u8::bits() - 1 - i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/lib.rs:193:14 [INFO] [stderr] | [INFO] [stderr] 193 | storage: GenericArray>> [INFO] [stderr] 197 | | ,BitsInOut [INFO] [stderr] 198 | | > [INFO] [stderr] 199 | | >, [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: item `BitArray` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/lib.rs:227:1 [INFO] [stderr] | [INFO] [stderr] 227 | / impl BitArray [INFO] [stderr] 228 | | where NBits: Add<::Output>, [INFO] [stderr] 229 | | ::Output>>::Output: Sub, [INFO] [stderr] 230 | | <::Output>>::Output as Sub>::Output: Div<::Output>, [INFO] [stderr] ... | [INFO] [stderr] 821 | | } [INFO] [stderr] 822 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1466:44 [INFO] [stderr] | [INFO] [stderr] 1466 | let bit_array: BitArray = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1480:44 [INFO] [stderr] | [INFO] [stderr] 1480 | let bit_array: BitArray = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1485:48 [INFO] [stderr] | [INFO] [stderr] 1485 | let bit_array: BitArray = long.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `long.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: This binary expression can be simplified [INFO] [stderr] --> src/lib.rs:1554:17 [INFO] [stderr] | [INFO] [stderr] 1554 | assert!(a <= b && a >= b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `a == b` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::double_comparisons)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_comparisons [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1614:44 [INFO] [stderr] | [INFO] [stderr] 1614 | let bit_array: BitArray = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1623:44 [INFO] [stderr] | [INFO] [stderr] 1623 | let bit_array: BitArray = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/lib.rs:1632:44 [INFO] [stderr] | [INFO] [stderr] 1632 | let bit_array: BitArray = bools.iter().map(|n| *n).collect(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `bools.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.19s [INFO] running `"docker" "inspect" "9df09d5114fd016cb3c6ecb7fb37614c1d86caefb274ce4a99f44c8e0e0e4153"` [INFO] running `"docker" "rm" "-f" "9df09d5114fd016cb3c6ecb7fb37614c1d86caefb274ce4a99f44c8e0e0e4153"` [INFO] [stdout] 9df09d5114fd016cb3c6ecb7fb37614c1d86caefb274ce4a99f44c8e0e0e4153