[INFO] crate bip_metainfo 0.12.0 is already in cache [INFO] extracting crate bip_metainfo 0.12.0 into work/ex/clippy-test-run/sources/stable/reg/bip_metainfo/0.12.0 [INFO] extracting crate bip_metainfo 0.12.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bip_metainfo/0.12.0 [INFO] validating manifest of bip_metainfo-0.12.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bip_metainfo-0.12.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bip_metainfo-0.12.0 [INFO] finished frobbing bip_metainfo-0.12.0 [INFO] frobbed toml for bip_metainfo-0.12.0 written to work/ex/clippy-test-run/sources/stable/reg/bip_metainfo/0.12.0/Cargo.toml [INFO] started frobbing bip_metainfo-0.12.0 [INFO] finished frobbing bip_metainfo-0.12.0 [INFO] frobbed toml for bip_metainfo-0.12.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bip_metainfo/0.12.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bip_metainfo-0.12.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bip_metainfo/0.12.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 043deeb3ea4a4bdd0bc45f9fc4162cbf878b5ce4cc99fe70b7d156a2d76f9f9a [INFO] running `"docker" "start" "-a" "043deeb3ea4a4bdd0bc45f9fc4162cbf878b5ce4cc99fe70b7d156a2d76f9f9a"` [INFO] [stderr] warning: `panic` setting is ignored for `bench` profile [INFO] [stderr] Checking bip_bencode v0.4.4 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking bip_util v0.5.0 [INFO] [stderr] Checking bip_metainfo v0.12.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/accessor.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | absolute_path: absolute_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `absolute_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/accessor.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | directory_name: directory_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/accessor.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | file_name: file_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/accessor.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | file_contents: file_contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/buffer.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | PieceBuffers { piece_queue: piece_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:85:58 [INFO] [stderr] | [INFO] [stderr] 85 | created_by: None, creation_date: None, info: info } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | announce: announce, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `announce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | info: info [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | info_hash: info_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | piece_len: piece_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | is_private: is_private, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | info_hash: info_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | piece_len: piece_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | is_private: is_private, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | md5sum: md5sum, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `md5sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | md5sum: md5sum, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `md5sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | pieces: pieces, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pieces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/accessor.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | absolute_path: absolute_path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `absolute_path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/accessor.rs:91:13 [INFO] [stderr] | [INFO] [stderr] 91 | directory_name: directory_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `directory_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/accessor.rs:177:13 [INFO] [stderr] | [INFO] [stderr] 177 | file_name: file_name, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_name` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/accessor.rs:178:13 [INFO] [stderr] | [INFO] [stderr] 178 | file_contents: file_contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `file_contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/builder/buffer.rs:24:24 [INFO] [stderr] | [INFO] [stderr] 24 | PieceBuffers { piece_queue: piece_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:85:58 [INFO] [stderr] | [INFO] [stderr] 85 | created_by: None, creation_date: None, info: info } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:105:9 [INFO] [stderr] | [INFO] [stderr] 105 | announce: announce, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `announce` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:109:9 [INFO] [stderr] | [INFO] [stderr] 109 | info: info [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:265:13 [INFO] [stderr] | [INFO] [stderr] 265 | info_hash: info_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:268:13 [INFO] [stderr] | [INFO] [stderr] 268 | piece_len: piece_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:269:13 [INFO] [stderr] | [INFO] [stderr] 269 | is_private: is_private, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:276:13 [INFO] [stderr] | [INFO] [stderr] 276 | info_hash: info_hash, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:279:13 [INFO] [stderr] | [INFO] [stderr] 279 | piece_len: piece_len, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:280:13 [INFO] [stderr] | [INFO] [stderr] 280 | is_private: is_private, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `is_private` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:334:13 [INFO] [stderr] | [INFO] [stderr] 334 | md5sum: md5sum, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `md5sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/metainfo.rs:356:13 [INFO] [stderr] | [INFO] [stderr] 356 | md5sum: md5sum, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `md5sum` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | files: files, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/iter.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | pieces: pieces, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `pieces` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | pub const ROOT_ERROR_KEY: &'static [u8] = b"root"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | pub const ANNOUNCE_URL_KEY: &'static [u8] = b"announce"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub const CREATION_DATE_KEY: &'static [u8] = b"creation date"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | pub const COMMENT_KEY: &'static [u8] = b"comment"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | pub const CREATED_BY_KEY: &'static [u8] = b"created by"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | pub const ENCODING_KEY: &'static [u8] = b"encoding"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | pub const INFO_KEY: &'static [u8] = b"info"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | pub const PIECE_LENGTH_KEY: &'static [u8] = b"piece length"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | pub const PIECES_KEY: &'static [u8] = b"pieces"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | pub const PRIVATE_KEY: &'static [u8] = b"private"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | pub const NAME_KEY: &'static [u8] = b"name"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:36:30 [INFO] [stderr] | [INFO] [stderr] 36 | pub const FILES_KEY: &'static [u8] = b"files"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub const LENGTH_KEY: &'static [u8] = b"length"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | pub const MD5SUM_KEY: &'static [u8] = b"md5sum"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | pub const PATH_KEY: &'static [u8] = b"path"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/metainfo.rs:628:29 [INFO] [stderr] | [INFO] [stderr] 628 | let creation_date = 5050505050; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `5_050_505_050` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:21:28 [INFO] [stderr] | [INFO] [stderr] 21 | pub const ROOT_ERROR_KEY: &'static [u8] = b"root"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:24:31 [INFO] [stderr] | [INFO] [stderr] 24 | pub const ANNOUNCE_URL_KEY: &'static [u8] = b"announce"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | pub const CREATION_DATE_KEY: &'static [u8] = b"creation date"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | pub const COMMENT_KEY: &'static [u8] = b"comment"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | pub const CREATED_BY_KEY: &'static [u8] = b"created by"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | pub const ENCODING_KEY: &'static [u8] = b"encoding"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | pub const INFO_KEY: &'static [u8] = b"info"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:32:30 [INFO] [stderr] | [INFO] [stderr] 32 | pub const PIECE_LENGTH_KEY: &'static [u8] = b"piece length"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:33:30 [INFO] [stderr] | [INFO] [stderr] 33 | pub const PIECES_KEY: &'static [u8] = b"pieces"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:34:30 [INFO] [stderr] | [INFO] [stderr] 34 | pub const PRIVATE_KEY: &'static [u8] = b"private"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:35:30 [INFO] [stderr] | [INFO] [stderr] 35 | pub const NAME_KEY: &'static [u8] = b"name"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:36:30 [INFO] [stderr] | [INFO] [stderr] 36 | pub const FILES_KEY: &'static [u8] = b"files"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:39:24 [INFO] [stderr] | [INFO] [stderr] 39 | pub const LENGTH_KEY: &'static [u8] = b"length"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:40:24 [INFO] [stderr] | [INFO] [stderr] 40 | pub const MD5SUM_KEY: &'static [u8] = b"md5sum"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/parse.rs:41:24 [INFO] [stderr] | [INFO] [stderr] 41 | pub const PATH_KEY: &'static [u8] = b"path"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/builder/worker.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | Err(_) => panic!("bip_metainfo: Master failed to verify all workers shutdown..."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> src/builder/mod.rs:35:43 [INFO] [stderr] | [INFO] [stderr] 35 | const FILE_SIZE_MIN_PIECE_LENGTH: usize = 1 * 1024 * 1024; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> src/builder/mod.rs:38:42 [INFO] [stderr] | [INFO] [stderr] 38 | const TRANSFER_MIN_PIECE_LENGTH: usize = 1 * 1024; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::MetainfoBuilder<'a>` [INFO] [stderr] --> src/builder/mod.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> MetainfoBuilder<'a> { [INFO] [stderr] 61 | | MetainfoBuilder { [INFO] [stderr] 62 | | root: BencodeMut::new_dict(), [INFO] [stderr] 63 | | info: InfoBuilder::new() [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | impl Default for builder::MetainfoBuilder<'a> { [INFO] [stderr] 59 | fn default() -> Self { [INFO] [stderr] 60 | Self::new() [INFO] [stderr] 61 | } [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::InfoBuilder<'a>` [INFO] [stderr] --> src/builder/mod.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / pub fn new() -> InfoBuilder<'a> { [INFO] [stderr] 154 | | InfoBuilder{ info: BencodeMut::new_dict(), piece_length: PieceLength::OptBalanced } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | impl Default for builder::InfoBuilder<'a> { [INFO] [stderr] 153 | fn default() -> Self { [INFO] [stderr] 154 | Self::new() [INFO] [stderr] 155 | } [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metainfo.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / pub fn pieces<'a>(&'a self) -> Pieces<'a> { [INFO] [stderr] 167 | | Pieces::new(&self.pieces) [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metainfo.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn files<'a>(&'a self) -> Files<'a> { [INFO] [stderr] 176 | | Files::new(&self.files) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/metainfo.rs:325:26 [INFO] [stderr] | [INFO] [stderr] 325 | fn as_single_file(info_dict: &BDictAccess) -> ParseResult [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/metainfo.rs:339:25 [INFO] [stderr] | [INFO] [stderr] 339 | fn as_multi_file(file_dict: &BDictAccess) -> ParseResult [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn parse_info_bencode<'a, B>(root_dict: &'a BDictAccess) -> ParseResult<&B> [INFO] [stderr] 81 | | where B: BRefAccess { [INFO] [stderr] 82 | | CONVERT.lookup(root_dict, INFO_KEY) [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: Err(_) will match all errors, maybe not a good idea [INFO] [stderr] --> src/builder/worker.rs:152:13 [INFO] [stderr] | [INFO] [stderr] 152 | Err(_) => panic!("bip_metainfo: Master failed to verify all workers shutdown..."), [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_wild_err_arm)] on by default [INFO] [stderr] = note: to remove this warning, match each error separately or use unreachable macro [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_wild_err_arm [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `DEFAULT_PIECE_LENGTH` [INFO] [stderr] --> src/builder/worker.rs:350:31 [INFO] [stderr] | [INFO] [stderr] 350 | DEFAULT_PIECE_LENGTH * 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/builder/worker.rs:352:46 [INFO] [stderr] | [INFO] [stderr] 352 | for ®ion_length in region_lengths.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `DEFAULT_PIECE_LENGTH` [INFO] [stderr] --> src/builder/worker.rs:364:31 [INFO] [stderr] | [INFO] [stderr] 364 | DEFAULT_PIECE_LENGTH * 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/builder/worker.rs:366:46 [INFO] [stderr] | [INFO] [stderr] 366 | for ®ion_length in region_lengths.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `DEFAULT_PIECE_LENGTH` [INFO] [stderr] --> src/builder/worker.rs:379:31 [INFO] [stderr] | [INFO] [stderr] 379 | DEFAULT_PIECE_LENGTH * 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/builder/worker.rs:381:46 [INFO] [stderr] | [INFO] [stderr] 381 | for ®ion_length in region_lengths.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `DEFAULT_PIECE_LENGTH` [INFO] [stderr] --> src/builder/worker.rs:394:31 [INFO] [stderr] | [INFO] [stderr] 394 | DEFAULT_PIECE_LENGTH * 1, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter() and will not move the array [INFO] [stderr] --> src/builder/worker.rs:396:46 [INFO] [stderr] | [INFO] [stderr] 396 | for ®ion_length in region_lengths.into_iter() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> src/builder/mod.rs:35:43 [INFO] [stderr] | [INFO] [stderr] 35 | const FILE_SIZE_MIN_PIECE_LENGTH: usize = 1 * 1024 * 1024; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> src/builder/mod.rs:38:42 [INFO] [stderr] | [INFO] [stderr] 38 | const TRANSFER_MIN_PIECE_LENGTH: usize = 1 * 1024; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::MetainfoBuilder<'a>` [INFO] [stderr] --> src/builder/mod.rs:60:5 [INFO] [stderr] | [INFO] [stderr] 60 | / pub fn new() -> MetainfoBuilder<'a> { [INFO] [stderr] 61 | | MetainfoBuilder { [INFO] [stderr] 62 | | root: BencodeMut::new_dict(), [INFO] [stderr] 63 | | info: InfoBuilder::new() [INFO] [stderr] 64 | | } [INFO] [stderr] 65 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 58 | impl Default for builder::MetainfoBuilder<'a> { [INFO] [stderr] 59 | fn default() -> Self { [INFO] [stderr] 60 | Self::new() [INFO] [stderr] 61 | } [INFO] [stderr] 62 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `builder::InfoBuilder<'a>` [INFO] [stderr] --> src/builder/mod.rs:153:5 [INFO] [stderr] | [INFO] [stderr] 153 | / pub fn new() -> InfoBuilder<'a> { [INFO] [stderr] 154 | | InfoBuilder{ info: BencodeMut::new_dict(), piece_length: PieceLength::OptBalanced } [INFO] [stderr] 155 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 152 | impl Default for builder::InfoBuilder<'a> { [INFO] [stderr] 153 | fn default() -> Self { [INFO] [stderr] 154 | Self::new() [INFO] [stderr] 155 | } [INFO] [stderr] 156 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metainfo.rs:166:5 [INFO] [stderr] | [INFO] [stderr] 166 | / pub fn pieces<'a>(&'a self) -> Pieces<'a> { [INFO] [stderr] 167 | | Pieces::new(&self.pieces) [INFO] [stderr] 168 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/metainfo.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | / pub fn files<'a>(&'a self) -> Files<'a> { [INFO] [stderr] 176 | | Files::new(&self.files) [INFO] [stderr] 177 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/metainfo.rs:325:26 [INFO] [stderr] | [INFO] [stderr] 325 | fn as_single_file(info_dict: &BDictAccess) -> ParseResult [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: methods called `as_*` usually take self by reference or self by mutable reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/metainfo.rs:339:25 [INFO] [stderr] | [INFO] [stderr] 339 | fn as_multi_file(file_dict: &BDictAccess) -> ParseResult [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stderr] --> src/metainfo.rs:402:42 [INFO] [stderr] | [INFO] [stderr] 402 | files: Option, [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 403 | | Option<&[u8]>, [INFO] [stderr] 404 | | Option>)>>) { [INFO] [stderr] | |___________________________________________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::type_complexity)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/metainfo.rs:393:5 [INFO] [stderr] | [INFO] [stderr] 393 | / fn validate_parse_from_params(tracker: Option<&str>, [INFO] [stderr] 394 | | create_date: Option, [INFO] [stderr] 395 | | comment: Option<&str>, [INFO] [stderr] 396 | | create_by: Option<&str>, [INFO] [stderr] ... | [INFO] [stderr] 525 | | } [INFO] [stderr] 526 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/metainfo.rs:428:25 [INFO] [stderr] | [INFO] [stderr] 428 | files.as_ref().map(|files| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 429 | || let mut bencode_files = BencodeMut::new_list(); [INFO] [stderr] 430 | || [INFO] [stderr] 431 | || { [INFO] [stderr] ... || [INFO] [stderr] 461 | || info_dict_access.insert(parse::FILES_KEY.into(), bencode_files); [INFO] [stderr] 462 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(files) = files.as_ref() { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/metainfo.rs:468:25 [INFO] [stderr] | [INFO] [stderr] 468 | files.as_ref().map(|files| { [INFO] [stderr] | _________________________^ [INFO] [stderr] | |_________________________| [INFO] [stderr] | || [INFO] [stderr] 469 | || let (ref opt_len, ref opt_md5, ref opt_path) = files[0]; [INFO] [stderr] 470 | || [INFO] [stderr] 471 | || opt_path.as_ref().map(|p| info_dict_access.insert(parse::NAME_KEY.into(), ben_bytes!(&p[0][..]))); [INFO] [stderr] 472 | || opt_len.map(|l| info_dict_access.insert(parse::LENGTH_KEY.into(), ben_int!(l))); [INFO] [stderr] 473 | || opt_md5.map(|m| info_dict_access.insert(parse::MD5SUM_KEY.into(), ben_bytes!(m))); [INFO] [stderr] 474 | || }); [INFO] [stderr] | ||__________________________^- help: try this: `if let Some(files) = files.as_ref() { ... }` [INFO] [stderr] | |___________________________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/parse.rs:80:1 [INFO] [stderr] | [INFO] [stderr] 80 | / pub fn parse_info_bencode<'a, B>(root_dict: &'a BDictAccess) -> ParseResult<&B> [INFO] [stderr] 81 | | where B: BRefAccess { [INFO] [stderr] 82 | | CONVERT.lookup(root_dict, INFO_KEY) [INFO] [stderr] 83 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bip_metainfo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `bip_metainfo`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "043deeb3ea4a4bdd0bc45f9fc4162cbf878b5ce4cc99fe70b7d156a2d76f9f9a"` [INFO] running `"docker" "rm" "-f" "043deeb3ea4a4bdd0bc45f9fc4162cbf878b5ce4cc99fe70b7d156a2d76f9f9a"` [INFO] [stdout] 043deeb3ea4a4bdd0bc45f9fc4162cbf878b5ce4cc99fe70b7d156a2d76f9f9a