[INFO] crate bip_handshake 0.7.1 is already in cache
[INFO] extracting crate bip_handshake 0.7.1 into work/ex/clippy-test-run/sources/stable/reg/bip_handshake/0.7.1
[INFO] extracting crate bip_handshake 0.7.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bip_handshake/0.7.1
[INFO] validating manifest of bip_handshake-0.7.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bip_handshake-0.7.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bip_handshake-0.7.1
[INFO] removed 0 missing tests
[INFO] finished frobbing bip_handshake-0.7.1
[INFO] frobbed toml for bip_handshake-0.7.1 written to work/ex/clippy-test-run/sources/stable/reg/bip_handshake/0.7.1/Cargo.toml
[INFO] started frobbing bip_handshake-0.7.1
[INFO] removed 0 missing tests
[INFO] finished frobbing bip_handshake-0.7.1
[INFO] frobbed toml for bip_handshake-0.7.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bip_handshake/0.7.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bip_handshake-0.7.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bip_handshake/0.7.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 06bab66e2f65dc452552d73f2e6a21f877c1bf356c78797f93c5826c80ceb232
[INFO] running `"docker" "start" "-a" "06bab66e2f65dc452552d73f2e6a21f877c1bf356c78797f93c5826c80ceb232"`
[INFO] [stderr]     Checking bip_util v0.5.0
[INFO] [stderr]     Checking bip_handshake v0.7.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/framed.rs:33:26
[INFO] [stderr]    |
[INFO] [stderr] 33 |         FramedHandshake{ sock: sock, write_buffer: BytesMut::with_capacity(1),
[INFO] [stderr]    |                          ^^^^^^^^^^ help: replace it with: `sock`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/message.rs:28:27
[INFO] [stderr]    |
[INFO] [stderr] 28 |         HandshakeMessage{ prot: prot, ext: ext, hash: hash, pid: pid }
[INFO] [stderr]    |                           ^^^^^^^^^^ help: replace it with: `prot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/message.rs:28:39
[INFO] [stderr]    |
[INFO] [stderr] 28 |         HandshakeMessage{ prot: prot, ext: ext, hash: hash, pid: pid }
[INFO] [stderr]    |                                       ^^^^^^^^ help: replace it with: `ext`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/message.rs:28:49
[INFO] [stderr]    |
[INFO] [stderr] 28 |         HandshakeMessage{ prot: prot, ext: ext, hash: hash, pid: pid }
[INFO] [stderr]    |                                                 ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/message.rs:28:61
[INFO] [stderr]    |
[INFO] [stderr] 28 |         HandshakeMessage{ prot: prot, ext: ext, hash: hash, pid: pid }
[INFO] [stderr]    |                                                             ^^^^^^^^ help: replace it with: `pid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handshake/handler/listener.rs:24:26
[INFO] [stderr]    |
[INFO] [stderr] 24 |         ListenerHandler{ opt_item: opt_item }
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `opt_item`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handshake/handler/timer.rs:14:25
[INFO] [stderr]    |
[INFO] [stderr] 14 |         HandshakeTimer{ timer: timer, duration: duration }
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: replace it with: `timer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handshake/handler/timer.rs:14:39
[INFO] [stderr]    |
[INFO] [stderr] 14 |         HandshakeTimer{ timer: timer, duration: duration }
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:165:24
[INFO] [stderr]     |
[INFO] [stderr] 165 |         Ok(Handshaker{ sink: sink, stream: stream })
[INFO] [stderr]     |                        ^^^^^^^^^^ help: replace it with: `sink`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:165:36
[INFO] [stderr]     |
[INFO] [stderr] 165 |         Ok(Handshaker{ sink: sink, stream: stream })
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:230:25
[INFO] [stderr]     |
[INFO] [stderr] 230 |         HandshakerSink{ send: send, port: port, pid: pid, filters: filters }
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `send`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:230:37
[INFO] [stderr]     |
[INFO] [stderr] 230 |         HandshakerSink{ send: send, port: port, pid: pid, filters: filters }
[INFO] [stderr]     |                                     ^^^^^^^^^^ help: replace it with: `port`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:230:49
[INFO] [stderr]     |
[INFO] [stderr] 230 |         HandshakerSink{ send: send, port: port, pid: pid, filters: filters }
[INFO] [stderr]     |                                                 ^^^^^^^^ help: replace it with: `pid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:230:59
[INFO] [stderr]     |
[INFO] [stderr] 230 |         HandshakerSink{ send: send, port: port, pid: pid, filters: filters }
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^ help: replace it with: `filters`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:282:27
[INFO] [stderr]     |
[INFO] [stderr] 282 |         HandshakerStream{ recv: recv }
[INFO] [stderr]     |                           ^^^^^^^^^^ help: replace it with: `recv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:26
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                          ^^^^^^^^^^ help: replace it with: `prot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:38
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                      ^^^^^^^^ help: replace it with: `ext`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:48
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                                ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:60
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                                            ^^^^^^^^ help: replace it with: `pid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:70
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                                                      ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:82
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                                                                  ^^^^^^^^^^ help: replace it with: `sock`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/extensions.rs:82:21
[INFO] [stderr]    |
[INFO] [stderr] 82 |         Extensions{ bytes: bytes }
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/extensions.rs:88:21
[INFO] [stderr]    |
[INFO] [stderr] 88 |         Extensions{ bytes: bytes }
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/initiate.rs:18:26
[INFO] [stderr]    |
[INFO] [stderr] 18 |         InitiateMessage{ prot: prot, hash: hash, addr: addr }
[INFO] [stderr]    |                          ^^^^^^^^^^ help: replace it with: `prot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/initiate.rs:18:38
[INFO] [stderr]    |
[INFO] [stderr] 18 |         InitiateMessage{ prot: prot, hash: hash, addr: addr }
[INFO] [stderr]    |                                      ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/initiate.rs:18:50
[INFO] [stderr]    |
[INFO] [stderr] 18 |         InitiateMessage{ prot: prot, hash: hash, addr: addr }
[INFO] [stderr]    |                                                  ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/filter/filters.rs:102:30
[INFO] [stderr]     |
[INFO] [stderr] 102 |             BlockAddrFilter{ addr: addr }
[INFO] [stderr]     |                              ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/filter/filters.rs:129:34
[INFO] [stderr]     |
[INFO] [stderr] 129 |             BlockProtocolFilter{ prot: prot }
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: replace it with: `prot`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/filter/filters.rs:156:32
[INFO] [stderr]     |
[INFO] [stderr] 156 |             BlockPeerIdFilter{ pid: pid }
[INFO] [stderr]     |                                ^^^^^^^^ help: replace it with: `pid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/transport.rs:61:28
[INFO] [stderr]    |
[INFO] [stderr] 61 |         TcpListenerStream{ listen_addr: listen_addr, listener: listener }
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/transport.rs:61:54
[INFO] [stderr]    |
[INFO] [stderr] 61 |         TcpListenerStream{ listen_addr: listen_addr, listener: listener }
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^ help: replace it with: `listener`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/transport.rs:120:27
[INFO] [stderr]     |
[INFO] [stderr] 120 |             MockListener{ addr: addr, empty: stream::empty() }
[INFO] [stderr]     |                           ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/framed.rs:33:26
[INFO] [stderr]    |
[INFO] [stderr] 33 |         FramedHandshake{ sock: sock, write_buffer: BytesMut::with_capacity(1),
[INFO] [stderr]    |                          ^^^^^^^^^^ help: replace it with: `sock`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/message.rs:28:27
[INFO] [stderr]    |
[INFO] [stderr] 28 |         HandshakeMessage{ prot: prot, ext: ext, hash: hash, pid: pid }
[INFO] [stderr]    |                           ^^^^^^^^^^ help: replace it with: `prot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/message.rs:28:39
[INFO] [stderr]    |
[INFO] [stderr] 28 |         HandshakeMessage{ prot: prot, ext: ext, hash: hash, pid: pid }
[INFO] [stderr]    |                                       ^^^^^^^^ help: replace it with: `ext`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/message.rs:28:49
[INFO] [stderr]    |
[INFO] [stderr] 28 |         HandshakeMessage{ prot: prot, ext: ext, hash: hash, pid: pid }
[INFO] [stderr]    |                                                 ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bittorrent/message.rs:28:61
[INFO] [stderr]    |
[INFO] [stderr] 28 |         HandshakeMessage{ prot: prot, ext: ext, hash: hash, pid: pid }
[INFO] [stderr]    |                                                             ^^^^^^^^ help: replace it with: `pid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handshake/handler/listener.rs:24:26
[INFO] [stderr]    |
[INFO] [stderr] 24 |         ListenerHandler{ opt_item: opt_item }
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^ help: replace it with: `opt_item`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handshake/handler/timer.rs:14:25
[INFO] [stderr]    |
[INFO] [stderr] 14 |         HandshakeTimer{ timer: timer, duration: duration }
[INFO] [stderr]    |                         ^^^^^^^^^^^^ help: replace it with: `timer`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/handshake/handler/timer.rs:14:39
[INFO] [stderr]    |
[INFO] [stderr] 14 |         HandshakeTimer{ timer: timer, duration: duration }
[INFO] [stderr]    |                                       ^^^^^^^^^^^^^^^^^^ help: replace it with: `duration`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:165:24
[INFO] [stderr]     |
[INFO] [stderr] 165 |         Ok(Handshaker{ sink: sink, stream: stream })
[INFO] [stderr]     |                        ^^^^^^^^^^ help: replace it with: `sink`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:165:36
[INFO] [stderr]     |
[INFO] [stderr] 165 |         Ok(Handshaker{ sink: sink, stream: stream })
[INFO] [stderr]     |                                    ^^^^^^^^^^^^^^ help: replace it with: `stream`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:230:25
[INFO] [stderr]     |
[INFO] [stderr] 230 |         HandshakerSink{ send: send, port: port, pid: pid, filters: filters }
[INFO] [stderr]     |                         ^^^^^^^^^^ help: replace it with: `send`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:230:37
[INFO] [stderr]     |
[INFO] [stderr] 230 |         HandshakerSink{ send: send, port: port, pid: pid, filters: filters }
[INFO] [stderr]     |                                     ^^^^^^^^^^ help: replace it with: `port`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:230:49
[INFO] [stderr]     |
[INFO] [stderr] 230 |         HandshakerSink{ send: send, port: port, pid: pid, filters: filters }
[INFO] [stderr]     |                                                 ^^^^^^^^ help: replace it with: `pid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:230:59
[INFO] [stderr]     |
[INFO] [stderr] 230 |         HandshakerSink{ send: send, port: port, pid: pid, filters: filters }
[INFO] [stderr]     |                                                           ^^^^^^^^^^^^^^^^ help: replace it with: `filters`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/handshake/handshaker.rs:282:27
[INFO] [stderr]     |
[INFO] [stderr] 282 |         HandshakerStream{ recv: recv }
[INFO] [stderr]     |                           ^^^^^^^^^^ help: replace it with: `recv`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:26
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                          ^^^^^^^^^^ help: replace it with: `prot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:38
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                      ^^^^^^^^ help: replace it with: `ext`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:48
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                                ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:60
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                                            ^^^^^^^^ help: replace it with: `pid`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:70
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                                                      ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/complete.rs:21:82
[INFO] [stderr]    |
[INFO] [stderr] 21 |         CompleteMessage{ prot: prot, ext: ext, hash: hash, pid: pid, addr: addr, sock: sock }
[INFO] [stderr]    |                                                                                  ^^^^^^^^^^ help: replace it with: `sock`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/extensions.rs:82:21
[INFO] [stderr]    |
[INFO] [stderr] 82 |         Extensions{ bytes: bytes }
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/extensions.rs:88:21
[INFO] [stderr]    |
[INFO] [stderr] 88 |         Extensions{ bytes: bytes }
[INFO] [stderr]    |                     ^^^^^^^^^^^^ help: replace it with: `bytes`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/initiate.rs:18:26
[INFO] [stderr]    |
[INFO] [stderr] 18 |         InitiateMessage{ prot: prot, hash: hash, addr: addr }
[INFO] [stderr]    |                          ^^^^^^^^^^ help: replace it with: `prot`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/initiate.rs:18:38
[INFO] [stderr]    |
[INFO] [stderr] 18 |         InitiateMessage{ prot: prot, hash: hash, addr: addr }
[INFO] [stderr]    |                                      ^^^^^^^^^^ help: replace it with: `hash`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/message/initiate.rs:18:50
[INFO] [stderr]    |
[INFO] [stderr] 18 |         InitiateMessage{ prot: prot, hash: hash, addr: addr }
[INFO] [stderr]    |                                                  ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/filter/filters.rs:102:30
[INFO] [stderr]     |
[INFO] [stderr] 102 |             BlockAddrFilter{ addr: addr }
[INFO] [stderr]     |                              ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/filter/filters.rs:129:34
[INFO] [stderr]     |
[INFO] [stderr] 129 |             BlockProtocolFilter{ prot: prot }
[INFO] [stderr]     |                                  ^^^^^^^^^^ help: replace it with: `prot`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/filter/filters.rs:156:32
[INFO] [stderr]     |
[INFO] [stderr] 156 |             BlockPeerIdFilter{ pid: pid }
[INFO] [stderr]     |                                ^^^^^^^^ help: replace it with: `pid`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/transport.rs:61:28
[INFO] [stderr]    |
[INFO] [stderr] 61 |         TcpListenerStream{ listen_addr: listen_addr, listener: listener }
[INFO] [stderr]    |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `listen_addr`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/transport.rs:61:54
[INFO] [stderr]    |
[INFO] [stderr] 61 |         TcpListenerStream{ listen_addr: listen_addr, listener: listener }
[INFO] [stderr]    |                                                      ^^^^^^^^^^^^^^^^^^ help: replace it with: `listener`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/transport.rs:120:27
[INFO] [stderr]     |
[INFO] [stderr] 120 |             MockListener{ addr: addr, empty: stream::empty() }
[INFO] [stderr]     |                           ^^^^^^^^^^ help: replace it with: `addr`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/message/protocol.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 | const BT_PROTOCOL:     &'static [u8] = b"BitTorrent protocol";
[INFO] [stderr]   |                        -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: Constants have by default a `'static` lifetime
[INFO] [stderr]  --> src/message/protocol.rs:7:25
[INFO] [stderr]   |
[INFO] [stderr] 7 | const BT_PROTOCOL:     &'static [u8] = b"BitTorrent protocol";
[INFO] [stderr]   |                        -^^^^^^^----- help: consider removing `'static`: `&[u8]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::const_static_lifetime)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/bittorrent/framed.rs:59:55
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 Async::Ready(0)       => { return Err(io::Error::new(io::ErrorKind::WriteZero, "Failed To Write Bytes").into()) },
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::new(io::ErrorKind::WriteZero, "Failed To Write Bytes")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `handshake::handshaker::HandshakerBuilder`
[INFO] [stderr]   --> src/handshake/handshaker.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 | /     pub fn new() -> HandshakerBuilder {
[INFO] [stderr] 45 | |         let default_v4_addr = Ipv4Addr::new(0, 0, 0, 0);
[INFO] [stderr] 46 | |         let default_v4_port = 0;
[INFO] [stderr] 47 | | 
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |                            ext: Extensions::new(), config: HandshakerConfig::default() }
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 42 | impl Default for handshake::handshaker::HandshakerBuilder {
[INFO] [stderr] 43 |     fn default() -> Self {
[INFO] [stderr] 44 |         Self::new()
[INFO] [stderr] 45 |     }
[INFO] [stderr] 46 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `message::extensions::Extensions`
[INFO] [stderr]   --> src/message/extensions.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     pub fn new() -> Extensions {
[INFO] [stderr] 24 | |         Extensions::with_bytes([0u8; NUM_EXTENSION_BYTES])
[INFO] [stderr] 25 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/extensions.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn contains(&self, extension: Extension) -> bool {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/extensions.rs:62:27
[INFO] [stderr]    |
[INFO] [stderr] 62 |     pub fn write_bytes<W>(&self, mut writer: W) -> io::Result<()>
[INFO] [stderr]    |                           ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/extensions.rs:70:18
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn union(&self, ext: &Extensions) -> Extensions {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/extensions.rs:70:30
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn union(&self, ext: &Extensions) -> Extensions {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: consider passing by value instead: `Extensions`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/message/protocol.rs:26:28
[INFO] [stderr]    |
[INFO] [stderr] 26 |           let (len, bytes) = match self {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 27 | |             &Protocol::BitTorrent       => (BT_PROTOCOL_LEN as usize, &BT_PROTOCOL[..]),
[INFO] [stderr] 28 | |             &Protocol::Custom(ref prot) => (prot.len(), &prot[..])
[INFO] [stderr] 29 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 26 |         let (len, bytes) = match *self {
[INFO] [stderr] 27 |             Protocol::BitTorrent       => (BT_PROTOCOL_LEN as usize, &BT_PROTOCOL[..]),
[INFO] [stderr] 28 |             Protocol::Custom(ref prot) => (prot.len(), &prot[..])
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/message/protocol.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self {
[INFO] [stderr] 40 | |             &Protocol::BitTorrent         => BT_PROTOCOL_LEN as usize,
[INFO] [stderr] 41 | |             &Protocol::Custom(ref custom) => custom.len()
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 39 |         match *self {
[INFO] [stderr] 40 |             Protocol::BitTorrent         => BT_PROTOCOL_LEN as usize,
[INFO] [stderr] 41 |             Protocol::Custom(ref custom) => custom.len()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/message/protocol.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     switch!(bytes, parse_raw_protocol,
[INFO] [stderr] 53 | |         // TODO: Move back to using constant here, for now, MIR compiler error occurs
[INFO] [stderr] 54 | |         b"BitTorrent protocol" => value!(Protocol::BitTorrent) |
[INFO] [stderr] 55 | |         custom                 => value!(Protocol::Custom(custom.to_vec()))
[INFO] [stderr] 56 | |     )
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/filter/filters.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 | /             match opt_found {
[INFO] [stderr] 34 | |                 Some(index) => { mut_filters.swap_remove(index); },
[INFO] [stderr] 35 | |                 None        => ()
[INFO] [stderr] 36 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(index) = opt_found { mut_filters.swap_remove(index); }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/filter/filters.rs:72:44
[INFO] [stderr]    |
[INFO] [stderr] 72 |     for (index, ref_filter) in ref_filters.into_iter().enumerate() {
[INFO] [stderr]    |                                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/filter/mod.rs:99:19
[INFO] [stderr]    |
[INFO] [stderr] 99 |     pub fn choose(&self, other: FilterDecision) -> FilterDecision {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/bittorrent/framed.rs:59:55
[INFO] [stderr]    |
[INFO] [stderr] 59 |                 Async::Ready(0)       => { return Err(io::Error::new(io::ErrorKind::WriteZero, "Failed To Write Bytes").into()) },
[INFO] [stderr]    |                                                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `io::Error::new(io::ErrorKind::WriteZero, "Failed To Write Bytes")`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/handshake/handler/listener.rs:50:44
[INFO] [stderr]    |
[INFO] [stderr] 50 |         let handler = ListenerHandler::new(exp_item.clone(), &Filters::new());
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `exp_item`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/handshake/handler/listener.rs:69:44
[INFO] [stderr]    |
[INFO] [stderr] 69 |         let handler = ListenerHandler::new(exp_item.clone(), &filters);
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `exp_item`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]   --> src/handshake/handler/listener.rs:88:44
[INFO] [stderr]    |
[INFO] [stderr] 88 |         let handler = ListenerHandler::new(exp_item.clone(), &filters);
[INFO] [stderr]    |                                            ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `exp_item`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/handshake/handler/listener.rs:107:44
[INFO] [stderr]     |
[INFO] [stderr] 107 |         let handler = ListenerHandler::new(exp_item.clone(), &filters);
[INFO] [stderr]     |                                            ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `exp_item`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider adding a `Default` implementation for `handshake::handshaker::HandshakerBuilder`
[INFO] [stderr]   --> src/handshake/handshaker.rs:44:5
[INFO] [stderr]    |
[INFO] [stderr] 44 | /     pub fn new() -> HandshakerBuilder {
[INFO] [stderr] 45 | |         let default_v4_addr = Ipv4Addr::new(0, 0, 0, 0);
[INFO] [stderr] 46 | |         let default_v4_port = 0;
[INFO] [stderr] 47 | | 
[INFO] [stderr] ...  |
[INFO] [stderr] 55 | |                            ext: Extensions::new(), config: HandshakerConfig::default() }
[INFO] [stderr] 56 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 42 | impl Default for handshake::handshaker::HandshakerBuilder {
[INFO] [stderr] 43 |     fn default() -> Self {
[INFO] [stderr] 44 |         Self::new()
[INFO] [stderr] 45 |     }
[INFO] [stderr] 46 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `message::extensions::Extensions`
[INFO] [stderr]   --> src/message/extensions.rs:23:5
[INFO] [stderr]    |
[INFO] [stderr] 23 | /     pub fn new() -> Extensions {
[INFO] [stderr] 24 | |         Extensions::with_bytes([0u8; NUM_EXTENSION_BYTES])
[INFO] [stderr] 25 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 17 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/extensions.rs:51:21
[INFO] [stderr]    |
[INFO] [stderr] 51 |     pub fn contains(&self, extension: Extension) -> bool {
[INFO] [stderr]    |                     ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/extensions.rs:62:27
[INFO] [stderr]    |
[INFO] [stderr] 62 |     pub fn write_bytes<W>(&self, mut writer: W) -> io::Result<()>
[INFO] [stderr]    |                           ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/extensions.rs:70:18
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn union(&self, ext: &Extensions) -> Extensions {
[INFO] [stderr]    |                  ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/message/extensions.rs:70:30
[INFO] [stderr]    |
[INFO] [stderr] 70 |     pub fn union(&self, ext: &Extensions) -> Extensions {
[INFO] [stderr]    |                              ^^^^^^^^^^^ help: consider passing by value instead: `Extensions`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/message/protocol.rs:26:28
[INFO] [stderr]    |
[INFO] [stderr] 26 |           let (len, bytes) = match self {
[INFO] [stderr]    |  ____________________________^
[INFO] [stderr] 27 | |             &Protocol::BitTorrent       => (BT_PROTOCOL_LEN as usize, &BT_PROTOCOL[..]),
[INFO] [stderr] 28 | |             &Protocol::Custom(ref prot) => (prot.len(), &prot[..])
[INFO] [stderr] 29 | |         };
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::match_ref_pats)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 26 |         let (len, bytes) = match *self {
[INFO] [stderr] 27 |             Protocol::BitTorrent       => (BT_PROTOCOL_LEN as usize, &BT_PROTOCOL[..]),
[INFO] [stderr] 28 |             Protocol::Custom(ref prot) => (prot.len(), &prot[..])
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: you don't need to add `&` to all patterns
[INFO] [stderr]   --> src/message/protocol.rs:39:9
[INFO] [stderr]    |
[INFO] [stderr] 39 | /         match self {
[INFO] [stderr] 40 | |             &Protocol::BitTorrent         => BT_PROTOCOL_LEN as usize,
[INFO] [stderr] 41 | |             &Protocol::Custom(ref custom) => custom.len()
[INFO] [stderr] 42 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats
[INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression
[INFO] [stderr]    |
[INFO] [stderr] 39 |         match *self {
[INFO] [stderr] 40 |             Protocol::BitTorrent         => BT_PROTOCOL_LEN as usize,
[INFO] [stderr] 41 |             Protocol::Custom(ref custom) => custom.len()
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/message/protocol.rs:52:5
[INFO] [stderr]    |
[INFO] [stderr] 52 | /     switch!(bytes, parse_raw_protocol,
[INFO] [stderr] 53 | |         // TODO: Move back to using constant here, for now, MIR compiler error occurs
[INFO] [stderr] 54 | |         b"BitTorrent protocol" => value!(Protocol::BitTorrent) |
[INFO] [stderr] 55 | |         custom                 => value!(Protocol::Custom(custom.to_vec()))
[INFO] [stderr] 56 | |     )
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let`
[INFO] [stderr]   --> src/filter/filters.rs:33:13
[INFO] [stderr]    |
[INFO] [stderr] 33 | /             match opt_found {
[INFO] [stderr] 34 | |                 Some(index) => { mut_filters.swap_remove(index); },
[INFO] [stderr] 35 | |                 None        => ()
[INFO] [stderr] 36 | |             }
[INFO] [stderr]    | |_____________^ help: try this: `if let Some(index) = opt_found { mut_filters.swap_remove(index); }`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_match)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match
[INFO] [stderr] 
[INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the slice
[INFO] [stderr]   --> src/filter/filters.rs:72:44
[INFO] [stderr]    |
[INFO] [stderr] 72 |     for (index, ref_filter) in ref_filters.into_iter().enumerate() {
[INFO] [stderr]    |                                            ^^^^^^^^^ help: call directly: `iter`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::into_iter_on_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref
[INFO] [stderr] 
[INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value
[INFO] [stderr]   --> src/filter/mod.rs:99:19
[INFO] [stderr]    |
[INFO] [stderr] 99 |     pub fn choose(&self, other: FilterDecision) -> FilterDecision {
[INFO] [stderr]    |                   ^^^^^ help: consider passing by value instead: `self`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> examples/handshake_torrent.rs:20:5
[INFO] [stderr]    |
[INFO] [stderr] 20 |     stdout.write(b"Enter An InfoHash In Hex Format: ").unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::unused_io_amount)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead
[INFO] [stderr]   --> examples/handshake_torrent.rs:26:5
[INFO] [stderr]    |
[INFO] [stderr] 26 |     stdout.write(b"Enter An Address And Port (eg: addr:port): ").unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `byte_index` is used to index `exact_bytes`
[INFO] [stderr]   --> examples/handshake_torrent.rs:56:23
[INFO] [stderr]    |
[INFO] [stderr] 56 |     for byte_index in 0..20 {
[INFO] [stderr]    |                       ^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]    |
[INFO] [stderr] 56 |     for (byte_index, <item>) in exact_bytes.iter_mut().enumerate() {
[INFO] [stderr]    |         ^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]   --> examples/handshake_torrent.rs:60:30
[INFO] [stderr]    |
[INFO] [stderr] 60 |         let hex_chunk = &hex[high_index..low_index + 1];
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `high_index..=low_index`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `bip_handshake`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] error: build failed
[INFO] running `"docker" "inspect" "06bab66e2f65dc452552d73f2e6a21f877c1bf356c78797f93c5826c80ceb232"`
[INFO] running `"docker" "rm" "-f" "06bab66e2f65dc452552d73f2e6a21f877c1bf356c78797f93c5826c80ceb232"`
[INFO] [stdout] 06bab66e2f65dc452552d73f2e6a21f877c1bf356c78797f93c5826c80ceb232