[INFO] crate bip_disk 0.6.0 is already in cache [INFO] extracting crate bip_disk 0.6.0 into work/ex/clippy-test-run/sources/stable/reg/bip_disk/0.6.0 [INFO] extracting crate bip_disk 0.6.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bip_disk/0.6.0 [INFO] validating manifest of bip_disk-0.6.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bip_disk-0.6.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bip_disk-0.6.0 [INFO] removed 0 missing tests [INFO] finished frobbing bip_disk-0.6.0 [INFO] frobbed toml for bip_disk-0.6.0 written to work/ex/clippy-test-run/sources/stable/reg/bip_disk/0.6.0/Cargo.toml [INFO] started frobbing bip_disk-0.6.0 [INFO] removed 0 missing tests [INFO] finished frobbing bip_disk-0.6.0 [INFO] frobbed toml for bip_disk-0.6.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bip_disk/0.6.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bip_disk-0.6.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bip_disk/0.6.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2327841624c4112659ddaf550db77b8632ddb8a93afe518a0f825b9c5016ac6b [INFO] running `"docker" "start" "-a" "2327841624c4112659ddaf550db77b8632ddb8a93afe518a0f825b9c5016ac6b"` [INFO] [stderr] warning: `panic` setting is ignored for `bench` profile [INFO] [stderr] Checking bip_bencode v0.3.1 [INFO] [stderr] Checking chrono v0.2.25 [INFO] [stderr] Checking bip_util v0.5.0 [INFO] [stderr] Checking bip_metainfo v0.11.0 [INFO] [stderr] Checking bip_disk v0.6.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | DiskManager{ sink: sink, stream: stream } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | DiskManager{ sink: sink, stream: stream } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:92:26 [INFO] [stderr] | [INFO] [stderr] 92 | DiskManagerSink{ pool: pool, context: context, max_capacity: max_capacity, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:92:38 [INFO] [stderr] | [INFO] [stderr] 92 | DiskManagerSink{ pool: pool, context: context, max_capacity: max_capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:92:56 [INFO] [stderr] | [INFO] [stderr] 92 | DiskManagerSink{ pool: pool, context: context, max_capacity: max_capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:93:54 [INFO] [stderr] | [INFO] [stderr] 93 | cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `task_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:157:28 [INFO] [stderr] | [INFO] [stderr] 157 | DiskManagerStream{ recv: recv, cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `recv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:157:40 [INFO] [stderr] | [INFO] [stderr] 157 | DiskManagerStream{ recv: recv, cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:157:68 [INFO] [stderr] | [INFO] [stderr] 157 | DiskManagerStream{ recv: recv, cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `task_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/fs/cache/file_handle.rs:23:70 [INFO] [stderr] | [INFO] [stderr] 23 | FileHandleCache{ cache: Mutex::new(LruCache::new(capacity)), inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/fs/native.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | NativeFile{ file: file } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/context.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | MetainfoState{ file: file, state: state } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/context.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | MetainfoState{ file: file, state: state } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/context.rs:32:78 [INFO] [stderr] | [INFO] [stderr] 32 | DiskManagerContext{ torrents: Arc::new(RwLock::new(HashMap::new())), out: out, fs: Arc::new(fs) } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_accessor.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | fs: fs, [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_accessor.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | info_dict: info_dict [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | fs: fs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | info_dict: info_dict, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | checker_state: checker_state [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `checker_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | total_blocks: total_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | last_block_size: last_block_size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/mod.rs:87:73 [INFO] [stderr] | [INFO] [stderr] 87 | Err(TorrentError::from_kind(TorrentErrorKind::InfoHashNotFound{ hash: hash })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/mod.rs:109:73 [INFO] [stderr] | [INFO] [stderr] 109 | Err(TorrentError::from_kind(TorrentErrorKind::InfoHashNotFound{ hash: hash })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | BlockMetadata{ info_hash: info_hash, piece_index: piece_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:20:46 [INFO] [stderr] | [INFO] [stderr] 20 | BlockMetadata{ info_hash: info_hash, piece_index: piece_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | block_offset: block_offset, block_length: block_length } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:21:52 [INFO] [stderr] | [INFO] [stderr] 21 | block_offset: block_offset, block_length: block_length } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | Block{ metadata: metadata, block_data: block_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | Block{ metadata: metadata, block_data: block_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | BlockMut{ metadata: metadata, block_data: block_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:102:39 [INFO] [stderr] | [INFO] [stderr] 102 | BlockMut{ metadata: metadata, block_data: block_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:38:22 [INFO] [stderr] | [INFO] [stderr] 38 | DiskManager{ sink: sink, stream: stream } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `sink` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:38:34 [INFO] [stderr] | [INFO] [stderr] 38 | DiskManager{ sink: sink, stream: stream } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stream` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:92:26 [INFO] [stderr] | [INFO] [stderr] 92 | DiskManagerSink{ pool: pool, context: context, max_capacity: max_capacity, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `pool` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:92:38 [INFO] [stderr] | [INFO] [stderr] 92 | DiskManagerSink{ pool: pool, context: context, max_capacity: max_capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `context` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:92:56 [INFO] [stderr] | [INFO] [stderr] 92 | DiskManagerSink{ pool: pool, context: context, max_capacity: max_capacity, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:93:26 [INFO] [stderr] | [INFO] [stderr] 93 | cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:93:54 [INFO] [stderr] | [INFO] [stderr] 93 | cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `task_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:157:28 [INFO] [stderr] | [INFO] [stderr] 157 | DiskManagerStream{ recv: recv, cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `recv` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:157:40 [INFO] [stderr] | [INFO] [stderr] 157 | DiskManagerStream{ recv: recv, cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cur_capacity` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/manager.rs:157:68 [INFO] [stderr] | [INFO] [stderr] 157 | DiskManagerStream{ recv: recv, cur_capacity: cur_capacity, task_queue: task_queue } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `task_queue` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/fs/cache/file_handle.rs:23:70 [INFO] [stderr] | [INFO] [stderr] 23 | FileHandleCache{ cache: Mutex::new(LruCache::new(capacity)), inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/fs/native.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | NativeFile{ file: file } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/context.rs:26:24 [INFO] [stderr] | [INFO] [stderr] 26 | MetainfoState{ file: file, state: state } [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `file` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/context.rs:26:36 [INFO] [stderr] | [INFO] [stderr] 26 | MetainfoState{ file: file, state: state } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/context.rs:32:78 [INFO] [stderr] | [INFO] [stderr] 32 | DiskManagerContext{ torrents: Arc::new(RwLock::new(HashMap::new())), out: out, fs: Arc::new(fs) } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `out` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_accessor.rs:18:13 [INFO] [stderr] | [INFO] [stderr] 18 | fs: fs, [INFO] [stderr] | ^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_accessor.rs:19:13 [INFO] [stderr] | [INFO] [stderr] 19 | info_dict: info_dict [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | fs: fs, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `fs` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:43:13 [INFO] [stderr] | [INFO] [stderr] 43 | info_dict: info_dict, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_dict` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:44:13 [INFO] [stderr] | [INFO] [stderr] 44 | checker_state: checker_state [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `checker_state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:170:13 [INFO] [stderr] | [INFO] [stderr] 170 | total_blocks: total_blocks, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total_blocks` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:171:13 [INFO] [stderr] | [INFO] [stderr] 171 | last_block_size: last_block_size [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `last_block_size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/mod.rs:87:73 [INFO] [stderr] | [INFO] [stderr] 87 | Err(TorrentError::from_kind(TorrentErrorKind::InfoHashNotFound{ hash: hash })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/disk/tasks/mod.rs:109:73 [INFO] [stderr] | [INFO] [stderr] 109 | Err(TorrentError::from_kind(TorrentErrorKind::InfoHashNotFound{ hash: hash })) [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:20:24 [INFO] [stderr] | [INFO] [stderr] 20 | BlockMetadata{ info_hash: info_hash, piece_index: piece_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `info_hash` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:20:46 [INFO] [stderr] | [INFO] [stderr] 20 | BlockMetadata{ info_hash: info_hash, piece_index: piece_index, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `piece_index` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:21:24 [INFO] [stderr] | [INFO] [stderr] 21 | block_offset: block_offset, block_length: block_length } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:21:52 [INFO] [stderr] | [INFO] [stderr] 21 | block_offset: block_offset, block_length: block_length } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:63:16 [INFO] [stderr] | [INFO] [stderr] 63 | Block{ metadata: metadata, block_data: block_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | Block{ metadata: metadata, block_data: block_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:102:19 [INFO] [stderr] | [INFO] [stderr] 102 | BlockMut{ metadata: metadata, block_data: block_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `metadata` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/memory/block.rs:102:39 [INFO] [stderr] | [INFO] [stderr] 102 | BlockMut{ metadata: metadata, block_data: block_data } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `block_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk/manager.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | return Ok(AsyncSink::Ready) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(AsyncSink::Ready)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `disk::builder::DiskManagerBuilder` [INFO] [stderr] --> src/disk/builder.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> DiskManagerBuilder { [INFO] [stderr] 19 | | DiskManagerBuilder{ builder: Builder::new(), pending_size: DEFAULT_PENDING_SIZE, [INFO] [stderr] 20 | | completed_size: DEFAULT_COMPLETED_SIZE } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for disk::builder::DiskManagerBuilder { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/disk/manager.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | / loop { [INFO] [stderr] 182 | | match self.task_queue.try_pop() { [INFO] [stderr] 183 | | Some(task) => task.notify(), [INFO] [stderr] 184 | | None => { break; } [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(task) = self.task_queue.try_pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:62:53 [INFO] [stderr] | [INFO] [stderr] 62 | let expected_hash = InfoHash::from_hash(info_dict [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 63 | | .pieces() [INFO] [stderr] 64 | | .skip(message.piece_index() as usize) [INFO] [stderr] 65 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:177:54 [INFO] [stderr] | [INFO] [stderr] 177 | self.pending_blocks.entry(msg.piece_index()).or_insert(Vec::new()).push(msg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk/tasks/mod.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | Ok(try!(sync_result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk/tasks/mod.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(try!(access_result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk/tasks/mod.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | Ok(try!(block_result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/disk/manager.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | return Ok(AsyncSink::Ready) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(AsyncSink::Ready)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> examples/add_torrent.rs:40:5 [INFO] [stderr] | [INFO] [stderr] 40 | print!("\n"); [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> test/mod.rs:99:34 [INFO] [stderr] | [INFO] [stderr] 99 | MultiFileDirectAccessor{ dir: dir, files: files } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> test/mod.rs:99:44 [INFO] [stderr] | [INFO] [stderr] 99 | MultiFileDirectAccessor{ dir: dir, files: files } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `files` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `disk::builder::DiskManagerBuilder` [INFO] [stderr] --> src/disk/builder.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> DiskManagerBuilder { [INFO] [stderr] 19 | | DiskManagerBuilder{ builder: Builder::new(), pending_size: DEFAULT_PENDING_SIZE, [INFO] [stderr] 20 | | completed_size: DEFAULT_COMPLETED_SIZE } [INFO] [stderr] 21 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 16 | impl Default for disk::builder::DiskManagerBuilder { [INFO] [stderr] 17 | fn default() -> Self { [INFO] [stderr] 18 | Self::new() [INFO] [stderr] 19 | } [INFO] [stderr] 20 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/disk/manager.rs:181:17 [INFO] [stderr] | [INFO] [stderr] 181 | / loop { [INFO] [stderr] 182 | | match self.task_queue.try_pop() { [INFO] [stderr] 183 | | Some(task) => task.notify(), [INFO] [stderr] 184 | | None => { break; } [INFO] [stderr] 185 | | } [INFO] [stderr] 186 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(task) = self.task_queue.try_pop() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: called `skip(x).next()` on an iterator. This is more succinctly expressed by calling `nth(x)` [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:62:53 [INFO] [stderr] | [INFO] [stderr] 62 | let expected_hash = InfoHash::from_hash(info_dict [INFO] [stderr] | _____________________________________________________^ [INFO] [stderr] 63 | | .pieces() [INFO] [stderr] 64 | | .skip(message.piece_index() as usize) [INFO] [stderr] 65 | | .next() [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::iter_skip_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/disk/tasks/helpers/piece_checker.rs:177:54 [INFO] [stderr] | [INFO] [stderr] 177 | self.pending_blocks.entry(msg.piece_index()).or_insert(Vec::new()).push(msg); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(Vec::new)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk/tasks/mod.rs:107:12 [INFO] [stderr] | [INFO] [stderr] 107 | Ok(try!(sync_result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk/tasks/mod.rs:127:12 [INFO] [stderr] | [INFO] [stderr] 127 | Ok(try!(access_result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/disk/tasks/mod.rs:159:12 [INFO] [stderr] | [INFO] [stderr] 159 | Ok(try!(block_result)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `bip_disk`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> examples/add_torrent.rs:51:13 [INFO] [stderr] | [INFO] [stderr] 51 | unexpected @ _ => panic!("Unexpected ODiskMessage {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/add_torrent.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/complete_torrent.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> test/complete_torrent.rs:58:51 [INFO] [stderr] | [INFO] [stderr] 58 | ::send_block(&mut blocking_send, &files_bytes[(1024 + 0)..(1024 + 500)], metainfo_file.info().info_hash(), 1, 0, 500, |_| ()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2048` [INFO] [stderr] --> test/complete_torrent.rs:63:51 [INFO] [stderr] | [INFO] [stderr] 63 | ::send_block(&mut blocking_send, &files_bytes[(2048 + 0)..(2048 + 500)], metainfo_file.info().info_hash(), 2, 0, 500, |_| ()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/complete_torrent.rs:76:17 [INFO] [stderr] | [INFO] [stderr] 76 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/complete_torrent.rs:116:17 [INFO] [stderr] | [INFO] [stderr] 116 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> test/load_block.rs:30:47 [INFO] [stderr] | [INFO] [stderr] 30 | process_block.extend_from_slice(&data_b.0[1..(50 + 1)]); [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=50` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::range_plus_one)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/load_block.rs:55:17 [INFO] [stderr] | [INFO] [stderr] 55 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> test/process_block.rs:30:47 [INFO] [stderr] | [INFO] [stderr] 30 | process_bytes.extend_from_slice(&data_b.0[1..(50 + 1)]); [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/process_block.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> test/process_block.rs:60:32 [INFO] [stderr] | [INFO] [stderr] 60 | (&mut expected_file_b_data[1..(1 + 50)]).copy_from_slice(&data_b.0[1..(50 + 1)]); [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: an inclusive range would be more readable [INFO] [stderr] --> test/process_block.rs:60:72 [INFO] [stderr] | [INFO] [stderr] 60 | (&mut expected_file_b_data[1..(1 + 50)]).copy_from_slice(&data_b.0[1..(50 + 1)]); [INFO] [stderr] | ^^^^^^^^^^^ help: use: `1..=50` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/remove_torrent.rs:47:17 [INFO] [stderr] | [INFO] [stderr] 47 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/resume_torrent.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/resume_torrent.rs:68:17 [INFO] [stderr] | [INFO] [stderr] 68 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/resume_torrent.rs:95:13 [INFO] [stderr] | [INFO] [stderr] 95 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/resume_torrent.rs:106:13 [INFO] [stderr] | [INFO] [stderr] 106 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> test/resume_torrent.rs:113:51 [INFO] [stderr] | [INFO] [stderr] 113 | ::send_block(&mut blocking_send, &files_bytes[(1024 + 0)..(1024 + 500)], metainfo_file.info().info_hash(), 1, 0, 500, |_| ()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `2048` [INFO] [stderr] --> test/resume_torrent.rs:118:51 [INFO] [stderr] | [INFO] [stderr] 118 | ::send_block(&mut blocking_send, &files_bytes[(2048 + 0)..(2048 + 500)], metainfo_file.info().info_hash(), 2, 0, 500, |_| ()); [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the `unexpected @ _` pattern can be written as just `unexpected` [INFO] [stderr] --> test/resume_torrent.rs:131:17 [INFO] [stderr] | [INFO] [stderr] 131 | unexpected @ _ => panic!("Unexpected Message: {:?}", unexpected) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `buffer`. [INFO] [stderr] --> test/mod.rs:39:14 [INFO] [stderr] | [INFO] [stderr] 39 | for i in 0..size { [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 39 | for in buffer.iter_mut().take(size) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> test/mod.rs:188:18 [INFO] [stderr] | [INFO] [stderr] 188 | .ok_or(io::Error::new(io::ErrorKind::NotFound, "File Not Found")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "File Not Found"))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> test/mod.rs:204:18 [INFO] [stderr] | [INFO] [stderr] 204 | .ok_or(io::Error::new(io::ErrorKind::NotFound, "File Not Found")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "File Not Found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> test/mod.rs:228:18 [INFO] [stderr] | [INFO] [stderr] 228 | .ok_or(io::Error::new(io::ErrorKind::NotFound, "File Not Found")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| io::Error::new(io::ErrorKind::NotFound, "File Not Found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2327841624c4112659ddaf550db77b8632ddb8a93afe518a0f825b9c5016ac6b"` [INFO] running `"docker" "rm" "-f" "2327841624c4112659ddaf550db77b8632ddb8a93afe518a0f825b9c5016ac6b"` [INFO] [stdout] 2327841624c4112659ddaf550db77b8632ddb8a93afe518a0f825b9c5016ac6b