[INFO] crate bip_bencode 0.4.4 is already in cache [INFO] extracting crate bip_bencode 0.4.4 into work/ex/clippy-test-run/sources/stable/reg/bip_bencode/0.4.4 [INFO] extracting crate bip_bencode 0.4.4 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bip_bencode/0.4.4 [INFO] validating manifest of bip_bencode-0.4.4 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bip_bencode-0.4.4 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bip_bencode-0.4.4 [INFO] removed 0 missing tests [INFO] finished frobbing bip_bencode-0.4.4 [INFO] frobbed toml for bip_bencode-0.4.4 written to work/ex/clippy-test-run/sources/stable/reg/bip_bencode/0.4.4/Cargo.toml [INFO] started frobbing bip_bencode-0.4.4 [INFO] removed 0 missing tests [INFO] finished frobbing bip_bencode-0.4.4 [INFO] frobbed toml for bip_bencode-0.4.4 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bip_bencode/0.4.4/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bip_bencode-0.4.4 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bip_bencode/0.4.4:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eaa4aadef8cd0b38f69c37e47fab77337250f9e43191bcd5e0dea735a61cf38a [INFO] running `"docker" "start" "-a" "eaa4aadef8cd0b38f69c37e47fab77337250f9e43191bcd5e0dea735a61cf38a"` [INFO] [stderr] warning: `panic` setting is ignored for `bench` profile [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking bip_bencode v0.4.4 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mutable/bencode_mut.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | BencodeMut{ inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode_opt.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | BDecodeOpt{ max_recursion: max_recursion, check_key_sort: check_key_sort, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_recursion` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode_opt.rs:18:51 [INFO] [stderr] | [INFO] [stderr] 18 | BDecodeOpt{ max_recursion: max_recursion, check_key_sort: check_key_sort, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `check_key_sort` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode_opt.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | enforce_full_decode: enforce_full_decode } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enforce_full_decode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:11:98 [INFO] [stderr] | [INFO] [stderr] 11 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidRecursionExceeded{ pos: pos, max: depth })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:33:83 [INFO] [stderr] | [INFO] [stderr] 33 | _ => Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidByte{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:42:112 [INFO] [stderr] | [INFO] [stderr] 42 | None => return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntNoDelimiter{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:49:100 [INFO] [stderr] | [INFO] [stderr] 49 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntNegativeZero{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:54:99 [INFO] [stderr] | [INFO] [stderr] 54 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntZeroPadding{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:60:104 [INFO] [stderr] | [INFO] [stderr] 60 | Err(_) => return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntParseError{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:68:97 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntParseError{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:76:95 [INFO] [stderr] | [INFO] [stderr] 76 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidLengthNegative{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:85:95 [INFO] [stderr] | [INFO] [stderr] 85 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidLengthOverflow{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:148:88 [INFO] [stderr] | [INFO] [stderr] 148 | .ok_or_else(|| BencodeParseError::from_kind(BencodeParseErrorKind::BytesEmpty{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/mutable/bencode_mut.rs:31:21 [INFO] [stderr] | [INFO] [stderr] 31 | BencodeMut{ inner: inner } [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode_opt.rs:18:21 [INFO] [stderr] | [INFO] [stderr] 18 | BDecodeOpt{ max_recursion: max_recursion, check_key_sort: check_key_sort, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_recursion` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode_opt.rs:18:51 [INFO] [stderr] | [INFO] [stderr] 18 | BDecodeOpt{ max_recursion: max_recursion, check_key_sort: check_key_sort, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `check_key_sort` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode_opt.rs:19:21 [INFO] [stderr] | [INFO] [stderr] 19 | enforce_full_decode: enforce_full_decode } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `enforce_full_decode` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:11:98 [INFO] [stderr] | [INFO] [stderr] 11 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidRecursionExceeded{ pos: pos, max: depth })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:33:83 [INFO] [stderr] | [INFO] [stderr] 33 | _ => Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidByte{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:42:112 [INFO] [stderr] | [INFO] [stderr] 42 | None => return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntNoDelimiter{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:49:100 [INFO] [stderr] | [INFO] [stderr] 49 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntNegativeZero{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:54:99 [INFO] [stderr] | [INFO] [stderr] 54 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntZeroPadding{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:60:104 [INFO] [stderr] | [INFO] [stderr] 60 | Err(_) => return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntParseError{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:68:97 [INFO] [stderr] | [INFO] [stderr] 68 | Err(_) => Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidIntParseError{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:76:95 [INFO] [stderr] | [INFO] [stderr] 76 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidLengthNegative{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:85:95 [INFO] [stderr] | [INFO] [stderr] 85 | return Err(BencodeParseError::from_kind(BencodeParseErrorKind::InvalidLengthOverflow{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/reference/decode.rs:148:88 [INFO] [stderr] | [INFO] [stderr] 148 | .ok_or_else(|| BencodeParseError::from_kind(BencodeParseErrorKind::BytesEmpty{ pos: pos })) [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:160:21 [INFO] [stderr] | [INFO] [stderr] 160 | const GENERAL: &'static [u8] = b"d0:12:zero_len_key8:location17:udp://test.com:8011:nested dictd4:listli-500500eee6:numberi500500ee"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:161:23 [INFO] [stderr] | [INFO] [stderr] 161 | const RECURSION: &'static [u8] = b"lllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllllleeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:162:24 [INFO] [stderr] | [INFO] [stderr] 162 | const BYTES_UTF8: &'static [u8] = b"16:valid_utf8_bytes"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:163:24 [INFO] [stderr] | [INFO] [stderr] 163 | const DICTIONARY: &'static [u8] = b"d9:test_dictd10:nested_key12:nested_value11:nested_listli500ei-500ei0eee8:test_key10:test_valuee"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:164:18 [INFO] [stderr] | [INFO] [stderr] 164 | const LIST: &'static [u8] = [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:166:19 [INFO] [stderr] | [INFO] [stderr] 166 | const BYTES: &'static [u8] = b"5:\xC5\xE6\xBE\xE6\xF2"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:167:28 [INFO] [stderr] | [INFO] [stderr] 167 | const BYTES_ZERO_LEN: &'static [u8] = b"0:"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:168:17 [INFO] [stderr] | [INFO] [stderr] 168 | const INT: &'static [u8] = b"i500e"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:169:26 [INFO] [stderr] | [INFO] [stderr] 169 | const INT_NEGATIVE: &'static [u8] = b"i-500e"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:170:22 [INFO] [stderr] | [INFO] [stderr] 170 | const INT_ZERO: &'static [u8] = b"i0e"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:171:21 [INFO] [stderr] | [INFO] [stderr] 171 | const PARTIAL: &'static [u8] = b"i0e_asd"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:174:27 [INFO] [stderr] | [INFO] [stderr] 174 | const BYTES_NEG_LEN: &'static [u8] = b"-4:test"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:175:25 [INFO] [stderr] | [INFO] [stderr] 175 | const BYTES_EXTRA: &'static [u8] = b"l15:processed_bytese17:unprocessed_bytes"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:176:28 [INFO] [stderr] | [INFO] [stderr] 176 | const BYTES_NOT_UTF8: &'static [u8] = b"5:\xC5\xE6\xBE\xE6\xF2"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:177:21 [INFO] [stderr] | [INFO] [stderr] 177 | const INT_NAN: &'static [u8] = b"i500a500e"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:178:30 [INFO] [stderr] | [INFO] [stderr] 178 | const INT_LEADING_ZERO: &'static [u8] = b"i0500e"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:179:29 [INFO] [stderr] | [INFO] [stderr] 179 | const INT_DOUBLE_ZERO: &'static [u8] = b"i00e"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:180:31 [INFO] [stderr] | [INFO] [stderr] 180 | const INT_NEGATIVE_ZERO: &'static [u8] = b"i-0e"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:181:33 [INFO] [stderr] | [INFO] [stderr] 181 | const INT_DOUBLE_NEGATIVE: &'static [u8] = b"i--5e"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:182:33 [INFO] [stderr] | [INFO] [stderr] 182 | const DICT_UNORDERED_KEYS: &'static [u8] = b"d5:z_key5:value5:a_key5:valuee"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:183:37 [INFO] [stderr] | [INFO] [stderr] 183 | const DICT_DUP_KEYS_SAME_DATA: &'static [u8] = b"d5:a_keyi0e5:a_keyi0ee"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/reference/decode.rs:184:37 [INFO] [stderr] | [INFO] [stderr] 184 | const DICT_DUP_KEYS_DIFF_DATA: &'static [u8] = b"d5:a_keyi0e5:a_key7:a_valuee"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reference/decode.rs:196:20 [INFO] [stderr] | [INFO] [stderr] 196 | 500500i64); [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_500i64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/reference/decode.rs:200:52 [INFO] [stderr] | [INFO] [stderr] 200 | assert_eq!(nested_list[0].int().unwrap(), -500500i64); [INFO] [stderr] | ^^^^^^^^^ help: consider: `500_500i64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/access/bencode.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | fn kind<'a>(&'a self) -> BencodeRefKind<'a, Self::BKey, Self::BType>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/access/bencode.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / fn kind<'b>(&'b self) -> BencodeRefKind<'b, Self::BKey, Self::BType> { [INFO] [stderr] 59 | | (*self).kind() [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/access/bencode.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | fn kind_mut<'a>(&'a mut self) -> BencodeMutKind<'a, Self::BKey, Self::BType>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | bencode.bytes_ext().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | _____________________________^ [INFO] [stderr] 14 | | key: error_key.as_ref().to_owned(), expected_type: "Bytes".to_owned() [INFO] [stderr] 15 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | bencode.bytes_ext().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 14 | key: error_key.as_ref().to_owned(), expected_type: "Bytes".to_owned() [INFO] [stderr] 15 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | bencode.str_ext().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | ___________________________^ [INFO] [stderr] 23 | | key: error_key.as_ref().to_owned(), expected_type: "UTF-8 Bytes".to_owned() [INFO] [stderr] 24 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | bencode.str_ext().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 23 | key: error_key.as_ref().to_owned(), expected_type: "UTF-8 Bytes".to_owned() [INFO] [stderr] 24 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | bencode.int().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | _______________________^ [INFO] [stderr] 56 | | key: error_key.as_ref().to_owned(), expected_type: "Integer".to_owned() [INFO] [stderr] 57 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | bencode.int().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 56 | key: error_key.as_ref().to_owned(), expected_type: "Integer".to_owned() [INFO] [stderr] 57 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | bencode.bytes().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 67 | | key: error_key.as_ref().to_owned(), expected_type: "Bytes".to_owned() [INFO] [stderr] 68 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | bencode.bytes().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 67 | key: error_key.as_ref().to_owned(), expected_type: "Bytes".to_owned() [INFO] [stderr] 68 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | bencode.str().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | _______________________^ [INFO] [stderr] 78 | | key: error_key.as_ref().to_owned(), expected_type: "UTF-8 Bytes".to_owned() [INFO] [stderr] 79 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | bencode.str().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 78 | key: error_key.as_ref().to_owned(), expected_type: "UTF-8 Bytes".to_owned() [INFO] [stderr] 79 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | bencode.list().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | ________________________^ [INFO] [stderr] 89 | | key: error_key.as_ref().to_owned(), expected_type: "List".to_owned() [INFO] [stderr] 90 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | bencode.list().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 89 | key: error_key.as_ref().to_owned(), expected_type: "List".to_owned() [INFO] [stderr] 90 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | bencode.dict().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | ________________________^ [INFO] [stderr] 100 | | key: error_key.as_ref().to_owned(), expected_type: "Dictionary".to_owned() [INFO] [stderr] 101 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | bencode.dict().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 100 | key: error_key.as_ref().to_owned(), expected_type: "Dictionary".to_owned() [INFO] [stderr] 101 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait `BListAccess` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/access/list.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub trait BListAccess { [INFO] [stderr] 5 | | /// Get a list element at the given index. [INFO] [stderr] 6 | | fn get(&self, index: usize) -> Option<&V>; [INFO] [stderr] 7 | | [INFO] [stderr] ... | [INFO] [stderr] 21 | | fn len(&self) -> usize; [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mutable/bencode_mut.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | BencodeMut::new(InnerBencodeMut::Bytes(value.into())) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mutable/encode.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | bytes.extend(list.iter().map(|n| *n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `list.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/mutable/encode.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | fn encode_dict<'a, K, V>(dict: &BDictAccess, bytes: &mut Vec) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/reference/decode.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / fn decode_int<'a>(bytes: &'a [u8], pos: usize, delim: u8) -> BencodeParseResult<(i64, usize)> { [INFO] [stderr] 38 | | let (_, begin_decode) = bytes.split_at(pos); [INFO] [stderr] 39 | | [INFO] [stderr] 40 | | let relative_end_pos = match begin_decode.iter().position(|n| *n == delim) { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reference/decode.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / bytes.get(pos) [INFO] [stderr] 147 | | .map(|n| *n) [INFO] [stderr] | |____________________^ help: Consider calling the dedicated `cloned` method: `bytes.get(pos).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/access/bencode.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | fn kind<'a>(&'a self) -> BencodeRefKind<'a, Self::BKey, Self::BType>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/access/bencode.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | / fn kind<'b>(&'b self) -> BencodeRefKind<'b, Self::BKey, Self::BType> { [INFO] [stderr] 59 | | (*self).kind() [INFO] [stderr] 60 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/access/bencode.rs:109:5 [INFO] [stderr] | [INFO] [stderr] 109 | fn kind_mut<'a>(&'a mut self) -> BencodeMutKind<'a, Self::BKey, Self::BType>; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:13:29 [INFO] [stderr] | [INFO] [stderr] 13 | bencode.bytes_ext().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | _____________________________^ [INFO] [stderr] 14 | | key: error_key.as_ref().to_owned(), expected_type: "Bytes".to_owned() [INFO] [stderr] 15 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 13 | bencode.bytes_ext().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 14 | key: error_key.as_ref().to_owned(), expected_type: "Bytes".to_owned() [INFO] [stderr] 15 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:22:27 [INFO] [stderr] | [INFO] [stderr] 22 | bencode.str_ext().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | ___________________________^ [INFO] [stderr] 23 | | key: error_key.as_ref().to_owned(), expected_type: "UTF-8 Bytes".to_owned() [INFO] [stderr] 24 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 22 | bencode.str_ext().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 23 | key: error_key.as_ref().to_owned(), expected_type: "UTF-8 Bytes".to_owned() [INFO] [stderr] 24 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:55:23 [INFO] [stderr] | [INFO] [stderr] 55 | bencode.int().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | _______________________^ [INFO] [stderr] 56 | | key: error_key.as_ref().to_owned(), expected_type: "Integer".to_owned() [INFO] [stderr] 57 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 55 | bencode.int().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 56 | key: error_key.as_ref().to_owned(), expected_type: "Integer".to_owned() [INFO] [stderr] 57 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:66:25 [INFO] [stderr] | [INFO] [stderr] 66 | bencode.bytes().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | _________________________^ [INFO] [stderr] 67 | | key: error_key.as_ref().to_owned(), expected_type: "Bytes".to_owned() [INFO] [stderr] 68 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 66 | bencode.bytes().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 67 | key: error_key.as_ref().to_owned(), expected_type: "Bytes".to_owned() [INFO] [stderr] 68 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:77:23 [INFO] [stderr] | [INFO] [stderr] 77 | bencode.str().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | _______________________^ [INFO] [stderr] 78 | | key: error_key.as_ref().to_owned(), expected_type: "UTF-8 Bytes".to_owned() [INFO] [stderr] 79 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 77 | bencode.str().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 78 | key: error_key.as_ref().to_owned(), expected_type: "UTF-8 Bytes".to_owned() [INFO] [stderr] 79 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:88:24 [INFO] [stderr] | [INFO] [stderr] 88 | bencode.list().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | ________________________^ [INFO] [stderr] 89 | | key: error_key.as_ref().to_owned(), expected_type: "List".to_owned() [INFO] [stderr] 90 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 88 | bencode.list().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 89 | key: error_key.as_ref().to_owned(), expected_type: "List".to_owned() [INFO] [stderr] 90 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/access/convert.rs:99:24 [INFO] [stderr] | [INFO] [stderr] 99 | bencode.dict().ok_or(self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] | ________________________^ [INFO] [stderr] 100 | | key: error_key.as_ref().to_owned(), expected_type: "Dictionary".to_owned() [INFO] [stderr] 101 | | }))) [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 99 | bencode.dict().ok_or_else(|| self.handle_error(BencodeConvertError::from_kind(BencodeConvertErrorKind::WrongType{ [INFO] [stderr] 100 | key: error_key.as_ref().to_owned(), expected_type: "Dictionary".to_owned() [INFO] [stderr] 101 | }))) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: trait `BListAccess` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stderr] --> src/access/list.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | / pub trait BListAccess { [INFO] [stderr] 5 | | /// Get a list element at the given index. [INFO] [stderr] 6 | | fn get(&self, index: usize) -> Option<&V>; [INFO] [stderr] 7 | | [INFO] [stderr] ... | [INFO] [stderr] 21 | | fn len(&self) -> usize; [INFO] [stderr] 22 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/mutable/bencode_mut.rs:41:48 [INFO] [stderr] | [INFO] [stderr] 41 | BencodeMut::new(InnerBencodeMut::Bytes(value.into())) [INFO] [stderr] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/mutable/encode.rs:30:18 [INFO] [stderr] | [INFO] [stderr] 30 | bytes.extend(list.iter().map(|n| *n)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: Consider calling the dedicated `cloned` method: `list.iter().cloned()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/mutable/encode.rs:44:16 [INFO] [stderr] | [INFO] [stderr] 44 | fn encode_dict<'a, K, V>(dict: &BDictAccess, bytes: &mut Vec) [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/reference/decode.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | / fn decode_int<'a>(bytes: &'a [u8], pos: usize, delim: u8) -> BencodeParseResult<(i64, usize)> { [INFO] [stderr] 38 | | let (_, begin_decode) = bytes.split_at(pos); [INFO] [stderr] 39 | | [INFO] [stderr] 40 | | let relative_end_pos = match begin_decode.iter().position(|n| *n == delim) { [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/reference/decode.rs:146:5 [INFO] [stderr] | [INFO] [stderr] 146 | / bytes.get(pos) [INFO] [stderr] 147 | | .map(|n| *n) [INFO] [stderr] | |____________________^ help: Consider calling the dedicated `cloned` method: `bytes.get(pos).cloned()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:191:36 [INFO] [stderr] | [INFO] [stderr] 191 | assert_eq!(ben_dict.lookup("".as_bytes()).unwrap().str().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:193:36 [INFO] [stderr] | [INFO] [stderr] 193 | assert_eq!(ben_dict.lookup("location".as_bytes()).unwrap().str().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"location"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:195:36 [INFO] [stderr] | [INFO] [stderr] 195 | assert_eq!(ben_dict.lookup("number".as_bytes()).unwrap().int().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"number"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:198:43 [INFO] [stderr] | [INFO] [stderr] 198 | let nested_dict = ben_dict.lookup("nested dict".as_bytes()).unwrap().dict().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"nested dict"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:199:46 [INFO] [stderr] | [INFO] [stderr] 199 | let nested_list = nested_dict.lookup("list".as_bytes()).unwrap().list().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"list"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:221:32 [INFO] [stderr] | [INFO] [stderr] 221 | assert_eq!(dict.lookup("test_key".as_bytes()).unwrap().str().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test_key"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:224:39 [INFO] [stderr] | [INFO] [stderr] 224 | let nested_dict = dict.lookup("test_dict".as_bytes()).unwrap().dict().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test_dict"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:225:39 [INFO] [stderr] | [INFO] [stderr] 225 | assert_eq!(nested_dict.lookup("nested_key".as_bytes()).unwrap().str().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"nested_key"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:228:46 [INFO] [stderr] | [INFO] [stderr] 228 | let nested_list = nested_dict.lookup("nested_list".as_bytes()).unwrap().list().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"nested_list"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/reference/decode.rs:248:39 [INFO] [stderr] | [INFO] [stderr] 248 | assert_eq!(nested_dict.lookup("test_key".as_bytes()).unwrap().str().unwrap(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"test_key"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/reference/decode.rs:323:9 [INFO] [stderr] | [INFO] [stderr] 323 | super::decode_int(INT_NAN, 1, ::BEN_END).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super::decode_int(INT_NAN, 1, ::BEN_END).unwrap();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/reference/decode.rs:329:9 [INFO] [stderr] | [INFO] [stderr] 329 | super::decode_int(INT_LEADING_ZERO, 1, ::BEN_END).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super::decode_int(INT_LEADING_ZERO, 1, ::BEN_END).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/reference/decode.rs:335:9 [INFO] [stderr] | [INFO] [stderr] 335 | super::decode_int(INT_DOUBLE_ZERO, 1, ::BEN_END).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super::decode_int(INT_DOUBLE_ZERO, 1, ::BEN_END).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/reference/decode.rs:341:9 [INFO] [stderr] | [INFO] [stderr] 341 | super::decode_int(INT_NEGATIVE_ZERO, 1, ::BEN_END).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super::decode_int(INT_NEGATIVE_ZERO, 1, ::BEN_END).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/reference/decode.rs:347:9 [INFO] [stderr] | [INFO] [stderr] 347 | super::decode_int(INT_DOUBLE_NEGATIVE, 1, ::BEN_END).unwrap().0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `super::decode_int(INT_DOUBLE_NEGATIVE, 1, ::BEN_END).unwrap();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] error[E0554]: #![feature] may not be used on the stable release channel [INFO] [stderr] --> benches/mod.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #![feature(test)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] For more information about this error, try `rustc --explain E0554`. [INFO] [stderr] error: Could not compile `bip_bencode`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> test/mod.rs:10:16 [INFO] [stderr] | [INFO] [stderr] 10 | assert_eq!("d3:key5:valuee".as_bytes(), &result[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"d3:key5:valuee"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> test/mod.rs:19:16 [INFO] [stderr] | [INFO] [stderr] 19 | assert_eq!("li5ee".as_bytes(), &result[..]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"li5ee"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "eaa4aadef8cd0b38f69c37e47fab77337250f9e43191bcd5e0dea735a61cf38a"` [INFO] running `"docker" "rm" "-f" "eaa4aadef8cd0b38f69c37e47fab77337250f9e43191bcd5e0dea735a61cf38a"` [INFO] [stdout] eaa4aadef8cd0b38f69c37e47fab77337250f9e43191bcd5e0dea735a61cf38a