[INFO] crate biorustlings 0.0.2 is already in cache [INFO] extracting crate biorustlings 0.0.2 into work/ex/clippy-test-run/sources/stable/reg/biorustlings/0.0.2 [INFO] extracting crate biorustlings 0.0.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/biorustlings/0.0.2 [INFO] validating manifest of biorustlings-0.0.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of biorustlings-0.0.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing biorustlings-0.0.2 [INFO] finished frobbing biorustlings-0.0.2 [INFO] frobbed toml for biorustlings-0.0.2 written to work/ex/clippy-test-run/sources/stable/reg/biorustlings/0.0.2/Cargo.toml [INFO] started frobbing biorustlings-0.0.2 [INFO] finished frobbing biorustlings-0.0.2 [INFO] frobbed toml for biorustlings-0.0.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/biorustlings/0.0.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting biorustlings-0.0.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/biorustlings/0.0.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1041ec5b4868b24850b9b2b2391315fdb3ae2ed738fb7867319b98eb3c573d54 [INFO] running `"docker" "start" "-a" "1041ec5b4868b24850b9b2b2391315fdb3ae2ed738fb7867319b98eb3c573d54"` [INFO] [stderr] Checking biorustlings v0.0.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | uniparc_id: uniparc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:290:9 [INFO] [stderr] | [INFO] [stderr] 290 | uniparc_id: uniparc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | uniparc_xref_idx: uniparc_xref_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_xref_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | property_idx: property_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `property_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | "ncbi_gi", [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | "ncbi_taxonomy_id", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | "protein_name", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | "gene_name", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | "chain", [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | "uniprot_kb_accession", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | "proteome_id", [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:434:13 [INFO] [stderr] | [INFO] [stderr] 434 | "component", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | "ncbi_gi", [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | "ncbi_taxonomy_id", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | "protein_name", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:480:13 [INFO] [stderr] | [INFO] [stderr] 480 | "gene_name", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | "chain", [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | "uniprot_kb_accession", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | "proteome_id", [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | "component", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:188:9 [INFO] [stderr] | [INFO] [stderr] 188 | uniparc_id: uniparc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_id` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:290:9 [INFO] [stderr] | [INFO] [stderr] 290 | uniparc_id: uniparc_id, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_id` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:291:9 [INFO] [stderr] | [INFO] [stderr] 291 | uniparc_xref_idx: uniparc_xref_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `uniparc_xref_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:292:9 [INFO] [stderr] | [INFO] [stderr] 292 | property_idx: property_idx, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `property_idx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:364:13 [INFO] [stderr] | [INFO] [stderr] 364 | "ncbi_gi", [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:374:13 [INFO] [stderr] | [INFO] [stderr] 374 | "ncbi_taxonomy_id", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:384:13 [INFO] [stderr] | [INFO] [stderr] 384 | "protein_name", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:394:13 [INFO] [stderr] | [INFO] [stderr] 394 | "gene_name", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:404:13 [INFO] [stderr] | [INFO] [stderr] 404 | "chain", [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:414:13 [INFO] [stderr] | [INFO] [stderr] 414 | "uniprot_kb_accession", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:424:13 [INFO] [stderr] | [INFO] [stderr] 424 | "proteome_id", [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:434:13 [INFO] [stderr] | [INFO] [stderr] 434 | "component", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:450:13 [INFO] [stderr] | [INFO] [stderr] 450 | "ncbi_gi", [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:460:13 [INFO] [stderr] | [INFO] [stderr] 460 | "ncbi_taxonomy_id", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:470:13 [INFO] [stderr] | [INFO] [stderr] 470 | "protein_name", [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:480:13 [INFO] [stderr] | [INFO] [stderr] 480 | "gene_name", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:490:13 [INFO] [stderr] | [INFO] [stderr] 490 | "chain", [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:500:13 [INFO] [stderr] | [INFO] [stderr] 500 | "uniprot_kb_accession", [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:510:13 [INFO] [stderr] | [INFO] [stderr] 510 | "proteome_id", [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:520:13 [INFO] [stderr] | [INFO] [stderr] 520 | "component", [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | uniparc_xrefs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[UniparcXRef]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | / if !property.contains_key(&attr_value) { [INFO] [stderr] 283 | | property_idx = (property.len() + 1) as i64; [INFO] [stderr] 284 | | property.insert(attr_value, property_idx); [INFO] [stderr] 285 | | } else { [INFO] [stderr] 286 | | property_idx = *property.get(&attr_value).unwrap(); [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____^ help: consider using: `property.entry(attr_value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:316:20 [INFO] [stderr] | [INFO] [stderr] 316 | uniparc_xrefs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[UniparcXRef]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:584:17 [INFO] [stderr] | [INFO] [stderr] 584 | / match name.local_name.as_ref() { [INFO] [stderr] 585 | | "entry" => { [INFO] [stderr] 586 | | println!( [INFO] [stderr] 587 | | "Saving entry with id: '{}' and sequence: '{}'", [INFO] [stderr] ... | [INFO] [stderr] 595 | | _ => {} [INFO] [stderr] 596 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 584 | if let "entry" = name.local_name.as_ref() { [INFO] [stderr] 585 | println!( [INFO] [stderr] 586 | "Saving entry with id: '{}' and sequence: '{}'", [INFO] [stderr] 587 | uniparc.id, [INFO] [stderr] 588 | uniparc.sequence [INFO] [stderr] 589 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:235:20 [INFO] [stderr] | [INFO] [stderr] 235 | uniparc_xrefs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[UniparcXRef]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: usage of `contains_key` followed by `insert` on a `HashMap` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:282:5 [INFO] [stderr] | [INFO] [stderr] 282 | / if !property.contains_key(&attr_value) { [INFO] [stderr] 283 | | property_idx = (property.len() + 1) as i64; [INFO] [stderr] 284 | | property.insert(attr_value, property_idx); [INFO] [stderr] 285 | | } else { [INFO] [stderr] 286 | | property_idx = *property.get(&attr_value).unwrap(); [INFO] [stderr] 287 | | } [INFO] [stderr] | |_____^ help: consider using: `property.entry(attr_value)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_entry)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_entry [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:316:20 [INFO] [stderr] | [INFO] [stderr] 316 | uniparc_xrefs: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[UniparcXRef]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/bin/uniparc_xml_parser.rs:584:17 [INFO] [stderr] | [INFO] [stderr] 584 | / match name.local_name.as_ref() { [INFO] [stderr] 585 | | "entry" => { [INFO] [stderr] 586 | | println!( [INFO] [stderr] 587 | | "Saving entry with id: '{}' and sequence: '{}'", [INFO] [stderr] ... | [INFO] [stderr] 595 | | _ => {} [INFO] [stderr] 596 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 584 | if let "entry" = name.local_name.as_ref() { [INFO] [stderr] 585 | println!( [INFO] [stderr] 586 | "Saving entry with id: '{}' and sequence: '{}'", [INFO] [stderr] 587 | uniparc.id, [INFO] [stderr] 588 | uniparc.sequence [INFO] [stderr] 589 | ); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.46s [INFO] running `"docker" "inspect" "1041ec5b4868b24850b9b2b2391315fdb3ae2ed738fb7867319b98eb3c573d54"` [INFO] running `"docker" "rm" "-f" "1041ec5b4868b24850b9b2b2391315fdb3ae2ed738fb7867319b98eb3c573d54"` [INFO] [stdout] 1041ec5b4868b24850b9b2b2391315fdb3ae2ed738fb7867319b98eb3c573d54