[INFO] crate bio-types 0.4.0 is already in cache [INFO] extracting crate bio-types 0.4.0 into work/ex/clippy-test-run/sources/stable/reg/bio-types/0.4.0 [INFO] extracting crate bio-types 0.4.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bio-types/0.4.0 [INFO] validating manifest of bio-types-0.4.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bio-types-0.4.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bio-types-0.4.0 [INFO] finished frobbing bio-types-0.4.0 [INFO] frobbed toml for bio-types-0.4.0 written to work/ex/clippy-test-run/sources/stable/reg/bio-types/0.4.0/Cargo.toml [INFO] started frobbing bio-types-0.4.0 [INFO] finished frobbing bio-types-0.4.0 [INFO] frobbed toml for bio-types-0.4.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bio-types/0.4.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bio-types-0.4.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bio-types/0.4.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 8878e4a12642cf8d435fd82b3c9ded435d64cee8ebc93ac0988a80faae0b6f06 [INFO] running `"docker" "start" "-a" "8878e4a12642cf8d435fd82b3c9ded435d64cee8ebc93ac0988a80faae0b6f06"` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] Checking bio-types v0.4.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | refid: refid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `refid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/pos.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | refid: refid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `refid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/pos.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/pos.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/pos.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | intron_length: intron_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intron_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | exon_length: exon_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exon_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | refid: refid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `refid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | exon_0_length: exon_0_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exon_0_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | refid: refid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `refid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | exon_0_length: exon_0_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exon_0_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | inexes: inexes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inexes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/annot/spliced.rs:800:9 [INFO] [stderr] | [INFO] [stderr] 800 | / print!( [INFO] [stderr] 801 | | "{}\t{}\t{:?}\t{:?}\t{:?}\n", [INFO] [stderr] 802 | | outstr, p0, p0_into_expected, p0_into_actual, p0_back_out_actual [INFO] [stderr] 803 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | refid: refid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `refid` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:67:13 [INFO] [stderr] | [INFO] [stderr] 67 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:109:17 [INFO] [stderr] | [INFO] [stderr] 109 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:121:17 [INFO] [stderr] | [INFO] [stderr] 121 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:122:17 [INFO] [stderr] | [INFO] [stderr] 122 | length: length, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/contig.rs:134:13 [INFO] [stderr] | [INFO] [stderr] 134 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/pos.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | refid: refid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `refid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/pos.rs:65:13 [INFO] [stderr] | [INFO] [stderr] 65 | pos: pos, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/pos.rs:66:13 [INFO] [stderr] | [INFO] [stderr] 66 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/pos.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:54:21 [INFO] [stderr] | [INFO] [stderr] 54 | intron_length: intron_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intron_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:55:21 [INFO] [stderr] | [INFO] [stderr] 55 | exon_length: exon_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exon_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | refid: refid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `refid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:248:13 [INFO] [stderr] | [INFO] [stderr] 248 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:249:13 [INFO] [stderr] | [INFO] [stderr] 249 | exon_0_length: exon_0_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exon_0_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:251:13 [INFO] [stderr] | [INFO] [stderr] 251 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:290:13 [INFO] [stderr] | [INFO] [stderr] 290 | refid: refid, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `refid` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:291:13 [INFO] [stderr] | [INFO] [stderr] 291 | start: start, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `start` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:292:13 [INFO] [stderr] | [INFO] [stderr] 292 | exon_0_length: exon_0_length, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `exon_0_length` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:293:13 [INFO] [stderr] | [INFO] [stderr] 293 | inexes: inexes, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `inexes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:294:13 [INFO] [stderr] | [INFO] [stderr] 294 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/annot/spliced.rs:358:13 [INFO] [stderr] | [INFO] [stderr] 358 | strand: strand, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `strand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `print!()` with a format string that ends in a single newline, consider using `println!()` instead [INFO] [stderr] --> src/annot/spliced.rs:800:9 [INFO] [stderr] | [INFO] [stderr] 800 | / print!( [INFO] [stderr] 801 | | "{}\t{}\t{:?}\t{:?}\t{:?}\n", [INFO] [stderr] 802 | | outstr, p0, p0_into_expected, p0_into_actual, p0_back_out_actual [INFO] [stderr] 803 | | ); [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::print_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_with_newline [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/contig.rs:422:56 [INFO] [stderr] | [INFO] [stderr] 422 | let tma22_first = Pos::new("chrX".to_string(), 461829, ReqStrand::Forward); [INFO] [stderr] | ^^^^^^ help: consider: `461_829` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/contig.rs:423:61 [INFO] [stderr] | [INFO] [stderr] 423 | let tma22 = Contig::with_first_length(&tma22_first, 462426 - 461829).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `462_426` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/contig.rs:423:70 [INFO] [stderr] | [INFO] [stderr] 423 | let tma22 = Contig::with_first_length(&tma22_first, 462426 - 461829).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `461_829` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/contig.rs:426:57 [INFO] [stderr] | [INFO] [stderr] 426 | let tma19_first = Pos::new("chrXI".to_string(), 335015, ReqStrand::Reverse); [INFO] [stderr] | ^^^^^^ help: consider: `335_015` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/contig.rs:427:61 [INFO] [stderr] | [INFO] [stderr] 427 | let tma19 = Contig::with_first_length(&tma19_first, 335016 - 334412).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `335_016` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/contig.rs:427:70 [INFO] [stderr] | [INFO] [stderr] 427 | let tma19 = Contig::with_first_length(&tma19_first, 335016 - 334412).unwrap(); [INFO] [stderr] | ^^^^^^ help: consider: `334_412` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/annot/contig.rs:467:77 [INFO] [stderr] | [INFO] [stderr] 467 | fn test_contig_ixn(ca_str: &str, cb_str: &str, cab_str: Option) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_unit)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:332:50 [INFO] [stderr] | [INFO] [stderr] 332 | let start = Pos::new("chrIV".to_owned(), 683946, Strand::Unknown); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:334:33 [INFO] [stderr] | [INFO] [stderr] 334 | assert_eq!(start.pos(), 683946); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:337:50 [INFO] [stderr] | [INFO] [stderr] 337 | let start = Pos::new("chrIV".to_owned(), 683946, Strand::Reverse); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:339:33 [INFO] [stderr] | [INFO] [stderr] 339 | assert_eq!(start.pos(), 683946); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:342:50 [INFO] [stderr] | [INFO] [stderr] 342 | let start = Pos::new("chrXV".to_owned(), 493433, Strand::Forward); [INFO] [stderr] | ^^^^^^ help: consider: `493_433` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:344:33 [INFO] [stderr] | [INFO] [stderr] 344 | assert_eq!(start.pos(), 493433); [INFO] [stderr] | ^^^^^^ help: consider: `493_433` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:365:50 [INFO] [stderr] | [INFO] [stderr] 365 | let start = Pos::new("chrIV".to_owned(), 683946, NoStrand::Unknown); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:369:50 [INFO] [stderr] | [INFO] [stderr] 369 | let start = Pos::new("chrIV".to_owned(), 683946, Strand::Unknown); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:373:50 [INFO] [stderr] | [INFO] [stderr] 373 | let start = Pos::new("chrIV".to_owned(), 683946, Strand::Reverse); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:377:50 [INFO] [stderr] | [INFO] [stderr] 377 | let start = Pos::new("chrXV".to_owned(), 493433, Strand::Forward); [INFO] [stderr] | ^^^^^^ help: consider: `493_433` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:381:50 [INFO] [stderr] | [INFO] [stderr] 381 | let start = Pos::new("chrIV".to_owned(), 683946, ReqStrand::Reverse); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:385:50 [INFO] [stderr] | [INFO] [stderr] 385 | let start = Pos::new("chrXV".to_owned(), 493433, ReqStrand::Forward); [INFO] [stderr] | ^^^^^^ help: consider: `493_433` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:392:50 [INFO] [stderr] | [INFO] [stderr] 392 | let start = Pos::new("chrIV".to_owned(), 683946, ReqStrand::Forward); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:398:17 [INFO] [stderr] | [INFO] [stderr] 398 | 683900, [INFO] [stderr] | ^^^^^^ help: consider: `683_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:407:17 [INFO] [stderr] | [INFO] [stderr] 407 | 683900, [INFO] [stderr] | ^^^^^^ help: consider: `683_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:416:17 [INFO] [stderr] | [INFO] [stderr] 416 | 683950, [INFO] [stderr] | ^^^^^^ help: consider: `683_950` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:426:17 [INFO] [stderr] | [INFO] [stderr] 426 | 683900, [INFO] [stderr] | ^^^^^^ help: consider: `683_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:435:17 [INFO] [stderr] | [INFO] [stderr] 435 | 683900, [INFO] [stderr] | ^^^^^^ help: consider: `683_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:441:51 [INFO] [stderr] | [INFO] [stderr] 441 | let rstart = Pos::new("chrIV".to_owned(), 683946, ReqStrand::Reverse); [INFO] [stderr] | ^^^^^^ help: consider: `683_946` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:446:17 [INFO] [stderr] | [INFO] [stderr] 446 | 683900, [INFO] [stderr] | ^^^^^^ help: consider: `683_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/pos.rs:455:17 [INFO] [stderr] | [INFO] [stderr] 455 | 683900, [INFO] [stderr] | ^^^^^^ help: consider: `683_900` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/spliced.rs:720:13 [INFO] [stderr] | [INFO] [stderr] 720 | 166236, [INFO] [stderr] | ^^^^^^ help: consider: `166_236` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/spliced.rs:743:13 [INFO] [stderr] | [INFO] [stderr] 743 | 173151, [INFO] [stderr] | ^^^^^^ help: consider: `173_151` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/spliced.rs:768:13 [INFO] [stderr] | [INFO] [stderr] 768 | 765265, [INFO] [stderr] | ^^^^^^ help: consider: `765_265` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/annot/spliced.rs:795:7 [INFO] [stderr] | [INFO] [stderr] 795 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/annot/spliced.rs:808:69 [INFO] [stderr] | [INFO] [stderr] 808 | fn test_no_into(loc: &Spliced, outstr: &str) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/spliced.rs:818:13 [INFO] [stderr] | [INFO] [stderr] 818 | 173151, [INFO] [stderr] | ^^^^^^ help: consider: `173_151` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/spliced.rs:846:13 [INFO] [stderr] | [INFO] [stderr] 846 | 765265, [INFO] [stderr] | ^^^^^^ help: consider: `765_265` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded unit return type [INFO] [stderr] --> src/annot/spliced.rs:879:7 [INFO] [stderr] | [INFO] [stderr] 879 | ) -> () { [INFO] [stderr] | ^^^^^ help: remove the `-> ()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/annot/spliced.rs:892:13 [INFO] [stderr] | [INFO] [stderr] 892 | 173151, [INFO] [stderr] | ^^^^^^ help: consider: `173_151` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/contig.rs:322:22 [INFO] [stderr] | [INFO] [stderr] 322 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/contig.rs:325:22 [INFO] [stderr] | [INFO] [stderr] 325 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/contig.rs:330:22 [INFO] [stderr] | [INFO] [stderr] 330 | .map_err(|e| ParseAnnotError::ParseStrand(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseStrand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/annot/pos.rs:110:47 [INFO] [stderr] | [INFO] [stderr] 110 | ReqStrand::Forward => self.pos += dist.into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `dist` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/annot/pos.rs:111:47 [INFO] [stderr] | [INFO] [stderr] 111 | ReqStrand::Reverse => self.pos -= dist.into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/annot/pos.rs:141:47 [INFO] [stderr] | [INFO] [stderr] 141 | ReqStrand::Forward => self.pos -= dist.into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/annot/pos.rs:142:47 [INFO] [stderr] | [INFO] [stderr] 142 | ReqStrand::Reverse => self.pos += dist.into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/annot/pos.rs:174:39 [INFO] [stderr] | [INFO] [stderr] 174 | } else if self.pos != pos.pos { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 175 | | None [INFO] [stderr] 176 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/annot/pos.rs:172:36 [INFO] [stderr] | [INFO] [stderr] 172 | if self.refid != pos.refid { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 173 | | None [INFO] [stderr] 174 | | } else if self.pos != pos.pos { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/pos.rs:263:22 [INFO] [stderr] | [INFO] [stderr] 263 | .map_err(|e| ParseAnnotError::ParseStrand(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseStrand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/pos.rs:269:26 [INFO] [stderr] | [INFO] [stderr] 269 | .map_err(|e| ParseAnnotError::ParseInt(e))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `annot::refids::RefIDSet` [INFO] [stderr] --> src/annot/refids.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> Self { [INFO] [stderr] 47 | | RefIDSet { [INFO] [stderr] 48 | | refids: HashMap::new(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/annot/spliced.rs:103:50 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn new(exon_0_length: usize, inexes: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[InEx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/annot/spliced.rs:170:50 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn new(exon_0_length: usize, inexes: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[InEx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/annot/spliced.rs:264:12 [INFO] [stderr] | [INFO] [stderr] 264 | if exon_starts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `exon_starts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/annot/spliced.rs:311:5 [INFO] [stderr] | [INFO] [stderr] 311 | / fn exes<'a>(&'a self) -> inex::Exes<'a> { [INFO] [stderr] 312 | | inex::Exes::new(self.exon_0_length, &self.inexes) [INFO] [stderr] 313 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/annot/spliced.rs:432:42 [INFO] [stderr] | [INFO] [stderr] 432 | } else if pos.pos() < self.start { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 433 | | return None; [INFO] [stderr] 434 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/annot/spliced.rs:430:39 [INFO] [stderr] | [INFO] [stderr] 430 | if self.refid != *pos.refid() { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 431 | | return None; [INFO] [stderr] 432 | | } else if pos.pos() < self.start { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/annot/spliced.rs:521:12 [INFO] [stderr] | [INFO] [stderr] 521 | if exon_starts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!exon_starts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:593:22 [INFO] [stderr] | [INFO] [stderr] 593 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:596:22 [INFO] [stderr] | [INFO] [stderr] 596 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:599:22 [INFO] [stderr] | [INFO] [stderr] 599 | .map_err(|e| ParseAnnotError::ParseStrand(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseStrand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:609:26 [INFO] [stderr] | [INFO] [stderr] 609 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:612:26 [INFO] [stderr] | [INFO] [stderr] 612 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:623:19 [INFO] [stderr] | [INFO] [stderr] 623 | ).map_err(|e| ParseAnnotError::Splicing(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::Splicing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/strand.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn from_char(strand_char: &char) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/strand.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn is_unknown(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/strand.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn on_strand(&self, x: T) -> T [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `variant::Kind` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/variant.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / impl Kind { [INFO] [stderr] 22 | | /// Return variant length. [INFO] [stderr] 23 | | pub fn len(&self) -> genome::Length { [INFO] [stderr] 24 | | match self { [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/variant.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match self { [INFO] [stderr] 25 | | &Kind::SNV(_) => 1, [INFO] [stderr] 26 | | &Kind::MNV(ref s) => s.len() as u32, [INFO] [stderr] 27 | | &Kind::Insertion(ref s) => s.len() as u32, [INFO] [stderr] ... | [INFO] [stderr] 31 | | &Kind::None => 1, [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | Kind::SNV(_) => 1, [INFO] [stderr] 26 | Kind::MNV(ref s) => s.len() as u32, [INFO] [stderr] 27 | Kind::Insertion(ref s) => s.len() as u32, [INFO] [stderr] 28 | Kind::Deletion(l) => l, [INFO] [stderr] 29 | Kind::Duplication(l) => l, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bio-types`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/contig.rs:322:22 [INFO] [stderr] | [INFO] [stderr] 322 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/contig.rs:325:22 [INFO] [stderr] | [INFO] [stderr] 325 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/contig.rs:330:22 [INFO] [stderr] | [INFO] [stderr] 330 | .map_err(|e| ParseAnnotError::ParseStrand(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseStrand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/annot/pos.rs:110:47 [INFO] [stderr] | [INFO] [stderr] 110 | ReqStrand::Forward => self.pos += dist.into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `dist` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/annot/pos.rs:111:47 [INFO] [stderr] | [INFO] [stderr] 111 | ReqStrand::Reverse => self.pos -= dist.into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/annot/pos.rs:141:47 [INFO] [stderr] | [INFO] [stderr] 141 | ReqStrand::Forward => self.pos -= dist.into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/annot/pos.rs:142:47 [INFO] [stderr] | [INFO] [stderr] 142 | ReqStrand::Reverse => self.pos += dist.into(), [INFO] [stderr] | ^^^^^^^^^^^ help: consider removing `.into()`: `dist` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/annot/pos.rs:174:39 [INFO] [stderr] | [INFO] [stderr] 174 | } else if self.pos != pos.pos { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 175 | | None [INFO] [stderr] 176 | | } else { [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::if_same_then_else)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/annot/pos.rs:172:36 [INFO] [stderr] | [INFO] [stderr] 172 | if self.refid != pos.refid { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 173 | | None [INFO] [stderr] 174 | | } else if self.pos != pos.pos { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/pos.rs:263:22 [INFO] [stderr] | [INFO] [stderr] 263 | .map_err(|e| ParseAnnotError::ParseStrand(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseStrand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/pos.rs:269:26 [INFO] [stderr] | [INFO] [stderr] 269 | .map_err(|e| ParseAnnotError::ParseInt(e))?, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `annot::refids::RefIDSet` [INFO] [stderr] --> src/annot/refids.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | / pub fn new() -> Self { [INFO] [stderr] 47 | | RefIDSet { [INFO] [stderr] 48 | | refids: HashMap::new(), [INFO] [stderr] 49 | | } [INFO] [stderr] 50 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 40 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/annot/spliced.rs:103:50 [INFO] [stderr] | [INFO] [stderr] 103 | pub fn new(exon_0_length: usize, inexes: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[InEx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/annot/spliced.rs:170:50 [INFO] [stderr] | [INFO] [stderr] 170 | pub fn new(exon_0_length: usize, inexes: &'a Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: change this to: `&[InEx]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to one [INFO] [stderr] --> src/annot/spliced.rs:264:12 [INFO] [stderr] | [INFO] [stderr] 264 | if exon_starts.len() < 1 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `exon_starts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/annot/spliced.rs:311:5 [INFO] [stderr] | [INFO] [stderr] 311 | / fn exes<'a>(&'a self) -> inex::Exes<'a> { [INFO] [stderr] 312 | | inex::Exes::new(self.exon_0_length, &self.inexes) [INFO] [stderr] 313 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: this `if` has identical blocks [INFO] [stderr] --> src/annot/spliced.rs:432:42 [INFO] [stderr] | [INFO] [stderr] 432 | } else if pos.pos() < self.start { [INFO] [stderr] | __________________________________________^ [INFO] [stderr] 433 | | return None; [INFO] [stderr] 434 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] note: same as this [INFO] [stderr] --> src/annot/spliced.rs:430:39 [INFO] [stderr] | [INFO] [stderr] 430 | if self.refid != *pos.refid() { [INFO] [stderr] | _______________________________________^ [INFO] [stderr] 431 | | return None; [INFO] [stderr] 432 | | } else if pos.pos() < self.start { [INFO] [stderr] | |_________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/annot/spliced.rs:521:12 [INFO] [stderr] | [INFO] [stderr] 521 | if exon_starts.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!exon_starts.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:593:22 [INFO] [stderr] | [INFO] [stderr] 593 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:596:22 [INFO] [stderr] | [INFO] [stderr] 596 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:599:22 [INFO] [stderr] | [INFO] [stderr] 599 | .map_err(|e| ParseAnnotError::ParseStrand(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseStrand` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:609:26 [INFO] [stderr] | [INFO] [stderr] 609 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:612:26 [INFO] [stderr] | [INFO] [stderr] 612 | .map_err(|e| ParseAnnotError::ParseInt(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::ParseInt` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/annot/spliced.rs:623:19 [INFO] [stderr] | [INFO] [stderr] 623 | ).map_err(|e| ParseAnnotError::Splicing(e))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `ParseAnnotError::Splicing` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:721:13 [INFO] [stderr] | [INFO] [stderr] 721 | &vec![535, 11], [INFO] [stderr] | ^^^^^^^^^^^^^^ help: you can use a slice directly: `&[535, 11]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:722:13 [INFO] [stderr] | [INFO] [stderr] 722 | &vec![0, 638], [INFO] [stderr] | ^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 638]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:744:13 [INFO] [stderr] | [INFO] [stderr] 744 | &vec![11, 94, 630], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[11, 94, 630]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:745:13 [INFO] [stderr] | [INFO] [stderr] 745 | &vec![0, 420, 921], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 420, 921]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:769:13 [INFO] [stderr] | [INFO] [stderr] 769 | &vec![808, 52, 109], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[808, 52, 109]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:770:13 [INFO] [stderr] | [INFO] [stderr] 770 | &vec![0, 864, 984], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 864, 984]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:819:13 [INFO] [stderr] | [INFO] [stderr] 819 | &vec![11, 94, 630], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[11, 94, 630]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:820:13 [INFO] [stderr] | [INFO] [stderr] 820 | &vec![0, 420, 921], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 420, 921]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:847:13 [INFO] [stderr] | [INFO] [stderr] 847 | &vec![808, 52, 109], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[808, 52, 109]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:848:13 [INFO] [stderr] | [INFO] [stderr] 848 | &vec![0, 864, 984], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 864, 984]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:893:13 [INFO] [stderr] | [INFO] [stderr] 893 | &vec![11, 94, 630], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[11, 94, 630]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/annot/spliced.rs:894:13 [INFO] [stderr] | [INFO] [stderr] 894 | &vec![0, 420, 921], [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[0, 420, 921]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/strand.rs:28:35 [INFO] [stderr] | [INFO] [stderr] 28 | pub fn from_char(strand_char: &char) -> Result { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/strand.rs:48:23 [INFO] [stderr] | [INFO] [stderr] 48 | pub fn is_unknown(&self) -> bool { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/strand.rs:158:25 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn on_strand(&self, x: T) -> T [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: item `variant::Kind` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/variant.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | / impl Kind { [INFO] [stderr] 22 | | /// Return variant length. [INFO] [stderr] 23 | | pub fn len(&self) -> genome::Length { [INFO] [stderr] 24 | | match self { [INFO] [stderr] ... | [INFO] [stderr] 33 | | } [INFO] [stderr] 34 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/variant.rs:24:9 [INFO] [stderr] | [INFO] [stderr] 24 | / match self { [INFO] [stderr] 25 | | &Kind::SNV(_) => 1, [INFO] [stderr] 26 | | &Kind::MNV(ref s) => s.len() as u32, [INFO] [stderr] 27 | | &Kind::Insertion(ref s) => s.len() as u32, [INFO] [stderr] ... | [INFO] [stderr] 31 | | &Kind::None => 1, [INFO] [stderr] 32 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 24 | match *self { [INFO] [stderr] 25 | Kind::SNV(_) => 1, [INFO] [stderr] 26 | Kind::MNV(ref s) => s.len() as u32, [INFO] [stderr] 27 | Kind::Insertion(ref s) => s.len() as u32, [INFO] [stderr] 28 | Kind::Deletion(l) => l, [INFO] [stderr] 29 | Kind::Duplication(l) => l, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bio-types`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "8878e4a12642cf8d435fd82b3c9ded435d64cee8ebc93ac0988a80faae0b6f06"` [INFO] running `"docker" "rm" "-f" "8878e4a12642cf8d435fd82b3c9ded435d64cee8ebc93ac0988a80faae0b6f06"` [INFO] [stdout] 8878e4a12642cf8d435fd82b3c9ded435d64cee8ebc93ac0988a80faae0b6f06