[INFO] crate binomial-heap 0.2.0 is already in cache [INFO] extracting crate binomial-heap 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/binomial-heap/0.2.0 [INFO] extracting crate binomial-heap 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binomial-heap/0.2.0 [INFO] validating manifest of binomial-heap-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of binomial-heap-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing binomial-heap-0.2.0 [INFO] finished frobbing binomial-heap-0.2.0 [INFO] frobbed toml for binomial-heap-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/binomial-heap/0.2.0/Cargo.toml [INFO] started frobbing binomial-heap-0.2.0 [INFO] finished frobbing binomial-heap-0.2.0 [INFO] frobbed toml for binomial-heap-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binomial-heap/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting binomial-heap-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/binomial-heap/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 0906c83612a06cec11441577ce288c2c94a45a3789a2ff95ed46fb413605705a [INFO] running `"docker" "start" "-a" "0906c83612a06cec11441577ce288c2c94a45a3789a2ff95ed46fb413605705a"` [INFO] [stderr] Checking binomial-heap v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:19:37 [INFO] [stderr] | [INFO] [stderr] 19 | let node = Some(Box::new(Node { item: item, order: 0, next: None, child: None })); [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `item` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:57:76 [INFO] [stderr] | [INFO] [stderr] 57 | Iter { nodes: root.as_ref().map(|root| &**root).into_iter().collect(), len: len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/node.rs:62:51 [INFO] [stderr] | [INFO] [stderr] 62 | IntoIter { nodes: root.into_iter().collect(), len: len } [INFO] [stderr] | ^^^^^^^^ help: replace it with: `len` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/node.rs:11:29 [INFO] [stderr] | [INFO] [stderr] 11 | pub fn append(root: &mut Box>, other: Option>>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Node` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::borrowed_box)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/node.rs:146:20 [INFO] [stderr] | [INFO] [stderr] 146 | fn merge(mut a: &mut Box>, mut b: Box>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use `&Box`. Consider using just `&T` [INFO] [stderr] --> src/node.rs:179:28 [INFO] [stderr] | [INFO] [stderr] 179 | fn coalesce(mut a: &mut Box>) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try: `&mut Node` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrowed_box [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.55s [INFO] running `"docker" "inspect" "0906c83612a06cec11441577ce288c2c94a45a3789a2ff95ed46fb413605705a"` [INFO] running `"docker" "rm" "-f" "0906c83612a06cec11441577ce288c2c94a45a3789a2ff95ed46fb413605705a"` [INFO] [stdout] 0906c83612a06cec11441577ce288c2c94a45a3789a2ff95ed46fb413605705a