[INFO] crate binjs_shared 0.1.1 is already in cache [INFO] extracting crate binjs_shared 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/binjs_shared/0.1.1 [INFO] extracting crate binjs_shared 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binjs_shared/0.1.1 [INFO] validating manifest of binjs_shared-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of binjs_shared-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing binjs_shared-0.1.1 [INFO] finished frobbing binjs_shared-0.1.1 [INFO] frobbed toml for binjs_shared-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/binjs_shared/0.1.1/Cargo.toml [INFO] started frobbing binjs_shared-0.1.1 [INFO] finished frobbing binjs_shared-0.1.1 [INFO] frobbed toml for binjs_shared-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binjs_shared/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting binjs_shared-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/binjs_shared/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eef898d370a691243408980fb59b99a63f51419172e175b183b0d11e094e0db9 [INFO] running `"docker" "start" "-a" "eef898d370a691243408980fb59b99a63f51419172e175b183b0d11e094e0db9"` [INFO] [stderr] Checking binjs_shared v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/json_conversion.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | json::from(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/json_conversion.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | json::from(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/json_conversion.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | json::from(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: item `ast::Path` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/ast.rs:112:1 [INFO] [stderr] | [INFO] [stderr] 112 | / impl Path where I: Debug + PartialEq, F: Debug + PartialEq { [INFO] [stderr] 113 | | /// Create an empty `Path`. [INFO] [stderr] 114 | | pub fn new() -> Self { [INFO] [stderr] 115 | | Self { [INFO] [stderr] ... | [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mru::MRU` [INFO] [stderr] --> src/mru.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> Self { [INFO] [stderr] 40 | | Self { [INFO] [stderr] 41 | | items: LinkedList::new(), [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 86 | | SharedString::Static(value) [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/json_conversion.rs:150:20 [INFO] [stderr] | [INFO] [stderr] 150 | json::from(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shared_string.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | #[derive(Clone, Eq, PartialOrd, Ord, Debug, Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | shared_string!(pub IdentifierName); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shared_string.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118| / impl PartialEq for $name { [INFO] [stderr] 119| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 120| | self.0.eq(&other.0) [INFO] [stderr] 121| | } [INFO] [stderr] 122| | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | shared_string!(pub IdentifierName); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/json_conversion.rs:155:20 [INFO] [stderr] | [INFO] [stderr] 155 | json::from(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/json_conversion.rs:160:20 [INFO] [stderr] | [INFO] [stderr] 160 | json::from(self.clone()) [INFO] [stderr] | ^^^^^^^^^^^^ help: try dereferencing it: `*self` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 103 | | $name(shared_string::SharedString::from_str(value)) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | shared_string!(pub IdentifierName); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shared_string.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | #[derive(Clone, Eq, PartialOrd, Ord, Debug, Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | shared_string!(pub PropertyKey); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shared_string.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118| / impl PartialEq for $name { [INFO] [stderr] 119| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 120| | self.0.eq(&other.0) [INFO] [stderr] 121| | } [INFO] [stderr] 122| | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | shared_string!(pub PropertyKey); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 103 | | $name(shared_string::SharedString::from_str(value)) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | shared_string!(pub PropertyKey); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shared_string.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | #[derive(Clone, Eq, PartialOrd, Ord, Debug, Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | shared_string!(pub InterfaceName); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shared_string.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118| / impl PartialEq for $name { [INFO] [stderr] 119| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 120| | self.0.eq(&other.0) [INFO] [stderr] 121| | } [INFO] [stderr] 122| | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | shared_string!(pub InterfaceName); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 103 | | $name(shared_string::SharedString::from_str(value)) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | shared_string!(pub InterfaceName); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shared_string.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | #[derive(Clone, Eq, PartialOrd, Ord, Debug, Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | shared_string!(pub FieldName); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shared_string.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118| / impl PartialEq for $name { [INFO] [stderr] 119| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 120| | self.0.eq(&other.0) [INFO] [stderr] 121| | } [INFO] [stderr] 122| | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | shared_string!(pub FieldName); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 103 | | $name(shared_string::SharedString::from_str(value)) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | shared_string!(pub FieldName); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] warning: item `ast::Path` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/ast.rs:112:1 [INFO] [stderr] | [INFO] [stderr] 112 | / impl Path where I: Debug + PartialEq, F: Debug + PartialEq { [INFO] [stderr] 113 | | /// Create an empty `Path`. [INFO] [stderr] 114 | | pub fn new() -> Self { [INFO] [stderr] 115 | | Self { [INFO] [stderr] ... | [INFO] [stderr] 198 | | } [INFO] [stderr] 199 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `binjs_shared`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `mru::MRU` [INFO] [stderr] --> src/mru.rs:39:5 [INFO] [stderr] | [INFO] [stderr] 39 | / pub fn new() -> Self { [INFO] [stderr] 40 | | Self { [INFO] [stderr] 41 | | items: LinkedList::new(), [INFO] [stderr] 42 | | } [INFO] [stderr] 43 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:85:5 [INFO] [stderr] | [INFO] [stderr] 85 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 86 | | SharedString::Static(value) [INFO] [stderr] 87 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::should_implement_trait)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shared_string.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | #[derive(Clone, Eq, PartialOrd, Ord, Debug, Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | shared_string!(pub IdentifierName); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::derive_hash_xor_eq)] on by default [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shared_string.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118| / impl PartialEq for $name { [INFO] [stderr] 119| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 120| | self.0.eq(&other.0) [INFO] [stderr] 121| | } [INFO] [stderr] 122| | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | shared_string!(pub IdentifierName); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 103 | | $name(shared_string::SharedString::from_str(value)) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | shared_string!(pub IdentifierName); [INFO] [stderr] | ----------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shared_string.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | #[derive(Clone, Eq, PartialOrd, Ord, Debug, Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | shared_string!(pub PropertyKey); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shared_string.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118| / impl PartialEq for $name { [INFO] [stderr] 119| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 120| | self.0.eq(&other.0) [INFO] [stderr] 121| | } [INFO] [stderr] 122| | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | shared_string!(pub PropertyKey); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 103 | | $name(shared_string::SharedString::from_str(value)) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:37:1 [INFO] [stderr] | [INFO] [stderr] 37 | shared_string!(pub PropertyKey); [INFO] [stderr] | -------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shared_string.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | #[derive(Clone, Eq, PartialOrd, Ord, Debug, Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | shared_string!(pub InterfaceName); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shared_string.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118| / impl PartialEq for $name { [INFO] [stderr] 119| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 120| | self.0.eq(&other.0) [INFO] [stderr] 121| | } [INFO] [stderr] 122| | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | shared_string!(pub InterfaceName); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 103 | | $name(shared_string::SharedString::from_str(value)) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | shared_string!(pub InterfaceName); [INFO] [stderr] | ---------------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: you are deriving `Hash` but have implemented `PartialEq` explicitly [INFO] [stderr] --> src/shared_string.rs:99:53 [INFO] [stderr] | [INFO] [stderr] 99 | #[derive(Clone, Eq, PartialOrd, Ord, Debug, Hash, Serialize, Deserialize)] [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | shared_string!(pub FieldName); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: `PartialEq` implemented here [INFO] [stderr] --> src/shared_string.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118| / impl PartialEq for $name { [INFO] [stderr] 119| | fn eq(&self, other: &$name) -> bool { [INFO] [stderr] 120| | self.0.eq(&other.0) [INFO] [stderr] 121| | } [INFO] [stderr] 122| | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | shared_string!(pub FieldName); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derive_hash_xor_eq [INFO] [stderr] [INFO] [stderr] warning: defining a method called `from_str` on this type; consider implementing the `std::str::FromStr` trait or choosing a less ambiguous name [INFO] [stderr] --> src/shared_string.rs:102:13 [INFO] [stderr] | [INFO] [stderr] 102 | / pub fn from_str(value: &'static str) -> Self { [INFO] [stderr] 103 | | $name(shared_string::SharedString::from_str(value)) [INFO] [stderr] 104 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:43:1 [INFO] [stderr] | [INFO] [stderr] 43 | shared_string!(pub FieldName); [INFO] [stderr] | ------------------------------ in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `binjs_shared`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "eef898d370a691243408980fb59b99a63f51419172e175b183b0d11e094e0db9"` [INFO] running `"docker" "rm" "-f" "eef898d370a691243408980fb59b99a63f51419172e175b183b0d11e094e0db9"` [INFO] [stdout] eef898d370a691243408980fb59b99a63f51419172e175b183b0d11e094e0db9