[INFO] crate binjs_generate_library 0.2.1 is already in cache
[INFO] extracting crate binjs_generate_library 0.2.1 into work/ex/clippy-test-run/sources/stable/reg/binjs_generate_library/0.2.1
[INFO] extracting crate binjs_generate_library 0.2.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binjs_generate_library/0.2.1
[INFO] validating manifest of binjs_generate_library-0.2.1 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of binjs_generate_library-0.2.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing binjs_generate_library-0.2.1
[INFO] finished frobbing binjs_generate_library-0.2.1
[INFO] frobbed toml for binjs_generate_library-0.2.1 written to work/ex/clippy-test-run/sources/stable/reg/binjs_generate_library/0.2.1/Cargo.toml
[INFO] started frobbing binjs_generate_library-0.2.1
[INFO] finished frobbing binjs_generate_library-0.2.1
[INFO] frobbed toml for binjs_generate_library-0.2.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binjs_generate_library/0.2.1/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting binjs_generate_library-0.2.1 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/binjs_generate_library/0.2.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 962b604558aa7a78d2677f60ca1b4008f1fc7e4e57bd3f0adfcce234c23f1c3e
[INFO] running `"docker" "start" "-a" "962b604558aa7a78d2677f60ca1b4008f1fc7e4e57bd3f0adfcce234c23f1c3e"`
[INFO] [stderr]    Compiling docopt v1.0.2
[INFO] [stderr]    Compiling lalrpop v0.16.3
[INFO] [stderr]    Compiling webidl v0.8.0
[INFO] [stderr]     Checking binjs_meta v0.4.3
[INFO] [stderr]     Checking binjs_generate_library v0.2.1 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/lib.rs:1303:25
[INFO] [stderr]      |
[INFO] [stderr] 1303 |                         return None;
[INFO] [stderr]      |                         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]     --> src/lib.rs:1303:25
[INFO] [stderr]      |
[INFO] [stderr] 1303 |                         return None;
[INFO] [stderr]      |                         ^^^^^^^^^^^^ help: remove `return` as shown: `None`
[INFO] [stderr]      |
[INFO] [stderr]      = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/lib.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |         let ref spec = spec.trim_left();
[INFO] [stderr]    |         ----^^^^^^^^-------------------- help: try: `let spec = &spec.trim_left();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]   --> src/lib.rs:43:13
[INFO] [stderr]    |
[INFO] [stderr] 43 |         let ref spec = spec.trim_left();
[INFO] [stderr]    |         ----^^^^^^^^-------------------- help: try: `let spec = &spec.trim_left();`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:329:41
[INFO] [stderr]     |
[INFO] [stderr] 329 |                         .or_insert_with(|| HashSet::new());
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:372:31
[INFO] [stderr]     |
[INFO] [stderr] 372 |                         Some((name.clone(), types))
[INFO] [stderr]     |                               ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 372 |                         Some((&(*name).clone(), types))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 372 |                         Some((&binjs_meta::spec::NodeName::clone(name), types))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:383:33
[INFO] [stderr]     |
[INFO] [stderr] 383 |                     let types = typesums.get(&node_name).unwrap(); // Just built above.
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&typesums[&node_name]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:439:49
[INFO] [stderr]     |
[INFO] [stderr] 439 |                                         cases = typesums.get(subsum_name).unwrap()
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&typesums[subsum_name]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/lib.rs:329:41
[INFO] [stderr]     |
[INFO] [stderr] 329 |                         .or_insert_with(|| HashSet::new());
[INFO] [stderr]     |                                         ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:372:31
[INFO] [stderr]     |
[INFO] [stderr] 372 |                         Some((name.clone(), types))
[INFO] [stderr]     |                               ^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 372 |                         Some((&(*name).clone(), types))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 372 |                         Some((&binjs_meta::spec::NodeName::clone(name), types))
[INFO] [stderr]     |                               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:383:33
[INFO] [stderr]     |
[INFO] [stderr] 383 |                     let types = typesums.get(&node_name).unwrap(); // Just built above.
[INFO] [stderr]     |                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&typesums[&node_name]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::get_unwrap)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]    --> src/lib.rs:439:49
[INFO] [stderr]     |
[INFO] [stderr] 439 |                                         cases = typesums.get(subsum_name).unwrap()
[INFO] [stderr]     |                                                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&typesums[subsum_name]`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:959:26
[INFO] [stderr]     |
[INFO] [stderr] 959 |                         (a.clone(), b)
[INFO] [stderr]     |                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 959 |                         (&(*a).clone(), b)
[INFO] [stderr]     |                          ^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 959 |                         (&binjs_meta::spec::FieldName::clone(a), b)
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]     --> src/lib.rs:1077:36
[INFO] [stderr]      |
[INFO] [stderr] 1077 |                             spec = field_specs_map.get(field.name()).unwrap(),
[INFO] [stderr]      |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&field_specs_map[field.name()]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/lib.rs:959:26
[INFO] [stderr]     |
[INFO] [stderr] 959 |                         (a.clone(), b)
[INFO] [stderr]     |                          ^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 959 |                         (&(*a).clone(), b)
[INFO] [stderr]     |                          ^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 959 |                         (&binjs_meta::spec::FieldName::clone(a), b)
[INFO] [stderr]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `binjs_generate_library`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise
[INFO] [stderr]     --> src/lib.rs:1077:36
[INFO] [stderr]      |
[INFO] [stderr] 1077 |                             spec = field_specs_map.get(field.name()).unwrap(),
[INFO] [stderr]      |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `&field_specs_map[field.name()]`
[INFO] [stderr]      |
[INFO] [stderr]      = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 2 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `binjs_generate_library`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "962b604558aa7a78d2677f60ca1b4008f1fc7e4e57bd3f0adfcce234c23f1c3e"`
[INFO] running `"docker" "rm" "-f" "962b604558aa7a78d2677f60ca1b4008f1fc7e4e57bd3f0adfcce234c23f1c3e"`
[INFO] [stdout] 962b604558aa7a78d2677f60ca1b4008f1fc7e4e57bd3f0adfcce234c23f1c3e