[INFO] crate bingrep 0.6.1 is already in cache [INFO] extracting crate bingrep 0.6.1 into work/ex/clippy-test-run/sources/stable/reg/bingrep/0.6.1 [INFO] extracting crate bingrep 0.6.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bingrep/0.6.1 [INFO] validating manifest of bingrep-0.6.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bingrep-0.6.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bingrep-0.6.1 [INFO] finished frobbing bingrep-0.6.1 [INFO] frobbed toml for bingrep-0.6.1 written to work/ex/clippy-test-run/sources/stable/reg/bingrep/0.6.1/Cargo.toml [INFO] started frobbing bingrep-0.6.1 [INFO] finished frobbing bingrep-0.6.1 [INFO] frobbed toml for bingrep-0.6.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bingrep/0.6.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bingrep-0.6.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bingrep/0.6.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 31137909fe9aace9fb700501b929f68493052722fbf8ceaf2161817fee40fd40 [INFO] running `"docker" "start" "-a" "31137909fe9aace9fb700501b929f68493052722fbf8ceaf2161817fee40fd40"` [INFO] [stderr] Checking memrange v0.1.3 [INFO] [stderr] Compiling cpp_demangle v0.2.12 [INFO] [stderr] Compiling scroll v0.9.2 [INFO] [stderr] Checking hexplay v0.2.1 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking theban_interval_tree v0.7.1 [INFO] [stderr] Checking goblin v0.0.19 [INFO] [stderr] Checking metagoblin v0.1.1 [INFO] [stderr] Checking bingrep v0.6.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format_elf.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | elf: elf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `elf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format_elf.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format_elf.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/format_elf.rs:389:39 [INFO] [stderr] | [INFO] [stderr] 389 | writeln!(fmt, "{}: None", "Dynamic")?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:406:9 [INFO] [stderr] | [INFO] [stderr] 406 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:412:9 [INFO] [stderr] | [INFO] [stderr] 412 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:415:9 [INFO] [stderr] | [INFO] [stderr] 415 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | writeln!(fmt, "") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format_elf.rs:55:13 [INFO] [stderr] | [INFO] [stderr] 55 | elf: elf, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `elf` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format_elf.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | bytes: bytes, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `bytes` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/format_elf.rs:57:13 [INFO] [stderr] | [INFO] [stderr] 57 | args: args, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `args` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:91:21 [INFO] [stderr] | [INFO] [stderr] 91 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::writeln_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:98:21 [INFO] [stderr] | [INFO] [stderr] 98 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:140:9 [INFO] [stderr] | [INFO] [stderr] 140 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:154:9 [INFO] [stderr] | [INFO] [stderr] 154 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:200:9 [INFO] [stderr] | [INFO] [stderr] 200 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:204:13 [INFO] [stderr] | [INFO] [stderr] 204 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:214:17 [INFO] [stderr] | [INFO] [stderr] 214 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:217:13 [INFO] [stderr] | [INFO] [stderr] 217 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:258:9 [INFO] [stderr] | [INFO] [stderr] 258 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:295:13 [INFO] [stderr] | [INFO] [stderr] 295 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:325:21 [INFO] [stderr] | [INFO] [stderr] 325 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:330:13 [INFO] [stderr] | [INFO] [stderr] 330 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:355:9 [INFO] [stderr] | [INFO] [stderr] 355 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:386:17 [INFO] [stderr] | [INFO] [stderr] 386 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/format_elf.rs:389:39 [INFO] [stderr] | [INFO] [stderr] 389 | writeln!(fmt, "{}: None", "Dynamic")?; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:391:9 [INFO] [stderr] | [INFO] [stderr] 391 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:392:9 [INFO] [stderr] | [INFO] [stderr] 392 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:397:13 [INFO] [stderr] | [INFO] [stderr] 397 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:399:9 [INFO] [stderr] | [INFO] [stderr] 399 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:403:9 [INFO] [stderr] | [INFO] [stderr] 403 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:406:9 [INFO] [stderr] | [INFO] [stderr] 406 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:409:9 [INFO] [stderr] | [INFO] [stderr] 409 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:412:9 [INFO] [stderr] | [INFO] [stderr] 412 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:415:9 [INFO] [stderr] | [INFO] [stderr] 415 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_elf.rs:418:9 [INFO] [stderr] | [INFO] [stderr] 418 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:80:13 [INFO] [stderr] | [INFO] [stderr] 80 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:120:13 [INFO] [stderr] | [INFO] [stderr] 120 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:122:9 [INFO] [stderr] | [INFO] [stderr] 122 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:240:13 [INFO] [stderr] | [INFO] [stderr] 240 | writeln!(fmt, "") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:257:13 [INFO] [stderr] | [INFO] [stderr] 257 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:259:9 [INFO] [stderr] | [INFO] [stderr] 259 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:264:13 [INFO] [stderr] | [INFO] [stderr] 264 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:266:9 [INFO] [stderr] | [INFO] [stderr] 266 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:270:9 [INFO] [stderr] | [INFO] [stderr] 270 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:273:9 [INFO] [stderr] | [INFO] [stderr] 273 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:276:9 [INFO] [stderr] | [INFO] [stderr] 276 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:279:9 [INFO] [stderr] | [INFO] [stderr] 279 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `writeln!(fmt, "")` [INFO] [stderr] --> src/format_mach.rs:282:9 [INFO] [stderr] | [INFO] [stderr] 282 | writeln!(fmt, "")?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: replace it with: `writeln!(fmt)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:147:24 [INFO] [stderr] | [INFO] [stderr] 147 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 148 | | if opt.debug { [INFO] [stderr] 149 | | println!("archive: {:#?}", &archive); [INFO] [stderr] 150 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 147 | } else if opt.debug { [INFO] [stderr] 148 | println!("archive: {:#?}", &archive); [INFO] [stderr] 149 | } else { [INFO] [stderr] 150 | let archive = Archive::new(archive, opt.clone()); [INFO] [stderr] 151 | archive.print()?; [INFO] [stderr] 152 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/main.rs:147:24 [INFO] [stderr] | [INFO] [stderr] 147 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 148 | | if opt.debug { [INFO] [stderr] 149 | | println!("archive: {:#?}", &archive); [INFO] [stderr] 150 | | } else { [INFO] [stderr] ... | [INFO] [stderr] 153 | | } [INFO] [stderr] 154 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 147 | } else if opt.debug { [INFO] [stderr] 148 | println!("archive: {:#?}", &archive); [INFO] [stderr] 149 | } else { [INFO] [stderr] 150 | let archive = Archive::new(archive, opt.clone()); [INFO] [stderr] 151 | archive.print()?; [INFO] [stderr] 152 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/format.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | Cell::new(&format!("{}", n.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `n.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / if let &Some(ref s) = s{ [INFO] [stderr] 189 | | fmt_str(fmt, s) [INFO] [stderr] 190 | | } else { [INFO] [stderr] 191 | | fmt_name_dim(fmt, "None") [INFO] [stderr] 192 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | if let Some(ref s) = *s{ [INFO] [stderr] | ^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format_elf.rs:28:46 [INFO] [stderr] | [INFO] [stderr] 28 | fn shndx_cell (opt: &Opt, idx: usize, shdrs: &elf::SectionHeaders, strtab: &metagoblin::strtab::Strtab) -> Cell { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/format_elf.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | Cell::new(&format!("ABS")).style_spec("iFw") [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"ABS".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format_elf.rs:61:34 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn search(&self, search: &String) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format_elf.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | / match self.bytes.pread_with::<&str>(i, StrCtx::Length(search.len())) { [INFO] [stderr] 69 | | Ok(res) => { [INFO] [stderr] 70 | | if res == search { [INFO] [stderr] 71 | | matches.push(i); [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | if let Ok(res) = self.bytes.pread_with::<&str>(i, StrCtx::Length(search.len())) { [INFO] [stderr] 69 | if res == search { [INFO] [stderr] 70 | matches.push(i); [INFO] [stderr] 71 | } [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_elf.rs:87:58 [INFO] [stderr] | [INFO] [stderr] 87 | for (i, phdr) in (&self.elf.program_headers).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_elf.rs:94:58 [INFO] [stderr] | [INFO] [stderr] 94 | for (i, shdr) in (&self.elf.section_headers).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has the same condition as a previous if [INFO] [stderr] --> src/format_elf.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | else if flags == program_header::PF_R { "R".to_owned() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::ifs_same_cond)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/format_elf.rs:165:21 [INFO] [stderr] | [INFO] [stderr] 165 | else if flags == program_header::PF_R { "R".to_owned() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_elf.rs:184:32 [INFO] [stderr] | [INFO] [stderr] 184 | for (i, phdr) in phdrs.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_elf.rs:223:54 [INFO] [stderr] | [INFO] [stderr] 223 | for (i, shdr) in (&self.elf.section_headers).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/format_elf.rs:262:16 [INFO] [stderr] | [INFO] [stderr] 262 | if syms.len() == 0 { return Ok(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `syms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/format_elf.rs:347:21 [INFO] [stderr] | [INFO] [stderr] 347 | let ref shdr = self.elf.section_headers[idx]; [INFO] [stderr] | ----^^^^^^^^--------------------------------- help: try: `let shdr = &self.elf.section_headers[idx];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/format_elf.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | / if let &Some(Dynamic { ref dyns, .. }) = &self.elf.dynamic { [INFO] [stderr] 358 | | fmt_header(fmt, "Dynamic", dyns.len())?; [INFO] [stderr] 359 | | for dyn in dyns { [INFO] [stderr] 360 | | let tag = dyn.d_tag; [INFO] [stderr] ... | [INFO] [stderr] 389 | | writeln!(fmt, "{}: None", "Dynamic")?; [INFO] [stderr] 390 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 357 | if let Some(Dynamic { ref dyns, .. }) = self.elf.dynamic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/format.rs:137:16 [INFO] [stderr] | [INFO] [stderr] 137 | Cell::new(&format!("{}", n.to_string())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: `to_string()` is enough: `n.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format.rs:188:5 [INFO] [stderr] | [INFO] [stderr] 188 | / if let &Some(ref s) = s{ [INFO] [stderr] 189 | | fmt_str(fmt, s) [INFO] [stderr] 190 | | } else { [INFO] [stderr] 191 | | fmt_name_dim(fmt, "None") [INFO] [stderr] 192 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 188 | if let Some(ref s) = *s{ [INFO] [stderr] | ^^^^^^^^^^^ ^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/format_elf.rs:28:46 [INFO] [stderr] | [INFO] [stderr] 28 | fn shndx_cell (opt: &Opt, idx: usize, shdrs: &elf::SectionHeaders, strtab: &metagoblin::strtab::Strtab) -> Cell { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/format_elf.rs:31:24 [INFO] [stderr] | [INFO] [stderr] 31 | Cell::new(&format!("ABS")).style_spec("iFw") [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using .to_string(): `"ABS".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/format_elf.rs:61:34 [INFO] [stderr] | [INFO] [stderr] 61 | pub fn search(&self, search: &String) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/format_elf.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | / match self.bytes.pread_with::<&str>(i, StrCtx::Length(search.len())) { [INFO] [stderr] 69 | | Ok(res) => { [INFO] [stderr] 70 | | if res == search { [INFO] [stderr] 71 | | matches.push(i); [INFO] [stderr] ... | [INFO] [stderr] 74 | | _ => (), [INFO] [stderr] 75 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 68 | if let Ok(res) = self.bytes.pread_with::<&str>(i, StrCtx::Length(search.len())) { [INFO] [stderr] 69 | if res == search { [INFO] [stderr] 70 | matches.push(i); [INFO] [stderr] 71 | } [INFO] [stderr] 72 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_elf.rs:87:58 [INFO] [stderr] | [INFO] [stderr] 87 | for (i, phdr) in (&self.elf.program_headers).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_elf.rs:94:58 [INFO] [stderr] | [INFO] [stderr] 94 | for (i, shdr) in (&self.elf.section_headers).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: this `if` has the same condition as a previous if [INFO] [stderr] --> src/format_elf.rs:167:21 [INFO] [stderr] | [INFO] [stderr] 167 | else if flags == program_header::PF_R { "R".to_owned() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::ifs_same_cond)] on by default [INFO] [stderr] note: same as this [INFO] [stderr] --> src/format_elf.rs:165:21 [INFO] [stderr] | [INFO] [stderr] 165 | else if flags == program_header::PF_R { "R".to_owned() } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ifs_same_cond [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_elf.rs:184:32 [INFO] [stderr] | [INFO] [stderr] 184 | for (i, phdr) in phdrs.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_mach.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | for (i, lc) in lcs.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_mach.rs:98:52 [INFO] [stderr] | [INFO] [stderr] 98 | for (i, &(ref section, _)) in sections.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/format_mach.rs:106:38 [INFO] [stderr] | [INFO] [stderr] 106 | offsetx_cell(section.offset as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section.offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/format_mach.rs:108:38 [INFO] [stderr] | [INFO] [stderr] 108 | offsetx_cell(section.reloff as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section.reloff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_elf.rs:223:54 [INFO] [stderr] | [INFO] [stderr] 223 | for (i, shdr) in (&self.elf.section_headers).into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/format_elf.rs:262:16 [INFO] [stderr] | [INFO] [stderr] 262 | if syms.len() == 0 { return Ok(()); } [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `syms.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format_mach.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | / match symbol { [INFO] [stderr] 160 | | &Ok((ref name, _)) => { [INFO] [stderr] 161 | | let name: &str = name; [INFO] [stderr] 162 | | if i == idx { [INFO] [stderr] ... | [INFO] [stderr] 166 | | &Err(_) => () [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | match *symbol { [INFO] [stderr] 160 | Ok((ref name, _)) => { [INFO] [stderr] 161 | let name: &str = name; [INFO] [stderr] 162 | if i == idx { [INFO] [stderr] 163 | maybe_name = Some(name); [INFO] [stderr] 164 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/format_elf.rs:347:21 [INFO] [stderr] | [INFO] [stderr] 347 | let ref shdr = self.elf.section_headers[idx]; [INFO] [stderr] | ----^^^^^^^^--------------------------------- help: try: `let shdr = &self.elf.section_headers[idx];` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/format_elf.rs:357:9 [INFO] [stderr] | [INFO] [stderr] 357 | / if let &Some(Dynamic { ref dyns, .. }) = &self.elf.dynamic { [INFO] [stderr] 358 | | fmt_header(fmt, "Dynamic", dyns.len())?; [INFO] [stderr] 359 | | for dyn in dyns { [INFO] [stderr] 360 | | let tag = dyn.d_tag; [INFO] [stderr] ... | [INFO] [stderr] 389 | | writeln!(fmt, "{}: None", "Dynamic")?; [INFO] [stderr] 390 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 357 | if let Some(Dynamic { ref dyns, .. }) = self.elf.dynamic { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/format_meta.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | let mut chars = SCALE.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `SCALE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `chars`. [INFO] [stderr] --> src/format_meta.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | for i in scaled_min..scaled_max { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in chars.iter_mut().take(scaled_max).skip(scaled_min) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_mach.rs:59:28 [INFO] [stderr] | [INFO] [stderr] 59 | for (i, lc) in lcs.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:143:25 [INFO] [stderr] | [INFO] [stderr] 143 | file.write(bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter() and will not move the Vec [INFO] [stderr] --> src/format_mach.rs:98:52 [INFO] [stderr] | [INFO] [stderr] 98 | for (i, &(ref section, _)) in sections.into_iter().enumerate() { [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/format_mach.rs:106:38 [INFO] [stderr] | [INFO] [stderr] 106 | offsetx_cell(section.offset as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section.offset)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/format_mach.rs:108:38 [INFO] [stderr] | [INFO] [stderr] 108 | offsetx_cell(section.reloff as u64), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `u64::from(section.reloff)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/format_mach.rs:159:29 [INFO] [stderr] | [INFO] [stderr] 159 | / match symbol { [INFO] [stderr] 160 | | &Ok((ref name, _)) => { [INFO] [stderr] 161 | | let name: &str = name; [INFO] [stderr] 162 | | if i == idx { [INFO] [stderr] ... | [INFO] [stderr] 166 | | &Err(_) => () [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 159 | match *symbol { [INFO] [stderr] 160 | Ok((ref name, _)) => { [INFO] [stderr] 161 | let name: &str = name; [INFO] [stderr] 162 | if i == idx { [INFO] [stderr] 163 | maybe_name = Some(name); [INFO] [stderr] 164 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bingrep`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: using `clone` on a `Copy` type [INFO] [stderr] --> src/format_meta.rs:47:29 [INFO] [stderr] | [INFO] [stderr] 47 | let mut chars = SCALE.clone(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: try removing the `clone` call: `SCALE` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::clone_on_copy)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `chars`. [INFO] [stderr] --> src/format_meta.rs:48:22 [INFO] [stderr] | [INFO] [stderr] 48 | for i in scaled_min..scaled_max { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 48 | for in chars.iter_mut().take(scaled_max).skip(scaled_min) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:143:25 [INFO] [stderr] | [INFO] [stderr] 143 | file.write(bytes)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 2 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bingrep`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "31137909fe9aace9fb700501b929f68493052722fbf8ceaf2161817fee40fd40"` [INFO] running `"docker" "rm" "-f" "31137909fe9aace9fb700501b929f68493052722fbf8ceaf2161817fee40fd40"` [INFO] [stdout] 31137909fe9aace9fb700501b929f68493052722fbf8ceaf2161817fee40fd40