[INFO] crate bindiff 0.0.1-pre is already in cache
[INFO] extracting crate bindiff 0.0.1-pre into work/ex/clippy-test-run/sources/stable/reg/bindiff/0.0.1-pre
[INFO] extracting crate bindiff 0.0.1-pre into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bindiff/0.0.1-pre
[INFO] validating manifest of bindiff-0.0.1-pre on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bindiff-0.0.1-pre on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bindiff-0.0.1-pre
[INFO] finished frobbing bindiff-0.0.1-pre
[INFO] frobbed toml for bindiff-0.0.1-pre written to work/ex/clippy-test-run/sources/stable/reg/bindiff/0.0.1-pre/Cargo.toml
[INFO] started frobbing bindiff-0.0.1-pre
[INFO] finished frobbing bindiff-0.0.1-pre
[INFO] frobbed toml for bindiff-0.0.1-pre written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bindiff/0.0.1-pre/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bindiff-0.0.1-pre against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bindiff/0.0.1-pre:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 554019d7bff0de76d416491d50d9d270d8c09417a6411ae9732d76e5c94fe7a8
[INFO] running `"docker" "start" "-a" "554019d7bff0de76d416491d50d9d270d8c09417a6411ae9732d76e5c94fe7a8"`
[INFO] [stderr]     Checking goblin v0.0.12
[INFO] [stderr]     Checking bindiff v0.0.1-pre (/opt/crater/workdir)
[INFO] [stderr] warning: field is never used: `buf`
[INFO] [stderr]   --> src/elf.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     buf: &'a [u8],
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/elf.rs:96:5
[INFO] [stderr]     |
[INFO] [stderr] 96  | /     let mut ret = Ok(());
[INFO] [stderr] 97  | |
[INFO] [stderr] 98  | |     // diff the ELF header
[INFO] [stderr] 99  | |     if file1.elf.header != file2.elf.header {
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |         ret = Err(err_msg("files differ"));
[INFO] [stderr] 103 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> ret = if file1.elf.header != file2.elf.header { ..; Err(err_msg("files differ")) } else { Ok(()) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr] warning: field is never used: `buf`
[INFO] [stderr]   --> src/elf.rs:18:5
[INFO] [stderr]    |
[INFO] [stderr] 18 |     buf: &'a [u8],
[INFO] [stderr]    |     ^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression
[INFO] [stderr]    --> src/elf.rs:96:5
[INFO] [stderr]     |
[INFO] [stderr] 96  | /     let mut ret = Ok(());
[INFO] [stderr] 97  | |
[INFO] [stderr] 98  | |     // diff the ELF header
[INFO] [stderr] 99  | |     if file1.elf.header != file2.elf.header {
[INFO] [stderr] ...   |
[INFO] [stderr] 102 | |         ret = Err(err_msg("files differ"));
[INFO] [stderr] 103 | |     }
[INFO] [stderr]     | |_____^ help: it is more idiomatic to write: `let <mut> ret = if file1.elf.header != file2.elf.header { ..; Err(err_msg("files differ")) } else { Ok(()) };`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::useless_let_if_seq)] on by default
[INFO] [stderr]     = note: you might not need `mut` at all
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 12.58s
[INFO] running `"docker" "inspect" "554019d7bff0de76d416491d50d9d270d8c09417a6411ae9732d76e5c94fe7a8"`
[INFO] running `"docker" "rm" "-f" "554019d7bff0de76d416491d50d9d270d8c09417a6411ae9732d76e5c94fe7a8"`
[INFO] [stdout] 554019d7bff0de76d416491d50d9d270d8c09417a6411ae9732d76e5c94fe7a8