[INFO] crate binary_tuples 0.1.1 is already in cache [INFO] extracting crate binary_tuples 0.1.1 into work/ex/clippy-test-run/sources/stable/reg/binary_tuples/0.1.1 [INFO] extracting crate binary_tuples 0.1.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binary_tuples/0.1.1 [INFO] validating manifest of binary_tuples-0.1.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of binary_tuples-0.1.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing binary_tuples-0.1.1 [INFO] finished frobbing binary_tuples-0.1.1 [INFO] frobbed toml for binary_tuples-0.1.1 written to work/ex/clippy-test-run/sources/stable/reg/binary_tuples/0.1.1/Cargo.toml [INFO] started frobbing binary_tuples-0.1.1 [INFO] finished frobbing binary_tuples-0.1.1 [INFO] frobbed toml for binary_tuples-0.1.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binary_tuples/0.1.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting binary_tuples-0.1.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/binary_tuples/0.1.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] cadcce35feb5ca6bbeaffc3f7bc741fc7b09441a20fb6d32f410bd006dd511d9 [INFO] running `"docker" "start" "-a" "cadcce35feb5ca6bbeaffc3f7bc741fc7b09441a20fb6d32f410bd006dd511d9"` [INFO] [stderr] Checking binary_tuples v0.1.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/segment.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | return Ok((segments, index)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((segments, index))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 12 | | if vals[0] == 0 { [INFO] [stderr] 13 | | read += 1; [INFO] [stderr] 14 | | if vals[1] != 0xFF { [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 11 | } else if vals[0] == 0 { [INFO] [stderr] 12 | read += 1; [INFO] [stderr] 13 | if vals[1] != 0xFF { [INFO] [stderr] 14 | return (read, bytes) [INFO] [stderr] 15 | } else { [INFO] [stderr] 16 | bytes.push(vals[0]); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/segment.rs:264:9 [INFO] [stderr] | [INFO] [stderr] 264 | return Ok((segments, index)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok((segments, index))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/segment.rs:293:9 [INFO] [stderr] | [INFO] [stderr] 293 | value [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/segment.rs:292:21 [INFO] [stderr] | [INFO] [stderr] 292 | let value = result.drain(0..1).next().unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/segment.rs:586:43 [INFO] [stderr] | [INFO] [stderr] 586 | assert_eq!(result, Segment::Float(1.0039063)); [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.003_906_3` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/segment.rs:607:44 [INFO] [stderr] | [INFO] [stderr] 607 | assert_eq!(result, Segment::Double(1.05859375)); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1.058_593_75` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/segment.rs:621:44 [INFO] [stderr] | [INFO] [stderr] 621 | assert_eq!(result, Segment::Double(31610.716851562498)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `31_610.716_851_562_498` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/utils.rs:11:16 [INFO] [stderr] | [INFO] [stderr] 11 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 12 | | if vals[0] == 0 { [INFO] [stderr] 13 | | read += 1; [INFO] [stderr] 14 | | if vals[1] != 0xFF { [INFO] [stderr] ... | [INFO] [stderr] 23 | | } [INFO] [stderr] 24 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 11 | } else if vals[0] == 0 { [INFO] [stderr] 12 | read += 1; [INFO] [stderr] 13 | if vals[1] != 0xFF { [INFO] [stderr] 14 | return (read, bytes) [INFO] [stderr] 15 | } else { [INFO] [stderr] 16 | bytes.push(vals[0]); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/segment.rs:240:40 [INFO] [stderr] | [INFO] [stderr] 240 | Ok(uuid) => Ok(segments.push(Segment::UUID(uuid))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 240 | Ok(uuid) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/constants.rs:22:11 [INFO] [stderr] | [INFO] [stderr] 22 | (1 << (1 * 8)) - 1, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/utils.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 35 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`. [INFO] [stderr] --> src/utils.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`. [INFO] [stderr] --> src/utils.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 62 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Tuple` [INFO] [stderr] --> src/lib.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Tuple { [INFO] [stderr] 22 | | Tuple { [INFO] [stderr] 23 | | buffer: Vec::with_capacity(128) [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/segment.rs:240:40 [INFO] [stderr] | [INFO] [stderr] 240 | Ok(uuid) => Ok(segments.push(Segment::UUID(uuid))), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] help: if you intended to pass a unit value, use a unit literal instead [INFO] [stderr] | [INFO] [stderr] 240 | Ok(uuid) => Ok(()), [INFO] [stderr] | ^^ [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:542:29 [INFO] [stderr] | [INFO] [stderr] 542 | let result = decode(&vec![STRING_CODE, 119, 111, 119, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[STRING_CODE, 119, 111, 119, 0]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_vec)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:549:29 [INFO] [stderr] | [INFO] [stderr] 549 | let result = decode(&vec![STRING_CODE, 119, 111, 119, 0, 255, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[STRING_CODE, 119, 111, 119, 0, 255, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:556:29 [INFO] [stderr] | [INFO] [stderr] 556 | let result = decode(&vec![STRING_CODE, 0, 255, 119, 0, 255, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[STRING_CODE, 0, 255, 119, 0, 255, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:563:29 [INFO] [stderr] | [INFO] [stderr] 563 | let result = decode(&vec![BYTES_CODE, 1, 2, 3, 4, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[BYTES_CODE, 1, 2, 3, 4, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:570:29 [INFO] [stderr] | [INFO] [stderr] 570 | let result = decode(&vec![BYTES_CODE, 1, 2, 0, 255, 3, 4, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[BYTES_CODE, 1, 2, 0, 255, 3, 4, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:577:29 [INFO] [stderr] | [INFO] [stderr] 577 | let result = decode(&vec![INT_ZERO_CODE]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:584:29 [INFO] [stderr] | [INFO] [stderr] 584 | let result = decode(&vec![FLOAT_CODE, 191, 128, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[FLOAT_CODE, 191, 128, 0, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:591:29 [INFO] [stderr] | [INFO] [stderr] 591 | let result = decode(&vec![FLOAT_CODE, 192, 0, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[FLOAT_CODE, 192, 0, 0, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:598:29 [INFO] [stderr] | [INFO] [stderr] 598 | let result = decode(&vec![FLOAT_CODE, 198, 245, 111, 7]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[FLOAT_CODE, 198, 245, 111, 7]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:605:29 [INFO] [stderr] | [INFO] [stderr] 605 | let result = decode(&vec![DOUBLE_CODE, 191, 240, 0, 0, 0, 0, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[DOUBLE_CODE, 191, 240, 0, 0, 0, 0, 0, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:612:29 [INFO] [stderr] | [INFO] [stderr] 612 | let result = decode(&vec![DOUBLE_CODE, 192, 0, 0, 0, 0, 0, 0, 0]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[DOUBLE_CODE, 192, 0, 0, 0, 0, 0, 0, 0]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:619:29 [INFO] [stderr] | [INFO] [stderr] 619 | let result = decode(&vec![DOUBLE_CODE, 192, 222, 173, 224, 229, 96, 65, 137]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[DOUBLE_CODE, 192, 222, 173, 224, 229, 96, 65, 137]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:626:29 [INFO] [stderr] | [INFO] [stderr] 626 | let result = decode(&vec![INT_ZERO_CODE + 1, 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE + 1, 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:633:29 [INFO] [stderr] | [INFO] [stderr] 633 | let result = decode(&vec![INT_ZERO_CODE + 2, 19, 136]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE + 2, 19, 136]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:640:29 [INFO] [stderr] | [INFO] [stderr] 640 | let result = decode(&vec![INT_ZERO_CODE + 2, 1, 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE + 2, 1, 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:647:29 [INFO] [stderr] | [INFO] [stderr] 647 | let result = decode(&vec![INT_ZERO_CODE - 1, 254]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE - 1, 254]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:654:29 [INFO] [stderr] | [INFO] [stderr] 654 | let result = decode(&vec![INT_ZERO_CODE - 1, 1]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE - 1, 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:661:38 [INFO] [stderr] | [INFO] [stderr] 661 | let result = Segment::decode(&vec![INT_ZERO_CODE - 1]).unwrap_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE - 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:668:38 [INFO] [stderr] | [INFO] [stderr] 668 | let result = Segment::decode(&vec![INT_ZERO_CODE + 1]).unwrap_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE + 1]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:675:38 [INFO] [stderr] | [INFO] [stderr] 675 | let result = Segment::decode(&vec![FLOAT_CODE]).unwrap_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[FLOAT_CODE]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:682:38 [INFO] [stderr] | [INFO] [stderr] 682 | let result = Segment::decode(&vec![DOUBLE_CODE]).unwrap_err(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[DOUBLE_CODE]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:689:29 [INFO] [stderr] | [INFO] [stderr] 689 | let result = decode(&vec![INT_ZERO_CODE + 8, 127, 255, 255, 255, 255, 255, 255, 255]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE + 8, 127, 255, 255, 255, 255, 255, 255, 255]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:696:29 [INFO] [stderr] | [INFO] [stderr] 696 | let result = decode(&vec![INT_ZERO_CODE - 8, 127, 255, 255, 255, 255, 255, 255, 255]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE - 8, 127, 255, 255, 255, 255, 255, 255, 255]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:703:29 [INFO] [stderr] | [INFO] [stderr] 703 | let result = decode(&vec![INT_ZERO_CODE - 2, 254, 255]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[INT_ZERO_CODE - 2, 254, 255]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:724:29 [INFO] [stderr] | [INFO] [stderr] 724 | let result = decode(&vec![TRUE_CODE]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[TRUE_CODE]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:731:29 [INFO] [stderr] | [INFO] [stderr] 731 | let result = decode(&vec![FALSE_CODE]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[FALSE_CODE]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:777:29 [INFO] [stderr] | [INFO] [stderr] 777 | let result = decode(&vec![NESTED_CODE, STRING_CODE, 72, 101, 108, 108, 111, NULL, TRUE_CODE, NULL]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[NESTED_CODE, STRING_CODE, 72, 101, 108, 108, 111, NULL, TRUE_CODE, NULL]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: useless use of `vec!` [INFO] [stderr] --> src/segment.rs:784:30 [INFO] [stderr] | [INFO] [stderr] 784 | let builder = decode(&vec![NESTED_CODE, NESTED_CODE, TRUE_CODE, STRING_CODE, 72, 101, 108, 108, 111, NULL, NULL, INT_ZERO_CODE + 2, 19, 136, NULL]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use a slice directly: `&[NESTED_CODE, NESTED_CODE, TRUE_CODE, STRING_CODE, 72, 101, 108, 108, 111, NULL, NULL, INT_ZERO_CODE + 2, 19, 136, NULL]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `8` [INFO] [stderr] --> src/constants.rs:22:11 [INFO] [stderr] | [INFO] [stderr] 22 | (1 << (1 * 8)) - 1, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `input`. [INFO] [stderr] --> src/utils.rs:35:14 [INFO] [stderr] | [INFO] [stderr] 35 | for i in 0..input.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 35 | for in &input { [INFO] [stderr] | ^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`. [INFO] [stderr] --> src/utils.rs:52:18 [INFO] [stderr] | [INFO] [stderr] 52 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 52 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `bytes`. [INFO] [stderr] --> src/utils.rs:62:18 [INFO] [stderr] | [INFO] [stderr] 62 | for i in 0..bytes.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 62 | for in &mut bytes { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `Tuple` [INFO] [stderr] --> src/lib.rs:21:5 [INFO] [stderr] | [INFO] [stderr] 21 | / pub fn new() -> Tuple { [INFO] [stderr] 22 | | Tuple { [INFO] [stderr] 23 | | buffer: Vec::with_capacity(128) [INFO] [stderr] 24 | | } [INFO] [stderr] 25 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 15 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.88s [INFO] running `"docker" "inspect" "cadcce35feb5ca6bbeaffc3f7bc741fc7b09441a20fb6d32f410bd006dd511d9"` [INFO] running `"docker" "rm" "-f" "cadcce35feb5ca6bbeaffc3f7bc741fc7b09441a20fb6d32f410bd006dd511d9"` [INFO] [stdout] cadcce35feb5ca6bbeaffc3f7bc741fc7b09441a20fb6d32f410bd006dd511d9