[INFO] crate binary-tree 0.2.0 is already in cache [INFO] extracting crate binary-tree 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/binary-tree/0.2.0 [INFO] extracting crate binary-tree 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binary-tree/0.2.0 [INFO] validating manifest of binary-tree-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of binary-tree-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing binary-tree-0.2.0 [INFO] finished frobbing binary-tree-0.2.0 [INFO] frobbed toml for binary-tree-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/binary-tree/0.2.0/Cargo.toml [INFO] started frobbing binary-tree-0.2.0 [INFO] finished frobbing binary-tree-0.2.0 [INFO] frobbed toml for binary-tree-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binary-tree/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting binary-tree-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/binary-tree/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c4fae1c17e31eea6f8e09a0279eac9c0fcf9bd5a408976ab8c77ea0301ba8f57 [INFO] running `"docker" "start" "-a" "c4fae1c17e31eea6f8e09a0279eac9c0fcf9bd5a408976ab8c77ea0301ba8f57"` [INFO] [stderr] Checking binary-tree v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/count.rs:573:13 [INFO] [stderr] | [INFO] [stderr] 573 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/count.rs:573:13 [INFO] [stderr] | [INFO] [stderr] 573 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/test.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | val: val, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/test.rs:217:21 [INFO] [stderr] | [INFO] [stderr] 217 | for _ in 0..200000 { [INFO] [stderr] | ^^^^^^ help: consider: `200_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `count::CountTree` [INFO] [stderr] --> src/count.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / pub fn new() -> CountTree { [INFO] [stderr] 187 | | CountTree(None) [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/count.rs:591:46 [INFO] [stderr] | [INFO] [stderr] 591 | self.left.as_ref().map_or(-1, |node| node.height as i32) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(node.height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/count.rs:592:51 [INFO] [stderr] | [INFO] [stderr] 592 | self.right.as_ref().map_or(-1, |node| node.height as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(node.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/count.rs:598:13 [INFO] [stderr] | [INFO] [stderr] 598 | self.left.as_mut().map(|node| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 599 | || if node.balance_factor() < 0 { [INFO] [stderr] 600 | || node.rotate_left().unwrap(); [INFO] [stderr] 601 | || } [INFO] [stderr] 602 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.left.as_mut() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/count.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | self.right.as_mut().map(|node| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 606 | || if node.balance_factor() > 0 { [INFO] [stderr] 607 | || node.rotate_right().unwrap(); [INFO] [stderr] 608 | || } [INFO] [stderr] 609 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.right.as_mut() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / unsafe fn borrow<'a, T, U>(raw: *const T, _: &'a U) -> &'a T { [INFO] [stderr] 28 | | &*raw [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:31:58 [INFO] [stderr] | [INFO] [stderr] 31 | unsafe fn borrow_mut<'a, T, U>(raw: *mut T, _: &'a U) -> &'a mut T { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:31:48 [INFO] [stderr] | [INFO] [stderr] 31 | unsafe fn borrow_mut<'a, T, U>(raw: *mut T, _: &'a U) -> &'a mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / unsafe fn borrow_mut<'a, T, U>(raw: *mut T, _: &'a U) -> &'a mut T { [INFO] [stderr] 32 | | &mut *raw [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let pin =` [INFO] [stderr] --> src/lib.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | let pin = (); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `binary-tree`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `count::CountTree` [INFO] [stderr] --> src/count.rs:186:5 [INFO] [stderr] | [INFO] [stderr] 186 | / pub fn new() -> CountTree { [INFO] [stderr] 187 | | CountTree(None) [INFO] [stderr] 188 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 178 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/count.rs:591:46 [INFO] [stderr] | [INFO] [stderr] 591 | self.left.as_ref().map_or(-1, |node| node.height as i32) - [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(node.height)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to i32 may become silently lossy if types change [INFO] [stderr] --> src/count.rs:592:51 [INFO] [stderr] | [INFO] [stderr] 592 | self.right.as_ref().map_or(-1, |node| node.height as i32) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: try: `i32::from(node.height)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/count.rs:598:13 [INFO] [stderr] | [INFO] [stderr] 598 | self.left.as_mut().map(|node| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 599 | || if node.balance_factor() < 0 { [INFO] [stderr] 600 | || node.rotate_left().unwrap(); [INFO] [stderr] 601 | || } [INFO] [stderr] 602 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.left.as_mut() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::option_map_unit_fn)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/count.rs:605:13 [INFO] [stderr] | [INFO] [stderr] 605 | self.right.as_mut().map(|node| { [INFO] [stderr] | _____________^ [INFO] [stderr] | |_____________| [INFO] [stderr] | || [INFO] [stderr] 606 | || if node.balance_factor() > 0 { [INFO] [stderr] 607 | || node.rotate_right().unwrap(); [INFO] [stderr] 608 | || } [INFO] [stderr] 609 | || }); [INFO] [stderr] | ||______________^- help: try this: `if let Some(node) = self.right.as_mut() { ... }` [INFO] [stderr] | |_______________| [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: called `map(f)` on an Option value where `f` is a unit closure [INFO] [stderr] --> src/count.rs:847:9 [INFO] [stderr] | [INFO] [stderr] 847 | ct.get_mut(3).map(|v| *v = 100); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^- [INFO] [stderr] | | [INFO] [stderr] | help: try this: `if let Some(v) = ct.get_mut(3) { ... }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_unit_fn [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / unsafe fn borrow<'a, T, U>(raw: *const T, _: &'a U) -> &'a T { [INFO] [stderr] 28 | | &*raw [INFO] [stderr] 29 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] error: mutable borrow from immutable input(s) [INFO] [stderr] --> src/lib.rs:31:58 [INFO] [stderr] | [INFO] [stderr] 31 | unsafe fn borrow_mut<'a, T, U>(raw: *mut T, _: &'a U) -> &'a mut T { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::mut_from_ref)] on by default [INFO] [stderr] note: immutable borrow here [INFO] [stderr] --> src/lib.rs:31:48 [INFO] [stderr] | [INFO] [stderr] 31 | unsafe fn borrow_mut<'a, T, U>(raw: *mut T, _: &'a U) -> &'a mut T { [INFO] [stderr] | ^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mut_from_ref [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:31:1 [INFO] [stderr] | [INFO] [stderr] 31 | / unsafe fn borrow_mut<'a, T, U>(raw: *mut T, _: &'a U) -> &'a mut T { [INFO] [stderr] 32 | | &mut *raw [INFO] [stderr] 33 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let pin =` [INFO] [stderr] --> src/lib.rs:135:17 [INFO] [stderr] | [INFO] [stderr] 135 | let pin = (); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `binary-tree`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "c4fae1c17e31eea6f8e09a0279eac9c0fcf9bd5a408976ab8c77ea0301ba8f57"` [INFO] running `"docker" "rm" "-f" "c4fae1c17e31eea6f8e09a0279eac9c0fcf9bd5a408976ab8c77ea0301ba8f57"` [INFO] [stdout] c4fae1c17e31eea6f8e09a0279eac9c0fcf9bd5a408976ab8c77ea0301ba8f57