[INFO] crate binance-async 0.2.0 is already in cache [INFO] extracting crate binance-async 0.2.0 into work/ex/clippy-test-run/sources/stable/reg/binance-async/0.2.0 [INFO] extracting crate binance-async 0.2.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binance-async/0.2.0 [INFO] validating manifest of binance-async-0.2.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of binance-async-0.2.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing binance-async-0.2.0 [INFO] finished frobbing binance-async-0.2.0 [INFO] frobbed toml for binance-async-0.2.0 written to work/ex/clippy-test-run/sources/stable/reg/binance-async/0.2.0/Cargo.toml [INFO] started frobbing binance-async-0.2.0 [INFO] finished frobbing binance-async-0.2.0 [INFO] frobbed toml for binance-async-0.2.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/binance-async/0.2.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting binance-async-0.2.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/binance-async/0.2.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] b6bbb6a3448262c80ca7eea34e615a2e383ee12e470ae11d3e61b4bdac0b2212 [INFO] running `"docker" "start" "-a" "b6bbb6a3448262c80ca7eea34e615a2e383ee12e470ae11d3e61b4bdac0b2212"` [INFO] [stderr] Checking min_max_macros v0.1.1 [INFO] [stderr] Checking vec_box v1.0.0 [INFO] [stderr] Checking tokio-dns-unofficial v0.3.1 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking sugar v0.2.0 [INFO] [stderr] Checking tokio-tungstenite v0.6.0 [INFO] [stderr] Checking binance-async v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/account.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/account.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/account.rs:73:13 [INFO] [stderr] | [INFO] [stderr] 73 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client/account.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | price: price, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `price` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/transport.rs:45:13 [INFO] [stderr] | [INFO] [stderr] 45 | client: client, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `client` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/websocket.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | const WS_URL: &'static str = "wss://stream.binance.com:9443/ws"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/transport.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/transport.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | let s = vec.into_iter().map(|(k, v)| format!("{}={}", k, v)).collect::>().join("&"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/client/websocket.rs:16:16 [INFO] [stderr] | [INFO] [stderr] 16 | const WS_URL: &'static str = "wss://stream.binance.com:9443/ws"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/transport.rs:219:9 [INFO] [stderr] | [INFO] [stderr] 219 | s [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/transport.rs:218:17 [INFO] [stderr] | [INFO] [stderr] 218 | let s = vec.into_iter().map(|(k, v)| format!("{}={}", k, v)).collect::>().join("&"); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client/account.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | qty: qty.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `qty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client/account.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | qty: qty.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `qty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client/account.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | qty: qty.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `qty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client/account.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | qty: qty.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `qty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::Binance` [INFO] [stderr] --> src/client/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Binance { transport: Transport::new() } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for client::Binance { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/error.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn to_result(self) -> StdResult { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/model/websocket.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Candlestick(CandelStickMessage), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 24 | Candlestick(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client/account.rs:72:18 [INFO] [stderr] | [INFO] [stderr] 72 | qty: qty.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `qty` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client/account.rs:89:18 [INFO] [stderr] | [INFO] [stderr] 89 | qty: qty.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `qty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client/account.rs:105:18 [INFO] [stderr] | [INFO] [stderr] 105 | qty: qty.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `qty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/client/account.rs:121:18 [INFO] [stderr] | [INFO] [stderr] 121 | qty: qty.into(), [INFO] [stderr] | ^^^^^^^^^^ help: consider removing `.into()`: `qty` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `client::Binance` [INFO] [stderr] --> src/client/mod.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | / pub fn new() -> Self { [INFO] [stderr] 16 | | Binance { transport: Transport::new() } [INFO] [stderr] 17 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | impl Default for client::Binance { [INFO] [stderr] 15 | fn default() -> Self { [INFO] [stderr] 16 | Self::new() [INFO] [stderr] 17 | } [INFO] [stderr] 18 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/error.rs:23:22 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn to_result(self) -> StdResult { [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: large size difference between variants [INFO] [stderr] --> src/model/websocket.rs:24:5 [INFO] [stderr] | [INFO] [stderr] 24 | Candlestick(CandelStickMessage), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::large_enum_variant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stderr] help: consider boxing the large fields to reduce the total size of the enum [INFO] [stderr] | [INFO] [stderr] 24 | Candlestick(Box), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `transport::Transport` [INFO] [stderr] --> src/transport.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | let https = HttpsConnector::new(4).unwrap(); [INFO] [stderr] 31 | | let client = Client::builder().build::<_, Body>(https); [INFO] [stderr] 32 | | [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for transport::Transport { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/transport.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | None => format!("{}", body), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `body.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: this .into_iter() call is equivalent to .iter_mut() and will not move the array [INFO] [stderr] --> src/transport.rs:338:27 [INFO] [stderr] | [INFO] [stderr] 338 | let q: Vec<_> = q.into_iter().map(|(k, v)| format!("{}={}", k, v)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::into_iter_on_array)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_array [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `binance-async`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: you should consider adding a `Default` implementation for `transport::Transport` [INFO] [stderr] --> src/transport.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | / pub fn new() -> Self { [INFO] [stderr] 30 | | let https = HttpsConnector::new(4).unwrap(); [INFO] [stderr] 31 | | let client = Client::builder().build::<_, Body>(https); [INFO] [stderr] 32 | | [INFO] [stderr] ... | [INFO] [stderr] 37 | | } [INFO] [stderr] 38 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 28 | impl Default for transport::Transport { [INFO] [stderr] 29 | fn default() -> Self { [INFO] [stderr] 30 | Self::new() [INFO] [stderr] 31 | } [INFO] [stderr] 32 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/transport.rs:195:21 [INFO] [stderr] | [INFO] [stderr] 195 | None => format!("{}", body), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `body.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "b6bbb6a3448262c80ca7eea34e615a2e383ee12e470ae11d3e61b4bdac0b2212"` [INFO] running `"docker" "rm" "-f" "b6bbb6a3448262c80ca7eea34e615a2e383ee12e470ae11d3e61b4bdac0b2212"` [INFO] [stdout] b6bbb6a3448262c80ca7eea34e615a2e383ee12e470ae11d3e61b4bdac0b2212