[INFO] crate bimap 0.1.5 is already in cache [INFO] extracting crate bimap 0.1.5 into work/ex/clippy-test-run/sources/stable/reg/bimap/0.1.5 [INFO] extracting crate bimap 0.1.5 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bimap/0.1.5 [INFO] validating manifest of bimap-0.1.5 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bimap-0.1.5 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bimap-0.1.5 [INFO] finished frobbing bimap-0.1.5 [INFO] frobbed toml for bimap-0.1.5 written to work/ex/clippy-test-run/sources/stable/reg/bimap/0.1.5/Cargo.toml [INFO] started frobbing bimap-0.1.5 [INFO] finished frobbing bimap-0.1.5 [INFO] frobbed toml for bimap-0.1.5 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bimap/0.1.5/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bimap-0.1.5 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bimap/0.1.5:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f9b4c62cc4cc7f1e85ca9231d4a197d8273e8d17cad36b121a4f01bc19e79be3 [INFO] running `"docker" "start" "-a" "f9b4c62cc4cc7f1e85ca9231d4a197d8273e8d17cad36b121a4f01bc19e79be3"` [INFO] [stderr] Checking bimap v0.1.5 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match self { [INFO] [stderr] 180 | | &Overwritten::Neither => false, [INFO] [stderr] 181 | | _ => true, [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *self { [INFO] [stderr] 180 | Overwritten::Neither => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | / pub fn iter<'a>(&'a self) -> Iter<'a, L, R> { [INFO] [stderr] 319 | | Iter { inner: self.left2right.iter() } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | / pub fn left_values<'a>(&'a self) -> LeftValues<'a, L, R> { [INFO] [stderr] 341 | | LeftValues { inner: self.left2right.iter() } [INFO] [stderr] 342 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn right_values<'a>(&'a self) -> RightValues<'a, L, R> { [INFO] [stderr] 363 | | RightValues { inner: self.left2right.iter() } [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | / match self { [INFO] [stderr] 180 | | &Overwritten::Neither => false, [INFO] [stderr] 181 | | _ => true, [INFO] [stderr] 182 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 179 | match *self { [INFO] [stderr] 180 | Overwritten::Neither => false, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:318:5 [INFO] [stderr] | [INFO] [stderr] 318 | / pub fn iter<'a>(&'a self) -> Iter<'a, L, R> { [INFO] [stderr] 319 | | Iter { inner: self.left2right.iter() } [INFO] [stderr] 320 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:340:5 [INFO] [stderr] | [INFO] [stderr] 340 | / pub fn left_values<'a>(&'a self) -> LeftValues<'a, L, R> { [INFO] [stderr] 341 | | LeftValues { inner: self.left2right.iter() } [INFO] [stderr] 342 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lib.rs:362:5 [INFO] [stderr] | [INFO] [stderr] 362 | / pub fn right_values<'a>(&'a self) -> RightValues<'a, L, R> { [INFO] [stderr] 363 | | RightValues { inner: self.left2right.iter() } [INFO] [stderr] 364 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.79s [INFO] running `"docker" "inspect" "f9b4c62cc4cc7f1e85ca9231d4a197d8273e8d17cad36b121a4f01bc19e79be3"` [INFO] running `"docker" "rm" "-f" "f9b4c62cc4cc7f1e85ca9231d4a197d8273e8d17cad36b121a4f01bc19e79be3"` [INFO] [stdout] f9b4c62cc4cc7f1e85ca9231d4a197d8273e8d17cad36b121a4f01bc19e79be3