[INFO] crate bill 0.3.0 is already in cache [INFO] extracting crate bill 0.3.0 into work/ex/clippy-test-run/sources/stable/reg/bill/0.3.0 [INFO] extracting crate bill 0.3.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bill/0.3.0 [INFO] validating manifest of bill-0.3.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bill-0.3.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bill-0.3.0 [INFO] finished frobbing bill-0.3.0 [INFO] frobbed toml for bill-0.3.0 written to work/ex/clippy-test-run/sources/stable/reg/bill/0.3.0/Cargo.toml [INFO] started frobbing bill-0.3.0 [INFO] finished frobbing bill-0.3.0 [INFO] frobbed toml for bill-0.3.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bill/0.3.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bill-0.3.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bill/0.3.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 32da00c06f572982bc01853f6da3aab4aa174315ddec2dd3aa4b7cb4462db874 [INFO] running `"docker" "start" "-a" "32da00c06f572982bc01853f6da3aab4aa174315ddec2dd3aa4b7cb4462db874"` [INFO] [stderr] Checking claude v0.3.0 [INFO] [stderr] Checking bill v0.3.0 (/opt/crater/workdir) [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `itemlist::ItemList

` [INFO] [stderr] --> src/itemlist.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | ItemList { items: Vec::new() } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tax.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn value(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `itemlist::ItemList

` [INFO] [stderr] --> src/itemlist.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | ItemList { items: Vec::new() } [INFO] [stderr] 18 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/tax.rs:20:18 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn value(&self) -> f64 { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `self` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:34:49 [INFO] [stderr] | [INFO] [stderr] 34 | let coffee = Product::new("Coffee", c(0250), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::zero_prefixed_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 34 | let coffee = Product::new("Coffee", c(250), 0.19); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 34 | let coffee = Product::new("Coffee", c(0o250), 0.19); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:35:46 [INFO] [stderr] | [INFO] [stderr] 35 | let tee = Product::new("Tea", c(0175), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 35 | let tee = Product::new("Tea", c(175), 0.19); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 35 | let tee = Product::new("Tea", c(0o175), 0.19); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:36:48 [INFO] [stderr] | [INFO] [stderr] 36 | let water = Product::new("Water", c(0061), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 36 | let water = Product::new("Water", c(61), 0.19); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 36 | let water = Product::new("Water", c(0o61), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:37:53 [INFO] [stderr] | [INFO] [stderr] 37 | let applejuice = Product::new("AppleJuice", c(0164), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 37 | let applejuice = Product::new("AppleJuice", c(164), 0.19); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 37 | let applejuice = Product::new("AppleJuice", c(0o164), 0.19); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:38:54 [INFO] [stderr] | [INFO] [stderr] 38 | let orangejuice = Product::new("OrangeJuice", c(0186), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 38 | let orangejuice = Product::new("OrangeJuice", c(186), 0.19); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 38 | let orangejuice = Product::new("OrangeJuice", c(0o186), 0.19); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:39:48 [INFO] [stderr] | [INFO] [stderr] 39 | let bagel = Product::new("Bagel", c(0219), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 39 | let bagel = Product::new("Bagel", c(219), 0.19); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 39 | let bagel = Product::new("Bagel", c(0o219), 0.19); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:40:51 [INFO] [stderr] | [INFO] [stderr] 40 | let sandwich = Product::new("Sandwich", c(0340), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 40 | let sandwich = Product::new("Sandwich", c(340), 0.19); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 40 | let sandwich = Product::new("Sandwich", c(0o340), 0.19); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:41:46 [INFO] [stderr] | [INFO] [stderr] 41 | let pie = Product::new("pie", c(0094), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 41 | let pie = Product::new("pie", c(94), 0.19); [INFO] [stderr] | ^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 41 | let pie = Product::new("pie", c(0o94), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:42:47 [INFO] [stderr] | [INFO] [stderr] 42 | let soup = Product::new("Soup", c(0310), 0.19); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 42 | let soup = Product::new("Soup", c(310), 0.19); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 42 | let soup = Product::new("Soup", c(0o310), 0.19); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this is a decimal constant [INFO] [stderr] --> examples/catalogue.rs:43:50 [INFO] [stderr] | [INFO] [stderr] 43 | let service = Product::new("Service", c(0800), 0.00); [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_prefixed_literal [INFO] [stderr] help: if you mean to use a decimal constant, remove the `0` to remove confusion [INFO] [stderr] | [INFO] [stderr] 43 | let service = Product::new("Service", c(800), 0.00); [INFO] [stderr] | ^^^ [INFO] [stderr] help: if you mean to use an octal constant, use `0o` [INFO] [stderr] | [INFO] [stderr] 43 | let service = Product::new("Service", c(0o800), 0.00); [INFO] [stderr] | ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.48s [INFO] running `"docker" "inspect" "32da00c06f572982bc01853f6da3aab4aa174315ddec2dd3aa4b7cb4462db874"` [INFO] running `"docker" "rm" "-f" "32da00c06f572982bc01853f6da3aab4aa174315ddec2dd3aa4b7cb4462db874"` [INFO] [stdout] 32da00c06f572982bc01853f6da3aab4aa174315ddec2dd3aa4b7cb4462db874