[INFO] crate bigdecimal 0.0.14 is already in cache [INFO] extracting crate bigdecimal 0.0.14 into work/ex/clippy-test-run/sources/stable/reg/bigdecimal/0.0.14 [INFO] extracting crate bigdecimal 0.0.14 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bigdecimal/0.0.14 [INFO] validating manifest of bigdecimal-0.0.14 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bigdecimal-0.0.14 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bigdecimal-0.0.14 [INFO] finished frobbing bigdecimal-0.0.14 [INFO] frobbed toml for bigdecimal-0.0.14 written to work/ex/clippy-test-run/sources/stable/reg/bigdecimal/0.0.14/Cargo.toml [INFO] started frobbing bigdecimal-0.0.14 [INFO] finished frobbing bigdecimal-0.0.14 [INFO] frobbed toml for bigdecimal-0.0.14 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bigdecimal/0.0.14/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bigdecimal-0.0.14 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bigdecimal/0.0.14:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] ec4a9d347440570b88c84f96fcf991797aae71e3faa683b774d58df175e2df53 [INFO] running `"docker" "start" "-a" "ec4a9d347440570b88c84f96fcf991797aae71e3faa683b774d58df175e2df53"` [INFO] [stderr] Checking bigdecimal v0.0.14 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:955:13 [INFO] [stderr] | [INFO] [stderr] 955 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1000:17 [INFO] [stderr] | [INFO] [stderr] 1000 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1026:17 [INFO] [stderr] | [INFO] [stderr] 1026 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1059:17 [INFO] [stderr] | [INFO] [stderr] 1059 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1379:13 [INFO] [stderr] | [INFO] [stderr] 1379 | int_val: int_val, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `int_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1380:13 [INFO] [stderr] | [INFO] [stderr] 1380 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/lib.rs:1621:1 [INFO] [stderr] | [INFO] [stderr] 1621 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:151:13 [INFO] [stderr] | [INFO] [stderr] 151 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:955:13 [INFO] [stderr] | [INFO] [stderr] 955 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1000:17 [INFO] [stderr] | [INFO] [stderr] 1000 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1026:17 [INFO] [stderr] | [INFO] [stderr] 1026 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1059:17 [INFO] [stderr] | [INFO] [stderr] 1059 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1379:13 [INFO] [stderr] | [INFO] [stderr] 1379 | int_val: int_val, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `int_val` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:1380:13 [INFO] [stderr] | [INFO] [stderr] 1380 | scale: scale, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `scale` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool_attributes [INFO] [stderr] --> src/lib.rs:1621:1 [INFO] [stderr] | [INFO] [stderr] 1621 | #[cfg_attr(rustfmt, rustfmt_skip)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deprecated_cfg_attr)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:92:43 [INFO] [stderr] | [INFO] [stderr] 92 | let mut digits = (int.bits() as f64 / 3.3219280949) as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `3.321_928_094_9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:114:39 [INFO] [stderr] | [INFO] [stderr] 114 | let digits = (num.bits() as f64 / 3.3219280949) as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `3.321_928_094_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:384:27 [INFO] [stderr] | [INFO] [stderr] 384 | let log2_10 = 3.32192809488736234787031942948939018_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.321_928_094_887_362_347_870_319_429_489_390_18_f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:385:37 [INFO] [stderr] | [INFO] [stderr] 385 | let magic_guess_scale = 1.1951678538495576_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.195_167_853_849_557_6_f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:458:27 [INFO] [stderr] | [INFO] [stderr] 458 | let log2_10 = 3.32192809488736234787031942948939018_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.321_928_094_887_362_347_870_319_429_489_390_18_f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:459:37 [INFO] [stderr] | [INFO] [stderr] 459 | let magic_guess_scale = 1.124960491619939_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.124_960_491_619_939_f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:546:9 [INFO] [stderr] | [INFO] [stderr] 546 | return result.with_prec(100); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.with_prec(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:981:5 [INFO] [stderr] | [INFO] [stderr] 981 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1006:9 [INFO] [stderr] | [INFO] [stderr] 1006 | return impl_division(self.int_val, &other.int_val, scale, max_precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `impl_division(self.int_val, &other.int_val, scale, max_precision)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1032:9 [INFO] [stderr] | [INFO] [stderr] 1032 | return impl_division(self.int_val, &other.int_val, scale, max_precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `impl_division(self.int_val, &other.int_val, scale, max_precision)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1065:9 [INFO] [stderr] | [INFO] [stderr] 1065 | return impl_division(num_int.clone(), &den_int, scale, max_precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `impl_division(num_int.clone(), &den_int, scale, max_precision)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:94:11 [INFO] [stderr] | [INFO] [stderr] 94 | while int >= &num { [INFO] [stderr] | ^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | if num < &n { [INFO] [stderr] | ^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if num < &n { [INFO] [stderr] | ^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:384:27 [INFO] [stderr] | [INFO] [stderr] 384 | let log2_10 = 3.32192809488736234787031942948939018_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.321_928_094_887_362` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:458:27 [INFO] [stderr] | [INFO] [stderr] 458 | let log2_10 = 3.32192809488736234787031942948939018_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.321_928_094_887_362` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:911:32 [INFO] [stderr] | [INFO] [stderr] 911 | let scale = self.scale + rhs.scale; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | } else if den == 1.0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | } else if den == 1.0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | } else if den == 0.5 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 0.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | } else if den == 0.5 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:190:27 [INFO] [stderr] | [INFO] [stderr] 190 | } else if den == 2.0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:190:27 [INFO] [stderr] | [INFO] [stderr] 190 | } else if den == 2.0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | } else if den == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(den - -1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | } else if den == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | } else if den == 1.0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | } else if den == 1.0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | } else if den == 0.5 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 0.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | } else if den == 0.5 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:190:27 [INFO] [stderr] | [INFO] [stderr] 190 | } else if den == 2.0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:190:27 [INFO] [stderr] | [INFO] [stderr] 190 | } else if den == 2.0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | } else if den == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(den - -1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | } else if den == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:943:11 [INFO] [stderr] | [INFO] [stderr] 943 | while &num < den { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:991:27 [INFO] [stderr] | [INFO] [stderr] 991 | if self.is_zero() || other.is_one() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:995:32 [INFO] [stderr] | [INFO] [stderr] 995 | let scale = self.scale - other.scale; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:997:12 [INFO] [stderr] | [INFO] [stderr] 997 | if &self.int_val == &other.int_val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 997 | if self.int_val == other.int_val { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:1017:27 [INFO] [stderr] | [INFO] [stderr] 1017 | if self.is_zero() || other.is_one() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:1021:32 [INFO] [stderr] | [INFO] [stderr] 1021 | let scale = self.scale - other.scale; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:1023:12 [INFO] [stderr] | [INFO] [stderr] 1023 | if &self.int_val == &other.int_val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1023 | if self.int_val == other.int_val { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:1047:27 [INFO] [stderr] | [INFO] [stderr] 1047 | if self.is_zero() || other.is_one() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:1051:32 [INFO] [stderr] | [INFO] [stderr] 1051 | let scale = self.scale - other.scale; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:92:43 [INFO] [stderr] | [INFO] [stderr] 92 | let mut digits = (int.bits() as f64 / 3.3219280949) as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `3.321_928_094_9` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:114:39 [INFO] [stderr] | [INFO] [stderr] 114 | let digits = (num.bits() as f64 / 3.3219280949) as u64; [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `3.321_928_094_9` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1396 | impl_from_type!(u8, u64); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:442:9 [INFO] [stderr] | [INFO] [stderr] 442 | return Some(result); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Some(result)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:384:27 [INFO] [stderr] | [INFO] [stderr] 384 | let log2_10 = 3.32192809488736234787031942948939018_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.321_928_094_887_362_347_870_319_429_489_390_18_f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:385:37 [INFO] [stderr] | [INFO] [stderr] 385 | let magic_guess_scale = 1.1951678538495576_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.195_167_853_849_557_6_f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:516:9 [INFO] [stderr] | [INFO] [stderr] 516 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:458:27 [INFO] [stderr] | [INFO] [stderr] 458 | let log2_10 = 3.32192809488736234787031942948939018_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `3.321_928_094_887_362_347_870_319_429_489_390_18_f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:459:37 [INFO] [stderr] | [INFO] [stderr] 459 | let magic_guess_scale = 1.124960491619939_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider: `1.124_960_491_619_939_f64` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:546:9 [INFO] [stderr] | [INFO] [stderr] 546 | return result.with_prec(100); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `result.with_prec(100)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:981:5 [INFO] [stderr] | [INFO] [stderr] 981 | return result; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `result` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1006:9 [INFO] [stderr] | [INFO] [stderr] 1006 | return impl_division(self.int_val, &other.int_val, scale, max_precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `impl_division(self.int_val, &other.int_val, scale, max_precision)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1032:9 [INFO] [stderr] | [INFO] [stderr] 1032 | return impl_division(self.int_val, &other.int_val, scale, max_precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `impl_division(self.int_val, &other.int_val, scale, max_precision)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/lib.rs:1065:9 [INFO] [stderr] | [INFO] [stderr] 1065 | return impl_division(num_int.clone(), &den_int, scale, max_precision); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `impl_division(num_int.clone(), &den_int, scale, max_precision)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1397 | impl_from_type!(u16, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1398 | impl_from_type!(u32, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1400 | impl_from_type!(i8, i64); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1401 | impl_from_type!(i16, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1402 | impl_from_type!(i32, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: aborting due to 15 previous errors [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/lib.rs:2321:26 [INFO] [stderr] | [INFO] [stderr] 2321 | ("1331.107", 1331107, 3), [INFO] [stderr] | ^^^^^^^ help: consider: `1_331_107` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] error: Could not compile `bigdecimal`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:94:11 [INFO] [stderr] | [INFO] [stderr] 94 | while int >= &num { [INFO] [stderr] | ^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `num` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:119:12 [INFO] [stderr] | [INFO] [stderr] 119 | if num < &n { [INFO] [stderr] | ^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/lib.rs:123:12 [INFO] [stderr] | [INFO] [stderr] 123 | if num < &n { [INFO] [stderr] | ^^^^^^-- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:384:27 [INFO] [stderr] | [INFO] [stderr] 384 | let log2_10 = 3.32192809488736234787031942948939018_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.321_928_094_887_362` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/lib.rs:458:27 [INFO] [stderr] | [INFO] [stderr] 458 | let log2_10 = 3.32192809488736234787031942948939018_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `3.321_928_094_887_362` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Mul` impl [INFO] [stderr] --> src/lib.rs:911:32 [INFO] [stderr] | [INFO] [stderr] 911 | let scale = self.scale + rhs.scale; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::suspicious_arithmetic_impl)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | } else if den == 1.0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::float_cmp)] on by default [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | } else if den == 1.0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | } else if den == 0.5 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 0.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | } else if den == 0.5 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:190:27 [INFO] [stderr] | [INFO] [stderr] 190 | } else if den == 2.0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:190:27 [INFO] [stderr] | [INFO] [stderr] 190 | } else if den == 2.0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | } else if den == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(den - -1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | } else if den == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | } else if den == 1.0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:186:27 [INFO] [stderr] | [INFO] [stderr] 186 | } else if den == 1.0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | } else if den == 0.5 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 0.5).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:188:27 [INFO] [stderr] | [INFO] [stderr] 188 | } else if den == 0.5 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:190:27 [INFO] [stderr] | [INFO] [stderr] 190 | } else if den == 2.0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider comparing them within some error: `(den - 2.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:190:27 [INFO] [stderr] | [INFO] [stderr] 190 | } else if den == 2.0 { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] error: strict comparison of f32 or f64 [INFO] [stderr] --> src/macros.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | } else if den == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider comparing them within some error: `(den - -1.0).abs() < error` [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available. [INFO] [stderr] --> src/macros.rs:192:27 [INFO] [stderr] | [INFO] [stderr] 192 | } else if den == -1.0 { [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] ::: src/lib.rs:926:1 [INFO] [stderr] | [INFO] [stderr] 926 | impl_div_for_primitives!(); [INFO] [stderr] | --------------------------- in this macro invocation [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of left operand [INFO] [stderr] --> src/lib.rs:943:11 [INFO] [stderr] | [INFO] [stderr] 943 | while &num < den { [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: use the left value directly: `num` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:991:27 [INFO] [stderr] | [INFO] [stderr] 991 | if self.is_zero() || other.is_one() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:995:32 [INFO] [stderr] | [INFO] [stderr] 995 | let scale = self.scale - other.scale; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:997:12 [INFO] [stderr] | [INFO] [stderr] 997 | if &self.int_val == &other.int_val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 997 | if self.int_val == other.int_val { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:1017:27 [INFO] [stderr] | [INFO] [stderr] 1017 | if self.is_zero() || other.is_one() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:1021:32 [INFO] [stderr] | [INFO] [stderr] 1021 | let scale = self.scale - other.scale; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: needlessly taken reference of both operands [INFO] [stderr] --> src/lib.rs:1023:12 [INFO] [stderr] | [INFO] [stderr] 1023 | if &self.int_val == &other.int_val { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] help: use the values directly [INFO] [stderr] | [INFO] [stderr] 1023 | if self.int_val == other.int_val { [INFO] [stderr] | ^^^^^^^^^^^^ ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:1047:27 [INFO] [stderr] | [INFO] [stderr] 1047 | if self.is_zero() || other.is_one() { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] error: Suspicious use of binary operator in `Div` impl [INFO] [stderr] --> src/lib.rs:1051:32 [INFO] [stderr] | [INFO] [stderr] 1051 | let scale = self.scale - other.scale; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#suspicious_arithmetic_impl [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1396 | impl_from_type!(u8, u64); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u16 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1397 | impl_from_type!(u16, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `u64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1398 | impl_from_type!(u32, u64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i8 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1400 | impl_from_type!(i8, i64); [INFO] [stderr] | ------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i16 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1401 | impl_from_type!(i16, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/lib.rs:1390:34 [INFO] [stderr] | [INFO] [stderr] 1390 | BigDecimal::from(n as $AsType) [INFO] [stderr] | ^ help: try: `i64::from(n)` [INFO] [stderr] ... [INFO] [stderr] 1402 | impl_from_type!(i32, i64); [INFO] [stderr] | -------------------------- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] error: approximate value of `f{32, 64}::consts::PI` found. Consider using it directly [INFO] [stderr] --> src/lib.rs:1651:22 [INFO] [stderr] | [INFO] [stderr] 1651 | ("3.14", 3.14), [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::approx_constant)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#approx_constant [INFO] [stderr] [INFO] [stderr] error: aborting due to 16 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `bigdecimal`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "ec4a9d347440570b88c84f96fcf991797aae71e3faa683b774d58df175e2df53"` [INFO] running `"docker" "rm" "-f" "ec4a9d347440570b88c84f96fcf991797aae71e3faa683b774d58df175e2df53"` [INFO] [stdout] ec4a9d347440570b88c84f96fcf991797aae71e3faa683b774d58df175e2df53