[INFO] crate bibtex 0.0.1 is already in cache [INFO] extracting crate bibtex 0.0.1 into work/ex/clippy-test-run/sources/stable/reg/bibtex/0.0.1 [INFO] extracting crate bibtex 0.0.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bibtex/0.0.1 [INFO] validating manifest of bibtex-0.0.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bibtex-0.0.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bibtex-0.0.1 [INFO] finished frobbing bibtex-0.0.1 [INFO] frobbed toml for bibtex-0.0.1 written to work/ex/clippy-test-run/sources/stable/reg/bibtex/0.0.1/Cargo.toml [INFO] started frobbing bibtex-0.0.1 [INFO] finished frobbing bibtex-0.0.1 [INFO] frobbed toml for bibtex-0.0.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bibtex/0.0.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bibtex-0.0.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bibtex/0.0.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f66e81fdf614e1867cbbd0534c8d3968841de7a5e7eb196e787d02442c3e4055 [INFO] running `"docker" "start" "-a" "f66e81fdf614e1867cbbd0534c8d3968841de7a5e7eb196e787d02442c3e4055"` [INFO] [stderr] Checking bibtex v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | fields: fields [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/entry.rs:14:13 [INFO] [stderr] | [INFO] [stderr] 14 | fields: fields [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `fields` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/entry.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | if *&self.fields.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cite_key` [INFO] [stderr] --> src/entry.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | fn cite_key(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `entry_type` [INFO] [stderr] --> src/entry.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn entry_type(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `field` [INFO] [stderr] --> src/entry.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | fn field(&self, field: &str) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/entry.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn to_string(&mut self) -> String { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/entry.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | &self.sort(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `self.sort();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/entry.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | &self.fields.sort(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.fields.sort();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: immediately dereferencing a reference [INFO] [stderr] --> src/entry.rs:38:12 [INFO] [stderr] | [INFO] [stderr] 38 | if *&self.fields.is_empty() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `self.fields.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::deref_addrof)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stderr] [INFO] [stderr] warning: method is never used: `cite_key` [INFO] [stderr] --> src/entry.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | fn cite_key(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `entry_type` [INFO] [stderr] --> src/entry.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | fn entry_type(&self) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `field` [INFO] [stderr] --> src/entry.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | fn field(&self, field: &str) -> &str { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: methods called `to_*` usually take self by reference; consider choosing a less ambiguous name [INFO] [stderr] --> src/entry.rs:29:22 [INFO] [stderr] | [INFO] [stderr] 29 | pub fn to_string(&mut self) -> String { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::wrong_self_convention)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/entry.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | &self.sort(); [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `self.sort();` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_operation)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] warning: statement can be reduced [INFO] [stderr] --> src/entry.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | &self.fields.sort(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.fields.sort();` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.88s [INFO] running `"docker" "inspect" "f66e81fdf614e1867cbbd0534c8d3968841de7a5e7eb196e787d02442c3e4055"` [INFO] running `"docker" "rm" "-f" "f66e81fdf614e1867cbbd0534c8d3968841de7a5e7eb196e787d02442c3e4055"` [INFO] [stdout] f66e81fdf614e1867cbbd0534c8d3968841de7a5e7eb196e787d02442c3e4055