[INFO] crate bflog-cli 0.3.1 is already in cache [INFO] extracting crate bflog-cli 0.3.1 into work/ex/clippy-test-run/sources/stable/reg/bflog-cli/0.3.1 [INFO] extracting crate bflog-cli 0.3.1 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bflog-cli/0.3.1 [INFO] validating manifest of bflog-cli-0.3.1 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bflog-cli-0.3.1 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bflog-cli-0.3.1 [INFO] finished frobbing bflog-cli-0.3.1 [INFO] frobbed toml for bflog-cli-0.3.1 written to work/ex/clippy-test-run/sources/stable/reg/bflog-cli/0.3.1/Cargo.toml [INFO] started frobbing bflog-cli-0.3.1 [INFO] finished frobbing bflog-cli-0.3.1 [INFO] frobbed toml for bflog-cli-0.3.1 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bflog-cli/0.3.1/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bflog-cli-0.3.1 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bflog-cli/0.3.1:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a5b93f6306a5eb42e19a12f815898bae087ec61dae61b236447fb5df683a85c5 [INFO] running `"docker" "start" "-a" "a5b93f6306a5eb42e19a12f815898bae087ec61dae61b236447fb5df683a85c5"` [INFO] [stderr] Checking bflog v0.3.1 [INFO] [stderr] Checking bflog-cli v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:94:10 [INFO] [stderr] | [INFO] [stderr] 94 | if string.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:7 [INFO] [stderr] | [INFO] [stderr] 131 | / match parse_context_arg(arg) { [INFO] [stderr] 132 | | (key, Some(value)) => { [INFO] [stderr] 133 | | context.with(key, &value.to_owned()); [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | [INFO] [stderr] 136 | | _ => {} [INFO] [stderr] 137 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let (key, Some(value)) = parse_context_arg(arg) { [INFO] [stderr] 132 | context.with(key, &value.to_owned()); [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:94:10 [INFO] [stderr] | [INFO] [stderr] 94 | if string.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!string.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:131:7 [INFO] [stderr] | [INFO] [stderr] 131 | / match parse_context_arg(arg) { [INFO] [stderr] 132 | | (key, Some(value)) => { [INFO] [stderr] 133 | | context.with(key, &value.to_owned()); [INFO] [stderr] 134 | | } [INFO] [stderr] 135 | | [INFO] [stderr] 136 | | _ => {} [INFO] [stderr] 137 | | } [INFO] [stderr] | |_______^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let (key, Some(value)) = parse_context_arg(arg) { [INFO] [stderr] 132 | context.with(key, &value.to_owned()); [INFO] [stderr] 133 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 6.18s [INFO] running `"docker" "inspect" "a5b93f6306a5eb42e19a12f815898bae087ec61dae61b236447fb5df683a85c5"` [INFO] running `"docker" "rm" "-f" "a5b93f6306a5eb42e19a12f815898bae087ec61dae61b236447fb5df683a85c5"` [INFO] [stdout] a5b93f6306a5eb42e19a12f815898bae087ec61dae61b236447fb5df683a85c5