[INFO] crate bfi 0.2.2 is already in cache [INFO] extracting crate bfi 0.2.2 into work/ex/clippy-test-run/sources/stable/reg/bfi/0.2.2 [INFO] extracting crate bfi 0.2.2 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bfi/0.2.2 [INFO] validating manifest of bfi-0.2.2 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bfi-0.2.2 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bfi-0.2.2 [INFO] finished frobbing bfi-0.2.2 [INFO] frobbed toml for bfi-0.2.2 written to work/ex/clippy-test-run/sources/stable/reg/bfi/0.2.2/Cargo.toml [INFO] started frobbing bfi-0.2.2 [INFO] finished frobbing bfi-0.2.2 [INFO] frobbed toml for bfi-0.2.2 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bfi/0.2.2/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bfi-0.2.2 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bfi/0.2.2:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 901011b499d34f7d8cb0e6567c3ae07c2d8a439bb87b5d84e276b4334e8556a3 [INFO] running `"docker" "start" "-a" "901011b499d34f7d8cb0e6567c3ae07c2d8a439bb87b5d84e276b4334e8556a3"` [INFO] [stderr] Checking bfi v0.2.2 (/opt/crater/workdir) [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/machine.rs:232:32 [INFO] [stderr] | [INFO] [stderr] 232 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 233 | | if jumps.len() > 0 { [INFO] [stderr] 234 | | let pos = jumps.pop().unwrap(); [INFO] [stderr] 235 | | code_ptr = pos - 1 [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 232 | } else if jumps.len() > 0 { [INFO] [stderr] 233 | let pos = jumps.pop().unwrap(); [INFO] [stderr] 234 | code_ptr = pos - 1 [INFO] [stderr] 235 | } else { [INFO] [stderr] 236 | return Err(BfError::Syntax(code_ptr)); [INFO] [stderr] 237 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/machine.rs:232:32 [INFO] [stderr] | [INFO] [stderr] 232 | } else { [INFO] [stderr] | ________________________________^ [INFO] [stderr] 233 | | if jumps.len() > 0 { [INFO] [stderr] 234 | | let pos = jumps.pop().unwrap(); [INFO] [stderr] 235 | | code_ptr = pos - 1 [INFO] [stderr] ... | [INFO] [stderr] 238 | | } [INFO] [stderr] 239 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 232 | } else if jumps.len() > 0 { [INFO] [stderr] 233 | let pos = jumps.pop().unwrap(); [INFO] [stderr] 234 | code_ptr = pos - 1 [INFO] [stderr] 235 | } else { [INFO] [stderr] 236 | return Err(BfError::Syntax(code_ptr)); [INFO] [stderr] 237 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/machine.rs:200:15 [INFO] [stderr] | [INFO] [stderr] 200 | code: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Val]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/machine.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | input: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Val]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/machine.rs:227:32 [INFO] [stderr] | [INFO] [stderr] 227 | if jumps.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!jumps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/machine.rs:233:32 [INFO] [stderr] | [INFO] [stderr] 233 | if jumps.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!jumps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/machine.rs:200:15 [INFO] [stderr] | [INFO] [stderr] 200 | code: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Val]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/machine.rs:201:16 [INFO] [stderr] | [INFO] [stderr] 201 | input: &Vec, [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[Val]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/machine.rs:227:32 [INFO] [stderr] | [INFO] [stderr] 227 | if jumps.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!jumps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/machine.rs:233:32 [INFO] [stderr] | [INFO] [stderr] 233 | if jumps.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!jumps.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.03s [INFO] running `"docker" "inspect" "901011b499d34f7d8cb0e6567c3ae07c2d8a439bb87b5d84e276b4334e8556a3"` [INFO] running `"docker" "rm" "-f" "901011b499d34f7d8cb0e6567c3ae07c2d8a439bb87b5d84e276b4334e8556a3"` [INFO] [stdout] 901011b499d34f7d8cb0e6567c3ae07c2d8a439bb87b5d84e276b4334e8556a3