[INFO] crate bex 0.1.0 is already in cache
[INFO] extracting crate bex 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bex/0.1.0
[INFO] extracting crate bex 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bex/0.1.0
[INFO] validating manifest of bex-0.1.0 on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of bex-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing bex-0.1.0
[INFO] finished frobbing bex-0.1.0
[INFO] frobbed toml for bex-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bex/0.1.0/Cargo.toml
[INFO] started frobbing bex-0.1.0
[INFO] finished frobbing bex-0.1.0
[INFO] frobbed toml for bex-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bex/0.1.0/Cargo.toml
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting bex-0.1.0 against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bex/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 59fbf5ff9516e912f3155d89e70190d1839827bbf67bd37d7e40145a0a3e461c
[INFO] running `"docker" "start" "-a" "59fbf5ff9516e912f3155d89e70190d1839827bbf67bd37d7e40145a0a3e461c"`
[INFO] [stderr]     Checking bex v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/base.rs:59:10
[INFO] [stderr]    |
[INFO] [stderr] 59 |     Base{bits: bits,
[INFO] [stderr]    |          ^^^^^^^^^^ help: replace it with: `bits`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/base.rs:60:10
[INFO] [stderr]    |
[INFO] [stderr] 60 |          nvars:nvars,
[INFO] [stderr]    |          ^^^^^^^^^^^ help: replace it with: `nvars`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/base.rs:61:10
[INFO] [stderr]    |
[INFO] [stderr] 61 |          tags: tags,
[INFO] [stderr]    |          ^^^^^^^^^^ help: replace it with: `tags`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/base.rs:291:20
[INFO] [stderr]     |
[INFO] [stderr] 291 |                let a = self.and(m,n); self.not(a)},
[INFO] [stderr]     |                    ^
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/base.rs:59:10
[INFO] [stderr]    |
[INFO] [stderr] 59 |     Base{bits: bits,
[INFO] [stderr]    |          ^^^^^^^^^^ help: replace it with: `bits`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_field_names)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/base.rs:60:10
[INFO] [stderr]    |
[INFO] [stderr] 60 |          nvars:nvars,
[INFO] [stderr]    |          ^^^^^^^^^^^ help: replace it with: `nvars`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/base.rs:61:10
[INFO] [stderr]    |
[INFO] [stderr] 61 |          tags: tags,
[INFO] [stderr]    |          ^^^^^^^^^^ help: replace it with: `tags`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/base.rs:291:20
[INFO] [stderr]     |
[INFO] [stderr] 291 |                let a = self.and(m,n); self.not(a)},
[INFO] [stderr]     |                    ^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/base.rs:298:12
[INFO] [stderr]     |
[INFO] [stderr] 298 |     let (a,b,c) = order3(x,y,z);
[INFO] [stderr]     |            ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/base.rs:298:14
[INFO] [stderr]     |
[INFO] [stderr] 298 |     let (a,b,c) = order3(x,y,z);
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bdd.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |     BDDBase{nvars:nvars, bits:bits,
[INFO] [stderr]    |             ^^^^^^^^^^^ help: replace it with: `nvars`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bdd.rs:89:26
[INFO] [stderr]    |
[INFO] [stderr] 89 |     BDDBase{nvars:nvars, bits:bits,
[INFO] [stderr]    |                          ^^^^^^^^^ help: replace it with: `bits`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:122:32
[INFO] [stderr]     |
[INFO] [stderr] 122 |       seen.insert(n); let (i,t,e) = self.tup(n); f(n,i,t,e);
[INFO] [stderr]     |                                ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:219:19
[INFO] [stderr]     |
[INFO] [stderr] 219 |       Norm::Tup(x,y,z) => self.ite_norm(x,y,z),
[INFO] [stderr]     |                   ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:219:21
[INFO] [stderr]     |
[INFO] [stderr] 219 |       Norm::Tup(x,y,z) => self.ite_norm(x,y,z),
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:220:19
[INFO] [stderr]     |
[INFO] [stderr] 220 |       Norm::Not(x,y,z) => not(self.ite_norm(x,y,z)) }}
[INFO] [stderr]     |                   ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:220:21
[INFO] [stderr]     |
[INFO] [stderr] 220 |       Norm::Not(x,y,z) => not(self.ite_norm(x,y,z)) }}
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |       Some(&n) => n,
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:243:21
[INFO] [stderr]     |
[INFO] [stderr] 243 |               Some(&n) => n,
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bdd.rs:247:40
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 self.bits.push(BDDNode{v:v, hi:hi, lo:lo});
[INFO] [stderr]     |                                        ^^^ help: replace it with: `v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bdd.rs:247:45
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 self.bits.push(BDDNode{v:v, hi:hi, lo:lo});
[INFO] [stderr]     |                                             ^^^^^ help: replace it with: `hi`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bdd.rs:247:52
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 self.bits.push(BDDNode{v:v, hi:hi, lo:lo});
[INFO] [stderr]     |                                                    ^^^^^ help: replace it with: `lo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:293:27
[INFO] [stderr]     |
[INFO] [stderr] 293 |               Norm::Not(x,y,z) => Norm::Tup(x,y,z),
[INFO] [stderr]     |                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:293:29
[INFO] [stderr]     |
[INFO] [stderr] 293 |               Norm::Not(x,y,z) => Norm::Tup(x,y,z),
[INFO] [stderr]     |                             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:294:27
[INFO] [stderr]     |
[INFO] [stderr] 294 |               Norm::Tup(x,y,z) => Norm::Not(x,y,z)}}
[INFO] [stderr]     |                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:294:29
[INFO] [stderr]     |
[INFO] [stderr] 294 |               Norm::Tup(x,y,z) => Norm::Not(x,y,z)}}
[INFO] [stderr]     |                             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/x32.rs:118:8
[INFO] [stderr]     |
[INFO] [stderr] 118 |   BB32{bits:bits} }
[INFO] [stderr]     |        ^^^^^^^^^ help: replace it with: `bits`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::many_single_char_names)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/base.rs:298:12
[INFO] [stderr]     |
[INFO] [stderr] 298 |     let (a,b,c) = order3(x,y,z);
[INFO] [stderr]     |            ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/base.rs:298:14
[INFO] [stderr]     |
[INFO] [stderr] 298 |     let (a,b,c) = order3(x,y,z);
[INFO] [stderr]     |              ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bdd.rs:89:13
[INFO] [stderr]    |
[INFO] [stderr] 89 |     BDDBase{nvars:nvars, bits:bits,
[INFO] [stderr]    |             ^^^^^^^^^^^ help: replace it with: `nvars`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]   --> src/bdd.rs:89:26
[INFO] [stderr]    |
[INFO] [stderr] 89 |     BDDBase{nvars:nvars, bits:bits,
[INFO] [stderr]    |                          ^^^^^^^^^ help: replace it with: `bits`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:122:32
[INFO] [stderr]     |
[INFO] [stderr] 122 |       seen.insert(n); let (i,t,e) = self.tup(n); f(n,i,t,e);
[INFO] [stderr]     |                                ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:219:19
[INFO] [stderr]     |
[INFO] [stderr] 219 |       Norm::Tup(x,y,z) => self.ite_norm(x,y,z),
[INFO] [stderr]     |                   ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:219:21
[INFO] [stderr]     |
[INFO] [stderr] 219 |       Norm::Tup(x,y,z) => self.ite_norm(x,y,z),
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:220:19
[INFO] [stderr]     |
[INFO] [stderr] 220 |       Norm::Not(x,y,z) => not(self.ite_norm(x,y,z)) }}
[INFO] [stderr]     |                   ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:220:21
[INFO] [stderr]     |
[INFO] [stderr] 220 |       Norm::Not(x,y,z) => not(self.ite_norm(x,y,z)) }}
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:232:13
[INFO] [stderr]     |
[INFO] [stderr] 232 |       Some(&n) => n,
[INFO] [stderr]     |             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:243:21
[INFO] [stderr]     |
[INFO] [stderr] 243 |               Some(&n) => n,
[INFO] [stderr]     |                     ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bdd.rs:247:40
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 self.bits.push(BDDNode{v:v, hi:hi, lo:lo});
[INFO] [stderr]     |                                        ^^^ help: replace it with: `v`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bdd.rs:247:45
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 self.bits.push(BDDNode{v:v, hi:hi, lo:lo});
[INFO] [stderr]     |                                             ^^^^^ help: replace it with: `hi`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/bdd.rs:247:52
[INFO] [stderr]     |
[INFO] [stderr] 247 |                 self.bits.push(BDDNode{v:v, hi:hi, lo:lo});
[INFO] [stderr]     |                                                    ^^^^^ help: replace it with: `lo`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:293:27
[INFO] [stderr]     |
[INFO] [stderr] 293 |               Norm::Not(x,y,z) => Norm::Tup(x,y,z),
[INFO] [stderr]     |                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:293:29
[INFO] [stderr]     |
[INFO] [stderr] 293 |               Norm::Not(x,y,z) => Norm::Tup(x,y,z),
[INFO] [stderr]     |                             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 5th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:294:27
[INFO] [stderr]     |
[INFO] [stderr] 294 |               Norm::Tup(x,y,z) => Norm::Not(x,y,z)}}
[INFO] [stderr]     |                           ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: 6th binding whose name is just one char
[INFO] [stderr]    --> src/bdd.rs:294:29
[INFO] [stderr]     |
[INFO] [stderr] 294 |               Norm::Tup(x,y,z) => Norm::Not(x,y,z)}}
[INFO] [stderr]     |                             ^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names
[INFO] [stderr] 
[INFO] [stderr] warning: redundant field names in struct initialization
[INFO] [stderr]    --> src/x32.rs:118:8
[INFO] [stderr]     |
[INFO] [stderr] 118 |   BB32{bits:bits} }
[INFO] [stderr]     |        ^^^^^^^^^ help: replace it with: `bits`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/base.rs:171:5
[INFO] [stderr]     |
[INFO] [stderr] 171 |     return (self.permute(&oldnids), keep.iter().map(|&i| newnids[i]).collect()); }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.permute(&oldnids), keep.iter().map(|&i| newnids[i]).collect())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bdd.rs:193:39
[INFO] [stderr]     |
[INFO] [stderr] 193 |   pub fn is_var(&self, n:NID)->bool { return is_var(n) }
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_var(n)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bdd.rs:300:5
[INFO] [stderr]     |
[INFO] [stderr] 300 |     return io::put(path, &s) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `io::put(path, &s)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bdd.rs:304:5
[INFO] [stderr]     |
[INFO] [stderr] 304 |     return Ok(bincode::deserialize(&s).unwrap()); }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bincode::deserialize(&s).unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/base.rs:171:5
[INFO] [stderr]     |
[INFO] [stderr] 171 |     return (self.permute(&oldnids), keep.iter().map(|&i| newnids[i]).collect()); }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(self.permute(&oldnids), keep.iter().map(|&i| newnids[i]).collect())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bdd.rs:193:39
[INFO] [stderr]     |
[INFO] [stderr] 193 |   pub fn is_var(&self, n:NID)->bool { return is_var(n) }
[INFO] [stderr]     |                                       ^^^^^^^^^^^^^^^^ help: remove `return` as shown: `is_var(n)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bdd.rs:300:5
[INFO] [stderr]     |
[INFO] [stderr] 300 |     return io::put(path, &s) }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `io::put(path, &s)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/bdd.rs:304:5
[INFO] [stderr]     |
[INFO] [stderr] 304 |     return Ok(bincode::deserialize(&s).unwrap()); }
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(bincode::deserialize(&s).unwrap())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/bdd.rs:341:23
[INFO] [stderr]     |
[INFO] [stderr] 341 |   assert_eq!(O, NID{n:0x2000000000000000u64});
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x2000_0000_0000_0000u64`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/bdd.rs:342:23
[INFO] [stderr]     |
[INFO] [stderr] 342 |   assert_eq!(I, NID{n:0xa000000000000000u64});
[INFO] [stderr]     |                       ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0xa000_0000_0000_0000u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/bdd.rs:343:27
[INFO] [stderr]     |
[INFO] [stderr] 343 |   assert_eq!(nv(0), NID{n:0x4000000000000000u64});
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x4000_0000_0000_0000u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/bdd.rs:344:27
[INFO] [stderr]     |
[INFO] [stderr] 344 |   assert_eq!(nv(1), NID{n:0x4000000100000000u64});
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x4000_0001_0000_0000u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/bdd.rs:345:30
[INFO] [stderr]     |
[INFO] [stderr] 345 |   assert_eq!(nvi(0,0), NID{n:0x0000000000000000u64});
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0000_0000u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/bdd.rs:346:30
[INFO] [stderr]     |
[INFO] [stderr] 346 |   assert_eq!(nvi(1,0), NID{n:0x0000000100000000u64}); }
[INFO] [stderr]     |                              ^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0001_0000_0000u64`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `n` is only used to index `bits`.
[INFO] [stderr]    --> src/base.rs:102:14
[INFO] [stderr]     |
[INFO] [stderr] 102 |     for n in 0..bits.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 102 |     for <item> in &bits {
[INFO] [stderr]     |         ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/base.rs:137:33
[INFO] [stderr]     |
[INFO] [stderr] 137 |   pub fn permute(&self, oldnids:&Vec<NID>)->Base {
[INFO] [stderr]     |                                 ^^^^^^^^^ help: change this to: `&[NID]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/base.rs:240:16
[INFO] [stderr]     |
[INFO] [stderr] 240 |       for i in known .. v+1 {
[INFO] [stderr]     |                ^^^^^^^^^^^^ help: use: `known..=v`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/apl.rs:5:24
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn group<'a,T>(xs: &'a Vec<T>) -> (Vec<&T>, HashMap<&T,Vec<usize>>)
[INFO] [stderr]   |                        ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/apl.rs:15:26
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn gradeup<'a,T>(xs: &'a Vec<T>) -> Vec<usize>
[INFO] [stderr]    |                          ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/apl.rs:20:26
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn at<'a,T:Clone>(xs:&'a Vec<T>, ys:&'a Vec<usize>) -> Vec<T> {
[INFO] [stderr]    |                          ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/apl.rs:20:41
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn at<'a,T:Clone>(xs:&'a Vec<T>, ys:&'a Vec<usize>) -> Vec<T> {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/bdd.rs:45:52
[INFO] [stderr]    |
[INFO] [stderr] 45 | #[inline(always)] pub fn nv(v:VID)->NID { NID { n:((v as u64) << 32)|VAR }}
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: try: `u64::from(v)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/bdd.rs:46:58
[INFO] [stderr]    |
[INFO] [stderr] 46 | #[inline(always)] pub fn nvi(v:VID,i:IDX)->NID { NID{ n:((v as u64) << 32) + i as u64 }}
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: try: `u64::from(v)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/bdd.rs:46:78
[INFO] [stderr]    |
[INFO] [stderr] 46 | #[inline(always)] pub fn nvi(v:VID,i:IDX)->NID { NID{ n:((v as u64) << 32) + i as u64 }}
[INFO] [stderr]    |                                                                              ^^^^^^^^ help: try: `u64::from(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/bdd.rs:79:10
[INFO] [stderr]    |
[INFO] [stderr] 79 |   xmemo: Vec<FnvHashMap<NID, FnvHashMap<(NID,NID), NID>>> }
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/bdd.rs:97:23
[INFO] [stderr]    |
[INFO] [stderr] 97 |   pub fn get(&self, s:&String)->Option<NID> { Some(*self.tags.get(s)?) }
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/bdd.rs:223:13
[INFO] [stderr]     |
[INFO] [stderr] 223 |     #[inline] fn get_norm_memo<'a>(&'a self, v:VID, f:NID, g:NID, h:NID) -> Option<&'a NID> {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 224 | |     if is_var(f) { self.vmemo[var(f) as usize].get(&(g,h)) }
[INFO] [stderr] 225 | |     else { self.xmemo[v as usize].get(&f).map_or(None, |fmemo| fmemo.get(&(g,h))) }}
[INFO] [stderr]     | |____________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/bdd.rs:225:12
[INFO] [stderr]     |
[INFO] [stderr] 225 |     else { self.xmemo[v as usize].get(&f).map_or(None, |fmemo| fmemo.get(&(g,h))) }}
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.xmemo[v as usize].get(&f).and_then(|fmemo| fmemo.get(&(g,h)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/bdd.rs:251:29
[INFO] [stderr]     |
[INFO] [stderr] 251 |             .or_insert_with(|| FnvHashMap::default());
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FnvHashMap::default`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.bits.iter().enumerate()` or similar iterators
[INFO] [stderr]    --> src/x32.rs:140:20
[INFO] [stderr]     |
[INFO] [stderr] 140 |     for ref bit in self.bits.iter() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/x32.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |     for ref bit in self.bits.iter() {
[INFO] [stderr]     |         ^^^^^^^    ---------------- help: try: `let bit = &self.bits.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/x32.rs:141:10
[INFO] [stderr]     |
[INFO] [stderr] 141 |       if bit.clone() == &self.i() { u|=1<<i }
[INFO] [stderr]     |          ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 141 |       if &(*bit).clone() == &self.i() { u|=1<<i }
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 141 |       if &x32::BaseBit::clone(bit) == &self.i() { u|=1<<i }
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/io.rs:24:34
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub fn put<T:Sized>(path:&str, v:&Vec<T>) -> ::std::io::Result<()> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/io.rs:38:30
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn put_map(path:&str, m:&HashMap<String,usize>) -> ::std::io::Result<()> {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn put_map<S: ::std::hash::BuildHasher>(path:&str, m:&HashMap<String, usize, S>) -> ::std::io::Result<()> {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^               ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `bex`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: the loop variable `n` is only used to index `bits`.
[INFO] [stderr]    --> src/base.rs:102:14
[INFO] [stderr]     |
[INFO] [stderr] 102 |     for n in 0..bits.len() {
[INFO] [stderr]     |              ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 102 |     for <item> in &bits {
[INFO] [stderr]     |         ^^^^^^    ^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]    --> src/base.rs:137:33
[INFO] [stderr]     |
[INFO] [stderr] 137 |   pub fn permute(&self, oldnids:&Vec<NID>)->Base {
[INFO] [stderr]     |                                 ^^^^^^^^^ help: change this to: `&[NID]`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: an inclusive range would be more readable
[INFO] [stderr]    --> src/base.rs:240:16
[INFO] [stderr]     |
[INFO] [stderr] 240 |       for i in known .. v+1 {
[INFO] [stderr]     |                ^^^^^^^^^^^^ help: use: `known..=v`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::range_plus_one)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#range_plus_one
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/apl.rs:5:24
[INFO] [stderr]   |
[INFO] [stderr] 5 | pub fn group<'a,T>(xs: &'a Vec<T>) -> (Vec<&T>, HashMap<&T,Vec<usize>>)
[INFO] [stderr]   |                        ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]   |
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/apl.rs:15:26
[INFO] [stderr]    |
[INFO] [stderr] 15 | pub fn gradeup<'a,T>(xs: &'a Vec<T>) -> Vec<usize>
[INFO] [stderr]    |                          ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/apl.rs:20:26
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn at<'a,T:Clone>(xs:&'a Vec<T>, ys:&'a Vec<usize>) -> Vec<T> {
[INFO] [stderr]    |                          ^^^^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/apl.rs:20:41
[INFO] [stderr]    |
[INFO] [stderr] 20 | pub fn at<'a,T:Clone>(xs:&'a Vec<T>, ys:&'a Vec<usize>) -> Vec<T> {
[INFO] [stderr]    |                                         ^^^^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/bdd.rs:45:52
[INFO] [stderr]    |
[INFO] [stderr] 45 | #[inline(always)] pub fn nv(v:VID)->NID { NID { n:((v as u64) << 32)|VAR }}
[INFO] [stderr]    |                                                    ^^^^^^^^^^ help: try: `u64::from(v)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/bdd.rs:46:58
[INFO] [stderr]    |
[INFO] [stderr] 46 | #[inline(always)] pub fn nvi(v:VID,i:IDX)->NID { NID{ n:((v as u64) << 32) + i as u64 }}
[INFO] [stderr]    |                                                          ^^^^^^^^^^ help: try: `u64::from(v)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u32 to u64 may become silently lossy if types change
[INFO] [stderr]   --> src/bdd.rs:46:78
[INFO] [stderr]    |
[INFO] [stderr] 46 | #[inline(always)] pub fn nvi(v:VID,i:IDX)->NID { NID{ n:((v as u64) << 32) + i as u64 }}
[INFO] [stderr]    |                                                                              ^^^^^^^^ help: try: `u64::from(i)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: very complex type used. Consider factoring parts into `type` definitions
[INFO] [stderr]   --> src/bdd.rs:79:10
[INFO] [stderr]    |
[INFO] [stderr] 79 |   xmemo: Vec<FnvHashMap<NID, FnvHashMap<(NID,NID), NID>>> }
[INFO] [stderr]    |          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::type_complexity)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do.
[INFO] [stderr]   --> src/bdd.rs:97:23
[INFO] [stderr]    |
[INFO] [stderr] 97 |   pub fn get(&self, s:&String)->Option<NID> { Some(*self.tags.get(s)?) }
[INFO] [stderr]    |                       ^^^^^^^ help: change this to: `&str`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration)
[INFO] [stderr]    --> src/bdd.rs:223:13
[INFO] [stderr]     |
[INFO] [stderr] 223 |     #[inline] fn get_norm_memo<'a>(&'a self, v:VID, f:NID, g:NID, h:NID) -> Option<&'a NID> {
[INFO] [stderr]     |  _____________^
[INFO] [stderr] 224 | |     if is_var(f) { self.vmemo[var(f) as usize].get(&(g,h)) }
[INFO] [stderr] 225 | |     else { self.xmemo[v as usize].get(&f).map_or(None, |fmemo| fmemo.get(&(g,h))) }}
[INFO] [stderr]     | |____________________________________________________________________________________^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_lifetimes)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes
[INFO] [stderr] 
[INFO] [stderr] warning: called `map_or(None, f)` on an Option value. This can be done more directly by calling `and_then(f)` instead
[INFO] [stderr]    --> src/bdd.rs:225:12
[INFO] [stderr]     |
[INFO] [stderr] 225 |     else { self.xmemo[v as usize].get(&f).map_or(None, |fmemo| fmemo.get(&(g,h))) }}
[INFO] [stderr]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try using and_then instead: `self.xmemo[v as usize].get(&f).and_then(|fmemo| fmemo.get(&(g,h)))`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::option_map_or_none)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]    --> src/bdd.rs:251:29
[INFO] [stderr]     |
[INFO] [stderr] 251 |             .or_insert_with(|| FnvHashMap::default());
[INFO] [stderr]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `FnvHashMap::default`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in self.bits.iter().enumerate()` or similar iterators
[INFO] [stderr]    --> src/x32.rs:140:20
[INFO] [stderr]     |
[INFO] [stderr] 140 |     for ref bit in self.bits.iter() {
[INFO] [stderr]     |                    ^^^^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::explicit_counter_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop
[INFO] [stderr] 
[INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead
[INFO] [stderr]    --> src/x32.rs:140:9
[INFO] [stderr]     |
[INFO] [stderr] 140 |     for ref bit in self.bits.iter() {
[INFO] [stderr]     |         ^^^^^^^    ---------------- help: try: `let bit = &self.bits.iter();`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::toplevel_ref_arg)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]    --> src/x32.rs:141:10
[INFO] [stderr]     |
[INFO] [stderr] 141 |       if bit.clone() == &self.i() { u|=1<<i }
[INFO] [stderr]     |          ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]     |
[INFO] [stderr] 141 |       if &(*bit).clone() == &self.i() { u|=1<<i }
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]     |
[INFO] [stderr] 141 |       if &x32::BaseBit::clone(bit) == &self.i() { u|=1<<i }
[INFO] [stderr]     |          ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/io.rs:24:34
[INFO] [stderr]    |
[INFO] [stderr] 24 | pub fn put<T:Sized>(path:&str, v:&Vec<T>) -> ::std::io::Result<()> {
[INFO] [stderr]    |                                  ^^^^^^^ help: change this to: `&[T]`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: parameter of type `HashMap` should be generalized over different hashers
[INFO] [stderr]   --> src/io.rs:38:30
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn put_map(path:&str, m:&HashMap<String,usize>) -> ::std::io::Result<()> {
[INFO] [stderr]    |                              ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::implicit_hasher)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#implicit_hasher
[INFO] [stderr] help: consider adding a type parameter
[INFO] [stderr]    |
[INFO] [stderr] 38 | pub fn put_map<S: ::std::hash::BuildHasher>(path:&str, m:&HashMap<String, usize, S>) -> ::std::io::Result<()> {
[INFO] [stderr]    |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^               ^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to previous error
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `bex`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "59fbf5ff9516e912f3155d89e70190d1839827bbf67bd37d7e40145a0a3e461c"`
[INFO] running `"docker" "rm" "-f" "59fbf5ff9516e912f3155d89e70190d1839827bbf67bd37d7e40145a0a3e461c"`
[INFO] [stdout] 59fbf5ff9516e912f3155d89e70190d1839827bbf67bd37d7e40145a0a3e461c