[INFO] crate bender 0.1.0 is already in cache [INFO] extracting crate bender 0.1.0 into work/ex/clippy-test-run/sources/stable/reg/bender/0.1.0 [INFO] extracting crate bender 0.1.0 into work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bender/0.1.0 [INFO] validating manifest of bender-0.1.0 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of bender-0.1.0 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing bender-0.1.0 [INFO] finished frobbing bender-0.1.0 [INFO] frobbed toml for bender-0.1.0 written to work/ex/clippy-test-run/sources/stable/reg/bender/0.1.0/Cargo.toml [INFO] started frobbing bender-0.1.0 [INFO] finished frobbing bender-0.1.0 [INFO] frobbed toml for bender-0.1.0 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/reg/bender/0.1.0/Cargo.toml [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "generate-lockfile" "--manifest-path" "Cargo.toml" "-Zno-index-update"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting bender-0.1.0 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/reg/bender/0.1.0:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 491d837b3bf696f75e473b578fcbeabb57522e1504d1d6fcba9065559153fa80 [INFO] running `"docker" "start" "-a" "491d837b3bf696f75e473b578fcbeabb57522e1504d1d6fcba9065559153fa80"` [INFO] [stderr] Checking moore-svlog-syntax v0.1.0 [INFO] [stderr] Checking moore-svlog-hir v0.1.0 [INFO] [stderr] Checking moore-svlog v0.1.0 [INFO] [stderr] Checking bender v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return len + indent - rem; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `len + indent - rem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | return ast; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | .unwrap_or_else(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | / match std::fs::File::open(filename) { [INFO] [stderr] 57 | | Err(e) => { [INFO] [stderr] 58 | | println!("Could not open `{}': {}.", filename, e.description()); [INFO] [stderr] 59 | | return; [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | _ => (), [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | if let Err(e) = std::fs::File::open(filename) { [INFO] [stderr] 57 | println!("Could not open `{}': {}.", filename, e.description()); [INFO] [stderr] 58 | return; [INFO] [stderr] 59 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:118:9 [INFO] [stderr] | [INFO] [stderr] 118 | return len + indent - rem; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `len + indent - rem` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:171:5 [INFO] [stderr] | [INFO] [stderr] 171 | return ast; [INFO] [stderr] | ^^^^^^^^^^^ help: remove `return` as shown: `ast` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:51:25 [INFO] [stderr] | [INFO] [stderr] 51 | .unwrap_or_else(|| Vec::new()); [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:56:13 [INFO] [stderr] | [INFO] [stderr] 56 | / match std::fs::File::open(filename) { [INFO] [stderr] 57 | | Err(e) => { [INFO] [stderr] 58 | | println!("Could not open `{}': {}.", filename, e.description()); [INFO] [stderr] 59 | | return; [INFO] [stderr] 60 | | } [INFO] [stderr] 61 | | _ => (), [INFO] [stderr] 62 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 56 | if let Err(e) = std::fs::File::open(filename) { [INFO] [stderr] 57 | println!("Could not open `{}': {}.", filename, e.description()); [INFO] [stderr] 58 | return; [INFO] [stderr] 59 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 13.04s [INFO] running `"docker" "inspect" "491d837b3bf696f75e473b578fcbeabb57522e1504d1d6fcba9065559153fa80"` [INFO] running `"docker" "rm" "-f" "491d837b3bf696f75e473b578fcbeabb57522e1504d1d6fcba9065559153fa80"` [INFO] [stdout] 491d837b3bf696f75e473b578fcbeabb57522e1504d1d6fcba9065559153fa80